René's URL Explorer Experiment


Title: Use @abstractmethod inside of abstract classes · Issue #1837 · python-telegram-bot/python-telegram-bot · GitHub

Open Graph Title: Use @abstractmethod inside of abstract classes · Issue #1837 · python-telegram-bot/python-telegram-bot

X Title: Use @abstractmethod inside of abstract classes · Issue #1837 · python-telegram-bot/python-telegram-bot

Description: $ grep NotImplementedError -r telegram --exclude-dir=vendor -I --line-number ./telegram/ext/handler.py: raise NotImplementedError ./telegram/ext/basepersistence.py: raise NotImplementedError ./telegram/ext/basepersistence.py: raise NotIm...

Open Graph Description: $ grep NotImplementedError -r telegram --exclude-dir=vendor -I --line-number ./telegram/ext/handler.py: raise NotImplementedError ./telegram/ext/basepersistence.py: raise NotImplementedError ./tele...

X Description: $ grep NotImplementedError -r telegram --exclude-dir=vendor -I --line-number ./telegram/ext/handler.py: raise NotImplementedError ./telegram/ext/basepersistence.py: raise NotImplementedError ./tele...

Opengraph URL: https://github.com/python-telegram-bot/python-telegram-bot/issues/1837

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Use @abstractmethod inside of abstract classes","articleBody":"```console\r\n$ grep NotImplementedError -r telegram --exclude-dir=vendor -I --line-number\r\n./telegram/ext/handler.py:        raise NotImplementedError\r\n./telegram/ext/basepersistence.py:        raise NotImplementedError\r\n./telegram/ext/basepersistence.py:        raise NotImplementedError\r\n./telegram/ext/basepersistence.py:        raise NotImplementedError\r\n./telegram/ext/basepersistence.py:        raise NotImplementedError\r\n./telegram/ext/basepersistence.py:        raise NotImplementedError\r\n./telegram/ext/basepersistence.py:        raise NotImplementedError\r\n./telegram/ext/basepersistence.py:        raise NotImplementedError\r\n./telegram/ext/basepersistence.py:        raise NotImplementedError\r\n./telegram/ext/filters.py:        raise NotImplementedError\r\n```\r\n\r\nWhilst looking through the code I noticed a few occurrences where the docstring states that methods must be overwritten/implemented und corresponding checks are apparently in the tests. However Python provides the `@abstractmethod` decorator which we could use. We could either use the `ABCMeta` metaclass for this or I could implement this into the *Python3 only* branch where we could simple inherit `ABC`.\r\nI think this change would make the code a bit more clear and prevents common pitfalls where one wants to inherit such classes but forgets to implement these methods (probably most common with `BasePersistence`)","author":{"url":"https://github.com/septatrix","@type":"Person","name":"septatrix"},"datePublished":"2020-03-19T16:20:43Z","url":"https://github.com/python-telegram-bot/python-telegram-bot/issues/1837"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:b7062f20-5dfa-7b60-7cf4-f9542ffbbaea
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idAAB6:323204:25B64F1:317FD6B:6B025DF6
html-safe-nonced93aade8a2aaf96d514037df28a83b776827e9f64e674c4f8b293805ceda9583
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBQUI2OjMyMzIwNDoyNUI2NEYxOjMxN0ZENkI6NkIwMjVERjYiLCJ2aXNpdG9yX2lkIjoiMzM4OTIwNTU0MDI3NzIxNDcxMCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacf28825ca4558b61c5d4c031f143c34f6be80001e629947f433e32ed916f73bfc
hovercard-subject-tagissue:584533441
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/python-telegram-bot/python-telegram-bot/1837/issue_layout
twitter:imagehttps://opengraph.githubassets.com/127a02718a53db841720e7623b3a3a54863a9dc438429574aa3a213c4013fb73/python-telegram-bot/python-telegram-bot/issues/1837
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/127a02718a53db841720e7623b3a3a54863a9dc438429574aa3a213c4013fb73/python-telegram-bot/python-telegram-bot/issues/1837
og:image:alt$ grep NotImplementedError -r telegram --exclude-dir=vendor -I --line-number ./telegram/ext/handler.py: raise NotImplementedError ./telegram/ext/basepersistence.py: raise NotImplementedError ./tele...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameseptatrix
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
go-importgithub.com/python-telegram-bot/python-telegram-bot git https://github.com/python-telegram-bot/python-telegram-bot.git
octolytics-dimension-user_id16178365
octolytics-dimension-user_loginpython-telegram-bot
octolytics-dimension-repository_id38696925
octolytics-dimension-repository_nwopython-telegram-bot/python-telegram-bot
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id38696925
octolytics-dimension-repository_network_root_nwopython-telegram-bot/python-telegram-bot
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/python-telegram-bot/python-telegram-bot/issues/1837#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython-telegram-bot%2Fpython-telegram-bot%2Fissues%2F1837
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython-telegram-bot%2Fpython-telegram-bot%2Fissues%2F1837
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=python-telegram-bot%2Fpython-telegram-bot
Reloadhttps://github.com/python-telegram-bot/python-telegram-bot/issues/1837
Reloadhttps://github.com/python-telegram-bot/python-telegram-bot/issues/1837
Reloadhttps://github.com/python-telegram-bot/python-telegram-bot/issues/1837
python-telegram-bothttps://github.com/python-telegram-bot
python-telegram-bothttps://github.com/python-telegram-bot/python-telegram-bot
Codehttps://github.com/python-telegram-bot/python-telegram-bot
Issues23 (23)https://github.com/python-telegram-bot/python-telegram-bot/issues
Pull requests19 (19)https://github.com/python-telegram-bot/python-telegram-bot/pulls
Discussionshttps://github.com/python-telegram-bot/python-telegram-bot/discussions
Actionshttps://github.com/python-telegram-bot/python-telegram-bot/actions
Projectshttps://github.com/python-telegram-bot/python-telegram-bot/projects
Wikihttps://github.com/python-telegram-bot/python-telegram-bot/wiki
Security and qualityhttps://github.com/python-telegram-bot/python-telegram-bot/security
Insightshttps://github.com/python-telegram-bot/python-telegram-bot/insights
https://github.com/python-telegram-bot/python-telegram-bot
New issuehttps://github.com/login?return_to=https://github.com/python-telegram-bot/python-telegram-bot/issues/1837
New issuehttps://github.com/login?return_to=https://github.com/python-telegram-bot/python-telegram-bot/issues/1837
💡 featurehttps://github.com/python-telegram-bot/python-telegram-bot/issues?q=type:"💡 feature"
#1905https://github.com/python-telegram-bot/python-telegram-bot/pull/1905
Use @abstractmethod inside of abstract classeshttps://github.com/python-telegram-bot/python-telegram-bot/issues/1837#top
#1905https://github.com/python-telegram-bot/python-telegram-bot/pull/1905
https://github.com/septatrix
septatrixhttps://github.com/septatrix
on Mar 19, 2020https://github.com/python-telegram-bot/python-telegram-bot/issues/1837#issue-584533441
septatrixhttps://github.com/septatrix
enhancementhttps://github.com/python-telegram-bot/python-telegram-bot/issues?q=state%3Aopen%20label%3A%22enhancement%22
on Mar 19, 2020https://github.com/python-telegram-bot/python-telegram-bot/issues/1837#event-3146288174
https://github.com/septatrix
septatrixhttps://github.com/septatrix
on Mar 19, 2020https://github.com/python-telegram-bot/python-telegram-bot/issues/1837#issuecomment-601276640
a86fc6chttps://github.com/python-telegram-bot/python-telegram-bot/commit/a86fc6c2ac1d984f070ac0dbfe12741b96ff373d
tsnoamhttps://github.com/tsnoam
completedhttps://github.com/python-telegram-bot/python-telegram-bot/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
#1905https://github.com/python-telegram-bot/python-telegram-bot/pull/1905
on May 1, 2020https://github.com/python-telegram-bot/python-telegram-bot/issues/1837#event-3294040466
github-actionshttps://github.com/apps/github-actions
on Aug 19, 2020https://github.com/python-telegram-bot/python-telegram-bot/issues/1837#event-3668992939
Bibo-Joshihttps://github.com/Bibo-Joshi
enhancementhttps://github.com/python-telegram-bot/python-telegram-bot/issues?q=state%3Aopen%20label%3A%22enhancement%22
on Nov 4, 2024https://github.com/python-telegram-bot/python-telegram-bot/issues/1837#event-15107545284
Sign up for freehttps://github.com/signup?return_to=https://github.com/python-telegram-bot/python-telegram-bot/issues/1837
Sign in to commenthttps://github.com/login?return_to=https://github.com/python-telegram-bot/python-telegram-bot/issues/1837
💡 featurehttps://github.com/python-telegram-bot/python-telegram-bot/issues?q=type:"💡 feature"
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.