René's URL Explorer Experiment


Title: [BUG] Job_queue is skipping job if timezone is not provided for job.run_daily · Issue #1693 · python-telegram-bot/python-telegram-bot · GitHub

Open Graph Title: [BUG] Job_queue is skipping job if timezone is not provided for job.run_daily · Issue #1693 · python-telegram-bot/python-telegram-bot

X Title: [BUG] Job_queue is skipping job if timezone is not provided for job.run_daily · Issue #1693 · python-telegram-bot/python-telegram-bot

Description: For example, my local timezone is +3 UTC and I want to run job every working day at 23:00 UTC. launch_time.tzinfo is None so it's expected to be interpreted as 23:00 UTC. launch_time = dtm.time(hour=23) job = job_queue.run_daily(run_once...

Open Graph Description: For example, my local timezone is +3 UTC and I want to run job every working day at 23:00 UTC. launch_time.tzinfo is None so it's expected to be interpreted as 23:00 UTC. launch_time = dtm.time(hou...

X Description: For example, my local timezone is +3 UTC and I want to run job every working day at 23:00 UTC. launch_time.tzinfo is None so it's expected to be interpreted as 23:00 UTC. launch_time = dtm.time...

Opengraph URL: https://github.com/python-telegram-bot/python-telegram-bot/issues/1693

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"[BUG] Job_queue is skipping job if timezone is not provided for job.run_daily","articleBody":"For example, my local timezone is +3 UTC and I want to run job every working day at 23:00 UTC.\r\n\r\n`launch_time.tzinfo` is `None` so it's expected to be interpreted as 23:00 UTC.\r\n```python\r\nlaunch_time = dtm.time(hour=23)\r\njob = job_queue.run_daily(run_once, launch_time,\r\n                          days=(0, 1, 3, 4))\r\n```\r\n\r\nSince `launch_time.tzinfo` was `None`, `job.tzinfo` is also equals `None` because of the following code from `JobQueue.run_daily` https://github.com/python-telegram-bot/python-telegram-bot/blob/3d42df3366d7cff030c3ce06d6a95259b3bdf62e/telegram/ext/jobqueue.py#L225-L232\r\n\r\nLet's assume now is 23:00 UTC Friday. \r\n\r\nThe following code from `JobQueue.tick` won't run the job because \r\n1) `datetime.datetime.now(None)` returns local time and local time now is 02:00 Saturday.\r\n2) then `datetime.datetime.now(job.tzinfo).date().weekday()` will return `5`\r\n3) `any(day == current_week_day for day in job.days)` will return `False` because we're looking for `(0, 1, 3, 4)`\r\nSo job won't be run until 23:00 UTC Sunday.\r\nhttps://github.com/python-telegram-bot/python-telegram-bot/blob/3d42df3366d7cff030c3ce06d6a95259b3bdf62e/telegram/ext/jobqueue.py#L275-L280\r\n\r\n\r\nAnd one more thing - when #1685 will be merged, in the described case `Job.next_t` will be returning local time when utc time is expected:\r\n```python\r\n    @property\r\n    def next_t(self):\r\n        return datetime.datetime.fromtimestamp(self._next_t, self.tzinfo) if self._next_t else None\r\n\r\n```\r\n","author":{"url":"https://github.com/Andrej730","@type":"Person","name":"Andrej730"},"datePublished":"2020-01-05T14:17:47Z","url":"https://github.com/python-telegram-bot/python-telegram-bot/issues/1693"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:c72bae55-580b-189e-e6f2-9302bf27fb3c
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idC948:EA06E:574A59C:6E5434C:6B02781C
html-safe-nonceee25ebbcae9133022211c4992a8ce8bcbc190219ee63abe83466d466e954fb70
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDOTQ4OkVBMDZFOjU3NEE1OUM6NkU1NDM0Qzo2QjAyNzgxQyIsInZpc2l0b3JfaWQiOiIyMTAyNDg5NzMxMzE2MjE3ODg1IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac01c8c99ba36916ab24560e708c1b7e2ae3eed79cdc2fc7fdb29e176a1f6e3f9f
hovercard-subject-tagissue:545423333
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/python-telegram-bot/python-telegram-bot/1693/issue_layout
twitter:imagehttps://opengraph.githubassets.com/5dfe06398d820d8b21189ddb6c5ba6209d707d509f6cc1a849e739d1647f9ab8/python-telegram-bot/python-telegram-bot/issues/1693
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/5dfe06398d820d8b21189ddb6c5ba6209d707d509f6cc1a849e739d1647f9ab8/python-telegram-bot/python-telegram-bot/issues/1693
og:image:altFor example, my local timezone is +3 UTC and I want to run job every working day at 23:00 UTC. launch_time.tzinfo is None so it's expected to be interpreted as 23:00 UTC. launch_time = dtm.time(hou...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameAndrej730
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
go-importgithub.com/python-telegram-bot/python-telegram-bot git https://github.com/python-telegram-bot/python-telegram-bot.git
octolytics-dimension-user_id16178365
octolytics-dimension-user_loginpython-telegram-bot
octolytics-dimension-repository_id38696925
octolytics-dimension-repository_nwopython-telegram-bot/python-telegram-bot
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id38696925
octolytics-dimension-repository_network_root_nwopython-telegram-bot/python-telegram-bot
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/python-telegram-bot/python-telegram-bot/issues/1693#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython-telegram-bot%2Fpython-telegram-bot%2Fissues%2F1693
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython-telegram-bot%2Fpython-telegram-bot%2Fissues%2F1693
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=python-telegram-bot%2Fpython-telegram-bot
Reloadhttps://github.com/python-telegram-bot/python-telegram-bot/issues/1693
Reloadhttps://github.com/python-telegram-bot/python-telegram-bot/issues/1693
Reloadhttps://github.com/python-telegram-bot/python-telegram-bot/issues/1693
python-telegram-bothttps://github.com/python-telegram-bot
python-telegram-bothttps://github.com/python-telegram-bot/python-telegram-bot
Codehttps://github.com/python-telegram-bot/python-telegram-bot
Issues23 (23)https://github.com/python-telegram-bot/python-telegram-bot/issues
Pull requests19 (19)https://github.com/python-telegram-bot/python-telegram-bot/pulls
Discussionshttps://github.com/python-telegram-bot/python-telegram-bot/discussions
Actionshttps://github.com/python-telegram-bot/python-telegram-bot/actions
Projectshttps://github.com/python-telegram-bot/python-telegram-bot/projects
Wikihttps://github.com/python-telegram-bot/python-telegram-bot/wiki
Security and qualityhttps://github.com/python-telegram-bot/python-telegram-bot/security
Insightshttps://github.com/python-telegram-bot/python-telegram-bot/insights
https://github.com/python-telegram-bot/python-telegram-bot
New issuehttps://github.com/login?return_to=https://github.com/python-telegram-bot/python-telegram-bot/issues/1693
New issuehttps://github.com/login?return_to=https://github.com/python-telegram-bot/python-telegram-bot/issues/1693
🐛 bughttps://github.com/python-telegram-bot/python-telegram-bot/issues?q=type:"🐛 bug"
#1696https://github.com/python-telegram-bot/python-telegram-bot/pull/1696
[BUG] Job_queue is skipping job if timezone is not provided for job.run_dailyhttps://github.com/python-telegram-bot/python-telegram-bot/issues/1693#top
#1696https://github.com/python-telegram-bot/python-telegram-bot/pull/1696
https://github.com/Andrej730
Andrej730https://github.com/Andrej730
on Jan 5, 2020https://github.com/python-telegram-bot/python-telegram-bot/issues/1693#issue-545423333
python-telegram-bot/telegram/ext/jobqueue.pyhttps://github.com/python-telegram-bot/python-telegram-bot/blob/3d42df3366d7cff030c3ce06d6a95259b3bdf62e/telegram/ext/jobqueue.py#L225-L232
3d42df3https://github.com/python-telegram-bot/python-telegram-bot/commit/3d42df3366d7cff030c3ce06d6a95259b3bdf62e
python-telegram-bot/telegram/ext/jobqueue.pyhttps://github.com/python-telegram-bot/python-telegram-bot/blob/3d42df3366d7cff030c3ce06d6a95259b3bdf62e/telegram/ext/jobqueue.py#L275-L280
3d42df3https://github.com/python-telegram-bot/python-telegram-bot/commit/3d42df3366d7cff030c3ce06d6a95259b3bdf62e
#1685https://github.com/python-telegram-bot/python-telegram-bot/pull/1685
Andrej730https://github.com/Andrej730
bug 🐛https://github.com/python-telegram-bot/python-telegram-bot/issues?q=state%3Aopen%20label%3A%22bug%20%3Abug%3A%22
on Jan 5, 2020https://github.com/python-telegram-bot/python-telegram-bot/issues/1693#event-2922493630
https://github.com/Bibo-Joshi
Bibo-Joshihttps://github.com/Bibo-Joshi
on Jan 5, 2020https://github.com/python-telegram-bot/python-telegram-bot/issues/1693#issuecomment-570916892
https://github.com/Andrej730
Andrej730https://github.com/Andrej730
on Jan 5, 2020https://github.com/python-telegram-bot/python-telegram-bot/issues/1693#issuecomment-570917624
#1685https://github.com/python-telegram-bot/python-telegram-bot/pull/1685
https://github.com/Bibo-Joshi
Bibo-Joshihttps://github.com/Bibo-Joshi
on Jan 5, 2020https://github.com/python-telegram-bot/python-telegram-bot/issues/1693#issuecomment-570918181
Bibo-Joshihttps://github.com/Bibo-Joshi
12.5https://github.com/python-telegram-bot/python-telegram-bot/milestone/17
on Jan 5, 2020https://github.com/python-telegram-bot/python-telegram-bot/issues/1693#event-2922527301
Bibo-Joshihttps://github.com/Bibo-Joshi
12.5https://github.com/python-telegram-bot/python-telegram-bot/milestone/17
on Feb 6, 2020https://github.com/python-telegram-bot/python-telegram-bot/issues/1693#event-3012887395
Andrej730https://github.com/Andrej730
on Feb 22, 2020https://github.com/python-telegram-bot/python-telegram-bot/issues/1693#event-3062549419
1. Made sure that default tzinfo in JobQueue is UTC python-telegram-b…https://github.com/Andrej730/python-telegram-bot/commit/4efb50f1a6e5714e2e1f2503be090add53b0ff31
python-telegram-b…https://github.com/python-telegram-bot/python-telegram-bot/issues/1693
4efb50fhttps://github.com/Andrej730/python-telegram-bot/commit/4efb50f1a6e5714e2e1f2503be090add53b0ff31
Fix for tzinfo issues in JobQueuehttps://github.com/Andrej730/python-telegram-bot/commit/4a6df2250c336f7dd30f4dc8e3916edcd913c5e6
4a6df22https://github.com/Andrej730/python-telegram-bot/commit/4a6df2250c336f7dd30f4dc8e3916edcd913c5e6
Bibo-Joshihttps://github.com/Bibo-Joshi
completedhttps://github.com/python-telegram-bot/python-telegram-bot/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
#1696https://github.com/python-telegram-bot/python-telegram-bot/pull/1696
on Mar 30, 2020https://github.com/python-telegram-bot/python-telegram-bot/issues/1693#event-3179388327
Bibo-Joshihttps://github.com/Bibo-Joshi
on Mar 30, 2020https://github.com/python-telegram-bot/python-telegram-bot/issues/1693#event-3179388499
Fix UTC as default tzinfo for Jobs (#1696)https://github.com/python-telegram-bot/python-telegram-bot/commit/9cb34af65ab3231c6e5ba1ccee9d65f38d787824
#1696https://github.com/python-telegram-bot/python-telegram-bot/pull/1696
9cb34afhttps://github.com/python-telegram-bot/python-telegram-bot/commit/9cb34af65ab3231c6e5ba1ccee9d65f38d787824
https://github.com/anh-source
anh-sourcehttps://github.com/anh-source
on Apr 22, 2020https://github.com/python-telegram-bot/python-telegram-bot/issues/1693#issuecomment-617801132
https://github.com/Bibo-Joshi
Bibo-Joshihttps://github.com/Bibo-Joshi
on Apr 22, 2020https://github.com/python-telegram-bot/python-telegram-bot/issues/1693#issuecomment-617812095
#1696https://github.com/python-telegram-bot/python-telegram-bot/pull/1696
github-actionshttps://github.com/apps/github-actions
on Aug 19, 2020https://github.com/python-telegram-bot/python-telegram-bot/issues/1693#event-3668993038
Bibo-Joshihttps://github.com/Bibo-Joshi
bug 🐛https://github.com/python-telegram-bot/python-telegram-bot/issues?q=state%3Aopen%20label%3A%22bug%20%3Abug%3A%22
on Nov 4, 2024https://github.com/python-telegram-bot/python-telegram-bot/issues/1693#event-15107545208
Sign up for freehttps://github.com/signup?return_to=https://github.com/python-telegram-bot/python-telegram-bot/issues/1693
Sign in to commenthttps://github.com/login?return_to=https://github.com/python-telegram-bot/python-telegram-bot/issues/1693
🐛 bughttps://github.com/python-telegram-bot/python-telegram-bot/issues?q=type:"🐛 bug"
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.