René's URL Explorer Experiment


Title: Dispatcher force updating persistence object's chat data attribute · Issue #1452 · python-telegram-bot/python-telegram-bot · GitHub

Open Graph Title: Dispatcher force updating persistence object's chat data attribute · Issue #1452 · python-telegram-bot/python-telegram-bot

X Title: Dispatcher force updating persistence object's chat data attribute · Issue #1452 · python-telegram-bot/python-telegram-bot

Description: Steps to reproduce Use the echobot2 example code with a few changes list below. In main function create a DictPersistence object with store_chat_data set to False. Create the Updater object with persistence set to the object created in t...

Open Graph Description: Steps to reproduce Use the echobot2 example code with a few changes list below. In main function create a DictPersistence object with store_chat_data set to False. Create the Updater object with pe...

X Description: Steps to reproduce Use the echobot2 example code with a few changes list below. In main function create a DictPersistence object with store_chat_data set to False. Create the Updater object with pe...

Opengraph URL: https://github.com/python-telegram-bot/python-telegram-bot/issues/1452

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Dispatcher force updating persistence object's chat data attribute","articleBody":"\u003c!--\r\nThanks for reporting issues of python-telegram-bot!\r\n\r\nUse this template to notify us if you found a bug, or if you want to request a new feature.\r\nIf you're looking for help with programming your bot using our library, feel free to ask your\r\nquestions in out telegram group at: https://t.me/pythontelegrambotgroup\r\n\r\nTo make it easier for us to help you please enter detailed information below.\r\n\r\nPlease note, we only support the latest version of python-telegram-bot and\r\nmaster branch. Please make sure to upgrade & recreate the issue on the latest\r\nversion prior to opening an issue.\r\n-->\r\n### Steps to reproduce\r\n1. Use the echobot2 example code with a few changes list below.\r\n\r\n2. In main function create a DictPersistence object with store_chat_data set to False.\r\n\r\n2. Create the Updater object with persistence set to the object created in the second step.\r\n\r\n4. Send SIGKILL to the process in which the example code is launched.\r\n### Expected behaviour\r\nThe code should normally terminate.\r\n\r\n### Actual behaviour\r\nThe code terminates with the following error:\r\nFile \".../echobot2.py\", line 81, in main\r\n    updater.idle()\r\n  File \".../.venv/lib/python3.7/site-packages/telegram/ext/updater.py\", line 529, in idle\r\n    sleep(1)\r\n  File \".../.venv/lib/python3.7/site-packages/telegram/ext/updater.py\", line 504, in signal_handler\r\n    self.dispatcher.update_persistence()\r\n  File \".../.venv/lib/python3.7/site-packages/telegram/ext/dispatcher.py\", line 437, in update_persistence\r\n    self.persistence.update_chat_data(chat_id, self.chat_data[chat_id])\r\n  File \".../.venv/lib/python3.7/site-packages/telegram/ext/dictpersistence.py\", line 193, in update_chat_data\r\n    if self._chat_data.get(chat_id) == data:\r\nAttributeError: 'NoneType' object has no attribute 'get'\r\n\r\nTracing back the error, it seems that when receiving the SIGKILL signal, the dispatcher is force updating the persistence object's chat data attribute without checking its store_chat_data attribute, see the following code from telegram.ext.dispatcher.py:\r\n\r\n def update_persistence(self):\r\n        \"\"\"Update :attr:`user_data` and :attr:`chat_data` in :attr:`persistence`.\r\n        \"\"\"\r\n        if self.persistence:\r\n            for chat_id in self.chat_data:\r\n                self.persistence.update_chat_data(chat_id, self.chat_data[chat_id])\r\n            for user_id in self.user_data:\r\n                self.persistence.update_user_data(user_id, self.user_data[user_id])\r\n\r\n### Configuration\r\n**Operating System:**\r\nManjaro 18.0.4 Illyria\r\n\r\n**Version of Python, python-telegram-bot & dependencies:**\r\npython-telegram-bot 12.0.0b1\r\ncertifi 2019.06.16\r\nfuture 0.17.1\r\nPython 3.7.3 (default, Jun 24 2019, 04:54:02)  [GCC 9.1.0]","author":{"url":"https://github.com/CuriousGeorgiy","@type":"Person","name":"CuriousGeorgiy"},"datePublished":"2019-07-20T20:18:59Z","url":"https://github.com/python-telegram-bot/python-telegram-bot/issues/1452"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:8a77711b-0c19-273c-2874-bd2871002491
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idA80E:D5B7F:D8A052:11C4A19:6B0279C7
html-safe-nonce06ff365115b40472329625b7d63152f355a8d49813cabfa64fa860b1e3327b1b
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBODBFOkQ1QjdGOkQ4QTA1MjoxMUM0QTE5OjZCMDI3OUM3IiwidmlzaXRvcl9pZCI6Ijc5MTA0NTcxNTI1MjE3OTYwMzkiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacdd13342c0b7085e4a1864225fc1c66a40ad71cd1f901128cea57351063045435
hovercard-subject-tagissue:470710964
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/python-telegram-bot/python-telegram-bot/1452/issue_layout
twitter:imagehttps://opengraph.githubassets.com/92b33aee7e56918eb34d7093ad2ce5a039c471146bc8ecd404f24f5ac979605c/python-telegram-bot/python-telegram-bot/issues/1452
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/92b33aee7e56918eb34d7093ad2ce5a039c471146bc8ecd404f24f5ac979605c/python-telegram-bot/python-telegram-bot/issues/1452
og:image:altSteps to reproduce Use the echobot2 example code with a few changes list below. In main function create a DictPersistence object with store_chat_data set to False. Create the Updater object with pe...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameCuriousGeorgiy
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
go-importgithub.com/python-telegram-bot/python-telegram-bot git https://github.com/python-telegram-bot/python-telegram-bot.git
octolytics-dimension-user_id16178365
octolytics-dimension-user_loginpython-telegram-bot
octolytics-dimension-repository_id38696925
octolytics-dimension-repository_nwopython-telegram-bot/python-telegram-bot
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id38696925
octolytics-dimension-repository_network_root_nwopython-telegram-bot/python-telegram-bot
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/python-telegram-bot/python-telegram-bot/issues/1452#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython-telegram-bot%2Fpython-telegram-bot%2Fissues%2F1452
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython-telegram-bot%2Fpython-telegram-bot%2Fissues%2F1452
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=python-telegram-bot%2Fpython-telegram-bot
Reloadhttps://github.com/python-telegram-bot/python-telegram-bot/issues/1452
Reloadhttps://github.com/python-telegram-bot/python-telegram-bot/issues/1452
Reloadhttps://github.com/python-telegram-bot/python-telegram-bot/issues/1452
python-telegram-bothttps://github.com/python-telegram-bot
python-telegram-bothttps://github.com/python-telegram-bot/python-telegram-bot
Codehttps://github.com/python-telegram-bot/python-telegram-bot
Issues23 (23)https://github.com/python-telegram-bot/python-telegram-bot/issues
Pull requests19 (19)https://github.com/python-telegram-bot/python-telegram-bot/pulls
Discussionshttps://github.com/python-telegram-bot/python-telegram-bot/discussions
Actionshttps://github.com/python-telegram-bot/python-telegram-bot/actions
Projectshttps://github.com/python-telegram-bot/python-telegram-bot/projects
Wikihttps://github.com/python-telegram-bot/python-telegram-bot/wiki
Security and qualityhttps://github.com/python-telegram-bot/python-telegram-bot/security
Insightshttps://github.com/python-telegram-bot/python-telegram-bot/insights
https://github.com/python-telegram-bot/python-telegram-bot
New issuehttps://github.com/login?return_to=https://github.com/python-telegram-bot/python-telegram-bot/issues/1452
New issuehttps://github.com/login?return_to=https://github.com/python-telegram-bot/python-telegram-bot/issues/1452
#1462https://github.com/python-telegram-bot/python-telegram-bot/pull/1462
Dispatcher force updating persistence object's chat data attributehttps://github.com/python-telegram-bot/python-telegram-bot/issues/1452#top
#1462https://github.com/python-telegram-bot/python-telegram-bot/pull/1462
📋 pending-mergework status: pending-mergehttps://github.com/python-telegram-bot/python-telegram-bot/issues?q=state%3Aopen%20label%3A%22%F0%9F%93%8B%20pending-merge%22
https://github.com/CuriousGeorgiy
CuriousGeorgiyhttps://github.com/CuriousGeorgiy
on Jul 20, 2019https://github.com/python-telegram-bot/python-telegram-bot/issues/1452#issue-470710964
https://github.com/Bibo-Joshi
Bibo-Joshihttps://github.com/Bibo-Joshi
on Aug 4, 2019https://github.com/python-telegram-bot/python-telegram-bot/issues/1452#issuecomment-517984000
#1312https://github.com/python-telegram-bot/python-telegram-bot/pull/1312
@maintainershttps://github.com/maintainers
Bibo-Joshihttps://github.com/Bibo-Joshi
📋 pending-mergework status: pending-mergehttps://github.com/python-telegram-bot/python-telegram-bot/issues?q=state%3Aopen%20label%3A%22%F0%9F%93%8B%20pending-merge%22
on Aug 21, 2019https://github.com/python-telegram-bot/python-telegram-bot/issues/1452#event-2574267167
tsnoamhttps://github.com/tsnoam
completedhttps://github.com/python-telegram-bot/python-telegram-bot/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
#1462https://github.com/python-telegram-bot/python-telegram-bot/pull/1462
on Aug 23, 2019https://github.com/python-telegram-bot/python-telegram-bot/issues/1452#event-2580558737
tsnoamhttps://github.com/tsnoam
on Aug 23, 2019https://github.com/python-telegram-bot/python-telegram-bot/issues/1452#event-2580558787
Fix for #1452 (#1462)https://github.com/python-telegram-bot/python-telegram-bot/commit/a1eabc0cae923b3e0c871621900e0a638d50a3cb
#1452https://github.com/python-telegram-bot/python-telegram-bot/issues/1452
#1462https://github.com/python-telegram-bot/python-telegram-bot/pull/1462
a1eabc0https://github.com/python-telegram-bot/python-telegram-bot/commit/a1eabc0cae923b3e0c871621900e0a638d50a3cb
github-actionshttps://github.com/apps/github-actions
on Aug 21, 2020https://github.com/python-telegram-bot/python-telegram-bot/issues/1452#event-3680548545
Sign up for freehttps://github.com/signup?return_to=https://github.com/python-telegram-bot/python-telegram-bot/issues/1452
Sign in to commenthttps://github.com/login?return_to=https://github.com/python-telegram-bot/python-telegram-bot/issues/1452
📋 pending-mergework status: pending-mergehttps://github.com/python-telegram-bot/python-telegram-bot/issues?q=state%3Aopen%20label%3A%22%F0%9F%93%8B%20pending-merge%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.