Title: Condition to split the text in `make_parts` function · Issue #182 · python-smpplib/python-smpplib · GitHub
Open Graph Title: Condition to split the text in `make_parts` function · Issue #182 · python-smpplib/python-smpplib
X Title: Condition to split the text in `make_parts` function · Issue #182 · python-smpplib/python-smpplib
Description: I noticed that when my message is 160 characters but it contains the char € (or any symbols from extended table), the encoded_length is 161 as it should be, since the € char counts for two. However, in the make_parts function from gsm.py...
Open Graph Description: I noticed that when my message is 160 characters but it contains the char € (or any symbols from extended table), the encoded_length is 161 as it should be, since the € char counts for two. However...
X Description: I noticed that when my message is 160 characters but it contains the char € (or any symbols from extended table), the encoded_length is 161 as it should be, since the € char counts for two. However...
Opengraph URL: https://github.com/python-smpplib/python-smpplib/issues/182
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Condition to split the text in `make_parts` function","articleBody":"I noticed that when my message is 160 characters but it contains the char € (or any symbols from extended table), the encoded_length is 161 as it should be, since the € char counts for two. However, in the make_parts function from gsm.py, the condition for knowing if the message should be split or not is based on `len(text)` which returns 160. To me, the condition should be based on `len(encoded_text)`\r\n\r\nEdit : I noticed it because of submit_sm_resp failed and the ESME told me I wasn't splitting the message although it was 161 characters. ","author":{"url":"https://github.com/fpalamour","@type":"Person","name":"fpalamour"},"datePublished":"2021-11-08T12:13:50.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":4},"url":"https://github.com/182/python-smpplib/issues/182"}
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:29eebc27-93bf-4d42-6d5d-86b75ea8358d |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | 8600:1E5465:1F50BEA:2C0B1DD:696F6156 |
| html-safe-nonce | 89446040337c65ec8d55b3dc993faf47999f86c9354ed8dc6f757d115184dad0 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4NjAwOjFFNTQ2NToxRjUwQkVBOjJDMEIxREQ6Njk2RjYxNTYiLCJ2aXNpdG9yX2lkIjoiNDU3NzU2Njg0MTY4NjgzODYyIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | e76d0756a9c15adbbb9d943c990e7d4d4f1e091e0a1d2873e664bea19b9a51eb |
| hovercard-subject-tag | issue:1047377238 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/python-smpplib/python-smpplib/182/issue_layout |
| twitter:image | https://opengraph.githubassets.com/05a49c05dfe3570bae8867803c29ab21be0365e0b4d08c5f6c2a2bd79cf6bf26/python-smpplib/python-smpplib/issues/182 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/05a49c05dfe3570bae8867803c29ab21be0365e0b4d08c5f6c2a2bd79cf6bf26/python-smpplib/python-smpplib/issues/182 |
| og:image:alt | I noticed that when my message is 160 characters but it contains the char € (or any symbols from extended table), the encoded_length is 161 as it should be, since the € char counts for two. However... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | fpalamour |
| hostname | github.com |
| expected-hostname | github.com |
| None | 774d0922d2c4577043d2dab90427344eb4c6ce1d5579acb1dd504cff1a7e46f8 |
| turbo-cache-control | no-preview |
| go-import | github.com/python-smpplib/python-smpplib git https://github.com/python-smpplib/python-smpplib.git |
| octolytics-dimension-user_id | 45378833 |
| octolytics-dimension-user_login | python-smpplib |
| octolytics-dimension-repository_id | 9441405 |
| octolytics-dimension-repository_nwo | python-smpplib/python-smpplib |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 9441405 |
| octolytics-dimension-repository_network_root_nwo | python-smpplib/python-smpplib |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 650acea592f12d1bd8931d44546c209e0b06ed6e |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width