| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:046f887b-d4ef-f8d4-bbea-e31f7924cefa |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | E622:147766:36341:49CF1:696FF61B |
| html-safe-nonce | e821622b46c9ae60cfc9016364d4f52a617329a2db1442a9a055ed880eb74592 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFNjIyOjE0Nzc2NjozNjM0MTo0OUNGMTo2OTZGRjYxQiIsInZpc2l0b3JfaWQiOiI2NTA4Njc2ODEzNjgyMjAzIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 4b83500fdf11690a3f9498a728df79eaa3d8e12862c24c665337369e1aa8b6e8 |
| hovercard-subject-tag | pull_request:1534127205 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python-semver/python-semver/427/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/8f95125d3c4a95e825ffcdf874ef6375fc015c84bc59f1933c2291f2c6f5ddee/python-semver/python-semver/pull/427 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/8f95125d3c4a95e825ffcdf874ef6375fc015c84bc59f1933c2291f2c6f5ddee/python-semver/python-semver/pull/427 |
| og:image:alt | This fixes PR #426
When using the replace method, an instance of the Version class is created and not the subclass. This commit fixes this behavior.
@dannystaple: Could you have a look, please? 🙂
(... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | tomschr |
| hostname | github.com |
| expected-hostname | github.com |
| None | 61db99bbb6a7517db80567029869280bdefa9fa883092d6c2aa07ec4ea15f359 |
| turbo-cache-control | no-preview |
| go-import | github.com/python-semver/python-semver git https://github.com/python-semver/python-semver.git |
| octolytics-dimension-user_id | 57228994 |
| octolytics-dimension-user_login | python-semver |
| octolytics-dimension-repository_id | 3375726 |
| octolytics-dimension-repository_nwo | python-semver/python-semver |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 3375726 |
| octolytics-dimension-repository_network_root_nwo | python-semver/python-semver |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 91ceb31fcdebd150222e05551caf4a28f9532341 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/python-semver/python-semver/pull/427#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython-semver%2Fpython-semver%2Fpull%2F427 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython-semver%2Fpython-semver%2Fpull%2F427 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python-semver%2Fpython-semver |
| Reload | https://github.com/python-semver/python-semver/pull/427 |
| Reload | https://github.com/python-semver/python-semver/pull/427 |
| Reload | https://github.com/python-semver/python-semver/pull/427 |
|
python-semver
| https://github.com/python-semver |
| python-semver | https://github.com/python-semver/python-semver |
|
Notifications
| https://github.com/login?return_to=%2Fpython-semver%2Fpython-semver |
|
Fork
96
| https://github.com/login?return_to=%2Fpython-semver%2Fpython-semver |
|
Star
516
| https://github.com/login?return_to=%2Fpython-semver%2Fpython-semver |
|
Code
| https://github.com/python-semver/python-semver |
|
Issues
12
| https://github.com/python-semver/python-semver/issues |
|
Pull requests
3
| https://github.com/python-semver/python-semver/pulls |
|
Discussions
| https://github.com/python-semver/python-semver/discussions |
|
Actions
| https://github.com/python-semver/python-semver/actions |
|
Projects
0
| https://github.com/python-semver/python-semver/projects |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/python-semver/python-semver/security |
| Please reload this page | https://github.com/python-semver/python-semver/pull/427 |
|
Insights
| https://github.com/python-semver/python-semver/pulse |
|
Code
| https://github.com/python-semver/python-semver |
|
Issues
| https://github.com/python-semver/python-semver/issues |
|
Pull requests
| https://github.com/python-semver/python-semver/pulls |
|
Discussions
| https://github.com/python-semver/python-semver/discussions |
|
Actions
| https://github.com/python-semver/python-semver/actions |
|
Projects
| https://github.com/python-semver/python-semver/projects |
|
Security
| https://github.com/python-semver/python-semver/security |
|
Insights
| https://github.com/python-semver/python-semver/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fpython-semver%2Fpython-semver%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fpython-semver%2Fpython-semver%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/python-semver/python-semver/pull/427#issue-comment-box |
| tomschr | https://github.com/tomschr |
| python-semver:master | https://github.com/python-semver/python-semver/tree/master |
| tomschr:fix-426-match-derivedclass | https://github.com/tomschr/python-semver/tree/fix-426-match-derivedclass |
|
Fix #426: call subclass when deriving from Version
| https://github.com/python-semver/python-semver/pull/427#top |
| tomschr | https://github.com/tomschr |
| python-semver:master | https://github.com/python-semver/python-semver/tree/master |
| tomschr:fix-426-match-derivedclass | https://github.com/tomschr/python-semver/tree/fix-426-match-derivedclass |
|
Conversation
2
| https://github.com/python-semver/python-semver/pull/427 |
|
Commits
2
| https://github.com/python-semver/python-semver/pull/427/commits |
|
Checks
0
| https://github.com/python-semver/python-semver/pull/427/checks |
|
Files changed
| https://github.com/python-semver/python-semver/pull/427/files |
| Please reload this page | https://github.com/python-semver/python-semver/pull/427 |
| https://github.co/hiddenchars |
| https://github.com/python-semver/python-semver/pull/{{ revealButtonHref }} |
|
| https://github.com/tomschr |
| tomschr | https://github.com/tomschr |
| Sep 28, 2023 | https://github.com/python-semver/python-semver/pull/427#issue-1917457958 |
| Please reload this page | https://github.com/python-semver/python-semver/pull/427 |
| #426 | https://github.com/python-semver/python-semver/issues/426 |
| @dannystaple | https://github.com/dannystaple |
| Please reload this page | https://github.com/python-semver/python-semver/pull/427 |
| https://github.com/tomschr |
| tomschr | https://github.com/tomschr |
|
Bug
| https://github.com/python-semver/python-semver/issues?q=state%3Aopen%20label%3ABug |
| Sep 28, 2023 | https://github.com/python-semver/python-semver/pull/427#event-10498907587 |
| https://github.com/dannystaple |
| dannystaple | https://github.com/dannystaple |
|
Sep 28, 2023
| https://github.com/python-semver/python-semver/pull/427#pullrequestreview-1649018143 |
|
View reviewed changes
| https://github.com/python-semver/python-semver/pull/427/files |
| https://github.com/dannystaple |
| dannystaple | https://github.com/dannystaple |
| Sep 28, 2023 | https://github.com/python-semver/python-semver/pull/427#issuecomment-1739371101 |
| Please reload this page | https://github.com/python-semver/python-semver/pull/427 |
| https://github.com/tomschr |
| tomschr | https://github.com/tomschr |
| force-pushed | https://github.com/python-semver/python-semver/compare/1f131ec8b757b28c0c0e9ff237854887e18bc592..cce839a6f263f6fdc20204ccddc90156ed2597fb |
| 1f131ec | https://github.com/python-semver/python-semver/commit/1f131ec8b757b28c0c0e9ff237854887e18bc592 |
| cce839a | https://github.com/python-semver/python-semver/commit/cce839a6f263f6fdc20204ccddc90156ed2597fb |
|
Compare
| https://github.com/python-semver/python-semver/compare/1f131ec8b757b28c0c0e9ff237854887e18bc592..cce839a6f263f6fdc20204ccddc90156ed2597fb |
| September 29, 2023 12:36 | https://github.com/python-semver/python-semver/pull/427#event-10510962394 |
|
| https://github.com/tomschr |
|
| https://github.com/dannystaple |
| Fix | https://github.com/python-semver/python-semver/pull/427/commits/4b03f867a3deaecb07240f471fed9bf9c9072629 |
| python-semver#426 | https://github.com/python-semver/python-semver/issues/426 |
| : call subclass when deriving from Version | https://github.com/python-semver/python-semver/pull/427/commits/4b03f867a3deaecb07240f471fed9bf9c9072629 |
| 4b03f86 | https://github.com/python-semver/python-semver/pull/427/commits/4b03f867a3deaecb07240f471fed9bf9c9072629 |
| https://github.com/tomschr |
| tomschr | https://github.com/tomschr |
| force-pushed | https://github.com/python-semver/python-semver/compare/cce839a6f263f6fdc20204ccddc90156ed2597fb..51812998000f16d897779eee09b1f5e233f4a794 |
| cce839a | https://github.com/python-semver/python-semver/commit/cce839a6f263f6fdc20204ccddc90156ed2597fb |
| 5181299 | https://github.com/python-semver/python-semver/commit/51812998000f16d897779eee09b1f5e233f4a794 |
|
Compare
| https://github.com/python-semver/python-semver/compare/cce839a6f263f6fdc20204ccddc90156ed2597fb..51812998000f16d897779eee09b1f5e233f4a794 |
| September 29, 2023 12:38 | https://github.com/python-semver/python-semver/pull/427#event-10510978241 |
|
| https://github.com/tomschr |
| GHA: Require setuptool>60 and setuptools-scm>60 | https://github.com/python-semver/python-semver/pull/427/commits/2dda51c0b3d0956187533210927533af50bf6175 |
| 2dda51c | https://github.com/python-semver/python-semver/pull/427/commits/2dda51c0b3d0956187533210927533af50bf6175 |
| https://github.com/tomschr |
| tomschr | https://github.com/tomschr |
| force-pushed | https://github.com/python-semver/python-semver/compare/51812998000f16d897779eee09b1f5e233f4a794..2dda51c0b3d0956187533210927533af50bf6175 |
| 5181299 | https://github.com/python-semver/python-semver/commit/51812998000f16d897779eee09b1f5e233f4a794 |
| 2dda51c | https://github.com/python-semver/python-semver/commit/2dda51c0b3d0956187533210927533af50bf6175 |
|
Compare
| https://github.com/python-semver/python-semver/compare/51812998000f16d897779eee09b1f5e233f4a794..2dda51c0b3d0956187533210927533af50bf6175 |
| September 29, 2023 12:41 | https://github.com/python-semver/python-semver/pull/427#event-10511009954 |
| https://github.com/tomschr |
| tomschr | https://github.com/tomschr |
| September 29, 2023 12:42 | https://github.com/python-semver/python-semver/pull/427#event-10511016278 |
| https://github.com/tomschr |
| tomschr | https://github.com/tomschr |
| c5c779a | https://github.com/python-semver/python-semver/commit/c5c779a6e4047fd0740cb330fc8e498389b37920 |
| Sep 29, 2023 | https://github.com/python-semver/python-semver/pull/427#event-10511042241 |
| https://github.com/tomschr |
| tomschr | https://github.com/tomschr |
| September 29, 2023 12:45 | https://github.com/python-semver/python-semver/pull/427#event-10511042771 |
| https://github.com/tomschr |
| tomschr | https://github.com/tomschr |
| Sep 29, 2023 | https://github.com/python-semver/python-semver/pull/427#issuecomment-1740843434 |
| @dannystaple | https://github.com/dannystaple |
| Please reload this page | https://github.com/python-semver/python-semver/pull/427 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython-semver%2Fpython-semver%2Fpull%2F427 |
|
| https://github.com/dannystaple |
|
dannystaple
| https://github.com/dannystaple |
|
| https://github.com/python-semver/python-semver/pull/427/files/31634530b5082f2201edb8f11323032dcb807e5b |
|
Bug
| https://github.com/python-semver/python-semver/issues?q=state%3Aopen%20label%3ABug |
| Please reload this page | https://github.com/python-semver/python-semver/pull/427 |
|
| https://github.com/tomschr |
|
| https://github.com/dannystaple |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |