René's URL Explorer Experiment

Title: Restore stubtest and release-tag wheel publishing by espressolee · Pull Request #237 · python-rapidjson/python-rapidjson · GitHub

Open Graph Title: Restore stubtest and release-tag wheel publishing by espressolee · Pull Request #237 · python-rapidjson/python-rapidjson

X Title: Restore stubtest and release-tag wheel publishing by espressolee · Pull Request #237 · python-rapidjson/python-rapidjson

Description: Summary Restore the two failing parts of the current master workflow: align the bundled stubs with the C extension types as checked by mypy 2.1; run the workflow for v* tags and publish wheels only after the test, debug, and wheel jobs have succeeded. Addresses #157. Why The latest exact-master workflow, run 28846305296 at 00e9a146e958d42f84c81dcfdf39572280ecf01f, failed in two independent places: stubtest rapidjson reported 19 errors after the test requirements moved to mypy 2.1. The C extension constructors are implemented in tp_new, while the stubs described them as __init__; Decoder and Encoder are also runtime disjoint bases. The upload job ran on an ordinary master push while the package version was still 1.23, so PyPI rejected the first wheel with 400 File already exists. The old upload condition also used github.event.ref, and the workflow only selected branch pushes, so a release tag could not reach the job even if the condition were re-enabled. Changes Typing stubs Describe Decoder, Encoder, RawJSON, and Validator construction with __new__, matching their C tp_new implementations. Mark Decoder and Encoder with @disjoint_base. This preserves valid single inheritance while rejecting the same incompatible-layout multiple inheritance that fails at runtime. Keep the stubs consumable by the branch's older mypy 1.16 through a narrow attr-defined compatibility ignore on the new typing extension import. Release workflow Trigger on v* tag pushes as well as master branch pushes. Use github.ref for the release-tag predicate. Skip publishing on pull requests and ordinary branch pushes. Require tests, debug-tests, and the complete wheel matrix to succeed before publishing. PR #235 contains a related upload guard on the free-threaded branch. This change targets the currently failing master release path and additionally restores the missing tag trigger and validation dependencies. Verification Based on 00e9a146e958d42f84c81dcfdf39572280ecf01f, candidate head e5663ec092e79cbbb4e00937de6d71b3fa35c7c1: mypy 2.1 stubtest: 19 baseline errors -> Success: no issues found; mypy 1.16 stubtest: pass; type fixtures: Decoder/Encoder single inheritance accepted; incompatible combined inheritance rejected; runtime fixture: the same single/multiple-inheritance behavior; pytest -q tests: 929 passed, 17 skipped, 2 xfailed; actionlint -ignore SC2046: pass (SC2046 is the pre-existing $(which python3) warning); workflow truth table: PR and master push do not publish; v1.24 does; other branches and non-v* tags do not trigger; git diff --check: pass. One local macOS/Python 3.13.12 doctest has a pre-existing final-digit float representation difference. It reproduced identically on unmodified master; the exact Linux workflow above passed all 274 doctests. No documentation or runtime source is changed here. No tag or real PyPI publication has been attempted from this branch. (Developed with AI assistance; the log analysis, runtime checks, and test runs were executed and verified by me.)

Open Graph Description: Summary Restore the two failing parts of the current master workflow: align the bundled stubs with the C extension types as checked by mypy 2.1; run the workflow for v* tags and publish wheels onl...

X Description: Summary Restore the two failing parts of the current master workflow: align the bundled stubs with the C extension types as checked by mypy 2.1; run the workflow for v* tags and publish wheels onl...

Opengraph URL: https://github.com/python-rapidjson/python-rapidjson/pull/237

X: @github

direct link

Domain: github.com

Links:

Viewport: width=device-width