René's URL Explorer Experiment


Title: Preserve tab stop references when changing position by FFspiky · Pull Request #1647 · python-openxml/python-docx · GitHub

Open Graph Title: Preserve tab stop references when changing position by FFspiky · Pull Request #1647 · python-openxml/python-docx

X Title: Preserve tab stop references when changing position by FFspiky · Pull Request #1647 · python-openxml/python-docx

Description: Changing TabStop.position replaces its XML node. If two references were obtained for that tab stop, moving one leaves the other attached to the removed node: setting a dot leader through the earlier reference silently loses that change when the document is saved. The moved proxy's .element also continues to refer to the removed node. Reinsert the existing node in position order, using the same ordering helper for new and moved tab stops. Existing references then see the new position and continue to modify the document. Tests cover node identity, negative positions, ties, and persistence of a leader edit through an earlier reference after saving and reopening the document. Seven regression cases fail on master e454546 and pass with the fix. Validation on macOS arm64 / Python 3.13.2: python -m pytest -q: 1,611 passed. python -m behave --format progress --stop --tags=-wip: 650 scenarios / 1,856 steps passed. Ruff, source/wheel build and git diff --check pass. Targeted Pyright is not clean on master (185 diagnostics) or this patch (161); these files still contain untyped legacy APIs. The test environment uses pytest 8.4.2 and pyparsing 3.2.3, which satisfy the declared development dependencies. Installing pyparsing 3.3.3 instead causes an existing deprecated delimitedList call in the test helper to fail collection under warnings-as-errors. Other platforms and Word rendering were not tested. AI disclosure: OpenAI Codex investigated the bug, prepared and reviewed the patch, and ran the reported checks.

Open Graph Description: Changing TabStop.position replaces its XML node. If two references were obtained for that tab stop, moving one leaves the other attached to the removed node: setting a dot leader through the earlie...

X Description: Changing TabStop.position replaces its XML node. If two references were obtained for that tab stop, moving one leaves the other attached to the removed node: setting a dot leader through the earlie...

Opengraph URL: https://github.com/python-openxml/python-docx/pull/1647

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:1b4a4297-e0a8-2491-e3cd-fffdb288a604
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8974:38602B:26349F:34A56C:6AFF65D4
html-safe-nonce3a18f0c396682132903195fb1779131bec639b159c471d899e2284f28480780e
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4OTc0OjM4NjAyQjoyNjM0OUY6MzRBNTZDOjZBRkY2NUQ0IiwidmlzaXRvcl9pZCI6IjIxMTM1OTE4OTk2NTM2MjkzOTYiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacb421d3cab5fbeb1fc7d2b2a6c41b1538ffffb32d528bdc9c7b54ed7d1ad4d886
hovercard-subject-tagpull_request:5348775178
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python-openxml/python-docx/pull/1647/files
twitter:imagehttps://avatars.githubusercontent.com/u/190641534?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/190641534?s=400&v=4
og:image:altChanging TabStop.position replaces its XML node. If two references were obtained for that tab stop, moving one leaves the other attached to the removed node: setting a dot leader through the earlie...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None41b58589a1c4eda1e3c8904144a412b88ca4455f63ca2ad3629f2e9f3c3a1d12
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python-openxml/python-docx git https://github.com/python-openxml/python-docx.git
octolytics-dimension-user_id3403760
octolytics-dimension-user_loginpython-openxml
octolytics-dimension-repository_id13592924
octolytics-dimension-repository_nwopython-openxml/python-docx
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id13592924
octolytics-dimension-repository_network_root_nwopython-openxml/python-docx
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8968d6d6acc65d74e4df332d23932dd3fd0502a4
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python-openxml/python-docx/pull/1647/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython-openxml%2Fpython-docx%2Fpull%2F1647%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython-openxml%2Fpython-docx%2Fpull%2F1647%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python-openxml%2Fpython-docx
Reloadhttps://github.com/python-openxml/python-docx/pull/1647/files
Reloadhttps://github.com/python-openxml/python-docx/pull/1647/files
Reloadhttps://github.com/python-openxml/python-docx/pull/1647/files
python-openxmlhttps://github.com/python-openxml
python-docxhttps://github.com/python-openxml/python-docx
Codehttps://github.com/python-openxml/python-docx
Issues387 (387)https://github.com/python-openxml/python-docx/issues
Pull requests167 (167)https://github.com/python-openxml/python-docx/pulls
Actionshttps://github.com/python-openxml/python-docx/actions
Projectshttps://github.com/python-openxml/python-docx/projects
Wikihttps://github.com/python-openxml/python-docx/wiki
Security and qualityhttps://github.com/python-openxml/python-docx/security
Insightshttps://github.com/python-openxml/python-docx/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fpython-openxml%2Fpython-docx%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython-openxml%2Fpython-docx%2Fissues%2Fnew%2Fchoose
FFspikyhttps://github.com/FFspiky
python-openxml:masterhttps://github.com/python-openxml/python-docx/tree/master
FFspiky:fix/preserve-tab-stop-referenceshttps://github.com/FFspiky/python-docx/tree/fix/preserve-tab-stop-references
Conversation 0 https://github.com/python-openxml/python-docx/pull/1647
Commits 1 https://github.com/python-openxml/python-docx/pull/1647/commits
Checks 0 https://github.com/python-openxml/python-docx/pull/1647/checks
Files changed https://github.com/python-openxml/python-docx/pull/1647/files
Please reload this pagehttps://github.com/python-openxml/python-docx/pull/1647/files
Preserve tab stop references when changing position https://github.com/python-openxml/python-docx/pull/1647/files#top
Show all changes 1 commit https://github.com/python-openxml/python-docx/pull/1647/files
daf31d3 Preserve tab stop references when changing position FFspiky Nov 17, 2026 https://github.com/python-openxml/python-docx/pull/1647/commits/daf31d3704d926241f9d9e04c1a09645851a4957
Clear filters https://github.com/python-openxml/python-docx/pull/1647/files
Please reload this pagehttps://github.com/python-openxml/python-docx/pull/1647/files
Please reload this pagehttps://github.com/python-openxml/python-docx/pull/1647/files
parfmt.py https://github.com/python-openxml/python-docx/pull/1647/files#diff-37c7a9dae166871f81fd1efa89fac0bf6e41c7aa7148fcde2556bb1e6943d37e
tabstops.py https://github.com/python-openxml/python-docx/pull/1647/files#diff-5167e9435c198b9f6f96774e1eb0a9545b43b583581dce194d29c4521fbc467e
test_tabstops.py https://github.com/python-openxml/python-docx/pull/1647/files#diff-9257389df8f5a4b16a79b50015681f61e41c3a50d3a5d1fb5575657d578f1363
src/docx/oxml/text/parfmt.pyhttps://github.com/python-openxml/python-docx/pull/1647/files#diff-37c7a9dae166871f81fd1efa89fac0bf6e41c7aa7148fcde2556bb1e6943d37e
View file https://github.com/python-openxml/python-docx/blob/daf31d3704d926241f9d9e04c1a09645851a4957/src/docx/oxml/text/parfmt.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python-openxml/python-docx/pull/1647/{{ revealButtonHref }}
https://github.com/python-openxml/python-docx/pull/1647/files#diff-37c7a9dae166871f81fd1efa89fac0bf6e41c7aa7148fcde2556bb1e6943d37e
https://github.com/python-openxml/python-docx/pull/1647/files#diff-37c7a9dae166871f81fd1efa89fac0bf6e41c7aa7148fcde2556bb1e6943d37e
src/docx/text/tabstops.pyhttps://github.com/python-openxml/python-docx/pull/1647/files#diff-5167e9435c198b9f6f96774e1eb0a9545b43b583581dce194d29c4521fbc467e
View file https://github.com/python-openxml/python-docx/blob/daf31d3704d926241f9d9e04c1a09645851a4957/src/docx/text/tabstops.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python-openxml/python-docx/pull/1647/{{ revealButtonHref }}
https://github.com/python-openxml/python-docx/pull/1647/files#diff-5167e9435c198b9f6f96774e1eb0a9545b43b583581dce194d29c4521fbc467e
tests/text/test_tabstops.pyhttps://github.com/python-openxml/python-docx/pull/1647/files#diff-9257389df8f5a4b16a79b50015681f61e41c3a50d3a5d1fb5575657d578f1363
View file https://github.com/python-openxml/python-docx/blob/daf31d3704d926241f9d9e04c1a09645851a4957/tests/text/test_tabstops.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python-openxml/python-docx/pull/1647/{{ revealButtonHref }}
https://github.com/python-openxml/python-docx/pull/1647/files#diff-9257389df8f5a4b16a79b50015681f61e41c3a50d3a5d1fb5575657d578f1363
https://github.com/python-openxml/python-docx/pull/1647/files#diff-9257389df8f5a4b16a79b50015681f61e41c3a50d3a5d1fb5575657d578f1363
https://github.com/python-openxml/python-docx/pull/1647/files#diff-9257389df8f5a4b16a79b50015681f61e41c3a50d3a5d1fb5575657d578f1363
https://github.com/python-openxml/python-docx/pull/1647/files#diff-9257389df8f5a4b16a79b50015681f61e41c3a50d3a5d1fb5575657d578f1363
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.