René's URL Explorer Experiment


Title: Use a set when allocating image part names by cakirmert · Pull Request #1639 · python-openxml/python-docx · GitHub

Open Graph Title: Use a set when allocating image part names by cakirmert · Pull Request #1639 · python-openxml/python-docx

X Title: Use a set when allocating image part names by cakirmert · Pull Request #1639 · python-openxml/python-docx

Description: _next_image_partname() checks candidate numbers against a list of image numbers already in use. Store those numbers in a set so these checks no longer repeatedly scan the list. The search still returns the lowest available number and reuses gaps. Name allocation becomes expected O(n) instead of O(n²) per new image, at the cost of some additional temporary memory. Full-operation timings against e45454602b53e8e572b179ccf1c91093ec9f4ed7, using CPython 3.12.6 on Windows 11 with generated 64×48 thumbnails. Timings include document creation or loading, picture insertion, and saving. Workload Before (ms) After (ms) Speedup Pairs 20 distinct PNGs 19.003 19.015 1.00x 20 250 distinct PNGs 174.814 166.176 1.05x 20 1,000 distinct PNGs 2667.254 2095.356 1.27x 7 2,000 distinct PNGs 13661.021 8684.973 1.57x 7 500 mixed PNG/JPEG images 649.474 582.158 1.12x 7 Same PNG repeated 250 times 91.880 92.626 0.99x 20 Load 1,000 images, add 100, save 736.627 534.916 1.38x 7 Paired-run medians after one warmup pair, alternating execution order with fresh inputs. Every ZIP entry's contents and order, image names, and shape counts matched exactly. Small and repeated-image controls were approximately unchanged. Validation: 1,609 existing unit tests and 650 acceptance scenarios passed; Ruff lint, formatting, and git diff --check passed. Existing tests cover choosing the next number and reusing gaps; no test files changed. AI-assisted investigation, implementation, benchmarking, and drafting with Codex.

Open Graph Description: _next_image_partname() checks candidate numbers against a list of image numbers already in use. Store those numbers in a set so these checks no longer repeatedly scan the list. The search still ret...

X Description: _next_image_partname() checks candidate numbers against a list of image numbers already in use. Store those numbers in a set so these checks no longer repeatedly scan the list. The search still ret...

Opengraph URL: https://github.com/python-openxml/python-docx/pull/1639

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:7b91806d-2765-7ea0-f8dd-7d5bf3e2a041
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9FDC:34D413:47FE1D:606FF9:6AFF6C06
html-safe-nonceed73b43041c340429df4af0458f24493271ef9a4f3a438a48ca4c0daf815e827
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5RkRDOjM0RDQxMzo0N0ZFMUQ6NjA2RkY5OjZBRkY2QzA2IiwidmlzaXRvcl9pZCI6IjM5OTYxNzY3MjY2Mzg5NDczMzQiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac3c8fcf3a68fe388b38c7e0ea5d4f1347fe1057c985d2a6eb6180cea3dfe1aa87
hovercard-subject-tagpull_request:5145365141
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python-openxml/python-docx/pull/1639/files
twitter:imagehttps://avatars.githubusercontent.com/u/66678730?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/66678730?s=400&v=4
og:image:alt_next_image_partname() checks candidate numbers against a list of image numbers already in use. Store those numbers in a set so these checks no longer repeatedly scan the list. The search still ret...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None6d580fc7098c193d7866bf290c4c2b4859a153e87379f44161f35a4495e6b730
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python-openxml/python-docx git https://github.com/python-openxml/python-docx.git
octolytics-dimension-user_id3403760
octolytics-dimension-user_loginpython-openxml
octolytics-dimension-repository_id13592924
octolytics-dimension-repository_nwopython-openxml/python-docx
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id13592924
octolytics-dimension-repository_network_root_nwopython-openxml/python-docx
turbo-body-classeslogged-out env-production page-responsive
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releaseec5dd94a369dad6e9ce618a1705cbe3b618a2863
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python-openxml/python-docx/pull/1639/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython-openxml%2Fpython-docx%2Fpull%2F1639%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython-openxml%2Fpython-docx%2Fpull%2F1639%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python-openxml%2Fpython-docx
Reloadhttps://github.com/python-openxml/python-docx/pull/1639/files
Reloadhttps://github.com/python-openxml/python-docx/pull/1639/files
Reloadhttps://github.com/python-openxml/python-docx/pull/1639/files
python-openxmlhttps://github.com/python-openxml
python-docxhttps://github.com/python-openxml/python-docx
Codehttps://github.com/python-openxml/python-docx
Issues387 (387)https://github.com/python-openxml/python-docx/issues
Pull requests167 (167)https://github.com/python-openxml/python-docx/pulls
Actionshttps://github.com/python-openxml/python-docx/actions
Projectshttps://github.com/python-openxml/python-docx/projects
Wikihttps://github.com/python-openxml/python-docx/wiki
Security and qualityhttps://github.com/python-openxml/python-docx/security
Insightshttps://github.com/python-openxml/python-docx/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fpython-openxml%2Fpython-docx%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython-openxml%2Fpython-docx%2Fissues%2Fnew%2Fchoose
cakirmerthttps://github.com/cakirmert
python-openxml:masterhttps://github.com/python-openxml/python-docx/tree/master
cakirmert:perf/image-partname-membershiphttps://github.com/cakirmert/python-docx/tree/perf/image-partname-membership
Conversation 0 https://github.com/python-openxml/python-docx/pull/1639
Commits 1 https://github.com/python-openxml/python-docx/pull/1639/commits
Checks 0 https://github.com/python-openxml/python-docx/pull/1639/checks
Files changed https://github.com/python-openxml/python-docx/pull/1639/files
Please reload this pagehttps://github.com/python-openxml/python-docx/pull/1639/files
Use a set when allocating image part names https://github.com/python-openxml/python-docx/pull/1639/files#top
Show all changes 1 commit https://github.com/python-openxml/python-docx/pull/1639/files
0a54e72 Use a set when allocating image part names cakirmert Nov 3, 2026 https://github.com/python-openxml/python-docx/pull/1639/commits/0a54e72585afe57c9cd5331c0ebae21006d07f4c
Clear filters https://github.com/python-openxml/python-docx/pull/1639/files
Please reload this pagehttps://github.com/python-openxml/python-docx/pull/1639/files
Please reload this pagehttps://github.com/python-openxml/python-docx/pull/1639/files
src/docx/package.pyhttps://github.com/python-openxml/python-docx/pull/1639/files#diff-e305bf01eb953d6120faa5b0babc585f74bd2cc1aef49fabb5a47adf7ba50136
View file https://github.com/python-openxml/python-docx/blob/0a54e72585afe57c9cd5331c0ebae21006d07f4c/src/docx/package.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python-openxml/python-docx/pull/1639/{{ revealButtonHref }}
https://github.com/python-openxml/python-docx/pull/1639/files#diff-e305bf01eb953d6120faa5b0babc585f74bd2cc1aef49fabb5a47adf7ba50136
https://github.com/python-openxml/python-docx/pull/1639/files#diff-e305bf01eb953d6120faa5b0babc585f74bd2cc1aef49fabb5a47adf7ba50136
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.