René's URL Explorer Experiment


Title: fix: do not leave an unreturned table behind when the style is undefined (#1631) by Uneadlight · Pull Request #1637 · python-openxml/python-docx · GitHub

Open Graph Title: fix: do not leave an unreturned table behind when the style is undefined (#1631) by Uneadlight · Pull Request #1637 · python-openxml/python-docx

X Title: fix: do not leave an unreturned table behind when the style is undefined (#1631) by Uneadlight · Pull Request #1637 · python-openxml/python-docx

Description: Document.add_table() assigns table.style = style after _Body.add_table() has already appended the w:tbl element to the body. When the style name is not defined in the document, Table.style raises KeyError — and the half-built table stays in the body. The caller gets an exception and no table object, so it cannot remove the stray table either. This rolls the table back before re-raising, so a failed call leaves the document exactly as it was: table = self._body.add_table(rows, cols, self._block_width) try: table.style = style except KeyError: table._tbl.getparent().remove(table._tbl) raise return table The KeyError still propagates (the caller should still learn the style name was wrong) — only the side effect is undone. This also matches what save()-then-reopen showed before the fix: the stray table was really written to the file, not just kept in memory. The regression test builds a real document (no mocks), calls add_table() with an undefined style and asserts document.tables stays empty. It is a module-level it_... function because python_functions in pyproject.toml only collects that prefix. Test results locally (Windows, Python 3.12, pyparsing==3.1.1 — 3.3.3 trips filterwarnings = ["error"]): before: 53 failed, 1547 passed, 9 errors after: 53 failed, 1548 passed, 9 errors Same failure set (all pre-existing Windows temp-file/path issues), +1 new passing test. ruff check and ruff format --check are clean. Fixes #1631.

Open Graph Description: Document.add_table() assigns table.style = style after _Body.add_table() has already appended the w:tbl element to the body. When the style name is not defined in the document, Table.style raises K...

X Description: Document.add_table() assigns table.style = style after _Body.add_table() has already appended the w:tbl element to the body. When the style name is not defined in the document, Table.style raises K...

Opengraph URL: https://github.com/python-openxml/python-docx/pull/1637

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:63b21e10-38dd-dbf4-a8c5-b4a57d7ab174
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id90DE:11E9D2:4891F3:6112DF:6AFF6BF1
html-safe-nonce1d1fd28db5656ce2b27182323f892a9809aeea54bffa377d6c0e1346ceef8294
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5MERFOjExRTlEMjo0ODkxRjM6NjExMkRGOjZBRkY2QkYxIiwidmlzaXRvcl9pZCI6IjEyNTQ1MTQwNDg2NDEyMzE4NTciLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmace65d89797d4734da29d64f18d1f149852c623d8e07d6971cf6844d75238dc567
hovercard-subject-tagpull_request:5105225554
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python-openxml/python-docx/pull/1637/files
twitter:imagehttps://avatars.githubusercontent.com/u/219332786?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/219332786?s=400&v=4
og:image:altDocument.add_table() assigns table.style = style after _Body.add_table() has already appended the w:tbl element to the body. When the style name is not defined in the document, Table.style raises K...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None6d580fc7098c193d7866bf290c4c2b4859a153e87379f44161f35a4495e6b730
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python-openxml/python-docx git https://github.com/python-openxml/python-docx.git
octolytics-dimension-user_id3403760
octolytics-dimension-user_loginpython-openxml
octolytics-dimension-repository_id13592924
octolytics-dimension-repository_nwopython-openxml/python-docx
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id13592924
octolytics-dimension-repository_network_root_nwopython-openxml/python-docx
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releaseec5dd94a369dad6e9ce618a1705cbe3b618a2863
ui-targetcanary-2
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python-openxml/python-docx/pull/1637/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython-openxml%2Fpython-docx%2Fpull%2F1637%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython-openxml%2Fpython-docx%2Fpull%2F1637%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python-openxml%2Fpython-docx
Reloadhttps://github.com/python-openxml/python-docx/pull/1637/files
Reloadhttps://github.com/python-openxml/python-docx/pull/1637/files
Reloadhttps://github.com/python-openxml/python-docx/pull/1637/files
python-openxmlhttps://github.com/python-openxml
python-docxhttps://github.com/python-openxml/python-docx
Codehttps://github.com/python-openxml/python-docx
Issues387 (387)https://github.com/python-openxml/python-docx/issues
Pull requests167 (167)https://github.com/python-openxml/python-docx/pulls
Actionshttps://github.com/python-openxml/python-docx/actions
Projectshttps://github.com/python-openxml/python-docx/projects
Wikihttps://github.com/python-openxml/python-docx/wiki
Security and qualityhttps://github.com/python-openxml/python-docx/security
Insightshttps://github.com/python-openxml/python-docx/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fpython-openxml%2Fpython-docx%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython-openxml%2Fpython-docx%2Fissues%2Fnew%2Fchoose
Uneadlighthttps://github.com/Uneadlight
python-openxml:masterhttps://github.com/python-openxml/python-docx/tree/master
Uneadlight:fix/1631-add-table-style-rollbackhttps://github.com/Uneadlight/python-docx/tree/fix/1631-add-table-style-rollback
Conversation 0 https://github.com/python-openxml/python-docx/pull/1637
Commits 1 https://github.com/python-openxml/python-docx/pull/1637/commits
Checks 0 https://github.com/python-openxml/python-docx/pull/1637/checks
Files changed https://github.com/python-openxml/python-docx/pull/1637/files
Please reload this pagehttps://github.com/python-openxml/python-docx/pull/1637/files
fix: do not leave an unreturned table behind when the style is undefined (#1631) https://github.com/python-openxml/python-docx/pull/1637/files#top
Show all changes 1 commit https://github.com/python-openxml/python-docx/pull/1637/files
4409177 fix: do not leave an unreturned table behind when the style is undefined Uneadlight Nov 1, 2026 https://github.com/python-openxml/python-docx/pull/1637/commits/4409177bf5cd492af4514db9a0351489f9a0d3f5
Clear filters https://github.com/python-openxml/python-docx/pull/1637/files
Please reload this pagehttps://github.com/python-openxml/python-docx/pull/1637/files
Please reload this pagehttps://github.com/python-openxml/python-docx/pull/1637/files
document.py https://github.com/python-openxml/python-docx/pull/1637/files#diff-8b5aed35cea2e719e419af099e5d7d2f6ff97b5737b5329dcf66c57031999541
test_document.py https://github.com/python-openxml/python-docx/pull/1637/files#diff-78e792cfafc71ca614966d5be40f70098bf25e7ef39acece8692f691102db801
src/docx/document.pyhttps://github.com/python-openxml/python-docx/pull/1637/files#diff-8b5aed35cea2e719e419af099e5d7d2f6ff97b5737b5329dcf66c57031999541
View file https://github.com/python-openxml/python-docx/blob/4409177bf5cd492af4514db9a0351489f9a0d3f5/src/docx/document.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python-openxml/python-docx/pull/1637/{{ revealButtonHref }}
https://github.com/python-openxml/python-docx/pull/1637/files#diff-8b5aed35cea2e719e419af099e5d7d2f6ff97b5737b5329dcf66c57031999541
https://github.com/python-openxml/python-docx/pull/1637/files#diff-8b5aed35cea2e719e419af099e5d7d2f6ff97b5737b5329dcf66c57031999541
tests/test_document.pyhttps://github.com/python-openxml/python-docx/pull/1637/files#diff-78e792cfafc71ca614966d5be40f70098bf25e7ef39acece8692f691102db801
View file https://github.com/python-openxml/python-docx/blob/4409177bf5cd492af4514db9a0351489f9a0d3f5/tests/test_document.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python-openxml/python-docx/pull/1637/{{ revealButtonHref }}
https://github.com/python-openxml/python-docx/pull/1637/files#diff-78e792cfafc71ca614966d5be40f70098bf25e7ef39acece8692f691102db801
https://github.com/python-openxml/python-docx/pull/1637/files#diff-78e792cfafc71ca614966d5be40f70098bf25e7ef39acece8692f691102db801
https://github.com/python-openxml/python-docx/pull/1637/files#diff-78e792cfafc71ca614966d5be40f70098bf25e7ef39acece8692f691102db801
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.