René's URL Explorer Experiment


Title: Validate table styles before inserting document tables by Seraph-x · Pull Request #1632 · python-openxml/python-docx · GitHub

Open Graph Title: Validate table styles before inserting document tables by Seraph-x · Pull Request #1632 · python-openxml/python-docx

X Title: Validate table styles before inserting document tables by Seraph-x · Pull Request #1632 · python-openxml/python-docx

Description: Fixes #1631. When Document.add_table() receives a missing style, it inserts the table before raising KeyError. Retrying without the style therefore leaves two tables in the document. Passing a paragraph or character style has the same side effect before raising ValueError. Resolve the table style with the existing style resolver before inserting the table, then apply the resolved ID. This preserves the existing exceptions and valid/default style behavior without leaving an extra table after a style error. Regression coverage checks missing styles, wrong-type style names and objects, preservation of existing document content, valid built-in/custom/default styles, and the reported retry followed by saving and reopening the document. Validation Base: e45454602b53e8e572b179ccf1c91093ec9f4ed7. Tested on macOS arm64. Unchanged upstream: 1,609 unit tests passed. The new regressions produced 11 expected failures before the fix. Python 3.13.16, editable source: 1,628 unit tests and all 650 Behave scenarios passed. Python 3.9.6, independently installed built wheel: 1,628 unit tests and all 650 Behave scenarios passed. Verified that the installed module matches the modified source byte-for-byte. Source distribution and wheel built successfully. Ruff lint/format checks on both changed files and git diff --check passed. Used pytest 8.4.2 and pyparsing 3.2.5 for both environments. Pyright reports one pre-existing add_comment(text: str | None) mismatch in document.py; checking the unchanged upstream file reproduces the same diagnostic. No new diagnostics in the changed files. The build also emits existing metadata/manifest deprecation warnings. Word/LibreOffice GUI validation was not run; the saved-file regression checks the actual reopened DOCX contents. AI assistance: OpenAI Codex.

Open Graph Description: Fixes #1631. When Document.add_table() receives a missing style, it inserts the table before raising KeyError. Retrying without the style therefore leaves two tables in the document. Passing a para...

X Description: Fixes #1631. When Document.add_table() receives a missing style, it inserts the table before raising KeyError. Retrying without the style therefore leaves two tables in the document. Passing a para...

Opengraph URL: https://github.com/python-openxml/python-docx/pull/1632

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:69cf5a8c-f893-4ae6-c05a-a896a84bc876
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idDDEC:18D70F:2565DB:339097:6AFF65D2
html-safe-nonce3f61be31e4be8d5e8eb947eac2d37a940a294e3695995b3626abee3dfb697bff
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEREVDOjE4RDcwRjoyNTY1REI6MzM5MDk3OjZBRkY2NUQyIiwidmlzaXRvcl9pZCI6IjEyNDI5MDc4NjU4OTE0MzE4OTAiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacdd037586919ddbaad19eeac5daffdcb30f2b9137be3c71a95057468a7c2928a8
hovercard-subject-tagpull_request:4981285931
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python-openxml/python-docx/pull/1632/files
twitter:imagehttps://avatars.githubusercontent.com/u/70804821?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/70804821?s=400&v=4
og:image:altFixes #1631. When Document.add_table() receives a missing style, it inserts the table before raising KeyError. Retrying without the style therefore leaves two tables in the document. Passing a para...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None41b58589a1c4eda1e3c8904144a412b88ca4455f63ca2ad3629f2e9f3c3a1d12
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python-openxml/python-docx git https://github.com/python-openxml/python-docx.git
octolytics-dimension-user_id3403760
octolytics-dimension-user_loginpython-openxml
octolytics-dimension-repository_id13592924
octolytics-dimension-repository_nwopython-openxml/python-docx
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id13592924
octolytics-dimension-repository_network_root_nwopython-openxml/python-docx
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8968d6d6acc65d74e4df332d23932dd3fd0502a4
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python-openxml/python-docx/pull/1632/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython-openxml%2Fpython-docx%2Fpull%2F1632%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython-openxml%2Fpython-docx%2Fpull%2F1632%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python-openxml%2Fpython-docx
Reloadhttps://github.com/python-openxml/python-docx/pull/1632/files
Reloadhttps://github.com/python-openxml/python-docx/pull/1632/files
Reloadhttps://github.com/python-openxml/python-docx/pull/1632/files
python-openxmlhttps://github.com/python-openxml
python-docxhttps://github.com/python-openxml/python-docx
Codehttps://github.com/python-openxml/python-docx
Issues387 (387)https://github.com/python-openxml/python-docx/issues
Pull requests167 (167)https://github.com/python-openxml/python-docx/pulls
Actionshttps://github.com/python-openxml/python-docx/actions
Projectshttps://github.com/python-openxml/python-docx/projects
Wikihttps://github.com/python-openxml/python-docx/wiki
Security and qualityhttps://github.com/python-openxml/python-docx/security
Insightshttps://github.com/python-openxml/python-docx/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fpython-openxml%2Fpython-docx%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython-openxml%2Fpython-docx%2Fissues%2Fnew%2Fchoose
Seraph-xhttps://github.com/Seraph-x
python-openxml:masterhttps://github.com/python-openxml/python-docx/tree/master
Seraph-x:fix/validate-table-style-before-insertionhttps://github.com/Seraph-x/python-docx/tree/fix/validate-table-style-before-insertion
Conversation 1 https://github.com/python-openxml/python-docx/pull/1632
Commits 1 https://github.com/python-openxml/python-docx/pull/1632/commits
Checks 0 https://github.com/python-openxml/python-docx/pull/1632/checks
Files changed https://github.com/python-openxml/python-docx/pull/1632/files
Please reload this pagehttps://github.com/python-openxml/python-docx/pull/1632/files
Validate table styles before inserting document tables https://github.com/python-openxml/python-docx/pull/1632/files#top
Show all changes 1 commit https://github.com/python-openxml/python-docx/pull/1632/files
363ba5e Validate table styles before inserting document tables Seraph-x Oct 23, 2026 https://github.com/python-openxml/python-docx/pull/1632/commits/363ba5e8d030363cbb359f38731e2193b900b218
Clear filters https://github.com/python-openxml/python-docx/pull/1632/files
Please reload this pagehttps://github.com/python-openxml/python-docx/pull/1632/files
Please reload this pagehttps://github.com/python-openxml/python-docx/pull/1632/files
document.py https://github.com/python-openxml/python-docx/pull/1632/files#diff-8b5aed35cea2e719e419af099e5d7d2f6ff97b5737b5329dcf66c57031999541
test_document.py https://github.com/python-openxml/python-docx/pull/1632/files#diff-78e792cfafc71ca614966d5be40f70098bf25e7ef39acece8692f691102db801
src/docx/document.pyhttps://github.com/python-openxml/python-docx/pull/1632/files#diff-8b5aed35cea2e719e419af099e5d7d2f6ff97b5737b5329dcf66c57031999541
View file https://github.com/python-openxml/python-docx/blob/363ba5e8d030363cbb359f38731e2193b900b218/src/docx/document.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python-openxml/python-docx/pull/1632/{{ revealButtonHref }}
https://github.com/python-openxml/python-docx/pull/1632/files#diff-8b5aed35cea2e719e419af099e5d7d2f6ff97b5737b5329dcf66c57031999541
https://github.com/python-openxml/python-docx/pull/1632/files#diff-8b5aed35cea2e719e419af099e5d7d2f6ff97b5737b5329dcf66c57031999541
https://github.com/python-openxml/python-docx/pull/1632/files#diff-8b5aed35cea2e719e419af099e5d7d2f6ff97b5737b5329dcf66c57031999541
https://github.com/python-openxml/python-docx/pull/1632/files#diff-8b5aed35cea2e719e419af099e5d7d2f6ff97b5737b5329dcf66c57031999541
tests/test_document.pyhttps://github.com/python-openxml/python-docx/pull/1632/files#diff-78e792cfafc71ca614966d5be40f70098bf25e7ef39acece8692f691102db801
View file https://github.com/python-openxml/python-docx/blob/363ba5e8d030363cbb359f38731e2193b900b218/tests/test_document.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python-openxml/python-docx/pull/1632/{{ revealButtonHref }}
https://github.com/python-openxml/python-docx/pull/1632/files#diff-78e792cfafc71ca614966d5be40f70098bf25e7ef39acece8692f691102db801
https://github.com/python-openxml/python-docx/pull/1632/files#diff-78e792cfafc71ca614966d5be40f70098bf25e7ef39acece8692f691102db801
https://github.com/python-openxml/python-docx/pull/1632/files#diff-78e792cfafc71ca614966d5be40f70098bf25e7ef39acece8692f691102db801
https://github.com/python-openxml/python-docx/pull/1632/files#diff-78e792cfafc71ca614966d5be40f70098bf25e7ef39acece8692f691102db801
https://github.com/python-openxml/python-docx/pull/1632/files#diff-78e792cfafc71ca614966d5be40f70098bf25e7ef39acece8692f691102db801
https://github.com/python-openxml/python-docx/pull/1632/files#diff-78e792cfafc71ca614966d5be40f70098bf25e7ef39acece8692f691102db801
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.