René's URL Explorer Experiment


Title: Support path-like filenames when adding pictures by LaoChouPro · Pull Request #1629 · python-openxml/python-docx · GitHub

Open Graph Title: Support path-like filenames when adding pictures by LaoChouPro · Pull Request #1629 · python-openxml/python-docx

X Title: Support path-like filenames when adding pictures by LaoChouPro · Pull Request #1629 · python-openxml/python-docx

Description: Passing a pathlib.Path to add_picture currently treats it as a file-like object and fails on seek(). This accepts path-like filenames in the image loader and updates the related type annotations. Fixes #1544. The tests cover string and Path inputs, both picture insertion methods, and saving and reopening a document with a Unicode image filename. All 1612 tests pass with pytest 8.4.2 and pyparsing 3.2.3, and both package builds pass. Pyright still reports the same two errors on the unchanged baseline.

Open Graph Description: Passing a pathlib.Path to add_picture currently treats it as a file-like object and fails on seek(). This accepts path-like filenames in the image loader and updates the related type annotations. F...

X Description: Passing a pathlib.Path to add_picture currently treats it as a file-like object and fails on seek(). This accepts path-like filenames in the image loader and updates the related type annotations. F...

Opengraph URL: https://github.com/python-openxml/python-docx/pull/1629

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:2acf49e6-8f3f-d259-ba81-da8ddda21e49
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9984:4D728:82AD46:978B48:6AFF65D6
html-safe-nonce92af748aafb28311c4dd3e53db6ed2ed998ec9759f49f31b32a6a27ea560938e
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5OTg0OjRENzI4OjgyQUQ0Njo5NzhCNDg6NkFGRjY1RDYiLCJ2aXNpdG9yX2lkIjoiNjUxMzA4ODk3MTUzNzM0Mzk1OCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac25ce2458e38f1759c45e59657d780000fc4574131754cf00cb5f8fa81802ecae
hovercard-subject-tagpull_request:4900508815
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python-openxml/python-docx/pull/1629/files
twitter:imagehttps://avatars.githubusercontent.com/u/173868159?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/173868159?s=400&v=4
og:image:altPassing a pathlib.Path to add_picture currently treats it as a file-like object and fails on seek(). This accepts path-like filenames in the image loader and updates the related type annotations. F...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None41b58589a1c4eda1e3c8904144a412b88ca4455f63ca2ad3629f2e9f3c3a1d12
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python-openxml/python-docx git https://github.com/python-openxml/python-docx.git
octolytics-dimension-user_id3403760
octolytics-dimension-user_loginpython-openxml
octolytics-dimension-repository_id13592924
octolytics-dimension-repository_nwopython-openxml/python-docx
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id13592924
octolytics-dimension-repository_network_root_nwopython-openxml/python-docx
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8968d6d6acc65d74e4df332d23932dd3fd0502a4
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python-openxml/python-docx/pull/1629/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython-openxml%2Fpython-docx%2Fpull%2F1629%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython-openxml%2Fpython-docx%2Fpull%2F1629%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python-openxml%2Fpython-docx
Reloadhttps://github.com/python-openxml/python-docx/pull/1629/files
Reloadhttps://github.com/python-openxml/python-docx/pull/1629/files
Reloadhttps://github.com/python-openxml/python-docx/pull/1629/files
python-openxmlhttps://github.com/python-openxml
python-docxhttps://github.com/python-openxml/python-docx
Codehttps://github.com/python-openxml/python-docx
Issues387 (387)https://github.com/python-openxml/python-docx/issues
Pull requests167 (167)https://github.com/python-openxml/python-docx/pulls
Actionshttps://github.com/python-openxml/python-docx/actions
Projectshttps://github.com/python-openxml/python-docx/projects
Wikihttps://github.com/python-openxml/python-docx/wiki
Security and qualityhttps://github.com/python-openxml/python-docx/security
Insightshttps://github.com/python-openxml/python-docx/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fpython-openxml%2Fpython-docx%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython-openxml%2Fpython-docx%2Fissues%2Fnew%2Fchoose
LaoChouProhttps://github.com/LaoChouPro
python-openxml:masterhttps://github.com/python-openxml/python-docx/tree/master
LaoChouPro:fix/pathlike-image-descriptorshttps://github.com/LaoChouPro/python-docx/tree/fix/pathlike-image-descriptors
Conversation 0 https://github.com/python-openxml/python-docx/pull/1629
Commits 1 https://github.com/python-openxml/python-docx/pull/1629/commits
Checks 0 https://github.com/python-openxml/python-docx/pull/1629/checks
Files changed https://github.com/python-openxml/python-docx/pull/1629/files
Please reload this pagehttps://github.com/python-openxml/python-docx/pull/1629/files
Support path-like filenames when adding pictures https://github.com/python-openxml/python-docx/pull/1629/files#top
Show all changes 1 commit https://github.com/python-openxml/python-docx/pull/1629/files
6cc2d07 Support path-like filenames when adding pictures LaoChouPro Oct 17, 2026 https://github.com/python-openxml/python-docx/pull/1629/commits/6cc2d072a02782f35a582bb41451f6baa8fc2420
Clear filters https://github.com/python-openxml/python-docx/pull/1629/files
Please reload this pagehttps://github.com/python-openxml/python-docx/pull/1629/files
Please reload this pagehttps://github.com/python-openxml/python-docx/pull/1629/files
document.py https://github.com/python-openxml/python-docx/pull/1629/files#diff-8b5aed35cea2e719e419af099e5d7d2f6ff97b5737b5329dcf66c57031999541
image.py https://github.com/python-openxml/python-docx/pull/1629/files#diff-f2160502d838b18b673a46b3f4c27a810356787275afcad3e134bf27e53e5f29
package.py https://github.com/python-openxml/python-docx/pull/1629/files#diff-e305bf01eb953d6120faa5b0babc585f74bd2cc1aef49fabb5a47adf7ba50136
story.py https://github.com/python-openxml/python-docx/pull/1629/files#diff-ba91bb830fd1ea6cad2c33712d5a7c8b7d827109abf3529134d376d8fe583da0
run.py https://github.com/python-openxml/python-docx/pull/1629/files#diff-93a63e78713879c0fd787128dfc3a563806eff684b68e9ba3a3fd0cd11e47e45
test_image.py https://github.com/python-openxml/python-docx/pull/1629/files#diff-bf1ebe321452ecef776b8537465e88f22c1649ee744c82fc3f24ec497ba4b046
test_api.py https://github.com/python-openxml/python-docx/pull/1629/files#diff-3451cc474d5698222168f66a293339a6bd296ee2c56f56409866bbae99917a79
src/docx/document.pyhttps://github.com/python-openxml/python-docx/pull/1629/files#diff-8b5aed35cea2e719e419af099e5d7d2f6ff97b5737b5329dcf66c57031999541
View file https://github.com/python-openxml/python-docx/blob/6cc2d072a02782f35a582bb41451f6baa8fc2420/src/docx/document.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python-openxml/python-docx/pull/1629/{{ revealButtonHref }}
https://github.com/python-openxml/python-docx/pull/1629/files#diff-8b5aed35cea2e719e419af099e5d7d2f6ff97b5737b5329dcf66c57031999541
https://github.com/python-openxml/python-docx/pull/1629/files#diff-8b5aed35cea2e719e419af099e5d7d2f6ff97b5737b5329dcf66c57031999541
https://github.com/python-openxml/python-docx/pull/1629/files#diff-8b5aed35cea2e719e419af099e5d7d2f6ff97b5737b5329dcf66c57031999541
https://github.com/python-openxml/python-docx/pull/1629/files#diff-8b5aed35cea2e719e419af099e5d7d2f6ff97b5737b5329dcf66c57031999541
src/docx/image/image.pyhttps://github.com/python-openxml/python-docx/pull/1629/files#diff-f2160502d838b18b673a46b3f4c27a810356787275afcad3e134bf27e53e5f29
View file https://github.com/python-openxml/python-docx/blob/6cc2d072a02782f35a582bb41451f6baa8fc2420/src/docx/image/image.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python-openxml/python-docx/pull/1629/{{ revealButtonHref }}
https://github.com/python-openxml/python-docx/pull/1629/files#diff-f2160502d838b18b673a46b3f4c27a810356787275afcad3e134bf27e53e5f29
https://github.com/python-openxml/python-docx/pull/1629/files#diff-f2160502d838b18b673a46b3f4c27a810356787275afcad3e134bf27e53e5f29
src/docx/package.pyhttps://github.com/python-openxml/python-docx/pull/1629/files#diff-e305bf01eb953d6120faa5b0babc585f74bd2cc1aef49fabb5a47adf7ba50136
View file https://github.com/python-openxml/python-docx/blob/6cc2d072a02782f35a582bb41451f6baa8fc2420/src/docx/package.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python-openxml/python-docx/pull/1629/{{ revealButtonHref }}
https://github.com/python-openxml/python-docx/pull/1629/files#diff-e305bf01eb953d6120faa5b0babc585f74bd2cc1aef49fabb5a47adf7ba50136
https://github.com/python-openxml/python-docx/pull/1629/files#diff-e305bf01eb953d6120faa5b0babc585f74bd2cc1aef49fabb5a47adf7ba50136
https://github.com/python-openxml/python-docx/pull/1629/files#diff-e305bf01eb953d6120faa5b0babc585f74bd2cc1aef49fabb5a47adf7ba50136
https://github.com/python-openxml/python-docx/pull/1629/files#diff-e305bf01eb953d6120faa5b0babc585f74bd2cc1aef49fabb5a47adf7ba50136
https://github.com/python-openxml/python-docx/pull/1629/files#diff-e305bf01eb953d6120faa5b0babc585f74bd2cc1aef49fabb5a47adf7ba50136
src/docx/parts/story.pyhttps://github.com/python-openxml/python-docx/pull/1629/files#diff-ba91bb830fd1ea6cad2c33712d5a7c8b7d827109abf3529134d376d8fe583da0
View file https://github.com/python-openxml/python-docx/blob/6cc2d072a02782f35a582bb41451f6baa8fc2420/src/docx/parts/story.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python-openxml/python-docx/pull/1629/{{ revealButtonHref }}
https://github.com/python-openxml/python-docx/pull/1629/files#diff-ba91bb830fd1ea6cad2c33712d5a7c8b7d827109abf3529134d376d8fe583da0
https://github.com/python-openxml/python-docx/pull/1629/files#diff-ba91bb830fd1ea6cad2c33712d5a7c8b7d827109abf3529134d376d8fe583da0
https://github.com/python-openxml/python-docx/pull/1629/files#diff-ba91bb830fd1ea6cad2c33712d5a7c8b7d827109abf3529134d376d8fe583da0
https://github.com/python-openxml/python-docx/pull/1629/files#diff-ba91bb830fd1ea6cad2c33712d5a7c8b7d827109abf3529134d376d8fe583da0
https://github.com/python-openxml/python-docx/pull/1629/files#diff-ba91bb830fd1ea6cad2c33712d5a7c8b7d827109abf3529134d376d8fe583da0
src/docx/text/run.pyhttps://github.com/python-openxml/python-docx/pull/1629/files#diff-93a63e78713879c0fd787128dfc3a563806eff684b68e9ba3a3fd0cd11e47e45
View file https://github.com/python-openxml/python-docx/blob/6cc2d072a02782f35a582bb41451f6baa8fc2420/src/docx/text/run.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python-openxml/python-docx/pull/1629/{{ revealButtonHref }}
https://github.com/python-openxml/python-docx/pull/1629/files#diff-93a63e78713879c0fd787128dfc3a563806eff684b68e9ba3a3fd0cd11e47e45
https://github.com/python-openxml/python-docx/pull/1629/files#diff-93a63e78713879c0fd787128dfc3a563806eff684b68e9ba3a3fd0cd11e47e45
https://github.com/python-openxml/python-docx/pull/1629/files#diff-93a63e78713879c0fd787128dfc3a563806eff684b68e9ba3a3fd0cd11e47e45
https://github.com/python-openxml/python-docx/pull/1629/files#diff-93a63e78713879c0fd787128dfc3a563806eff684b68e9ba3a3fd0cd11e47e45
tests/image/test_image.pyhttps://github.com/python-openxml/python-docx/pull/1629/files#diff-bf1ebe321452ecef776b8537465e88f22c1649ee744c82fc3f24ec497ba4b046
View file https://github.com/python-openxml/python-docx/blob/6cc2d072a02782f35a582bb41451f6baa8fc2420/tests/image/test_image.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python-openxml/python-docx/pull/1629/{{ revealButtonHref }}
https://github.com/python-openxml/python-docx/pull/1629/files#diff-bf1ebe321452ecef776b8537465e88f22c1649ee744c82fc3f24ec497ba4b046
https://github.com/python-openxml/python-docx/pull/1629/files#diff-bf1ebe321452ecef776b8537465e88f22c1649ee744c82fc3f24ec497ba4b046
https://github.com/python-openxml/python-docx/pull/1629/files#diff-bf1ebe321452ecef776b8537465e88f22c1649ee744c82fc3f24ec497ba4b046
tests/test_api.pyhttps://github.com/python-openxml/python-docx/pull/1629/files#diff-3451cc474d5698222168f66a293339a6bd296ee2c56f56409866bbae99917a79
View file https://github.com/python-openxml/python-docx/blob/6cc2d072a02782f35a582bb41451f6baa8fc2420/tests/test_api.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python-openxml/python-docx/pull/1629/{{ revealButtonHref }}
https://github.com/python-openxml/python-docx/pull/1629/files#diff-3451cc474d5698222168f66a293339a6bd296ee2c56f56409866bbae99917a79
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.