René's URL Explorer Experiment


Title: Fix lazyproperty re-evaluating getters that return None by jipeng6036-del · Pull Request #1626 · python-openxml/python-docx · GitHub

Open Graph Title: Fix lazyproperty re-evaluating getters that return None by jipeng6036-del · Pull Request #1626 · python-openxml/python-docx

X Title: Fix lazyproperty re-evaluating getters that return None by jipeng6036-del · Pull Request #1626 · python-openxml/python-docx

Description: Fixes #1600. lazyproperty treated a cached None the same as "not computed yet", so a getter that legitimately returns None ran again on every access. That contradicts the documented "evaluated only on first access" behavior. The lookup now uses key presence in the instance __dict__ instead of comparing the stored value to None. Testing uv run pytest tests/test_shared.py — 23 passed New None-returning case fails on unmodified master (call_count 3 vs 1) and passes with this change Existing non-None caching still holds ruff check / ruff format --check on the changed files Full uv run pytest on Windows: 1555 passed, 56 failed. The failures are existing XML snippet / SHA-1 fixtures (tests/oxml/test_table.py, tests/opc/test_phys_pkg.py, header/footer templates) from CRLF checkout; they are outside the files in this PR.

Open Graph Description: Fixes #1600. lazyproperty treated a cached None the same as "not computed yet", so a getter that legitimately returns None ran again on every access. That contradicts the documented "...

X Description: Fixes #1600. lazyproperty treated a cached None the same as "not computed yet", so a getter that legitimately returns None ran again on every access. That contradicts the document...

Opengraph URL: https://github.com/python-openxml/python-docx/pull/1626

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:70406e73-2341-bdcf-1182-7d7e862f6bf4
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idEA44:2EAE2D:748FD:9DA59:6AFF6C0B
html-safe-noncec1431d586ccfc6b1143f282f179c6d98fd7cfff782a6064c18e680ebf094e49d
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFQTQ0OjJFQUUyRDo3NDhGRDo5REE1OTo2QUZGNkMwQiIsInZpc2l0b3JfaWQiOiIxMjM1Nzk2MzE5MTcyMjU4ODI3IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac46e1d1410d78dd58eea609a4fbb911da1fb7009eb355476110369cf45f7d044b
hovercard-subject-tagpull_request:4757448800
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python-openxml/python-docx/pull/1626/files
twitter:imagehttps://avatars.githubusercontent.com/u/241105014?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/241105014?s=400&v=4
og:image:altFixes #1600. lazyproperty treated a cached None the same as "not computed yet", so a getter that legitimately returns None ran again on every access. That contradicts the documented "...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None6d580fc7098c193d7866bf290c4c2b4859a153e87379f44161f35a4495e6b730
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python-openxml/python-docx git https://github.com/python-openxml/python-docx.git
octolytics-dimension-user_id3403760
octolytics-dimension-user_loginpython-openxml
octolytics-dimension-repository_id13592924
octolytics-dimension-repository_nwopython-openxml/python-docx
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id13592924
octolytics-dimension-repository_network_root_nwopython-openxml/python-docx
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releaseec5dd94a369dad6e9ce618a1705cbe3b618a2863
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python-openxml/python-docx/pull/1626/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython-openxml%2Fpython-docx%2Fpull%2F1626%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython-openxml%2Fpython-docx%2Fpull%2F1626%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python-openxml%2Fpython-docx
Reloadhttps://github.com/python-openxml/python-docx/pull/1626/files
Reloadhttps://github.com/python-openxml/python-docx/pull/1626/files
Reloadhttps://github.com/python-openxml/python-docx/pull/1626/files
python-openxmlhttps://github.com/python-openxml
python-docxhttps://github.com/python-openxml/python-docx
Codehttps://github.com/python-openxml/python-docx
Issues387 (387)https://github.com/python-openxml/python-docx/issues
Pull requests167 (167)https://github.com/python-openxml/python-docx/pulls
Actionshttps://github.com/python-openxml/python-docx/actions
Projectshttps://github.com/python-openxml/python-docx/projects
Wikihttps://github.com/python-openxml/python-docx/wiki
Security and qualityhttps://github.com/python-openxml/python-docx/security
Insightshttps://github.com/python-openxml/python-docx/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fpython-openxml%2Fpython-docx%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython-openxml%2Fpython-docx%2Fissues%2Fnew%2Fchoose
jipeng6036-delhttps://github.com/jipeng6036-del
python-openxml:masterhttps://github.com/python-openxml/python-docx/tree/master
jipeng6036-del:fix/1600-lazyproperty-none-cachehttps://github.com/jipeng6036-del/python-docx/tree/fix/1600-lazyproperty-none-cache
Conversation 0 https://github.com/python-openxml/python-docx/pull/1626
Commits 1 https://github.com/python-openxml/python-docx/pull/1626/commits
Checks 0 https://github.com/python-openxml/python-docx/pull/1626/checks
Files changed https://github.com/python-openxml/python-docx/pull/1626/files
Please reload this pagehttps://github.com/python-openxml/python-docx/pull/1626/files
Fix lazyproperty re-evaluating getters that return None https://github.com/python-openxml/python-docx/pull/1626/files#top
Show all changes 1 commit https://github.com/python-openxml/python-docx/pull/1626/files
a6fcfea Fix lazyproperty re-evaluating getters that return None jipeng6036-del Oct 6, 2026 https://github.com/python-openxml/python-docx/pull/1626/commits/a6fcfea1f516c37b2b0b2d557f0e0e3909bb8e6c
Clear filters https://github.com/python-openxml/python-docx/pull/1626/files
Please reload this pagehttps://github.com/python-openxml/python-docx/pull/1626/files
Please reload this pagehttps://github.com/python-openxml/python-docx/pull/1626/files
shared.py https://github.com/python-openxml/python-docx/pull/1626/files#diff-37f17e5dc834df9ba125713368713382097e3c6dd0f3657493291cb852bb1671
test_shared.py https://github.com/python-openxml/python-docx/pull/1626/files#diff-93e6a263c6feedde95e28efcd268d55e23ae8ff141853bcf66ba6479821236eb
src/docx/shared.pyhttps://github.com/python-openxml/python-docx/pull/1626/files#diff-37f17e5dc834df9ba125713368713382097e3c6dd0f3657493291cb852bb1671
View file https://github.com/python-openxml/python-docx/blob/a6fcfea1f516c37b2b0b2d557f0e0e3909bb8e6c/src/docx/shared.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python-openxml/python-docx/pull/1626/{{ revealButtonHref }}
https://github.com/python-openxml/python-docx/pull/1626/files#diff-37f17e5dc834df9ba125713368713382097e3c6dd0f3657493291cb852bb1671
https://github.com/python-openxml/python-docx/pull/1626/files#diff-37f17e5dc834df9ba125713368713382097e3c6dd0f3657493291cb852bb1671
tests/test_shared.pyhttps://github.com/python-openxml/python-docx/pull/1626/files#diff-93e6a263c6feedde95e28efcd268d55e23ae8ff141853bcf66ba6479821236eb
View file https://github.com/python-openxml/python-docx/blob/a6fcfea1f516c37b2b0b2d557f0e0e3909bb8e6c/tests/test_shared.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python-openxml/python-docx/pull/1626/{{ revealButtonHref }}
https://github.com/python-openxml/python-docx/pull/1626/files#diff-93e6a263c6feedde95e28efcd268d55e23ae8ff141853bcf66ba6479821236eb
https://github.com/python-openxml/python-docx/pull/1626/files#diff-93e6a263c6feedde95e28efcd268d55e23ae8ff141853bcf66ba6479821236eb
https://github.com/python-openxml/python-docx/pull/1626/files#diff-93e6a263c6feedde95e28efcd268d55e23ae8ff141853bcf66ba6479821236eb
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.