René's URL Explorer Experiment


Title: Fix rendered page break fragments adjacent to hyperlinks by kokotatan · Pull Request #1625 · python-openxml/python-docx · GitHub

Open Graph Title: Fix rendered page break fragments adjacent to hyperlinks by kokotatan · Pull Request #1625 · python-openxml/python-docx

X Title: Fix rendered page break fragments adjacent to hyperlinks by kokotatan · Pull Request #1625 · python-openxml/python-docx

Description: RenderedPageBreak.preceding_paragraph_fragment and following_paragraph_fragment can return None when the paragraph still contains a hyperlink on that side of the break. For example, a hyperlink followed by a run that starts with a rendered page break loses the hyperlink during page-by-page text extraction. The boundary checks currently consider only direct w:r children. Include w:hyperlink when selecting the first/last paragraph content element, matching CT_P.inner_content_elements. Fragment construction itself already preserves hyperlinks. Four regression cases cover links before and after the break, with and without non-content siblings. They check the extracted text, hyperlink anchor, and that the original paragraph XML is unchanged. All four fail on the unmodified source and pass with this fix. Validation on Windows / Python 3.12.12: pytest -q: 1,613 passed. behave --format progress --stop --tags=-wip: 67 features / 650 scenarios passed. ruff check . and formatting checks for both changed files passed. Source distribution and wheel built successfully. Pyright reports the same 7,588 existing diagnostics on the original and patched source (compared by file, severity, rule, and message); no diagnostics were added or removed. Local test setup uses pytest 8.4.2 and pyparsing 3.2.5, and LF fixture/template files. Dependency and line-ending adjustments are not included in this change. The declared lxml type stubs are installed for the type comparison. AI assistance was used to investigate, implement, test, and review this change.

Open Graph Description: RenderedPageBreak.preceding_paragraph_fragment and following_paragraph_fragment can return None when the paragraph still contains a hyperlink on that side of the break. For example, a hyperlink fol...

X Description: RenderedPageBreak.preceding_paragraph_fragment and following_paragraph_fragment can return None when the paragraph still contains a hyperlink on that side of the break. For example, a hyperlink fol...

Opengraph URL: https://github.com/python-openxml/python-docx/pull/1625

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:39aea8eb-60d8-e64c-dbf5-63115aa2ec0e
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idBAA0:59CDA:98439C:B608CE:6AFF6C19
html-safe-noncef2cd3d5c171703e7f0100f5759198dec598e4c1d8a2ea83b7b6f5c5e1ba8617f
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCQUEwOjU5Q0RBOjk4NDM5QzpCNjA4Q0U6NkFGRjZDMTkiLCJ2aXNpdG9yX2lkIjoiMjMxNTk1NzcxOTEyMDQ0MDM0NSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac709a635d3880c07551df080ae8c7e22e64c481ad16ac13cbb579bc7b31cff185
hovercard-subject-tagpull_request:4727637130
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python-openxml/python-docx/pull/1625/files
twitter:imagehttps://avatars.githubusercontent.com/u/199421981?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/199421981?s=400&v=4
og:image:altRenderedPageBreak.preceding_paragraph_fragment and following_paragraph_fragment can return None when the paragraph still contains a hyperlink on that side of the break. For example, a hyperlink fol...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None6d580fc7098c193d7866bf290c4c2b4859a153e87379f44161f35a4495e6b730
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python-openxml/python-docx git https://github.com/python-openxml/python-docx.git
octolytics-dimension-user_id3403760
octolytics-dimension-user_loginpython-openxml
octolytics-dimension-repository_id13592924
octolytics-dimension-repository_nwopython-openxml/python-docx
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id13592924
octolytics-dimension-repository_network_root_nwopython-openxml/python-docx
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releaseec5dd94a369dad6e9ce618a1705cbe3b618a2863
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python-openxml/python-docx/pull/1625/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython-openxml%2Fpython-docx%2Fpull%2F1625%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython-openxml%2Fpython-docx%2Fpull%2F1625%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python-openxml%2Fpython-docx
Reloadhttps://github.com/python-openxml/python-docx/pull/1625/files
Reloadhttps://github.com/python-openxml/python-docx/pull/1625/files
Reloadhttps://github.com/python-openxml/python-docx/pull/1625/files
python-openxmlhttps://github.com/python-openxml
python-docxhttps://github.com/python-openxml/python-docx
Codehttps://github.com/python-openxml/python-docx
Issues387 (387)https://github.com/python-openxml/python-docx/issues
Pull requests167 (167)https://github.com/python-openxml/python-docx/pulls
Actionshttps://github.com/python-openxml/python-docx/actions
Projectshttps://github.com/python-openxml/python-docx/projects
Wikihttps://github.com/python-openxml/python-docx/wiki
Security and qualityhttps://github.com/python-openxml/python-docx/security
Insightshttps://github.com/python-openxml/python-docx/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fpython-openxml%2Fpython-docx%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython-openxml%2Fpython-docx%2Fissues%2Fnew%2Fchoose
kokotatanhttps://github.com/kokotatan
python-openxml:masterhttps://github.com/python-openxml/python-docx/tree/master
kokotatan:fix-page-break-adjacent-hyperlinkshttps://github.com/kokotatan/python-docx/tree/fix-page-break-adjacent-hyperlinks
Conversation 0 https://github.com/python-openxml/python-docx/pull/1625
Commits 1 https://github.com/python-openxml/python-docx/pull/1625/commits
Checks 0 https://github.com/python-openxml/python-docx/pull/1625/checks
Files changed https://github.com/python-openxml/python-docx/pull/1625/files
Please reload this pagehttps://github.com/python-openxml/python-docx/pull/1625/files
Fix rendered page break fragments adjacent to hyperlinks https://github.com/python-openxml/python-docx/pull/1625/files#top
Show all changes 1 commit https://github.com/python-openxml/python-docx/pull/1625/files
8000e63 Fix rendered page break fragments adjacent to hyperlinks kokotatan Oct 3, 2026 https://github.com/python-openxml/python-docx/pull/1625/commits/8000e636278a7e30416e28fe4635dd621dca933a
Clear filters https://github.com/python-openxml/python-docx/pull/1625/files
Please reload this pagehttps://github.com/python-openxml/python-docx/pull/1625/files
Please reload this pagehttps://github.com/python-openxml/python-docx/pull/1625/files
pagebreak.py https://github.com/python-openxml/python-docx/pull/1625/files#diff-cf2c68b53338bcf668c0ee5087a7953d3c16385bb16bc5fb0e6c08858ce94e73
test_pagebreak.py https://github.com/python-openxml/python-docx/pull/1625/files#diff-ffdbf908bcbbdc2b23987cb5450f9fc97df287aec1e38714515592b5003e59ab
src/docx/oxml/text/pagebreak.pyhttps://github.com/python-openxml/python-docx/pull/1625/files#diff-cf2c68b53338bcf668c0ee5087a7953d3c16385bb16bc5fb0e6c08858ce94e73
View file https://github.com/python-openxml/python-docx/blob/8000e636278a7e30416e28fe4635dd621dca933a/src/docx/oxml/text/pagebreak.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python-openxml/python-docx/pull/1625/{{ revealButtonHref }}
https://github.com/python-openxml/python-docx/pull/1625/files#diff-cf2c68b53338bcf668c0ee5087a7953d3c16385bb16bc5fb0e6c08858ce94e73
https://github.com/python-openxml/python-docx/pull/1625/files#diff-cf2c68b53338bcf668c0ee5087a7953d3c16385bb16bc5fb0e6c08858ce94e73
https://github.com/python-openxml/python-docx/pull/1625/files#diff-cf2c68b53338bcf668c0ee5087a7953d3c16385bb16bc5fb0e6c08858ce94e73
tests/text/test_pagebreak.pyhttps://github.com/python-openxml/python-docx/pull/1625/files#diff-ffdbf908bcbbdc2b23987cb5450f9fc97df287aec1e38714515592b5003e59ab
View file https://github.com/python-openxml/python-docx/blob/8000e636278a7e30416e28fe4635dd621dca933a/tests/text/test_pagebreak.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python-openxml/python-docx/pull/1625/{{ revealButtonHref }}
https://github.com/python-openxml/python-docx/pull/1625/files#diff-ffdbf908bcbbdc2b23987cb5450f9fc97df287aec1e38714515592b5003e59ab
https://github.com/python-openxml/python-docx/pull/1625/files#diff-ffdbf908bcbbdc2b23987cb5450f9fc97df287aec1e38714515592b5003e59ab
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.