René's URL Explorer Experiment


Title: fix: skip non-image parts when matching by sha1 in ImageParts by TemRevil · Pull Request #1566 · python-openxml/python-docx · GitHub

Open Graph Title: fix: skip non-image parts when matching by sha1 in ImageParts by TemRevil · Pull Request #1566 · python-openxml/python-docx

X Title: fix: skip non-image parts when matching by sha1 in ImageParts by TemRevil · Pull Request #1566 · python-openxml/python-docx

Description: Closes #1565. Problem Package._gather_image_parts walks the package relationships and appends the target of every image relationship to the ImageParts collection, casting it to ImagePart: def _gather_image_parts(self): for rel in self.iter_rels(): if rel.is_external: continue if rel.reltype != RT.IMAGE: continue if rel.target_part in self.image_parts: continue self.image_parts.append(cast("ImagePart", rel.target_part)) The cast is only a type hint. If an image uses a type that does not load as an ImagePart (an SVG, or an image with broken or non-standard EXIF data as in the report), the target part is a plain Part, which has no sha1. Once such a part is in the collection, the next add_picture call runs ImageParts._get_by_sha1, which reads .sha1 on every collected part, so it raised 'Part' object has no attribute 'sha1'. Fix Skip parts that have no sha1 while matching: for image_part in self._image_parts: if not hasattr(image_part, "sha1"): continue if image_part.sha1 == sha1: return image_part This mirrors the same fix already made in python-pptx (_ImageParts._find_by_sha1, commit 4c0fd125), which the issue links to. Tests Added it_skips_parts_without_a_sha1_when_matching in tests/test_package.py. It puts a plain Part (no sha1) ahead of the matching ImagePart in the collection and asserts _get_by_sha1 returns the ImagePart rather than raising. The test fails on the current code with the reported AttributeError and passes with the fix. Verified with pytest tests/test_package.py (9 passed) and ruff check on the changed files. The unrelated collection failures elsewhere in the suite on my machine come from a pyparsing version mismatch in the cxml test helper and are present on a clean checkout too.

Open Graph Description: Closes #1565. Problem Package._gather_image_parts walks the package relationships and appends the target of every image relationship to the ImageParts collection, casting it to ImagePart: def _gath...

X Description: Closes #1565. Problem Package._gather_image_parts walks the package relationships and appends the target of every image relationship to the ImageParts collection, casting it to ImagePart: def _gath...

Opengraph URL: https://github.com/python-openxml/python-docx/pull/1566

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:e347c744-361a-9bf2-3402-2e720eed9e4e
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idBAC2:77A5A:9623E6:B37FE1:6AFF6C29
html-safe-noncefafe8db48d4945e6b72a40659043eb49754b89e0e82b2e8bfb06b97f76c34950
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCQUMyOjc3QTVBOjk2MjNFNjpCMzdGRTE6NkFGRjZDMjkiLCJ2aXNpdG9yX2lkIjoiOTA5NDkxNTU3MTE5MDgxOTg4MiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac7827ba6309ed35ed5901e88522cfcda97ccb6704056bf3bcf1d1ab5ae011bdcb
hovercard-subject-tagpull_request:4033440680
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python-openxml/python-docx/pull/1566/files
twitter:imagehttps://avatars.githubusercontent.com/u/146881507?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/146881507?s=400&v=4
og:image:altCloses #1565. Problem Package._gather_image_parts walks the package relationships and appends the target of every image relationship to the ImageParts collection, casting it to ImagePart: def _gath...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None6d580fc7098c193d7866bf290c4c2b4859a153e87379f44161f35a4495e6b730
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python-openxml/python-docx git https://github.com/python-openxml/python-docx.git
octolytics-dimension-user_id3403760
octolytics-dimension-user_loginpython-openxml
octolytics-dimension-repository_id13592924
octolytics-dimension-repository_nwopython-openxml/python-docx
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id13592924
octolytics-dimension-repository_network_root_nwopython-openxml/python-docx
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releaseec5dd94a369dad6e9ce618a1705cbe3b618a2863
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python-openxml/python-docx/pull/1566/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython-openxml%2Fpython-docx%2Fpull%2F1566%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython-openxml%2Fpython-docx%2Fpull%2F1566%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python-openxml%2Fpython-docx
Reloadhttps://github.com/python-openxml/python-docx/pull/1566/files
Reloadhttps://github.com/python-openxml/python-docx/pull/1566/files
Reloadhttps://github.com/python-openxml/python-docx/pull/1566/files
python-openxmlhttps://github.com/python-openxml
python-docxhttps://github.com/python-openxml/python-docx
Codehttps://github.com/python-openxml/python-docx
Issues387 (387)https://github.com/python-openxml/python-docx/issues
Pull requests167 (167)https://github.com/python-openxml/python-docx/pulls
Actionshttps://github.com/python-openxml/python-docx/actions
Projectshttps://github.com/python-openxml/python-docx/projects
Wikihttps://github.com/python-openxml/python-docx/wiki
Security and qualityhttps://github.com/python-openxml/python-docx/security
Insightshttps://github.com/python-openxml/python-docx/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fpython-openxml%2Fpython-docx%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython-openxml%2Fpython-docx%2Fissues%2Fnew%2Fchoose
TemRevilhttps://github.com/TemRevil
python-openxml:masterhttps://github.com/python-openxml/python-docx/tree/master
TemRevil:fix/imageparts-skip-non-image-sha1https://github.com/TemRevil/python-docx/tree/fix/imageparts-skip-non-image-sha1
Conversation 0 https://github.com/python-openxml/python-docx/pull/1566
Commits 1 https://github.com/python-openxml/python-docx/pull/1566/commits
Checks 0 https://github.com/python-openxml/python-docx/pull/1566/checks
Files changed 2 https://github.com/python-openxml/python-docx/pull/1566/files
fix: skip non-image parts when matching by sha1 in ImageParts https://github.com/python-openxml/python-docx/pull/1566/files#top
Show all changes 1 commit https://github.com/python-openxml/python-docx/pull/1566/files
4652fda fix: skip non-image parts when matching by sha1 in ImageParts TemRevil Jul 11, 2026 https://github.com/python-openxml/python-docx/pull/1566/commits/4652fdaaa61f256aab9fe6d84827f31be1f5ff28
Clear filters https://github.com/python-openxml/python-docx/pull/1566/files
Please reload this pagehttps://github.com/python-openxml/python-docx/pull/1566/files
Please reload this pagehttps://github.com/python-openxml/python-docx/pull/1566/files
package.py https://github.com/python-openxml/python-docx/pull/1566/files#diff-e305bf01eb953d6120faa5b0babc585f74bd2cc1aef49fabb5a47adf7ba50136
test_package.py https://github.com/python-openxml/python-docx/pull/1566/files#diff-441a0361e528cef731ad578b384ca4efb4448c0d1939ddf7700aa570703d0c76
src/docx/package.pyhttps://github.com/python-openxml/python-docx/pull/1566/files#diff-e305bf01eb953d6120faa5b0babc585f74bd2cc1aef49fabb5a47adf7ba50136
View file https://github.com/python-openxml/python-docx/blob/4652fdaaa61f256aab9fe6d84827f31be1f5ff28/src/docx/package.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python-openxml/python-docx/pull/1566/{{ revealButtonHref }}
https://github.com/python-openxml/python-docx/pull/1566/files#diff-e305bf01eb953d6120faa5b0babc585f74bd2cc1aef49fabb5a47adf7ba50136
https://github.com/python-openxml/python-docx/pull/1566/files#diff-e305bf01eb953d6120faa5b0babc585f74bd2cc1aef49fabb5a47adf7ba50136
tests/test_package.pyhttps://github.com/python-openxml/python-docx/pull/1566/files#diff-441a0361e528cef731ad578b384ca4efb4448c0d1939ddf7700aa570703d0c76
View file https://github.com/python-openxml/python-docx/blob/4652fdaaa61f256aab9fe6d84827f31be1f5ff28/tests/test_package.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python-openxml/python-docx/pull/1566/{{ revealButtonHref }}
https://github.com/python-openxml/python-docx/pull/1566/files#diff-441a0361e528cef731ad578b384ca4efb4448c0d1939ddf7700aa570703d0c76
https://github.com/python-openxml/python-docx/pull/1566/files#diff-441a0361e528cef731ad578b384ca4efb4448c0d1939ddf7700aa570703d0c76
https://github.com/python-openxml/python-docx/pull/1566/files#diff-441a0361e528cef731ad578b384ca4efb4448c0d1939ddf7700aa570703d0c76
https://github.com/python-openxml/python-docx/pull/1566/files#diff-441a0361e528cef731ad578b384ca4efb4448c0d1939ddf7700aa570703d0c76
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.