René's URL Explorer Experiment


Title: fix: map highlight w:val="none" to None instead of raising by mithunvoe · Pull Request #1560 · python-openxml/python-docx · GitHub

Open Graph Title: fix: map highlight w:val="none" to None instead of raising by mithunvoe · Pull Request #1560 · python-openxml/python-docx

X Title: fix: map highlight w:val="none" to None instead of raising by mithunvoe · Pull Request #1560 · python-openxml/python-docx

Description: Fixes #1559. Problem Reading Font.highlight_color on a run with raises ValueError: WD_COLOR_INDEX has no XML mapping for 'none'. none is a valid ST_HighlightColor value that Word writes when a highlight is explicitly cleared. Because the error fires during parsing, it aborts processing of any document containing the value. from docx import Document from docx.oxml.ns import qn doc = Document() r = doc.add_paragraph().add_run("hi")._r hl = r.get_or_add_rPr().makeelement(qn("w:highlight"), {qn("w:val"): "none"}) r.get_or_add_rPr().append(hl) doc.paragraphs[0].runs[0].font.highlight_color # ValueError before this change Fix none means "not highlighted" — the same state python-docx already represents as None (returned when no w:highlight element is present, and what the highlight_val setter writes by removing the element). The getter now maps the explicit none value to None. none is the only ST_HighlightColor value absent from WD_COLOR_INDEX, so this closes the gap without introducing an enum member that would collide on MS-API value 0 with AUTO. Changes src/docx/oxml/text/font.py: CT_RPr.highlight_val returns None for w:val="none". tests/text/test_font.py: added a parametrized case asserting w:val=none reads as None. Verification pytest — full suite (1610 passed), including the new case ruff check / ruff format --check — clean pyright on the changed source — 0 errors

Open Graph Description: Fixes #1559. Problem Reading Font.highlight_color on a run with <w:highlight w:val="none"/> raises ValueError: WD_COLOR_INDEX has no XML mapping for 'none'. none is a valid ...

X Description: Fixes #1559. Problem Reading Font.highlight_color on a run with &lt;w:highlight w:val=&quot;none&quot;/&gt; raises ValueError: WD_COLOR_INDEX has no XML mapping for &#39;none&am...

Opengraph URL: https://github.com/python-openxml/python-docx/pull/1560

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:105fa321-94d7-9758-a940-4835ea1624be
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idEA84:1ECF9E:7B9D7:AB614:6AFF6C12
html-safe-nonce0aaf8f471ff43900d3ee4a3b5453892576c3f0d8a7ccc06628f109364d68ede5
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFQTg0OjFFQ0Y5RTo3QjlENzpBQjYxNDo2QUZGNkMxMiIsInZpc2l0b3JfaWQiOiI2OTY5ODkxMTAxNzUwNTUzNjE4IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac02cb795734104dc9d66de13d898e3bd92dd3e4712e1572e4ce4d1ceb9f588816
hovercard-subject-tagpull_request:3841876005
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python-openxml/python-docx/pull/1560/files
twitter:imagehttps://avatars.githubusercontent.com/u/71849009?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/71849009?s=400&v=4
og:image:altFixes #1559. Problem Reading Font.highlight_color on a run with <w:highlight w:val="none"/> raises ValueError: WD_COLOR_INDEX has no XML mapping for 'none'. none is a valid ...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None6d580fc7098c193d7866bf290c4c2b4859a153e87379f44161f35a4495e6b730
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python-openxml/python-docx git https://github.com/python-openxml/python-docx.git
octolytics-dimension-user_id3403760
octolytics-dimension-user_loginpython-openxml
octolytics-dimension-repository_id13592924
octolytics-dimension-repository_nwopython-openxml/python-docx
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id13592924
octolytics-dimension-repository_network_root_nwopython-openxml/python-docx
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releaseec5dd94a369dad6e9ce618a1705cbe3b618a2863
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python-openxml/python-docx/pull/1560/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython-openxml%2Fpython-docx%2Fpull%2F1560%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython-openxml%2Fpython-docx%2Fpull%2F1560%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python-openxml%2Fpython-docx
Reloadhttps://github.com/python-openxml/python-docx/pull/1560/files
Reloadhttps://github.com/python-openxml/python-docx/pull/1560/files
Reloadhttps://github.com/python-openxml/python-docx/pull/1560/files
python-openxmlhttps://github.com/python-openxml
python-docxhttps://github.com/python-openxml/python-docx
Codehttps://github.com/python-openxml/python-docx
Issues387 (387)https://github.com/python-openxml/python-docx/issues
Pull requests167 (167)https://github.com/python-openxml/python-docx/pulls
Actionshttps://github.com/python-openxml/python-docx/actions
Projectshttps://github.com/python-openxml/python-docx/projects
Wikihttps://github.com/python-openxml/python-docx/wiki
Security and qualityhttps://github.com/python-openxml/python-docx/security
Insightshttps://github.com/python-openxml/python-docx/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fpython-openxml%2Fpython-docx%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython-openxml%2Fpython-docx%2Fissues%2Fnew%2Fchoose
mithunvoehttps://github.com/mithunvoe
python-openxml:masterhttps://github.com/python-openxml/python-docx/tree/master
mithunvoe:fix/highlight-val-nonehttps://github.com/mithunvoe/python-docx/tree/fix/highlight-val-none
Conversation 0 https://github.com/python-openxml/python-docx/pull/1560
Commits 1 https://github.com/python-openxml/python-docx/pull/1560/commits
Checks 0 https://github.com/python-openxml/python-docx/pull/1560/checks
Files changed https://github.com/python-openxml/python-docx/pull/1560/files
Please reload this pagehttps://github.com/python-openxml/python-docx/pull/1560/files
fix: map highlight w:val="none" to None instead of raising https://github.com/python-openxml/python-docx/pull/1560/files#top
Show all changes 1 commit https://github.com/python-openxml/python-docx/pull/1560/files
ce390d3 fix: map highlight w:val="none" to None instead of raising mithunvoe Jun 10, 2026 https://github.com/python-openxml/python-docx/pull/1560/commits/ce390d3e79c773cb239d8a40dfbe5f2163aa2c35
Clear filters https://github.com/python-openxml/python-docx/pull/1560/files
Please reload this pagehttps://github.com/python-openxml/python-docx/pull/1560/files
Please reload this pagehttps://github.com/python-openxml/python-docx/pull/1560/files
font.py https://github.com/python-openxml/python-docx/pull/1560/files#diff-dffd363ba1c03765f79ed3684ba70ecf2bf91dcbd3a4234ff827a915ad5c7249
test_font.py https://github.com/python-openxml/python-docx/pull/1560/files#diff-8ddad0b23dad925b0c5d566d1734e40767ec808312db9b97ee1e78feb6f3ed53
src/docx/oxml/text/font.pyhttps://github.com/python-openxml/python-docx/pull/1560/files#diff-dffd363ba1c03765f79ed3684ba70ecf2bf91dcbd3a4234ff827a915ad5c7249
View file https://github.com/python-openxml/python-docx/blob/ce390d3e79c773cb239d8a40dfbe5f2163aa2c35/src/docx/oxml/text/font.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python-openxml/python-docx/pull/1560/{{ revealButtonHref }}
https://github.com/python-openxml/python-docx/pull/1560/files#diff-dffd363ba1c03765f79ed3684ba70ecf2bf91dcbd3a4234ff827a915ad5c7249
https://github.com/python-openxml/python-docx/pull/1560/files#diff-dffd363ba1c03765f79ed3684ba70ecf2bf91dcbd3a4234ff827a915ad5c7249
https://github.com/python-openxml/python-docx/pull/1560/files#diff-dffd363ba1c03765f79ed3684ba70ecf2bf91dcbd3a4234ff827a915ad5c7249
https://github.com/python-openxml/python-docx/pull/1560/files#diff-dffd363ba1c03765f79ed3684ba70ecf2bf91dcbd3a4234ff827a915ad5c7249
tests/text/test_font.pyhttps://github.com/python-openxml/python-docx/pull/1560/files#diff-8ddad0b23dad925b0c5d566d1734e40767ec808312db9b97ee1e78feb6f3ed53
View file https://github.com/python-openxml/python-docx/blob/ce390d3e79c773cb239d8a40dfbe5f2163aa2c35/tests/text/test_font.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python-openxml/python-docx/pull/1560/{{ revealButtonHref }}
https://github.com/python-openxml/python-docx/pull/1560/files#diff-8ddad0b23dad925b0c5d566d1734e40767ec808312db9b97ee1e78feb6f3ed53
https://github.com/python-openxml/python-docx/pull/1560/files#diff-8ddad0b23dad925b0c5d566d1734e40767ec808312db9b97ee1e78feb6f3ed53
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.