René's URL Explorer Experiment


Title: Validation of required fields inconsistent · Issue #373 · python-openapi/openapi-spec-validator · GitHub

Open Graph Title: Validation of required fields inconsistent · Issue #373 · python-openapi/openapi-spec-validator

X Title: Validation of required fields inconsistent · Issue #373 · python-openapi/openapi-spec-validator

Description: The validation of the required keyword does not make sense as it is implemented right now, IMHO. It really does not make any sense to list properties in required that do not exist. If you want to use it with allOf and therefore have prop...

Open Graph Description: The validation of the required keyword does not make sense as it is implemented right now, IMHO. It really does not make any sense to list properties in required that do not exist. If you want to u...

X Description: The validation of the required keyword does not make sense as it is implemented right now, IMHO. It really does not make any sense to list properties in required that do not exist. If you want to u...

Opengraph URL: https://github.com/python-openapi/openapi-spec-validator/issues/373

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Validation of required fields inconsistent","articleBody":"The validation of the `required` keyword does not make sense as it is implemented right now, IMHO.\r\n\r\n1. It really does not make any sense to list properties in `required` that do not exist.\r\n2. If you want to use it with `allOf` and therefore have properties in `required` that do not exist, there are already precautions (#154).\r\n3. Currently, there is no validation error in the standard case but as soon as I have `allOf` in my schema, there is a validation error. That is inconsistent. The PR that breaks it: #312\r\n4. In `$ref`erenced schemas, the validation does not take effect either.\r\n\r\nOne of the main reasons why this should urgently be validated (as was in version 0.7.0) is that validators (that use the specification to validate requests/responses) will fail if there is e.g. a typo in one of the entries in `required`. And now there is no way to detect that.\r\n\r\nIn general, the OpenAPI/JsonSchema specification is quite relaxed. If only the bare minimum should be validated, this is probably not the only validation that can basically be removed completely.\r\n\r\nMy take on this:\r\n\r\n1. Best case: Throw validation errors for things that are obvious errors (like specifying a field as required that does not even exist).\r\n2. Second best option: make it configurable (\"strict mode\") or filterable (error IDs to exclude, filter levels, ...).\r\n3. Absolutely necessary minium: make it consistent.\r\n\r\nI'd be willing to provide a PR. But since this has been going [back ](#97) and [forth](#266) I'd like a decision first, where this is going.","author":{"url":"https://github.com/Archelyst","@type":"Person","name":"Archelyst"},"datePublished":"2024-08-09T11:01:52.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":1},"url":"https://github.com/373/openapi-spec-validator/issues/373"}

route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:26fbaf00-cc76-078d-6116-be27f17e534a
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idA6A8:1D778D:51D054:73C6C7:696A513E
html-safe-nonceb9f8d1e428776ed7208d6cfce3801bba99b46364c2fca1588903d56f1c6f13e8
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBNkE4OjFENzc4RDo1MUQwNTQ6NzNDNkM3OjY5NkE1MTNFIiwidmlzaXRvcl9pZCI6IjM0NTY1ODgwMzIzMjE5MzM2MzAiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac5ca5fbe63e8c3f010b43e8214c1650aed5ec38977d3acdae314842280ba6affe
hovercard-subject-tagissue:2457671438
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/python-openapi/openapi-spec-validator/373/issue_layout
twitter:imagehttps://opengraph.githubassets.com/2c3544d629169aaea65e45547ed3f3232b610d6e547213c774e6397168bc9781/python-openapi/openapi-spec-validator/issues/373
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/2c3544d629169aaea65e45547ed3f3232b610d6e547213c774e6397168bc9781/python-openapi/openapi-spec-validator/issues/373
og:image:altThe validation of the required keyword does not make sense as it is implemented right now, IMHO. It really does not make any sense to list properties in required that do not exist. If you want to u...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameArchelyst
hostnamegithub.com
expected-hostnamegithub.com
None3f871c8e07f0ae1886fa8dac284166d28b09ad5bada6476fc10b674e489788ef
turbo-cache-controlno-preview
go-importgithub.com/python-openapi/openapi-spec-validator git https://github.com/python-openapi/openapi-spec-validator.git
octolytics-dimension-user_id126442889
octolytics-dimension-user_loginpython-openapi
octolytics-dimension-repository_id102581313
octolytics-dimension-repository_nwopython-openapi/openapi-spec-validator
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id102581313
octolytics-dimension-repository_network_root_nwopython-openapi/openapi-spec-validator
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release63c426b30d262aba269ef14c40e3c817b384cd61
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python-openapi/openapi-spec-validator/issues/373#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython-openapi%2Fopenapi-spec-validator%2Fissues%2F373
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython-openapi%2Fopenapi-spec-validator%2Fissues%2F373
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=python-openapi%2Fopenapi-spec-validator
Reloadhttps://github.com/python-openapi/openapi-spec-validator/issues/373
Reloadhttps://github.com/python-openapi/openapi-spec-validator/issues/373
Reloadhttps://github.com/python-openapi/openapi-spec-validator/issues/373
python-openapi https://github.com/python-openapi
openapi-spec-validatorhttps://github.com/python-openapi/openapi-spec-validator
Please reload this pagehttps://github.com/python-openapi/openapi-spec-validator/issues/373
Notifications https://github.com/login?return_to=%2Fpython-openapi%2Fopenapi-spec-validator
Fork 70 https://github.com/login?return_to=%2Fpython-openapi%2Fopenapi-spec-validator
Star 384 https://github.com/login?return_to=%2Fpython-openapi%2Fopenapi-spec-validator
Code https://github.com/python-openapi/openapi-spec-validator
Issues 46 https://github.com/python-openapi/openapi-spec-validator/issues
Pull requests 9 https://github.com/python-openapi/openapi-spec-validator/pulls
Discussions https://github.com/python-openapi/openapi-spec-validator/discussions
Actions https://github.com/python-openapi/openapi-spec-validator/actions
Projects 0 https://github.com/python-openapi/openapi-spec-validator/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python-openapi/openapi-spec-validator/security
Please reload this pagehttps://github.com/python-openapi/openapi-spec-validator/issues/373
Insights https://github.com/python-openapi/openapi-spec-validator/pulse
Code https://github.com/python-openapi/openapi-spec-validator
Issues https://github.com/python-openapi/openapi-spec-validator/issues
Pull requests https://github.com/python-openapi/openapi-spec-validator/pulls
Discussions https://github.com/python-openapi/openapi-spec-validator/discussions
Actions https://github.com/python-openapi/openapi-spec-validator/actions
Projects https://github.com/python-openapi/openapi-spec-validator/projects
Security https://github.com/python-openapi/openapi-spec-validator/security
Insights https://github.com/python-openapi/openapi-spec-validator/pulse
New issuehttps://github.com/login?return_to=https://github.com/python-openapi/openapi-spec-validator/issues/373
New issuehttps://github.com/login?return_to=https://github.com/python-openapi/openapi-spec-validator/issues/373
Validation of required fields inconsistenthttps://github.com/python-openapi/openapi-spec-validator/issues/373#top
https://github.com/Archelyst
https://github.com/Archelyst
Archelysthttps://github.com/Archelyst
on Aug 9, 2024https://github.com/python-openapi/openapi-spec-validator/issues/373#issue-2457671438
feat: handle allof when required linked to parent object (#97) #154https://github.com/python-openapi/openapi-spec-validator/pull/154
Allow undefined required properties #312https://github.com/python-openapi/openapi-spec-validator/pull/312
back https://github.com/python-openapi/openapi-spec-validator/issues/373#97
forthhttps://github.com/python-openapi/openapi-spec-validator/issues/373#266
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.