René's URL Explorer Experiment


Title: Fix required in composition by sebastianmika · Pull Request #16 · python-openapi/openapi-schema-validator · GitHub

Open Graph Title: Fix required in composition by sebastianmika · Pull Request #16 · python-openapi/openapi-schema-validator

X Title: Fix required in composition by sebastianmika · Pull Request #16 · python-openapi/openapi-schema-validator

Description: This would close #14 and #15 at the expense of only being able to validate required and readOnly/writeOnly combinations when the required is defined on the same schema as the readOnly/writeOnly property. Personally I would find that more balanced, esp. since readOnly and writeOnly seem to have been dropped from the latest 3.1.0 OpenAPI specs (cf. OAI/OpenAPI-Specification#1622). That being said, it might even be more consequent to just resort back to the jsonschema.validators.required.

Open Graph Description: This would close #14 and #15 at the expense of only being able to validate required and readOnly/writeOnly combinations when the required is defined on the same schema as the readOnly/writeOnly pr...

X Description: This would close #14 and #15 at the expense of only being able to validate required and readOnly/writeOnly combinations when the required is defined on the same schema as the readOnly/writeOnly pr...

Opengraph URL: https://github.com/python-openapi/openapi-schema-validator/pull/16

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:31b52eeb-b668-3ce2-47e7-f86c3b043ebc
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB380:42EA3:7A29D3:AAAC47:6AF9CE1A
html-safe-noncee758d20cf4655f5cb8f8d10bac810aa162d747604b3aa6af8c01ec054edfb0a1
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCMzgwOjQyRUEzOjdBMjlEMzpBQUFDNDc6NkFGOUNFMUEiLCJ2aXNpdG9yX2lkIjoiNzI1NzkwNTc1NDU3OTUyMTA1MCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac33afe0edcd7994842b34d110d1a03254817cdd67cd8004df73975f6657585226
hovercard-subject-tagpull_request:677306902
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python-openapi/openapi-schema-validator/pull/16/files
twitter:imagehttps://avatars.githubusercontent.com/u/7964253?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/7964253?s=400&v=4
og:image:altThis would close #14 and #15 at the expense of only being able to validate required and readOnly/writeOnly combinations when the required is defined on the same schema as the readOnly/writeOnly pr...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None612d3e6ffd693e7ea8d9fcf452370995872baef31d825b1fedef704cd3d24ac7
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python-openapi/openapi-schema-validator git https://github.com/python-openapi/openapi-schema-validator.git
octolytics-dimension-user_id126442889
octolytics-dimension-user_loginpython-openapi
octolytics-dimension-repository_id245119225
octolytics-dimension-repository_nwopython-openapi/openapi-schema-validator
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id245119225
octolytics-dimension-repository_network_root_nwopython-openapi/openapi-schema-validator
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release072e34035c13c31543fba9f025cbbbda4210dae4
ui-targetcanary-2
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python-openapi/openapi-schema-validator/pull/16/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython-openapi%2Fopenapi-schema-validator%2Fpull%2F16%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython-openapi%2Fopenapi-schema-validator%2Fpull%2F16%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python-openapi%2Fopenapi-schema-validator
Reloadhttps://github.com/python-openapi/openapi-schema-validator/pull/16/files
Reloadhttps://github.com/python-openapi/openapi-schema-validator/pull/16/files
Reloadhttps://github.com/python-openapi/openapi-schema-validator/pull/16/files
python-openapihttps://github.com/python-openapi
openapi-schema-validatorhttps://github.com/python-openapi/openapi-schema-validator
Codehttps://github.com/python-openapi/openapi-schema-validator
Issues1 (1)https://github.com/python-openapi/openapi-schema-validator/issues
Pull requests17 (17)https://github.com/python-openapi/openapi-schema-validator/pulls
Discussionshttps://github.com/python-openapi/openapi-schema-validator/discussions
Actionshttps://github.com/python-openapi/openapi-schema-validator/actions
Projectshttps://github.com/python-openapi/openapi-schema-validator/projects
Security and qualityhttps://github.com/python-openapi/openapi-schema-validator/security
Insightshttps://github.com/python-openapi/openapi-schema-validator/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython-openapi%2Fopenapi-schema-validator%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython-openapi%2Fopenapi-schema-validator%2Fissues%2Fnew%2Fchoose
p1c2uhttps://github.com/p1c2u
python-openapi:masterhttps://github.com/python-openapi/openapi-schema-validator/tree/master
sebastianmika:fix_required_in_compositionhttps://github.com/sebastianmika/openapi-schema-validator/tree/fix_required_in_composition
Conversation 3 https://github.com/python-openapi/openapi-schema-validator/pull/16
Commits 2 https://github.com/python-openapi/openapi-schema-validator/pull/16/commits
Checks 0 https://github.com/python-openapi/openapi-schema-validator/pull/16/checks
Files changed https://github.com/python-openapi/openapi-schema-validator/pull/16/files
Please reload this pagehttps://github.com/python-openapi/openapi-schema-validator/pull/16/files
Fix required in composition https://github.com/python-openapi/openapi-schema-validator/pull/16/files#top
Show all changes 2 commits https://github.com/python-openapi/openapi-schema-validator/pull/16/files
92df023 Only validate readOnly/writeOnly for required properties if the prope… Jun 24, 2021 https://github.com/python-openapi/openapi-schema-validator/pull/16/commits/92df0237ff755d80e7a9806d2b23d7e6af0b429c
b106d9c more test coverage Jun 24, 2021 https://github.com/python-openapi/openapi-schema-validator/pull/16/commits/b106d9c422a1b82e6d0726fc7559f80cb3628faf
Clear filters https://github.com/python-openapi/openapi-schema-validator/pull/16/files
Please reload this pagehttps://github.com/python-openapi/openapi-schema-validator/pull/16/files
Please reload this pagehttps://github.com/python-openapi/openapi-schema-validator/pull/16/files
_validators.py https://github.com/python-openapi/openapi-schema-validator/pull/16/files#diff-b9d2563e069b133108c20aa9ab9e3f476535ca08dea9d454fef264c93663306f
test_validators.py https://github.com/python-openapi/openapi-schema-validator/pull/16/files#diff-8e185a479ff937a663d56eacc24717aae4494e7c5e2c15f24edd6955b1680eef
openapi_schema_validator/_validators.pyhttps://github.com/python-openapi/openapi-schema-validator/pull/16/files#diff-b9d2563e069b133108c20aa9ab9e3f476535ca08dea9d454fef264c93663306f
View file https://github.com/sebastianmika/openapi-schema-validator/blob/b106d9c422a1b82e6d0726fc7559f80cb3628faf/openapi_schema_validator/_validators.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python-openapi/openapi-schema-validator/pull/16/{{ revealButtonHref }}
https://github.com/python-openapi/openapi-schema-validator/pull/16/files#diff-b9d2563e069b133108c20aa9ab9e3f476535ca08dea9d454fef264c93663306f
https://github.com/python-openapi/openapi-schema-validator/pull/16/files#diff-b9d2563e069b133108c20aa9ab9e3f476535ca08dea9d454fef264c93663306f
https://github.com/python-openapi/openapi-schema-validator/pull/16/files#diff-b9d2563e069b133108c20aa9ab9e3f476535ca08dea9d454fef264c93663306f
tests/integration/test_validators.pyhttps://github.com/python-openapi/openapi-schema-validator/pull/16/files#diff-8e185a479ff937a663d56eacc24717aae4494e7c5e2c15f24edd6955b1680eef
View file https://github.com/sebastianmika/openapi-schema-validator/blob/b106d9c422a1b82e6d0726fc7559f80cb3628faf/tests/integration/test_validators.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python-openapi/openapi-schema-validator/pull/16/{{ revealButtonHref }}
https://github.com/python-openapi/openapi-schema-validator/pull/16/files#diff-8e185a479ff937a663d56eacc24717aae4494e7c5e2c15f24edd6955b1680eef
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.