René's URL Explorer Experiment

{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"[Bug]: Raises `DeprecationWarning` for deprecated parameters that were not provided","articleBody":"### Actual Behavior\r\n\r\nIf I write an OpenAPI document that specifies a parameter `foo` that’s `deprecated: true`, and use it to validate a request that *does not include that parameter*, openapi-core still raises `DeprecationWarning: foo parameter is deprecated` for no reason.\r\n\r\n### Expected Behavior\r\n\r\nNo `DeprecationWarning` should be raised.\r\n\r\nI don’t think `DeprecationWarning` is appropriate at all here, as a `DeprecationWarning` is one that’s “[intended for other Python developers](https://docs.python.org/3/library/exceptions.html#DeprecationWarning)” and not for users of a network API. But at the least, it’s obviously inappropriate when the parameter being warned about was not even provided.\r\n\r\n### Steps to Reproduce\r\n\r\nRun with `python -Werror` (or in another way that enables warnings, such as [development mode](https://docs.python.org/3/library/devmode.html)):\r\n\r\n```python\r\nfrom openapi_core import OpenAPI\r\nfrom openapi_core.testing import MockRequest\r\n\r\nspec = OpenAPI.from_dict(\r\n    {\r\n        \"openapi\": \"3.1.0\",\r\n        \"info\": {\"version\": \"0\", \"title\": \"test\"},\r\n        \"paths\": {\r\n            \"/test\": {\r\n                \"get\": {\r\n                    \"parameters\": [\r\n                        {\r\n                            \"name\": \"foo\",\r\n                            \"in\": \"query\",\r\n                            \"schema\": {},\r\n                            \"deprecated\": True,\r\n                        },\r\n                    ],\r\n                },\r\n            },\r\n        },\r\n    }\r\n)\r\nspec.validate_request(MockRequest(\"http://localhost\", \"get\", \"/test\"))\r\n```\r\n\r\n```pytb\r\nTraceback (most recent call last):\r\n  File \"/home/anders/python/openapi-core/deprecated_test.py\", line 24, in \u003cmodule\u003e\r\n    spec.validate_request(MockRequest(\"http://localhost\", \"get\", \"/test\"))\r\n  File \"/home/anders/python/openapi-core/openapi_core/app.py\", line 360, in validate_request\r\n    self.validate_apicall_request(request)\r\n  File \"/home/anders/python/openapi-core/openapi_core/app.py\", line 373, in validate_apicall_request\r\n    self.request_validator.validate(request)\r\n  File \"/home/anders/python/openapi-core/openapi_core/validation/request/validators.py\", line 286, in validate\r\n    for err in self.iter_errors(request):\r\n               ^^^^^^^^^^^^^^^^^^^^^^^^^\r\n  File \"/home/anders/python/openapi-core/openapi_core/validation/request/validators.py\", line 349, in iter_errors\r\n    yield from self._iter_errors(request, operation, path)\r\n  File \"/home/anders/python/openapi-core/openapi_core/validation/request/validators.py\", line 115, in _iter_errors\r\n    self._get_parameters(request.parameters, operation, path)\r\n  File \"/home/anders/python/openapi-core/openapi_core/validation/request/validators.py\", line 172, in _get_parameters\r\n    value = self._get_parameter(parameters, param)\r\n            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^\r\n  File \"/home/anders/python/openapi-core/openapi_core/validation/decorators.py\", line 31, in wrapper\r\n    return f(*args, **kwds)\r\n           ^^^^^^^^^^^^^^^^\r\n  File \"/home/anders/python/openapi-core/openapi_core/validation/request/validators.py\", line 199, in _get_parameter\r\n    warnings.warn(\r\nDeprecationWarning: foo parameter is deprecated\r\n```\r\n\r\n### OpenAPI Core Version\r\n\r\n0.19.4\r\n\r\n### OpenAPI Core Integration\r\n\r\nnone\r\n\r\n### Affected Area(s)\r\n\r\n_No response_\r\n\r\n### References\r\n\r\nvalidation\r\n\r\n### Anything else we need to know?\r\n\r\n_No response_\r\n\r\n### Would you like to implement a fix?\r\n\r\nNone","author":{"url":"https://github.com/andersk","@type":"Person","name":"andersk"},"datePublished":"2024-10-23T03:17:52.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":0},"url":"https://github.com/931/openapi-core/issues/931"}