René's URL Explorer Experiment

{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"[Bug]: No casting applied if type is object","articleBody":"### Actual Behavior\n\nWhen validating a request, I get a different validation error depending on the structure of the schema.\r\n\r\nIf I have the following schema:\r\n```yaml\r\nPet:\r\n  type: object  # \u003c-- this causes the difference\r\n  properties:\r\n    id:\r\n      type: integer\r\nPet2:\r\n  allOf:\r\n    - properties:\r\n        id:\r\n          type: integer\r\n```\r\nand send a request with body `{\"id\": \"hello\"}`,\r\n\r\nwith the first schema I get:\r\n```\r\nopenapi_core.casting.schemas.exceptions.CastError: Failed to cast value to integer type: hello\r\n```\r\nwhereas in the second one I get:\r\n```\r\nopenapi_core.validation.schemas.exceptions.InvalidSchemaValue: Value {'id': 'hello'} not valid for schema of type any: (\u003cValidationError: \"'hello' is not of type 'integer'\"\u003e,)\r\n```\n\n### Expected Behavior\n\nThese schemas are equivalent, and as such I expected to get the same error. Specifically, I expected the validation error in both cases rather than the casting error as I asked for request validation.\r\nAlso, removing the `type: object` in the first schema seems to bypass casting entirely and leads to the same validation error as the second schema.\n\n### Steps to Reproduce\n\n\u003cdetails\u003e\r\n\u003csummary\u003eschema.yaml\u003c/summary\u003e\r\n\r\n```yaml\r\nopenapi: \"3.0.0\"\r\ninfo:\r\n  title: \"Sample API\"\r\n  version: \"1.0.0\"\r\nservers:\r\n  - url: /\r\npaths:\r\n  /pets:\r\n    post:\r\n      summary: Create a pet\r\n      operationId: createPet\r\n      requestBody:\r\n        content:\r\n          application/json:\r\n            schema:\r\n              $ref: \"#/components/schemas/Pet\"\r\n      responses:\r\n        '201':\r\n          description: Created\r\n          content:\r\n            application/json:\r\n              schema:\r\n                $ref: \"#/components/schemas/Pet\"\r\n  /pets2:\r\n    post:\r\n      summary: Create a pet\r\n      operationId: createPet2\r\n      requestBody:\r\n        content:\r\n          application/json:\r\n            schema:\r\n              $ref: \"#/components/schemas/Pet2\"\r\n      responses:\r\n        '201':\r\n          description: Created\r\n          content:\r\n            application/json:\r\n              schema:\r\n                $ref: \"#/components/schemas/Pet\"\r\ncomponents:\r\n  schemas:\r\n    Pet:\r\n      type: object  # \u003c-- this causes the difference\r\n      properties:\r\n        id:\r\n          type: integer\r\n    Pet2:\r\n      allOf:\r\n        - properties:\r\n            id:\r\n              type: integer\r\n```\r\n\r\n\u003c/details\u003e\r\n\r\n```python\r\nimport json\r\nimport traceback\r\nimport openapi_core\r\nfrom openapi_core.contrib.starlette import StarletteOpenAPIRequest\r\nfrom starlette.requests import Request\r\n\r\n\r\ndef starlette_request(path: str):\r\n    return Request({\r\n        \"type\": \"http\",\r\n        \"method\": \"POST\",\r\n        \"path\": path,\r\n        \"headers\": [(b\"content-type\", b\"application/json\")],\r\n        \"query_string\": \"\",\r\n    })\r\n\r\n\r\nbody = json.dumps({\"id\": \"hello\"})\r\n\r\nopenapi = openapi_core.OpenAPI.from_file_path(\"schema.yaml\")\r\ntry:\r\n    openapi.validate_request(\r\n        StarletteOpenAPIRequest(starlette_request(\"/pets\"), body=body)\r\n    )\r\nexcept openapi_core.exceptions.OpenAPIError:\r\n    traceback.print_exc()\r\n\r\ntry:\r\n    openapi.validate_request(\r\n        StarletteOpenAPIRequest(starlette_request(\"/pets2\"), body=body)\r\n    )\r\nexcept openapi_core.exceptions.OpenAPIError:\r\n    traceback.print_exc()\r\n```\n\n### OpenAPI Core Version\n\n0.19.0\n\n### OpenAPI Core Integration\n\nstarlette\n\n### Affected Area(s)\n\ncasting, validation\n\n### References\n\n_No response_\n\n### Anything else we need to know?\n\n_No response_\n\n### Would you like to implement a fix?\n\nNone","author":{"url":"https://github.com/jonathanberthias","@type":"Person","name":"jonathanberthias"},"datePublished":"2024-03-01T09:44:35.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":0},"url":"https://github.com/800/openapi-core/issues/800"}