Title: [Bug]: Won’t validate empty request body even if it satisfies the schema · Issue #702 · python-openapi/openapi-core · GitHub
Open Graph Title: [Bug]: Won’t validate empty request body even if it satisfies the schema · Issue #702 · python-openapi/openapi-core
X Title: [Bug]: Won’t validate empty request body even if it satisfies the schema · Issue #702 · python-openapi/openapi-core
Description: Actual Behavior An empty application/x-www-form-urlencoded request body unexpectedly fails to validate even if it should satisfy the schema, such as when all parameters are optional. Traceback (most recent call last): File "/home/anders/...
Open Graph Description: Actual Behavior An empty application/x-www-form-urlencoded request body unexpectedly fails to validate even if it should satisfy the schema, such as when all parameters are optional. Traceback (mos...
X Description: Actual Behavior An empty application/x-www-form-urlencoded request body unexpectedly fails to validate even if it should satisfy the schema, such as when all parameters are optional. Traceback (mos...
Opengraph URL: https://github.com/python-openapi/openapi-core/issues/702
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"[Bug]: Won’t validate empty request body even if it satisfies the schema","articleBody":"### Actual Behavior\r\n\r\nAn empty `application/x-www-form-urlencoded` request body unexpectedly fails to validate even if it should satisfy the schema, such as when all parameters are optional.\r\n\r\n```pytb\r\nTraceback (most recent call last):\r\n File \"/home/anders/python/openapi-core/test.py\", line 56, in \u003cmodule\u003e\r\n validate_request(request, spec=spec) # error\r\n File \"/home/anders/python/openapi-core/openapi_core/shortcuts.py\", line 321, in validate_request\r\n validate_apicall_request(\r\n File \"/home/anders/python/openapi-core/openapi_core/shortcuts.py\", line 396, in validate_apicall_request\r\n return v.validate(request)\r\n File \"/home/anders/python/openapi-core/openapi_core/validation/request/validators.py\", line 279, in validate\r\n raise err\r\n File \"/home/anders/python/openapi-core/openapi_core/validation/request/validators.py\", line 114, in _iter_errors\r\n self._get_body(request.body, request.content_type, operation)\r\n File \"/home/anders/python/openapi-core/openapi_core/validation/decorators.py\", line 35, in wrapper\r\n self._raise_error(exc, self.err_cls, f, *args, **kwds)\r\n File \"/home/anders/python/openapi-core/openapi_core/validation/decorators.py\", line 31, in wrapper\r\n return f(*args, **kwds)\r\n File \"/home/anders/python/openapi-core/openapi_core/validation/request/validators.py\", line 259, in _get_body\r\n raw_body = self._get_body_value(body, request_body)\r\n File \"/home/anders/python/openapi-core/openapi_core/validation/request/validators.py\", line 269, in _get_body_value\r\n raise MissingRequestBody\r\nopenapi_core.validation.request.exceptions.MissingRequestBody: Missing request body\r\n```\r\n\r\n### Expected Behavior\r\n\r\nNo error.\r\n\r\n### Steps to Reproduce\r\n\r\n```python\r\nfrom openapi_core import Spec, validate_request\r\nfrom openapi_core.testing import MockRequest\r\n\r\nspec = Spec.from_dict(\r\n {\r\n \"openapi\": \"3.1.0\",\r\n \"info\": {\"version\": \"0\", \"title\": \"test\"},\r\n \"paths\": {\r\n \"/test\": {\r\n \"post\": {\r\n \"requestBody\": {\r\n \"content\": {\r\n \"application/x-www-form-urlencoded\": {\r\n \"schema\": {\r\n \"type\": \"object\",\r\n \"properties\": {\r\n \"foo\": {\"type\": \"string\"},\r\n \"bar\": {\"type\": \"string\"},\r\n },\r\n },\r\n }\r\n }\r\n },\r\n \"responses\": {\"200\": {\"description\": \"OK\"}},\r\n }\r\n }\r\n },\r\n }\r\n)\r\n\r\nrequest = MockRequest(\r\n \"http://localhost\",\r\n \"post\",\r\n \"/test\",\r\n data=\"foo=foo\",\r\n content_type=\"application/x-www-form-urlencoded\",\r\n)\r\nvalidate_request(request, spec=spec) # ok\r\n\r\nrequest = MockRequest(\r\n \"http://localhost\",\r\n \"post\",\r\n \"/test\",\r\n data=\"bar=bar\",\r\n content_type=\"application/x-www-form-urlencoded\",\r\n)\r\nvalidate_request(request, spec=spec) # ok\r\n\r\nrequest = MockRequest(\r\n \"http://localhost\",\r\n \"post\",\r\n \"/test\",\r\n data=\"\",\r\n content_type=\"application/x-www-form-urlencoded\",\r\n)\r\nvalidate_request(request, spec=spec) # error\r\n```\r\n\r\n### OpenAPI Core Version\r\n\r\ncurrent Git (efaa5aca494341837470552e905ca6f35f1fe88e)\r\n\r\n### OpenAPI Core Integration\r\n\r\nnone\r\n\r\n### Affected Area(s)\r\n\r\n_No response_\r\n\r\n### References\r\n\r\n_No response_\r\n\r\n### Anything else we need to know?\r\n\r\n_No response_\r\n\r\n### Would you like to implement a fix?\r\n\r\nNone","author":{"url":"https://github.com/andersk","@type":"Person","name":"andersk"},"datePublished":"2023-10-23T04:11:42.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":1},"url":"https://github.com/702/openapi-core/issues/702"}
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:00b373bb-35ed-91ee-290b-ad674d58f5f0 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | DE06:1B0C8B:F0061:152571:697780C4 |
| html-safe-nonce | bd50e8d9a9bc59223dfae64821e637faa5f7de540d8081beb1ec6db4d9b8fbf7 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJERTA2OjFCMEM4QjpGMDA2MToxNTI1NzE6Njk3NzgwQzQiLCJ2aXNpdG9yX2lkIjoiNzY1NjY0NTY1MjExNjg5Nzk4OCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 16645eae64a9eed9c7f62d210b2465734ed378a8bd298f16c91517b144c736ac |
| hovercard-subject-tag | issue:1956313464 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/python-openapi/openapi-core/702/issue_layout |
| twitter:image | https://opengraph.githubassets.com/5837240dac054a5b4ed7d4b2444c93a49fcd11d4320c074a94568b3478177b0f/python-openapi/openapi-core/issues/702 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/5837240dac054a5b4ed7d4b2444c93a49fcd11d4320c074a94568b3478177b0f/python-openapi/openapi-core/issues/702 |
| og:image:alt | Actual Behavior An empty application/x-www-form-urlencoded request body unexpectedly fails to validate even if it should satisfy the schema, such as when all parameters are optional. Traceback (mos... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | andersk |
| hostname | github.com |
| expected-hostname | github.com |
| None | fd37f8e74ecc49b700617ea694fa6d7b395b6c9a4b79c59b3014da220462ac69 |
| turbo-cache-control | no-preview |
| go-import | github.com/python-openapi/openapi-core git https://github.com/python-openapi/openapi-core.git |
| octolytics-dimension-user_id | 126442889 |
| octolytics-dimension-user_login | python-openapi |
| octolytics-dimension-repository_id | 104200746 |
| octolytics-dimension-repository_nwo | python-openapi/openapi-core |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 104200746 |
| octolytics-dimension-repository_network_root_nwo | python-openapi/openapi-core |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 37dddf0637fe1f68f5c5d619bd3e03ec27105339 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width