René's URL Explorer Experiment

{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"UnmarshallerError if specifying `format` with `type: [foo, 'null']`","articleBody":"I'm still working on minimal reproducer to prove this out so apologies for the lack of a one in advance.\r\n\r\nI've got a schema like this:\r\n\r\n```yaml\r\nopenapi: '3.1.0'\r\n# ...\r\ncomponents:\r\n  schemas:\r\n    PatchList:\r\n      type: 'object'\r\n      properties:\r\n        # ...\r\n        pull_url:\r\n          title: 'Pull URL'\r\n          type:\r\n            - 'string'\r\n            - 'null'\r\n          format: 'uri'\r\n          maxLength: 255\r\n        # ...\r\n```\r\n\r\nIf my server returns a response with `pull_url` set to `null`, then the call to `openapi_core.validation.response.validators.ResponseValidator.validate` fails with the following traceback:\r\n\r\n```python\r\nTraceback (most recent call last):\r\n  File \"/dev/patchwork/patchwork/tests/api/test_relation.py\", line 267, in test_remove_one_patch_from_relation_good\r\n    resp = self.client.patch(\r\n  File \"/dev/patchwork/patchwork/tests/api/utils.py\", line 241, in patch\r\n    validator.validate_data(\r\n  File \"/dev/patchwork/patchwork/tests/api/validator.py\", line 141, in validate_data\r\n    result.raise_for_errors()\r\n  File \"/dev/openapi-core/openapi_core/validation/datatypes.py\", line 12, in raise_for_errors\r\n    raise error\r\n  File \"/dev/openapi-core/openapi_core/validation/response/validators.py\", line 245, in validate\r\n    data = self._get_data(response, operation_response)\r\n  File \"/dev/openapi-core/openapi_core/validation/response/validators.py\", line 88, in _get_data\r\n    data = self._unmarshal(schema, casted)\r\n  File \"/dev/openapi-core/openapi_core/validation/validators.py\", line 76, in _unmarshal\r\n    return unmarshaller(value)\r\n  File \"/dev/openapi-core/openapi_core/unmarshalling/schemas/unmarshallers.py\", line 91, in __call__\r\n    return self.unmarshal(value)\r\n  File \"/dev/openapi-core/openapi_core/unmarshalling/schemas/unmarshallers.py\", line 434, in unmarshal\r\n    return unmarshaller.unmarshal(value)\r\n  File \"/dev/openapi-core/openapi_core/unmarshalling/schemas/unmarshallers.py\", line 316, in unmarshal\r\n    properties = self.format(value)\r\n  File \"/dev/openapi-core/openapi_core/unmarshalling/schemas/unmarshallers.py\", line 325, in format\r\n    return self._unmarshal_properties(formatted, schema_only=schema_only)\r\n  File \"/dev/openapi-core/openapi_core/unmarshalling/schemas/unmarshallers.py\", line 354, in _unmarshal_properties\r\n    all_of_properties = self._clone(all_of_schema).format(\r\n  File \"/dev/openapi-core/openapi_core/unmarshalling/schemas/unmarshallers.py\", line 325, in format\r\n    return self._unmarshal_properties(formatted, schema_only=schema_only)\r\n  File \"/dev/openapi-core/openapi_core/unmarshalling/schemas/unmarshallers.py\", line 373, in _unmarshal_properties\r\n    properties[prop_name] = self.unmarshallers_factory.create(\r\n  File \"/dev/openapi-core/openapi_core/unmarshalling/schemas/unmarshallers.py\", line 91, in __call__\r\n    return self.unmarshal(value)\r\n  File \"/dev/openapi-core/openapi_core/unmarshalling/schemas/unmarshallers.py\", line 433, in unmarshal\r\n    unmarshaller = self._get_best_unmarshaller(value)\r\n  File \"/dev/openapi-core/openapi_core/unmarshalling/schemas/unmarshallers.py\", line 430, in _get_best_unmarshaller\r\n    raise UnmarshallerError(\"Unmarshaller not found for type(s)\")\r\nopenapi_core.unmarshalling.schemas.exceptions.UnmarshallerError: Unmarshaller not found for type(s)\r\n```\r\n\r\nIf I comment out `format`, things work as expected. I suspect it's attempting to apply a formatter for the null values. As far as I can tell, this should work though.","author":{"url":"https://github.com/stephenfin","@type":"Person","name":"stephenfin"},"datePublished":"2023-01-24T16:44:06.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":10},"url":"https://github.com/483/openapi-core/issues/483"}