René's URL Explorer Experiment


Title: Claim ownership of socket once we've passed it to libldap by mistotebe · Pull Request #544 · python-ldap/python-ldap · GitHub

Open Graph Title: Claim ownership of socket once we've passed it to libldap by mistotebe · Pull Request #544 · python-ldap/python-ldap

X Title: Claim ownership of socket once we've passed it to libldap by mistotebe · Pull Request #544 · python-ldap/python-ldap

Description: Per Python docs a socket object will close the underlying file descriptor on garbage collection and to use it elsewhere, one needs to call detach(). Fixes: #460 Closes: #543

Open Graph Description: Per Python docs a socket object will close the underlying file descriptor on garbage collection and to use it elsewhere, one needs to call detach(). Fixes: #460 Closes: #543

X Description: Per Python docs a socket object will close the underlying file descriptor on garbage collection and to use it elsewhere, one needs to call detach(). Fixes: #460 Closes: #543

Opengraph URL: https://github.com/python-ldap/python-ldap/pull/544

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:2b55f601-9ead-35bc-bcdd-a3a58c8b007b
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idABDE:25975D:1396272:1B0B016:69777545
html-safe-nonce9de1dbf746648cf103defe955ac409e11883d2367af380f6f62432eb9e0d0a8a
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBQkRFOjI1OTc1RDoxMzk2MjcyOjFCMEIwMTY6Njk3Nzc1NDUiLCJ2aXNpdG9yX2lkIjoiNDU2MzE4NDQ4NzgyNjQyMTA2MSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac1a58907b3ee48bb1bf8a746919a8d8f11c074838d24b494f9f444fef46bc6ef0
hovercard-subject-tagpull_request:1583076077
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python-ldap/python-ldap/544/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/e3416f02d6646111d422e07086dc14dd652de5da76eb79e296055d9979a02214/python-ldap/python-ldap/pull/544
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/e3416f02d6646111d422e07086dc14dd652de5da76eb79e296055d9979a02214/python-ldap/python-ldap/pull/544
og:image:altPer Python docs a socket object will close the underlying file descriptor on garbage collection and to use it elsewhere, one needs to call detach(). Fixes: #460 Closes: #543
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamemistotebe
hostnamegithub.com
expected-hostnamegithub.com
None9fea6af76c6e24ca5c5728a18d4220d768790d04abe1ba6aafa18526daff96e7
turbo-cache-controlno-preview
go-importgithub.com/python-ldap/python-ldap git https://github.com/python-ldap/python-ldap.git
octolytics-dimension-user_id33895877
octolytics-dimension-user_loginpython-ldap
octolytics-dimension-repository_id111794776
octolytics-dimension-repository_nwopython-ldap/python-ldap
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id111794776
octolytics-dimension-repository_network_root_nwopython-ldap/python-ldap
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release6c4a3fa336c0d96309887d0be819777cadd37121
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python-ldap/python-ldap/pull/544#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython-ldap%2Fpython-ldap%2Fpull%2F544
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython-ldap%2Fpython-ldap%2Fpull%2F544
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python-ldap%2Fpython-ldap
Reloadhttps://github.com/python-ldap/python-ldap/pull/544
Reloadhttps://github.com/python-ldap/python-ldap/pull/544
Reloadhttps://github.com/python-ldap/python-ldap/pull/544
python-ldap https://github.com/python-ldap
python-ldaphttps://github.com/python-ldap/python-ldap
Notifications https://github.com/login?return_to=%2Fpython-ldap%2Fpython-ldap
Fork 137 https://github.com/login?return_to=%2Fpython-ldap%2Fpython-ldap
Star 436 https://github.com/login?return_to=%2Fpython-ldap%2Fpython-ldap
Code https://github.com/python-ldap/python-ldap
Issues 83 https://github.com/python-ldap/python-ldap/issues
Pull requests 19 https://github.com/python-ldap/python-ldap/pulls
Actions https://github.com/python-ldap/python-ldap/actions
Projects 0 https://github.com/python-ldap/python-ldap/projects
Security 3 https://github.com/python-ldap/python-ldap/security
Insights https://github.com/python-ldap/python-ldap/pulse
Code https://github.com/python-ldap/python-ldap
Issues https://github.com/python-ldap/python-ldap/issues
Pull requests https://github.com/python-ldap/python-ldap/pulls
Actions https://github.com/python-ldap/python-ldap/actions
Projects https://github.com/python-ldap/python-ldap/projects
Security https://github.com/python-ldap/python-ldap/security
Insights https://github.com/python-ldap/python-ldap/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython-ldap%2Fpython-ldap%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython-ldap%2Fpython-ldap%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/python-ldap/python-ldap/pull/544#issue-comment-box
mistotebehttps://github.com/mistotebe
python-ldap:mainhttps://github.com/python-ldap/python-ldap/tree/main
mistotebe:socket-ownershiphttps://github.com/mistotebe/python-ldap/tree/socket-ownership
Claim ownership of socket once we've passed it to libldap https://github.com/python-ldap/python-ldap/pull/544#top
mistotebehttps://github.com/mistotebe
python-ldap:mainhttps://github.com/python-ldap/python-ldap/tree/main
mistotebe:socket-ownershiphttps://github.com/mistotebe/python-ldap/tree/socket-ownership
Conversation 2 https://github.com/python-ldap/python-ldap/pull/544
Commits 1 https://github.com/python-ldap/python-ldap/pull/544/commits
Checks 0 https://github.com/python-ldap/python-ldap/pull/544/checks
Files changed https://github.com/python-ldap/python-ldap/pull/544/files
Please reload this pagehttps://github.com/python-ldap/python-ldap/pull/544
https://github.co/hiddenchars
https://github.com/python-ldap/python-ldap/pull/{{ revealButtonHref }}
https://github.com/mistotebe
mistotebehttps://github.com/mistotebe
Nov 1, 2023https://github.com/python-ldap/python-ldap/pull/544#issue-1972836068
Python docshttps://docs.python.org/3/library/socket.html#socket.socket.detach
#460https://github.com/python-ldap/python-ldap/issues/460
#543https://github.com/python-ldap/python-ldap/pull/543
Please reload this pagehttps://github.com/python-ldap/python-ldap/pull/544
https://github.com/tiran
tiranhttps://github.com/tiran
Nov 2, 2023 https://github.com/python-ldap/python-ldap/pull/544#pullrequestreview-1709445515
View reviewed changes https://github.com/python-ldap/python-ldap/pull/544/files
Tests/t_ldapobject.pyhttps://github.com/python-ldap/python-ldap/pull/544/files#diff-8b11250d72c96c3395e369b65bfc47aebaa146fd4574ca90e7f74ea74fe3efb5
Please reload this pagehttps://github.com/python-ldap/python-ldap/pull/544
https://github.com/mistotebe
Claim ownership of socket once we've passed it to libldaphttps://github.com/python-ldap/python-ldap/pull/544/commits/d7b80dead9a17be68c24cfae79ddb04a404222fd
d7b80dehttps://github.com/python-ldap/python-ldap/pull/544/commits/d7b80dead9a17be68c24cfae79ddb04a404222fd
python-ldap#460https://github.com/python-ldap/python-ldap/issues/460
python-ldap#543https://github.com/python-ldap/python-ldap/pull/543
https://github.com/mistotebe
mistotebehttps://github.com/mistotebe
force-pushedhttps://github.com/python-ldap/python-ldap/compare/b51740eac819d202c1eefe95104b3168715d13ce..d7b80dead9a17be68c24cfae79ddb04a404222fd
b51740ehttps://github.com/python-ldap/python-ldap/commit/b51740eac819d202c1eefe95104b3168715d13ce
d7b80dehttps://github.com/python-ldap/python-ldap/commit/d7b80dead9a17be68c24cfae79ddb04a404222fd
Compare https://github.com/python-ldap/python-ldap/compare/b51740eac819d202c1eefe95104b3168715d13ce..d7b80dead9a17be68c24cfae79ddb04a404222fd
November 2, 2023 09:24https://github.com/python-ldap/python-ldap/pull/544#event-10841378830
https://github.com/tiran
tiranhttps://github.com/tiran
Nov 2, 2023 https://github.com/python-ldap/python-ldap/pull/544#pullrequestreview-1709832712
View reviewed changes https://github.com/python-ldap/python-ldap/pull/544/files/d7b80dead9a17be68c24cfae79ddb04a404222fd
tiranhttps://github.com/tiran
https://github.com/python-ldap/python-ldap/pull/544#pullrequestreview-1709832712
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python-ldap/python-ldap/pull/544
https://github.com/mistotebe
mistotebehttps://github.com/mistotebe
1490e99https://github.com/python-ldap/python-ldap/commit/1490e999e10960f0fdf974f6da804a2fc55e4b05
Nov 2, 2023https://github.com/python-ldap/python-ldap/pull/544#event-10841650963
https://github.com/ClydeByrdIII
ClydeByrdIIIhttps://github.com/ClydeByrdIII
Aug 30, 2024 https://github.com/python-ldap/python-ldap/pull/544#ref-issue-2498151925
ldap.initialize(fileno=fileno) does take ownership of the fileno #575 https://github.com/python-ldap/python-ldap/issues/575
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython-ldap%2Fpython-ldap%2Fpull%2F544
https://github.com/tiran
tiran https://github.com/tiran
https://github.com/python-ldap/python-ldap/pull/544/files/d7b80dead9a17be68c24cfae79ddb04a404222fd
Tests/t_ldapobject.py fails on pypy3 CI run https://github.com/python-ldap/python-ldap/issues/460
Please reload this pagehttps://github.com/python-ldap/python-ldap/pull/544
https://github.com/mistotebe
https://github.com/tiran
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.