| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:66510c3b-f539-d9e7-42e2-255dd4d1e719 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 8AF6:31363C:19494E7:206D956:6975C42B |
| html-safe-nonce | 5257f0b3a34ce02f9b03d1b043c08bdc3373c734db89997527aed720900c450d |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4QUY2OjMxMzYzQzoxOTQ5NEU3OjIwNkQ5NTY6Njk3NUM0MkIiLCJ2aXNpdG9yX2lkIjoiOTQ5MzE2MDM5MDg4NjUzMzU1IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 44a6f0ee098c2f5de9cbb8856347630d8ab04a3528036e1b8b5393f73b9c2562 |
| hovercard-subject-tag | pull_request:279864388 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python-ldap/python-ldap/288/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/418aa9ee2e2f86141f714306403923c2cf17d62b6a749751483fffc20da6c477/python-ldap/python-ldap/pull/288 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/418aa9ee2e2f86141f714306403923c2cf17d62b6a749751483fffc20da6c477/python-ldap/python-ldap/pull/288 |
| og:image:alt | Work to improve how we raise exceptions on result, deals with controls and msgid being missing (#177, #208).
Ready for merging (pending #282, #283, #284 have been accepted) apart from last commit w... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | mistotebe |
| hostname | github.com |
| expected-hostname | github.com |
| None | 4a4bf5f4e28041a9d2e5c107d7d20b78b4294ba261cab243b28167c16a623a1f |
| turbo-cache-control | no-preview |
| go-import | github.com/python-ldap/python-ldap git https://github.com/python-ldap/python-ldap.git |
| octolytics-dimension-user_id | 33895877 |
| octolytics-dimension-user_login | python-ldap |
| octolytics-dimension-repository_id | 111794776 |
| octolytics-dimension-repository_nwo | python-ldap/python-ldap |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 111794776 |
| octolytics-dimension-repository_network_root_nwo | python-ldap/python-ldap |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 488b30e96dfd057fbbe44c6665ccbc030b729dde |
| ui-target | canary-1 |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/python-ldap/python-ldap/pull/288#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython-ldap%2Fpython-ldap%2Fpull%2F288 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython-ldap%2Fpython-ldap%2Fpull%2F288 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python-ldap%2Fpython-ldap |
| Reload | https://github.com/python-ldap/python-ldap/pull/288 |
| Reload | https://github.com/python-ldap/python-ldap/pull/288 |
| Reload | https://github.com/python-ldap/python-ldap/pull/288 |
|
python-ldap
| https://github.com/python-ldap |
| python-ldap | https://github.com/python-ldap/python-ldap |
|
Notifications
| https://github.com/login?return_to=%2Fpython-ldap%2Fpython-ldap |
|
Fork
137
| https://github.com/login?return_to=%2Fpython-ldap%2Fpython-ldap |
|
Star
436
| https://github.com/login?return_to=%2Fpython-ldap%2Fpython-ldap |
|
Code
| https://github.com/python-ldap/python-ldap |
|
Issues
83
| https://github.com/python-ldap/python-ldap/issues |
|
Pull requests
19
| https://github.com/python-ldap/python-ldap/pulls |
|
Actions
| https://github.com/python-ldap/python-ldap/actions |
|
Projects
0
| https://github.com/python-ldap/python-ldap/projects |
|
Security
3
| https://github.com/python-ldap/python-ldap/security |
|
Insights
| https://github.com/python-ldap/python-ldap/pulse |
|
Code
| https://github.com/python-ldap/python-ldap |
|
Issues
| https://github.com/python-ldap/python-ldap/issues |
|
Pull requests
| https://github.com/python-ldap/python-ldap/pulls |
|
Actions
| https://github.com/python-ldap/python-ldap/actions |
|
Projects
| https://github.com/python-ldap/python-ldap/projects |
|
Security
| https://github.com/python-ldap/python-ldap/security |
|
Insights
| https://github.com/python-ldap/python-ldap/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fpython-ldap%2Fpython-ldap%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fpython-ldap%2Fpython-ldap%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/python-ldap/python-ldap/pull/288#issue-comment-box |
| encukou | https://github.com/encukou |
| python-ldap:master | https://github.com/python-ldap/python-ldap/tree/master |
| mistotebe:exceptions | https://github.com/mistotebe/python-ldap/tree/exceptions |
|
Additional exception fields
| https://github.com/python-ldap/python-ldap/pull/288#top |
| encukou | https://github.com/encukou |
| python-ldap:master | https://github.com/python-ldap/python-ldap/tree/master |
| mistotebe:exceptions | https://github.com/mistotebe/python-ldap/tree/exceptions |
|
Conversation
21
| https://github.com/python-ldap/python-ldap/pull/288 |
|
Commits
7
| https://github.com/python-ldap/python-ldap/pull/288/commits |
|
Checks
0
| https://github.com/python-ldap/python-ldap/pull/288/checks |
|
Files changed
| https://github.com/python-ldap/python-ldap/pull/288/files |
| Please reload this page | https://github.com/python-ldap/python-ldap/pull/288 |
| https://github.co/hiddenchars |
| https://github.com/python-ldap/python-ldap/pull/{{ revealButtonHref }} |
|
| https://github.com/mistotebe |
| mistotebe | https://github.com/mistotebe |
| May 17, 2019 | https://github.com/python-ldap/python-ldap/pull/288#issue-445407769 |
| #177 | https://github.com/python-ldap/python-ldap/issues/177 |
| #208 | https://github.com/python-ldap/python-ldap/issues/208 |
| #282 | https://github.com/python-ldap/python-ldap/pull/282 |
| #283 | https://github.com/python-ldap/python-ldap/pull/283 |
| #284 | https://github.com/python-ldap/python-ldap/pull/284 |
| Please reload this page | https://github.com/python-ldap/python-ldap/pull/288 |
| https://github.com/somay |
| somay | https://github.com/somay |
| May 26, 2019 | https://github.com/python-ldap/python-ldap/pull/288#issuecomment-495977533 |
| #208 | https://github.com/python-ldap/python-ldap/issues/208 |
| Please reload this page | https://github.com/python-ldap/python-ldap/pull/288 |
| https://github.com/mistotebe |
| mistotebe | https://github.com/mistotebe |
| Jun 5, 2019 | https://github.com/python-ldap/python-ldap/pull/288#issuecomment-499114266 |
| @tiran | https://github.com/tiran |
| @encukou | https://github.com/encukou |
| Please reload this page | https://github.com/python-ldap/python-ldap/pull/288 |
| https://github.com/encukou |
| encukou | https://github.com/encukou |
| Jan 29, 2020 | https://github.com/python-ldap/python-ldap/pull/288#issuecomment-579793476 |
| @tiran | https://github.com/tiran |
| Please reload this page | https://github.com/python-ldap/python-ldap/pull/288 |
| https://github.com/mistotebe |
| mistotebe | https://github.com/mistotebe |
| April 9, 2020 08:18 | https://github.com/python-ldap/python-ldap/pull/288#event-3217265839 |
| https://github.com/mistotebe |
| mistotebe | https://github.com/mistotebe |
| Apr 14, 2020 | https://github.com/python-ldap/python-ldap/pull/288#issuecomment-613348907 |
| Please reload this page | https://github.com/python-ldap/python-ldap/pull/288 |
| https://github.com/encukou |
| encukou | https://github.com/encukou |
| Apr 29, 2020 | https://github.com/python-ldap/python-ldap/pull/288#issuecomment-621529237 |
| Please reload this page | https://github.com/python-ldap/python-ldap/pull/288 |
| https://github.com/mistotebe |
| mistotebe | https://github.com/mistotebe |
| Apr 30, 2020 | https://github.com/python-ldap/python-ldap/pull/288#issuecomment-621668946 |
| Please reload this page | https://github.com/python-ldap/python-ldap/pull/288 |
| https://github.com/mistotebe |
| mistotebe | https://github.com/mistotebe |
| force-pushed | https://github.com/python-ldap/python-ldap/compare/82f050b8513b35c5d291f199154bff6ec1bd8885..8492b16801a01ad45d911845f019b17e2ed8f12e |
| 82f050b | https://github.com/python-ldap/python-ldap/commit/82f050b8513b35c5d291f199154bff6ec1bd8885 |
| 8492b16 | https://github.com/python-ldap/python-ldap/commit/8492b16801a01ad45d911845f019b17e2ed8f12e |
|
Compare
| https://github.com/python-ldap/python-ldap/compare/82f050b8513b35c5d291f199154bff6ec1bd8885..8492b16801a01ad45d911845f019b17e2ed8f12e |
| April 30, 2020 11:34 | https://github.com/python-ldap/python-ldap/pull/288#event-3288872601 |
| https://github.com/mistotebe |
| mistotebe | https://github.com/mistotebe |
| Apr 30, 2020 | https://github.com/python-ldap/python-ldap/pull/288#issuecomment-621779308 |
| Please reload this page | https://github.com/python-ldap/python-ldap/pull/288 |
| https://github.com/encukou |
| encukou | https://github.com/encukou |
| May 6, 2020 | https://github.com/python-ldap/python-ldap/pull/288#issuecomment-624679702 |
| Use PyStructSequence for result() return value #61 | https://github.com/python-ldap/python-ldap/issues/61 |
| Please reload this page | https://github.com/python-ldap/python-ldap/pull/288 |
| https://github.com/encukou |
| encukou | https://github.com/encukou |
|
May 6, 2020
| https://github.com/python-ldap/python-ldap/pull/288#pullrequestreview-406651997 |
|
View reviewed changes
| https://github.com/python-ldap/python-ldap/pull/288/files |
| Modules/constants.c | https://github.com/python-ldap/python-ldap/pull/288/files#diff-676c71dd15cf5089dacb1555221c30e43c8dbb36fbdaeb03a0fc52e2cfbe73d1 |
| Please reload this page | https://github.com/python-ldap/python-ldap/pull/288 |
| Modules/LDAPObject.c | https://github.com/python-ldap/python-ldap/pull/288/files#diff-0b78ed8976050fd2ce9edfeed45bbcfb4087b5f970b1699f5f8fe4706bd097f3 |
| Please reload this page | https://github.com/python-ldap/python-ldap/pull/288 |
| Modules/constants.c | https://github.com/python-ldap/python-ldap/pull/288/files#diff-676c71dd15cf5089dacb1555221c30e43c8dbb36fbdaeb03a0fc52e2cfbe73d1 |
| Please reload this page | https://github.com/python-ldap/python-ldap/pull/288 |
| Modules/LDAPObject.c | https://github.com/python-ldap/python-ldap/pull/288/files#diff-0b78ed8976050fd2ce9edfeed45bbcfb4087b5f970b1699f5f8fe4706bd097f3 |
| Please reload this page | https://github.com/python-ldap/python-ldap/pull/288 |
| mistotebe | https://github.com/mistotebe |
| May 7, 2020 14:55 | https://github.com/python-ldap/python-ldap/pull/288#commits-pushed-7d92e0f |
|
| https://github.com/mistotebe |
| Pass message type as is | https://github.com/python-ldap/python-ldap/pull/288/commits/7d92e0fb76e9d5da63638ecde2c615f8d0084f75 |
| 7d92e0f | https://github.com/python-ldap/python-ldap/pull/288/commits/7d92e0fb76e9d5da63638ecde2c615f8d0084f75 |
|
| https://github.com/mistotebe |
| Attach msgid/controls/... to exceptions ( | https://github.com/python-ldap/python-ldap/pull/288/commits/f754e35dcbc65bea6c879e6a68de3e5889a43460 |
| Closes | https://github.com/python-ldap/python-ldap/pull/288/commits/f754e35dcbc65bea6c879e6a68de3e5889a43460 |
| python-ldap#177 | https://github.com/python-ldap/python-ldap/issues/177 |
| , | https://github.com/python-ldap/python-ldap/pull/288/commits/f754e35dcbc65bea6c879e6a68de3e5889a43460 |
| pyth… | https://github.com/python-ldap/python-ldap/issues/208 |
| f754e35 | https://github.com/python-ldap/python-ldap/pull/288/commits/f754e35dcbc65bea6c879e6a68de3e5889a43460 |
| …on-ldap#208 | https://github.com/python-ldap/python-ldap/issues/208 |
| python-ldap#177 | https://github.com/python-ldap/python-ldap/issues/177 |
| python-ldap#208 | https://github.com/python-ldap/python-ldap/issues/208 |
|
| https://github.com/mistotebe |
| Sample test for previous commit | https://github.com/python-ldap/python-ldap/pull/288/commits/07f44122f1f4b4e2b1550a6dc6e13d0d14e664ee |
| 07f4412 | https://github.com/python-ldap/python-ldap/pull/288/commits/07f44122f1f4b4e2b1550a6dc6e13d0d14e664ee |
|
| https://github.com/mistotebe |
| refs is now unused | https://github.com/python-ldap/python-ldap/pull/288/commits/972490c9cb916f7954c372a718e0050943d5dffe |
| 972490c | https://github.com/python-ldap/python-ldap/pull/288/commits/972490c9cb916f7954c372a718e0050943d5dffe |
|
| https://github.com/mistotebe |
| Add .errnum to LDAPExceptions | https://github.com/python-ldap/python-ldap/pull/288/commits/785729194f133fd7947c2366a941363a57380429 |
| 7857291 | https://github.com/python-ldap/python-ldap/pull/288/commits/785729194f133fd7947c2366a941363a57380429 |
| https://github.com/mistotebe |
| mistotebe | https://github.com/mistotebe |
| force-pushed | https://github.com/python-ldap/python-ldap/compare/8492b16801a01ad45d911845f019b17e2ed8f12e..785729194f133fd7947c2366a941363a57380429 |
| 8492b16 | https://github.com/python-ldap/python-ldap/commit/8492b16801a01ad45d911845f019b17e2ed8f12e |
| 7857291 | https://github.com/python-ldap/python-ldap/commit/785729194f133fd7947c2366a941363a57380429 |
|
Compare
| https://github.com/python-ldap/python-ldap/compare/8492b16801a01ad45d911845f019b17e2ed8f12e..785729194f133fd7947c2366a941363a57380429 |
| May 7, 2020 13:57 | https://github.com/python-ldap/python-ldap/pull/288#event-3313023443 |
| https://github.com/mistotebe |
| mistotebe | https://github.com/mistotebe |
| May 7, 2020 | https://github.com/python-ldap/python-ldap/pull/288#issuecomment-625272938 |
| Please reload this page | https://github.com/python-ldap/python-ldap/pull/288 |
| mistotebe | https://github.com/mistotebe |
| May 18, 2020 13:44 | https://github.com/python-ldap/python-ldap/pull/288#commits-pushed-18a261e |
|
| https://github.com/mistotebe |
| Drop unused/unusable argument | https://github.com/python-ldap/python-ldap/pull/288/commits/18a261effe2498f49560a35b2adbee438c2ebcb8 |
| 18a261e | https://github.com/python-ldap/python-ldap/pull/288/commits/18a261effe2498f49560a35b2adbee438c2ebcb8 |
|
| https://github.com/mistotebe |
| Fix error in test failure reporting | https://github.com/python-ldap/python-ldap/pull/288/commits/5f083fe45c4d0f12f86adadc904a514c95a676de |
| 5f083fe | https://github.com/python-ldap/python-ldap/pull/288/commits/5f083fe45c4d0f12f86adadc904a514c95a676de |
| https://github.com/encukou |
| encukou | https://github.com/encukou |
|
Jun 5, 2020
| https://github.com/python-ldap/python-ldap/pull/288#pullrequestreview-425329470 |
|
View reviewed changes
| https://github.com/python-ldap/python-ldap/pull/288/files/5f083fe45c4d0f12f86adadc904a514c95a676de |
| encukou | https://github.com/encukou |
| https://github.com/python-ldap/python-ldap/pull/288#pullrequestreview-425329470 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python-ldap/python-ldap/pull/288 |
| https://github.com/encukou |
| encukou | https://github.com/encukou |
| 3c0f7ef | https://github.com/python-ldap/python-ldap/commit/3c0f7ef92ba16918823978c9470cd826a3f0dfa3 |
| Jun 5, 2020 | https://github.com/python-ldap/python-ldap/pull/288#event-3411455160 |
|
Store message id for exceptions raised from result4()
#262
| https://github.com/python-ldap/python-ldap/pull/262 |
|
Attach response controls to exceptions
#251
| https://github.com/python-ldap/python-ldap/pull/251 |
| https://github.com/tiran |
| tiran | https://github.com/tiran |
| 3.3 | https://github.com/python-ldap/python-ldap/milestone/3 |
| Jun 5, 2020 | https://github.com/python-ldap/python-ldap/pull/288#event-3412935163 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython-ldap%2Fpython-ldap%2Fpull%2F288 |
|
| https://github.com/encukou |
|
encukou
| https://github.com/encukou |
|
| https://github.com/python-ldap/python-ldap/pull/288/files/5f083fe45c4d0f12f86adadc904a514c95a676de |
|
3.3
| https://github.com/python-ldap/python-ldap/milestone/3 |
| Please reload this page | https://github.com/python-ldap/python-ldap/pull/288 |
|
| https://github.com/mistotebe |
|
| https://github.com/somay |
|
| https://github.com/encukou |
|
| https://github.com/tiran |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |