René's URL Explorer Experiment


Title: Do not leak serverctrls by mistotebe · Pull Request #284 · python-ldap/python-ldap · GitHub

Open Graph Title: Do not leak serverctrls by mistotebe · Pull Request #284 · python-ldap/python-ldap

X Title: Do not leak serverctrls by mistotebe · Pull Request #284 · python-ldap/python-ldap

Description: There are two code paths in l_ldap_result4 that allow serverctrls to be leaked. This plugs them.

Open Graph Description: There are two code paths in l_ldap_result4 that allow serverctrls to be leaked. This plugs them.

X Description: There are two code paths in l_ldap_result4 that allow serverctrls to be leaked. This plugs them.

Opengraph URL: https://github.com/python-ldap/python-ldap/pull/284

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:f2d989a4-6fac-ffc0-fecf-1a92d7c43816
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8430:1DFAA9:A857CC1:DA12F2D:69766E32
html-safe-nonce2ad2b51e40a062b83c67a31e955dd84c67affd9a3065b790ad7cd22934ba047f
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4NDMwOjFERkFBOTpBODU3Q0MxOkRBMTJGMkQ6Njk3NjZFMzIiLCJ2aXNpdG9yX2lkIjoiMjYyNDI3MzgxOTA0Mzc4NjI5MCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac1d9911f32f8fb5eb41d94cf6b25954b67109fdf1b3a4beea1fc55685436a6629
hovercard-subject-tagpull_request:275421357
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python-ldap/python-ldap/284/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/ff2ebbb41695cfc14d9ee1094983044ff0f2d1631bd8d542e2030b7f6f10b70c/python-ldap/python-ldap/pull/284
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/ff2ebbb41695cfc14d9ee1094983044ff0f2d1631bd8d542e2030b7f6f10b70c/python-ldap/python-ldap/pull/284
og:image:altThere are two code paths in l_ldap_result4 that allow serverctrls to be leaked. This plugs them.
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamemistotebe
hostnamegithub.com
expected-hostnamegithub.com
None032152924a283b83384255d9489e7b93b54ba01da8d380b05ecd3953b3212411
turbo-cache-controlno-preview
go-importgithub.com/python-ldap/python-ldap git https://github.com/python-ldap/python-ldap.git
octolytics-dimension-user_id33895877
octolytics-dimension-user_loginpython-ldap
octolytics-dimension-repository_id111794776
octolytics-dimension-repository_nwopython-ldap/python-ldap
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id111794776
octolytics-dimension-repository_network_root_nwopython-ldap/python-ldap
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release5b577f6be6482e336e3c30e8daefa30144947b17
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python-ldap/python-ldap/pull/284#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython-ldap%2Fpython-ldap%2Fpull%2F284
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython-ldap%2Fpython-ldap%2Fpull%2F284
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python-ldap%2Fpython-ldap
Reloadhttps://github.com/python-ldap/python-ldap/pull/284
Reloadhttps://github.com/python-ldap/python-ldap/pull/284
Reloadhttps://github.com/python-ldap/python-ldap/pull/284
python-ldap https://github.com/python-ldap
python-ldaphttps://github.com/python-ldap/python-ldap
Notifications https://github.com/login?return_to=%2Fpython-ldap%2Fpython-ldap
Fork 137 https://github.com/login?return_to=%2Fpython-ldap%2Fpython-ldap
Star 436 https://github.com/login?return_to=%2Fpython-ldap%2Fpython-ldap
Code https://github.com/python-ldap/python-ldap
Issues 83 https://github.com/python-ldap/python-ldap/issues
Pull requests 19 https://github.com/python-ldap/python-ldap/pulls
Actions https://github.com/python-ldap/python-ldap/actions
Projects 0 https://github.com/python-ldap/python-ldap/projects
Security 3 https://github.com/python-ldap/python-ldap/security
Insights https://github.com/python-ldap/python-ldap/pulse
Code https://github.com/python-ldap/python-ldap
Issues https://github.com/python-ldap/python-ldap/issues
Pull requests https://github.com/python-ldap/python-ldap/pulls
Actions https://github.com/python-ldap/python-ldap/actions
Projects https://github.com/python-ldap/python-ldap/projects
Security https://github.com/python-ldap/python-ldap/security
Insights https://github.com/python-ldap/python-ldap/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython-ldap%2Fpython-ldap%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython-ldap%2Fpython-ldap%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/python-ldap/python-ldap/pull/284#issue-comment-box
encukouhttps://github.com/encukou
python-ldap:masterhttps://github.com/python-ldap/python-ldap/tree/master
mistotebe:serverctrls_leakhttps://github.com/mistotebe/python-ldap/tree/serverctrls_leak
Do not leak serverctrls https://github.com/python-ldap/python-ldap/pull/284#top
encukouhttps://github.com/encukou
python-ldap:masterhttps://github.com/python-ldap/python-ldap/tree/master
mistotebe:serverctrls_leakhttps://github.com/mistotebe/python-ldap/tree/serverctrls_leak
Conversation 1 https://github.com/python-ldap/python-ldap/pull/284
Commits 1 https://github.com/python-ldap/python-ldap/pull/284/commits
Checks 0 https://github.com/python-ldap/python-ldap/pull/284/checks
Files changed https://github.com/python-ldap/python-ldap/pull/284/files
Please reload this pagehttps://github.com/python-ldap/python-ldap/pull/284
https://github.co/hiddenchars
https://github.com/python-ldap/python-ldap/pull/{{ revealButtonHref }}
https://github.com/mistotebe
mistotebehttps://github.com/mistotebe
May 2, 2019https://github.com/python-ldap/python-ldap/pull/284#issue-439664195
Please reload this pagehttps://github.com/python-ldap/python-ldap/pull/284
https://github.com/mistotebe
Do not leak serverctrlshttps://github.com/python-ldap/python-ldap/pull/284/commits/1986511dda84edbc37ae54dc65054b72797fd601
1986511https://github.com/python-ldap/python-ldap/pull/284/commits/1986511dda84edbc37ae54dc65054b72797fd601
https://github.com/apps/codecov
codecovhttps://github.com/apps/codecov
May 2, 2019https://github.com/python-ldap/python-ldap/pull/284#issuecomment-488731456
Please reload this pagehttps://github.com/python-ldap/python-ldap/pull/284
Codecovhttps://codecov.io/gh/python-ldap/python-ldap/pull/284?src=pr&el=h1
#284https://codecov.io/gh/python-ldap/python-ldap/pull/284?src=pr&el=desc
masterhttps://codecov.io/gh/python-ldap/python-ldap/commit/adf9dc402380572b1d3b5bc6fa1d353bbed35074?src=pr&el=desc
Impacted Fileshttps://codecov.io/gh/python-ldap/python-ldap/pull/284?src=pr&el=tree
Modules/LDAPObject.chttps://codecov.io/gh/python-ldap/python-ldap/pull/284/diff?src=pr&el=tree#diff-TW9kdWxlcy9MREFQT2JqZWN0LmM=
Lib/ldap/controls/deref.pyhttps://codecov.io/gh/python-ldap/python-ldap/pull/284/diff?src=pr&el=tree#diff-TGliL2xkYXAvY29udHJvbHMvZGVyZWYucHk=
Continue to review full report at Codecovhttps://codecov.io/gh/python-ldap/python-ldap/pull/284?src=pr&el=continue
Click here to learn morehttps://docs.codecov.io/docs/codecov-delta
Codecovhttps://codecov.io/gh/python-ldap/python-ldap/pull/284?src=pr&el=footer
adf9dc4...1986511https://codecov.io/gh/python-ldap/python-ldap/pull/284?src=pr&el=lastupdated
comment docshttps://docs.codecov.io/docs/pull-request-comments
Please reload this pagehttps://github.com/python-ldap/python-ldap/pull/284
https://github.com/mistotebe
mistotebehttps://github.com/mistotebe
May 17, 2019 https://github.com/python-ldap/python-ldap/pull/284#ref-pullrequest-445407769
Additional exception fields #288 https://github.com/python-ldap/python-ldap/pull/288
https://github.com/encukou
encukouhttps://github.com/encukou
Sep 20, 2019 https://github.com/python-ldap/python-ldap/pull/284#pullrequestreview-291171384
View reviewed changes https://github.com/python-ldap/python-ldap/pull/284/files/1986511dda84edbc37ae54dc65054b72797fd601
https://github.com/encukou
encukouhttps://github.com/encukou
da432d7https://github.com/python-ldap/python-ldap/commit/da432d727138c315846fec5f271f065d7b4bc15e
Sep 20, 2019https://github.com/python-ldap/python-ldap/pull/284#event-2650370611
https://github.com/tiran
tiranhttps://github.com/tiran
3.3https://github.com/python-ldap/python-ldap/milestone/3
May 27, 2020https://github.com/python-ldap/python-ldap/pull/284#event-3379782179
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython-ldap%2Fpython-ldap%2Fpull%2F284
https://github.com/encukou
encukou https://github.com/encukou
https://github.com/python-ldap/python-ldap/pull/284/files/1986511dda84edbc37ae54dc65054b72797fd601
3.3 https://github.com/python-ldap/python-ldap/milestone/3
Please reload this pagehttps://github.com/python-ldap/python-ldap/pull/284
https://github.com/mistotebe
https://github.com/encukou
https://github.com/tiran
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.