| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:f6daac64-05ea-d93c-a740-5aeec7e961da |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | C2E6:DEB58:CCC3F0:11C72D1:698237E0 |
| html-safe-nonce | e924a56778dec82a69211ae1876b6fd6e32d998c4c156428b5233bc7bb188b1e |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDMkU2OkRFQjU4OkNDQzNGMDoxMUM3MkQxOjY5ODIzN0UwIiwidmlzaXRvcl9pZCI6IjU1Mzg1ODk3ODMwNDYzNjg5NyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | deec14220aa65a746b226833567834edf1ab27ad0110a51bae9882655b04ae87 |
| hovercard-subject-tag | pull_request:1620367860 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python-kasa/python-kasa/556/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/d523849de2aee2fa646ea9e0d382a0db131ab74f6940afe6e60fac1546ea2886/python-kasa/python-kasa/pull/556 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/d523849de2aee2fa646ea9e0d382a0db131ab74f6940afe6e60fac1546ea2886/python-kasa/python-kasa/pull/556 |
| og:image:alt | Updated dump_devinfo to capture the 20002 discovery result if present and save it in the fixtures file. This will be used for testing, for example to ensure that the correct fake protocol is used ... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | sdb9696 |
| hostname | github.com |
| expected-hostname | github.com |
| None | 9135c12c87e8ba63197821abe054b7c0a2842a97636ee220df564bb0788e556d |
| turbo-cache-control | no-preview |
| go-import | github.com/python-kasa/python-kasa git https://github.com/python-kasa/python-kasa.git |
| octolytics-dimension-user_id | 57733869 |
| octolytics-dimension-user_login | python-kasa |
| octolytics-dimension-repository_id | 221571611 |
| octolytics-dimension-repository_nwo | python-kasa/python-kasa |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 221571611 |
| octolytics-dimension-repository_network_root_nwo | python-kasa/python-kasa |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 6b281db2f76bdbf4b45c30b597223c551b06e6e0 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/python-kasa/python-kasa/pull/556#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython-kasa%2Fpython-kasa%2Fpull%2F556 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython-kasa%2Fpython-kasa%2Fpull%2F556 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python-kasa%2Fpython-kasa |
| Reload | https://github.com/python-kasa/python-kasa/pull/556 |
| Reload | https://github.com/python-kasa/python-kasa/pull/556 |
| Reload | https://github.com/python-kasa/python-kasa/pull/556 |
|
python-kasa
| https://github.com/python-kasa |
| python-kasa | https://github.com/python-kasa/python-kasa |
| Please reload this page | https://github.com/python-kasa/python-kasa/pull/556 |
|
Notifications
| https://github.com/login?return_to=%2Fpython-kasa%2Fpython-kasa |
|
Fork
246
| https://github.com/login?return_to=%2Fpython-kasa%2Fpython-kasa |
|
Star
1.6k
| https://github.com/login?return_to=%2Fpython-kasa%2Fpython-kasa |
|
Code
| https://github.com/python-kasa/python-kasa |
|
Issues
51
| https://github.com/python-kasa/python-kasa/issues |
|
Pull requests
36
| https://github.com/python-kasa/python-kasa/pulls |
|
Discussions
| https://github.com/python-kasa/python-kasa/discussions |
|
Actions
| https://github.com/python-kasa/python-kasa/actions |
|
Projects
0
| https://github.com/python-kasa/python-kasa/projects |
|
Security
0
| https://github.com/python-kasa/python-kasa/security |
|
Insights
| https://github.com/python-kasa/python-kasa/pulse |
|
Code
| https://github.com/python-kasa/python-kasa |
|
Issues
| https://github.com/python-kasa/python-kasa/issues |
|
Pull requests
| https://github.com/python-kasa/python-kasa/pulls |
|
Discussions
| https://github.com/python-kasa/python-kasa/discussions |
|
Actions
| https://github.com/python-kasa/python-kasa/actions |
|
Projects
| https://github.com/python-kasa/python-kasa/projects |
|
Security
| https://github.com/python-kasa/python-kasa/security |
|
Insights
| https://github.com/python-kasa/python-kasa/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fpython-kasa%2Fpython-kasa%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fpython-kasa%2Fpython-kasa%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/python-kasa/python-kasa/pull/556#issue-comment-box |
| rytilahti | https://github.com/rytilahti |
| python-kasa:master | https://github.com/python-kasa/python-kasa/tree/master |
| sdb9696:update_dump_devinfo | https://github.com/sdb9696/python-kasa/tree/update_dump_devinfo |
|
Update dump_devinfo to include 20002 discovery results
| https://github.com/python-kasa/python-kasa/pull/556#top |
| rytilahti | https://github.com/rytilahti |
| python-kasa:master | https://github.com/python-kasa/python-kasa/tree/master |
| sdb9696:update_dump_devinfo | https://github.com/sdb9696/python-kasa/tree/update_dump_devinfo |
|
Conversation
24
| https://github.com/python-kasa/python-kasa/pull/556 |
|
Commits
3
| https://github.com/python-kasa/python-kasa/pull/556/commits |
|
Checks
0
| https://github.com/python-kasa/python-kasa/pull/556/checks |
|
Files changed
| https://github.com/python-kasa/python-kasa/pull/556/files |
| Please reload this page | https://github.com/python-kasa/python-kasa/pull/556 |
| https://github.co/hiddenchars |
| https://github.com/python-kasa/python-kasa/pull/{{ revealButtonHref }} |
|
| https://github.com/sdb9696 |
| sdb9696 | https://github.com/sdb9696 |
| Nov 28, 2023 | https://github.com/python-kasa/python-kasa/pull/556#issue-2014944011 |
| Please reload this page | https://github.com/python-kasa/python-kasa/pull/556 |
| https://github.com/apps/codecov |
| codecov | https://github.com/apps/codecov |
| Nov 28, 2023 | https://github.com/python-kasa/python-kasa/pull/556#issuecomment-1830354631 |
| Please reload this page | https://github.com/python-kasa/python-kasa/pull/556 |
| Codecov | https://app.codecov.io/gh/python-kasa/python-kasa/pull/556?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=python-kasa |
| (9728866) | https://app.codecov.io/gh/python-kasa/python-kasa/commit/9728866afb5539e5d5e6b5371d012ad50658eaa7?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=python-kasa |
| (8981bf5) | https://app.codecov.io/gh/python-kasa/python-kasa/pull/556?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=python-kasa |
| ☔ View full report in Codecov by Sentry | https://app.codecov.io/gh/python-kasa/python-kasa/pull/556?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=python-kasa |
| Share it here | https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=python-kasa |
| Please reload this page | https://github.com/python-kasa/python-kasa/pull/556 |
| https://github.com/sdb9696 |
| sdb9696 | https://github.com/sdb9696 |
| force-pushed | https://github.com/python-kasa/python-kasa/compare/63c0dbab1b43892dfac8f81487a4971dbe9d89ab..a077f1981e782a8af67f73a7eb96cac1680a9511 |
| 63c0dba | https://github.com/python-kasa/python-kasa/commit/63c0dbab1b43892dfac8f81487a4971dbe9d89ab |
| a077f19 | https://github.com/python-kasa/python-kasa/commit/a077f1981e782a8af67f73a7eb96cac1680a9511 |
|
Compare
| https://github.com/python-kasa/python-kasa/compare/63c0dbab1b43892dfac8f81487a4971dbe9d89ab..a077f1981e782a8af67f73a7eb96cac1680a9511 |
| November 28, 2023 18:04 | https://github.com/python-kasa/python-kasa/pull/556#event-11087034176 |
| https://github.com/rytilahti |
| rytilahti | https://github.com/rytilahti |
|
Nov 28, 2023
| https://github.com/python-kasa/python-kasa/pull/556#pullrequestreview-1753967902 |
|
View reviewed changes
| https://github.com/python-kasa/python-kasa/pull/556/files |
| rytilahti | https://github.com/rytilahti |
| https://github.com/python-kasa/python-kasa/pull/556#pullrequestreview-1753967902 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python-kasa/python-kasa/pull/556 |
| devtools/dump_devinfo.py | https://github.com/python-kasa/python-kasa/pull/556/files#diff-942f6b87f2ce42051a8565e3d27362e8cc929b749d886d8ffb69686018ab7446 |
| Please reload this page | https://github.com/python-kasa/python-kasa/pull/556 |
| kasa/discover.py | https://github.com/python-kasa/python-kasa/pull/556/files#diff-5e81b58a19fa4037d13d8a879cd13f4619ee94c91e8c2e889a7991c552e06afb |
| Please reload this page | https://github.com/python-kasa/python-kasa/pull/556 |
| kasa/smartdevice.py | https://github.com/python-kasa/python-kasa/pull/556/files#diff-f5ec66bf90b284e06109dccc7d4ac1c66a54e02edc96f10c2761bea15713e309 |
| Please reload this page | https://github.com/python-kasa/python-kasa/pull/556 |
| kasa/tests/fixtures/HS100(UK)_4.1_1.1.0.json | https://github.com/python-kasa/python-kasa/pull/556/files#diff-c5e6f97f94a0dd4ddbb392deae3ecb69c20badbea7e95b7c0f678535e58093a6 |
| Please reload this page | https://github.com/python-kasa/python-kasa/pull/556 |
| https://github.com/rytilahti |
| rytilahti | https://github.com/rytilahti |
|
Nov 29, 2023
| https://github.com/python-kasa/python-kasa/pull/556#pullrequestreview-1755590172 |
|
View reviewed changes
| https://github.com/python-kasa/python-kasa/pull/556/files |
| devtools/dump_devinfo.py | https://github.com/python-kasa/python-kasa/pull/556/files#diff-942f6b87f2ce42051a8565e3d27362e8cc929b749d886d8ffb69686018ab7446 |
| rytilahti | https://github.com/rytilahti |
| Nov 29, 2023 | https://github.com/python-kasa/python-kasa/pull/556#discussion_r1409481376 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| https://github.com/home-assistant/core/blob/b36ddaa15c5975fbae36e2b4eef9721ef45f1a35/homeassistant/components/tplink/diagnostics.py#L14 | https://github.com/home-assistant/core/blob/b36ddaa15c5975fbae36e2b4eef9721ef45f1a35/homeassistant/components/tplink/diagnostics.py#L14 |
| Please reload this page | https://github.com/python-kasa/python-kasa/pull/556 |
| https://github.com/rytilahti |
| rytilahti | https://github.com/rytilahti |
|
Nov 29, 2023
| https://github.com/python-kasa/python-kasa/pull/556#pullrequestreview-1755602148 |
|
View reviewed changes
| https://github.com/python-kasa/python-kasa/pull/556/files/ff7647174ff816e24472f8c06ac28780f78738b4 |
| rytilahti | https://github.com/rytilahti |
| https://github.com/python-kasa/python-kasa/pull/556#pullrequestreview-1755602148 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python-kasa/python-kasa/pull/556 |
| kasa/discover.py | https://github.com/python-kasa/python-kasa/pull/556/files#diff-5e81b58a19fa4037d13d8a879cd13f4619ee94c91e8c2e889a7991c552e06afb |
| Please reload this page | https://github.com/python-kasa/python-kasa/pull/556 |
| sdb9696 | https://github.com/sdb9696 |
| November 29, 2023 16:26 | https://github.com/python-kasa/python-kasa/pull/556#commits-pushed-e41ef83 |
|
| https://github.com/sdb9696 |
| Fix dump_devinfo and add discovery_result to json | https://github.com/python-kasa/python-kasa/pull/556/commits/e41ef83b08609e927f4ebc090602eecb6d86b7b4 |
| e41ef83 | https://github.com/python-kasa/python-kasa/pull/556/commits/e41ef83b08609e927f4ebc090602eecb6d86b7b4 |
|
| https://github.com/sdb9696 |
| Update following review. Do not serialize aliases. | https://github.com/python-kasa/python-kasa/pull/556/commits/ff7647174ff816e24472f8c06ac28780f78738b4 |
| ff76471 | https://github.com/python-kasa/python-kasa/pull/556/commits/ff7647174ff816e24472f8c06ac28780f78738b4 |
| https://github.com/sdb9696 |
| sdb9696 | https://github.com/sdb9696 |
| force-pushed | https://github.com/python-kasa/python-kasa/compare/b54dba664d574feaa1a5e96b42c66b92f772116f..ff7647174ff816e24472f8c06ac28780f78738b4 |
| b54dba6 | https://github.com/python-kasa/python-kasa/commit/b54dba664d574feaa1a5e96b42c66b92f772116f |
| ff76471 | https://github.com/python-kasa/python-kasa/commit/ff7647174ff816e24472f8c06ac28780f78738b4 |
|
Compare
| https://github.com/python-kasa/python-kasa/compare/b54dba664d574feaa1a5e96b42c66b92f772116f..ff7647174ff816e24472f8c06ac28780f78738b4 |
| November 29, 2023 16:27 | https://github.com/python-kasa/python-kasa/pull/556#event-11098764656 |
| https://github.com/sdb9696 |
| sdb9696 | https://github.com/sdb9696 |
| Nov 29, 2023 | https://github.com/python-kasa/python-kasa/pull/556#issuecomment-1832324346 |
| Please reload this page | https://github.com/python-kasa/python-kasa/pull/556 |
| https://github.com/rytilahti |
| rytilahti | https://github.com/rytilahti |
|
Nov 29, 2023
| https://github.com/python-kasa/python-kasa/pull/556#pullrequestreview-1755773394 |
|
View reviewed changes
| https://github.com/python-kasa/python-kasa/pull/556/files/ff7647174ff816e24472f8c06ac28780f78738b4 |
| kasa/tests/fixtures/HS100(UK)_1.0_1.2.6.json | https://github.com/python-kasa/python-kasa/pull/556/files/ff7647174ff816e24472f8c06ac28780f78738b4#diff-6dd4643cc88ee94a5df9d094132684e731a2b592d052173bb0d10389e47c25b4 |
| Please reload this page | https://github.com/python-kasa/python-kasa/pull/556 |
| https://github.com/rytilahti |
| rytilahti | https://github.com/rytilahti |
| Nov 29, 2023 | https://github.com/python-kasa/python-kasa/pull/556#event-11099293687 |
| https://github.com/rytilahti |
| rytilahti | https://github.com/rytilahti |
|
enhancement
| https://github.com/python-kasa/python-kasa/issues?q=state%3Aopen%20label%3Aenhancement |
| Nov 29, 2023 | https://github.com/python-kasa/python-kasa/pull/556#event-11099295401 |
|
| https://github.com/sdb9696 |
| Delete kasa/tests/fixtures/HS100(UK)_1.0_1.2.6.json | https://github.com/python-kasa/python-kasa/pull/556/commits/8981bf5da1a3b7c71152b58c6f20ff41d35e912d |
| 8981bf5 | https://github.com/python-kasa/python-kasa/pull/556/commits/8981bf5da1a3b7c71152b58c6f20ff41d35e912d |
| https://github.com/sdb9696 |
| sdb9696 | https://github.com/sdb9696 |
|
Nov 29, 2023
| https://github.com/python-kasa/python-kasa/pull/556#ref-pullrequest-2008602260 |
|
Add support for the protocol used by TAPO devices and some newer KASA devices.
#552
| https://github.com/python-kasa/python-kasa/pull/552 |
| https://github.com/rytilahti |
| rytilahti | https://github.com/rytilahti |
| 9de3f69 | https://github.com/python-kasa/python-kasa/commit/9de3f69033e5d99ead79af854966a6d681acba62 |
| Nov 29, 2023 | https://github.com/python-kasa/python-kasa/pull/556#event-11100365208 |
| https://github.com/sdb9696 |
| sdb9696 | https://github.com/sdb9696 |
| December 6, 2023 19:29 | https://github.com/python-kasa/python-kasa/pull/556#event-11172779774 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython-kasa%2Fpython-kasa%2Fpull%2F556 |
|
| https://github.com/rytilahti |
|
rytilahti
| https://github.com/rytilahti |
|
| https://github.com/python-kasa/python-kasa/pull/556/files/ff7647174ff816e24472f8c06ac28780f78738b4 |
|
enhancement
| https://github.com/python-kasa/python-kasa/issues?q=state%3Aopen%20label%3Aenhancement |
| Please reload this page | https://github.com/python-kasa/python-kasa/pull/556 |
|
| https://github.com/sdb9696 |
|
| https://github.com/rytilahti |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |