René's URL Explorer Experiment


Title: Simplify device class detection for discovery, fix hardcoded timeout by rytilahti · Pull Request #112 · python-kasa/python-kasa · GitHub

Open Graph Title: Simplify device class detection for discovery, fix hardcoded timeout by rytilahti · Pull Request #112 · python-kasa/python-kasa

X Title: Simplify device class detection for discovery, fix hardcoded timeout by rytilahti · Pull Request #112 · python-kasa/python-kasa

Description: With this PR the device class detection is made purely using the information available in the system.get_sysinfo call. This will make it easier to approach fixing #105

Open Graph Description: With this PR the device class detection is made purely using the information available in the system.get_sysinfo call. This will make it easier to approach fixing #105

X Description: With this PR the device class detection is made purely using the information available in the system.get_sysinfo call. This will make it easier to approach fixing #105

Opengraph URL: https://github.com/python-kasa/python-kasa/pull/112

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:a6a75e8c-f357-91df-81b7-7a0af09b0816
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8BBA:11CD52:16AD69:1EEDF4:69823D14
html-safe-nonce9201dd41628190c8330d81718255820f268ef96fda0ebdbae4c2bc7c78dcc52a
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4QkJBOjExQ0Q1MjoxNkFENjk6MUVFREY0OjY5ODIzRDE0IiwidmlzaXRvcl9pZCI6IjkxNDQ2MDQ3NzM2NjI3MzU2MzYiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac7f752d35753eca1ed280e95b6ec02ba125b5dac1df53db5e0397fc1056674124
hovercard-subject-tagpull_request:517201977
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python-kasa/python-kasa/112/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/0c25c65f690372ceae5b3175ca4de5d0c38cd581d2b9ea5362fcad888e30d284/python-kasa/python-kasa/pull/112
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/0c25c65f690372ceae5b3175ca4de5d0c38cd581d2b9ea5362fcad888e30d284/python-kasa/python-kasa/pull/112
og:image:altWith this PR the device class detection is made purely using the information available in the system.get_sysinfo call. This will make it easier to approach fixing #105
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamerytilahti
hostnamegithub.com
expected-hostnamegithub.com
None9135c12c87e8ba63197821abe054b7c0a2842a97636ee220df564bb0788e556d
turbo-cache-controlno-preview
go-importgithub.com/python-kasa/python-kasa git https://github.com/python-kasa/python-kasa.git
octolytics-dimension-user_id57733869
octolytics-dimension-user_loginpython-kasa
octolytics-dimension-repository_id221571611
octolytics-dimension-repository_nwopython-kasa/python-kasa
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id221571611
octolytics-dimension-repository_network_root_nwopython-kasa/python-kasa
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release43c4df4df458d3c3f6a23d91be88780178a97bdc
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python-kasa/python-kasa/pull/112#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython-kasa%2Fpython-kasa%2Fpull%2F112
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython-kasa%2Fpython-kasa%2Fpull%2F112
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python-kasa%2Fpython-kasa
Reloadhttps://github.com/python-kasa/python-kasa/pull/112
Reloadhttps://github.com/python-kasa/python-kasa/pull/112
Reloadhttps://github.com/python-kasa/python-kasa/pull/112
python-kasa https://github.com/python-kasa
python-kasahttps://github.com/python-kasa/python-kasa
Please reload this pagehttps://github.com/python-kasa/python-kasa/pull/112
Notifications https://github.com/login?return_to=%2Fpython-kasa%2Fpython-kasa
Fork 246 https://github.com/login?return_to=%2Fpython-kasa%2Fpython-kasa
Star 1.6k https://github.com/login?return_to=%2Fpython-kasa%2Fpython-kasa
Code https://github.com/python-kasa/python-kasa
Issues 51 https://github.com/python-kasa/python-kasa/issues
Pull requests 36 https://github.com/python-kasa/python-kasa/pulls
Discussions https://github.com/python-kasa/python-kasa/discussions
Actions https://github.com/python-kasa/python-kasa/actions
Projects 0 https://github.com/python-kasa/python-kasa/projects
Security 0 https://github.com/python-kasa/python-kasa/security
Insights https://github.com/python-kasa/python-kasa/pulse
Code https://github.com/python-kasa/python-kasa
Issues https://github.com/python-kasa/python-kasa/issues
Pull requests https://github.com/python-kasa/python-kasa/pulls
Discussions https://github.com/python-kasa/python-kasa/discussions
Actions https://github.com/python-kasa/python-kasa/actions
Projects https://github.com/python-kasa/python-kasa/projects
Security https://github.com/python-kasa/python-kasa/security
Insights https://github.com/python-kasa/python-kasa/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython-kasa%2Fpython-kasa%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython-kasa%2Fpython-kasa%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/python-kasa/python-kasa/pull/112#issue-comment-box
rytilahtihttps://github.com/rytilahti
python-kasa:masterhttps://github.com/python-kasa/python-kasa/tree/master
rytilahti:refactor/simplify_discoverhttps://github.com/rytilahti/python-kasa/tree/refactor/simplify_discover
Simplify device class detection for discovery, fix hardcoded timeout https://github.com/python-kasa/python-kasa/pull/112#top
rytilahtihttps://github.com/rytilahti
python-kasa:masterhttps://github.com/python-kasa/python-kasa/tree/master
rytilahti:refactor/simplify_discoverhttps://github.com/rytilahti/python-kasa/tree/refactor/simplify_discover
Conversation 2 https://github.com/python-kasa/python-kasa/pull/112
Commits 1 https://github.com/python-kasa/python-kasa/pull/112/commits
Checks 0 https://github.com/python-kasa/python-kasa/pull/112/checks
Files changed https://github.com/python-kasa/python-kasa/pull/112/files
Please reload this pagehttps://github.com/python-kasa/python-kasa/pull/112
https://github.co/hiddenchars
https://github.com/python-kasa/python-kasa/pull/{{ revealButtonHref }}
https://github.com/rytilahti
rytilahtihttps://github.com/rytilahti
Nov 7, 2020https://github.com/python-kasa/python-kasa/pull/112#issue-738331962
Please reload this pagehttps://github.com/python-kasa/python-kasa/pull/112
#105https://github.com/python-kasa/python-kasa/issues/105
Please reload this pagehttps://github.com/python-kasa/python-kasa/pull/112
https://github.com/rytilahti
Simplify device class detection for discovery, fix mistakenly hardcod…https://github.com/python-kasa/python-kasa/pull/112/commits/c8a1e07d552af139caa1db4a50854a3277ea4654
c8a1e07https://github.com/python-kasa/python-kasa/pull/112/commits/c8a1e07d552af139caa1db4a50854a3277ea4654
https://github.com/codecov-io
codecov-iohttps://github.com/codecov-io
Nov 7, 2020https://github.com/python-kasa/python-kasa/pull/112#issuecomment-723505129
Please reload this pagehttps://github.com/python-kasa/python-kasa/pull/112
Codecovhttps://codecov.io/gh/python-kasa/python-kasa/pull/112?src=pr&el=h1
#112https://codecov.io/gh/python-kasa/python-kasa/pull/112?src=pr&el=desc
c8a1e07https://github.com/python-kasa/python-kasa/commit/c8a1e07d552af139caa1db4a50854a3277ea4654
masterhttps://codecov.io/gh/python-kasa/python-kasa/commit/70061cbe671bbf8183db784a5f8551e245b9e068?el=desc
70061cbhttps://github.com/python-kasa/python-kasa/commit/70061cbe671bbf8183db784a5f8551e245b9e068
https://codecov.io/gh/python-kasa/python-kasa/pull/112?src=pr&el=tree
Impacted Fileshttps://codecov.io/gh/python-kasa/python-kasa/pull/112?src=pr&el=tree
kasa/discover.pyhttps://codecov.io/gh/python-kasa/python-kasa/pull/112/diff?src=pr&el=tree#diff-a2FzYS9kaXNjb3Zlci5weQ==
kasa/smartdevice.pyhttps://codecov.io/gh/python-kasa/python-kasa/pull/112/diff?src=pr&el=tree#diff-a2FzYS9zbWFydGRldmljZS5weQ==
Continue to review full report at Codecovhttps://codecov.io/gh/python-kasa/python-kasa/pull/112?src=pr&el=continue
Click here to learn morehttps://docs.codecov.io/docs/codecov-delta
Codecovhttps://codecov.io/gh/python-kasa/python-kasa/pull/112?src=pr&el=footer
70061cb...c8a1e07https://codecov.io/gh/python-kasa/python-kasa/pull/112?src=pr&el=lastupdated
comment docshttps://docs.codecov.io/docs/pull-request-comments
Please reload this pagehttps://github.com/python-kasa/python-kasa/pull/112
rytilahtihttps://github.com/rytilahti
Nov 7, 2020 https://github.com/python-kasa/python-kasa/pull/112#ref-commit-32dc52a
https://github.com/Belval
Use get_sysinfo to identify if device is Dimmerhttps://github.com/Belval/python-kasa/commit/32dc52a4fd5b517d7550a1b8f5e0918a226242ca
https://github.com/Belval/python-kasa/commit/32dc52a4fd5b517d7550a1b8f5e0918a226242ca#comments
32dc52ahttps://github.com/Belval/python-kasa/commit/32dc52a4fd5b517d7550a1b8f5e0918a226242ca
https://github.com/jimboca
jimbocahttps://github.com/jimboca
Nov 8, 2020https://github.com/python-kasa/python-kasa/pull/112#issuecomment-723518414
Please reload this pagehttps://github.com/python-kasa/python-kasa/pull/112
https://github.com/rytilahti
rytilahtihttps://github.com/rytilahti
56eb2cdhttps://github.com/python-kasa/python-kasa/commit/56eb2cdcb5d96552b2aa0d5c22fa2fb4883639a5
Nov 8, 2020https://github.com/python-kasa/python-kasa/pull/112#event-3970753901
https://github.com/rytilahti
rytilahtihttps://github.com/rytilahti
November 8, 2020 13:32https://github.com/python-kasa/python-kasa/pull/112#event-3970753953
https://github.com/rytilahti
rytilahtihttps://github.com/rytilahti
bug https://github.com/python-kasa/python-kasa/issues?q=state%3Aopen%20label%3Abug
Nov 21, 2020https://github.com/python-kasa/python-kasa/pull/112#event-4024229962
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython-kasa%2Fpython-kasa%2Fpull%2F112
bug https://github.com/python-kasa/python-kasa/issues?q=state%3Aopen%20label%3Abug
Please reload this pagehttps://github.com/python-kasa/python-kasa/pull/112
https://github.com/rytilahti
https://github.com/codecov-io
https://github.com/jimboca
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.