René's URL Explorer Experiment


Title: Reject port numbers that aren't composed only of ASCII digits. by kenballus · Pull Request #89 · python-hyper/rfc3986 · GitHub

Open Graph Title: Reject port numbers that aren't composed only of ASCII digits. by kenballus · Pull Request #89 · python-hyper/rfc3986

X Title: Reject port numbers that aren't composed only of ASCII digits. by kenballus · Pull Request #89 · python-hyper/rfc3986

Description: Parsing port numbers with int allows port numbers to be padded with whitespace (ASCII or unicode) preceded by a plus or minus sign interrupted with underscores composed of unicode digits None of these behaviors are permitted by any of the URL specifications. This PR adds a check to make sure that ports get rejected if they contain any characters that aren't ASCII digits. A similar bug was recently fixed in CPython's urllib.parse module.

Open Graph Description: Parsing port numbers with int allows port numbers to be padded with whitespace (ASCII or unicode) preceded by a plus or minus sign interrupted with underscores composed of unicode digits None of ...

X Description: Parsing port numbers with int allows port numbers to be padded with whitespace (ASCII or unicode) preceded by a plus or minus sign interrupted with underscores composed of unicode digits None of ...

Opengraph URL: https://github.com/python-hyper/rfc3986/pull/89

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:f2c81a11-e041-0e3f-a1e9-fb4101e7313b
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD2C8:291B58:43FA34B:55EAB70:6B026964
html-safe-noncebb2bd8cfd376de4b1075ea2b1ace962d781c01cb38d12930a61f35b71665e91d
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEMkM4OjI5MUI1ODo0M0ZBMzRCOjU1RUFCNzA6NkIwMjY5NjQiLCJ2aXNpdG9yX2lkIjoiMTQ0ODA1OTE5NDk4ODE5NDE0OCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac1c88ddc498c70bf7ac76f54e699142d79a8c781d20bd524b888ddbdc0b29894f
hovercard-subject-tagpull_request:1120121329
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python-hyper/rfc3986/pull/89/files
twitter:imagehttps://avatars.githubusercontent.com/u/49924171?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/49924171?s=400&v=4
og:image:altParsing port numbers with int allows port numbers to be padded with whitespace (ASCII or unicode) preceded by a plus or minus sign interrupted with underscores composed of unicode digits None of ...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python-hyper/rfc3986 git https://github.com/python-hyper/rfc3986.git
octolytics-dimension-user_id13035907
octolytics-dimension-user_loginpython-hyper
octolytics-dimension-repository_id21205959
octolytics-dimension-repository_nwopython-hyper/rfc3986
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id21205959
octolytics-dimension-repository_network_root_nwopython-hyper/rfc3986
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python-hyper/rfc3986/pull/89/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython-hyper%2Frfc3986%2Fpull%2F89%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython-hyper%2Frfc3986%2Fpull%2F89%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python-hyper%2Frfc3986
Reloadhttps://github.com/python-hyper/rfc3986/pull/89/files
Reloadhttps://github.com/python-hyper/rfc3986/pull/89/files
Reloadhttps://github.com/python-hyper/rfc3986/pull/89/files
python-hyperhttps://github.com/python-hyper
rfc3986https://github.com/python-hyper/rfc3986
Codehttps://github.com/python-hyper/rfc3986
Issues21 (21)https://github.com/python-hyper/rfc3986/issues
Pull requests13 (13)https://github.com/python-hyper/rfc3986/pulls
Actionshttps://github.com/python-hyper/rfc3986/actions
Projectshttps://github.com/python-hyper/rfc3986/projects
Wikihttps://github.com/python-hyper/rfc3986/wiki
Security and qualityhttps://github.com/python-hyper/rfc3986/security
Insightshttps://github.com/python-hyper/rfc3986/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fpython-hyper%2Frfc3986%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython-hyper%2Frfc3986%2Fissues%2Fnew%2Fchoose
sethmlarsonhttps://github.com/sethmlarson
python-hyper:mainhttps://github.com/python-hyper/rfc3986/tree/main
Conversation 2 https://github.com/python-hyper/rfc3986/pull/89
Commits 3 https://github.com/python-hyper/rfc3986/pull/89/commits
Checks 0 https://github.com/python-hyper/rfc3986/pull/89/checks
Files changed https://github.com/python-hyper/rfc3986/pull/89/files
Please reload this pagehttps://github.com/python-hyper/rfc3986/pull/89/files
Reject port numbers that aren't composed only of ASCII digits. https://github.com/python-hyper/rfc3986/pull/89/files#top
Show all changes 3 commits https://github.com/python-hyper/rfc3986/pull/89/files
ce474d7 Ensure rejection of ports that consist of anything other than ASCII d… kenballus Nov 12, 2022 https://github.com/python-hyper/rfc3986/pull/89/commits/ce474d7c0411ea388d6a47c69e7d7ff88e0bf943
7073041 add missing colon kenballus Nov 12, 2022 https://github.com/python-hyper/rfc3986/pull/89/commits/7073041a86feaf094b4302cd07d31e700315b688
14eb318 add test kenballus Nov 13, 2022 https://github.com/python-hyper/rfc3986/pull/89/commits/14eb318bb1766fb738df025679f52b6ffc25fbdb
Clear filters https://github.com/python-hyper/rfc3986/pull/89/files
Please reload this pagehttps://github.com/python-hyper/rfc3986/pull/89/files
Please reload this pagehttps://github.com/python-hyper/rfc3986/pull/89/files
parseresult.py https://github.com/python-hyper/rfc3986/pull/89/files#diff-795cb0c09c6685efdd83e6afce46b04432e39e56b935bc29d339af4e0e756628
test_parseresult.py https://github.com/python-hyper/rfc3986/pull/89/files#diff-508db959dbfa534246293f2034c6fa8d33d567d08f4a660d10ae6f5b367ce132
src/rfc3986/parseresult.pyhttps://github.com/python-hyper/rfc3986/pull/89/files#diff-795cb0c09c6685efdd83e6afce46b04432e39e56b935bc29d339af4e0e756628
View file https://github.com/python-hyper/rfc3986/blob/14eb318bb1766fb738df025679f52b6ffc25fbdb/src/rfc3986/parseresult.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python-hyper/rfc3986/pull/89/{{ revealButtonHref }}
https://github.com/python-hyper/rfc3986/pull/89/files#diff-795cb0c09c6685efdd83e6afce46b04432e39e56b935bc29d339af4e0e756628
tests/test_parseresult.pyhttps://github.com/python-hyper/rfc3986/pull/89/files#diff-508db959dbfa534246293f2034c6fa8d33d567d08f4a660d10ae6f5b367ce132
View file https://github.com/python-hyper/rfc3986/blob/14eb318bb1766fb738df025679f52b6ffc25fbdb/tests/test_parseresult.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python-hyper/rfc3986/pull/89/{{ revealButtonHref }}
https://github.com/python-hyper/rfc3986/pull/89/files#diff-508db959dbfa534246293f2034c6fa8d33d567d08f4a660d10ae6f5b367ce132
https://github.com/python-hyper/rfc3986/pull/89/files#diff-508db959dbfa534246293f2034c6fa8d33d567d08f4a660d10ae6f5b367ce132
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.