René's URL Explorer Experiment


Title: END_STREAM not marked when last chunk of length MAX_CHUNK · Issue #355 · python-hyper/hyper · GitHub

Open Graph Title: END_STREAM not marked when last chunk of length MAX_CHUNK · Issue #355 · python-hyper/hyper

X Title: END_STREAM not marked when last chunk of length MAX_CHUNK · Issue #355 · python-hyper/hyper

Description: https://github.com/Lukasa/hyper/blob/13e2a909e14349d14ae2b86217062e1568242b9a/hyper/http20/stream.py#L330 End of the stream is not marked when the last chunk is of size equal to MAX_CHUNK (1024). Condition len(data) < MAX_CHUNK works fin...

Open Graph Description: https://github.com/Lukasa/hyper/blob/13e2a909e14349d14ae2b86217062e1568242b9a/hyper/http20/stream.py#L330 End of the stream is not marked when the last chunk is of size equal to MAX_CHUNK (1024). C...

X Description: https://github.com/Lukasa/hyper/blob/13e2a909e14349d14ae2b86217062e1568242b9a/hyper/http20/stream.py#L330 End of the stream is not marked when the last chunk is of size equal to MAX_CHUNK (1024). C...

Opengraph URL: https://github.com/python-hyper/hyper/issues/355

X: @github

direct link

Domain: github.com

Hey, it has json ld scripts: 
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"END_STREAM not marked when last chunk of length MAX_CHUNK","articleBody":"https://github.com/Lukasa/hyper/blob/13e2a909e14349d14ae2b86217062e1568242b9a/hyper/http20/stream.py#L330\r\n\r\nEnd of the stream is not marked when the last chunk is of size equal to MAX_CHUNK (1024). Condition `len(data) \u003c MAX_CHUNK` works fine in all cases when the last chunk is of size smaller than 1024 but not in case when last chunk is of size 1024. If we change this to `len(data) \u003c= MAX_CHUNK` it wont work since we will mark END_STREAM for every chunk. Suggested solution is to make another argument that tell you when you have a last chunk. ","author":{"url":"https://github.com/PrimozGodec","@type":"Person","name":"PrimozGodec"},"datePublished":"2017-10-26T11:58:53.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":0},"url":"https://github.com/355/hyper/issues/355"}
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:23654735-b346-4f35-3c36-b92f9255adb8
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idB010:25C52D:3D7561:4F7E71:696B0882
html-safe-nonce9097be972690eef258ee00df28a854327a1b333a97950db1bda46c5cad7bcbdc
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCMDEwOjI1QzUyRDozRDc1NjE6NEY3RTcxOjY5NkIwODgyIiwidmlzaXRvcl9pZCI6IjYwMTQzNTIxMzM1MzQxODk2OTkiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac789c056a334cd881b3050b9fdb2e73a2f2a6527f4671752889e78129b9ea25a4
hovercard-subject-tagissue:268732352
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/python-hyper/hyper/355/issue_layout
twitter:imagehttps://opengraph.githubassets.com/74277856182342c6a201ca1bc8544e6f1b3545743627d9fa333a828586bb273f/python-hyper/hyper/issues/355
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/74277856182342c6a201ca1bc8544e6f1b3545743627d9fa333a828586bb273f/python-hyper/hyper/issues/355
og:image:althttps://github.com/Lukasa/hyper/blob/13e2a909e14349d14ae2b86217062e1568242b9a/hyper/http20/stream.py#L330 End of the stream is not marked when the last chunk is of size equal to MAX_CHUNK (1024). C...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamePrimozGodec
hostnamegithub.com
expected-hostnamegithub.com
None5f99f7c1d70f01da5b93e5ca90303359738944d8ab470e396496262c66e60b8d
turbo-cache-controlno-preview
go-importgithub.com/python-hyper/hyper git https://github.com/python-hyper/hyper.git
octolytics-dimension-user_id13035907
octolytics-dimension-user_loginpython-hyper
octolytics-dimension-repository_id16165969
octolytics-dimension-repository_nwopython-hyper/hyper
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id16165969
octolytics-dimension-repository_network_root_nwopython-hyper/hyper
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release82560a55c6b2054555076f46e683151ee28a19bc
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python-hyper/hyper/issues/355#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython-hyper%2Fhyper%2Fissues%2F355
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython-hyper%2Fhyper%2Fissues%2F355
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=python-hyper%2Fhyper
Reloadhttps://github.com/python-hyper/hyper/issues/355
Reloadhttps://github.com/python-hyper/hyper/issues/355
Reloadhttps://github.com/python-hyper/hyper/issues/355
python-hyper https://github.com/python-hyper
hyperhttps://github.com/python-hyper/hyper
Notifications https://github.com/login?return_to=%2Fpython-hyper%2Fhyper
Fork 197 https://github.com/login?return_to=%2Fpython-hyper%2Fhyper
Star 1k https://github.com/login?return_to=%2Fpython-hyper%2Fhyper
Code https://github.com/python-hyper/hyper
Issues 78 https://github.com/python-hyper/hyper/issues
Pull requests 23 https://github.com/python-hyper/hyper/pulls
Actions https://github.com/python-hyper/hyper/actions
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python-hyper/hyper/security
Please reload this pagehttps://github.com/python-hyper/hyper/issues/355
Insights https://github.com/python-hyper/hyper/pulse
Code https://github.com/python-hyper/hyper
Issues https://github.com/python-hyper/hyper/issues
Pull requests https://github.com/python-hyper/hyper/pulls
Actions https://github.com/python-hyper/hyper/actions
Security https://github.com/python-hyper/hyper/security
Insights https://github.com/python-hyper/hyper/pulse
END_STREAM not marked when last chunk of length MAX_CHUNKhttps://github.com/python-hyper/hyper/issues/355#top
https://github.com/PrimozGodec
https://github.com/PrimozGodec
PrimozGodechttps://github.com/PrimozGodec
on Oct 26, 2017https://github.com/python-hyper/hyper/issues/355#issue-268732352
https://github.com/Lukasa/hyper/blob/13e2a909e14349d14ae2b86217062e1568242b9a/hyper/http20/stream.py#L330https://github.com/Lukasa/hyper/blob/13e2a909e14349d14ae2b86217062e1568242b9a/hyper/http20/stream.py#L330
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.