René's URL Explorer Experiment


Title: feat(api)!: ListMixin.list typing overload by igorp-collabora · Pull Request #3122 · python-gitlab/python-gitlab · GitHub

Open Graph Title: feat(api)!: ListMixin.list typing overload by igorp-collabora · Pull Request #3122 · python-gitlab/python-gitlab

X Title: feat(api)!: ListMixin.list typing overload by igorp-collabora · Pull Request #3122 · python-gitlab/python-gitlab

Description: BREAKING CHANGE: The http_list method will no longer ignore the iterator argument if the page argument is not None. The ListMixin.list() will now return either list or iterator based on the iterator argument. This will make certain type narrowing checks redundant. Overload ListMixin.list method typing to return either RESTObjectList or list based on the iterator argument. By default then iterator is False return a list otherwise return an iterator. Provide 3 overloads: iterator: Literal[False] - this is the default and returns a list. iterator: Literal[True] - return an iterator. iterator: bool - return either list or iterator. It is useful when the list function is being extended by another function that can also take either True or False for the iterator argument. Make page argument to http_list not override the iterator to make the function signatures more straight forward. This also makes it easier to unpack **kwargs as only iterator argument will control if a list or iterator is returned so the **kwargs can no longer have a hidden page argument. OLD Questions: Should calling without get_all or iterator raise deprecation warning? (mypy needs a fix python/mypy#18474) Is it get_all or all? Documentation still uses all but apparently it was replaced in favour of get_all? **kwargs are used for all options. Should at least some options become keyword arguments? This will improve code completion tools.

Open Graph Description: BREAKING CHANGE: The http_list method will no longer ignore the iterator argument if the page argument is not None. The ListMixin.list() will now return either list or iterator based on the iterato...

X Description: BREAKING CHANGE: The http_list method will no longer ignore the iterator argument if the page argument is not None. The ListMixin.list() will now return either list or iterator based on the iterato...

Opengraph URL: https://github.com/python-gitlab/python-gitlab/pull/3122

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:1789782d-5501-bdb2-b5c7-4bd9159036e7
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idBC88:3AE712:2B0C98:3A1D22:6B00258F
html-safe-noncea55329333c1504362ef04602f57974070e16bfb381b2f4c5a95afab10b579f77
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCQzg4OjNBRTcxMjoyQjBDOTg6M0ExRDIyOjZCMDAyNThGIiwidmlzaXRvcl9pZCI6IjY2OTMxMjI2MDYwMzc0NzY3NTEiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac39d4dc92affe6e35bf5814144b4eb2b221fc0201f2eae7aff7cd89fb960c337a
hovercard-subject-tagpull_request:2320260407
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python-gitlab/python-gitlab/pull/3122/files
twitter:imagehttps://avatars.githubusercontent.com/u/192702368?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/192702368?s=400&v=4
og:image:altBREAKING CHANGE: The http_list method will no longer ignore the iterator argument if the page argument is not None. The ListMixin.list() will now return either list or iterator based on the iterato...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None4eb4cba0d69f045374ac15de9666d22b0961e1d555cc3824f36b7734c00c78e0
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python-gitlab/python-gitlab git https://github.com/python-gitlab/python-gitlab.git
octolytics-dimension-user_id28886265
octolytics-dimension-user_loginpython-gitlab
octolytics-dimension-repository_id8077625
octolytics-dimension-repository_nwopython-gitlab/python-gitlab
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id8077625
octolytics-dimension-repository_network_root_nwopython-gitlab/python-gitlab
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release44c658b24abf00491fb7ae5f56d42c9f38cbeab2
ui-targetcanary-1
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python-gitlab/python-gitlab/pull/3122/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython-gitlab%2Fpython-gitlab%2Fpull%2F3122%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython-gitlab%2Fpython-gitlab%2Fpull%2F3122%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python-gitlab%2Fpython-gitlab
Reloadhttps://github.com/python-gitlab/python-gitlab/pull/3122/files
Reloadhttps://github.com/python-gitlab/python-gitlab/pull/3122/files
Reloadhttps://github.com/python-gitlab/python-gitlab/pull/3122/files
python-gitlabhttps://github.com/python-gitlab
python-gitlabhttps://github.com/python-gitlab/python-gitlab
Codehttps://github.com/python-gitlab/python-gitlab
Issues23 (23)https://github.com/python-gitlab/python-gitlab/issues
Pull requests19 (19)https://github.com/python-gitlab/python-gitlab/pulls
Discussionshttps://github.com/python-gitlab/python-gitlab/discussions
Actionshttps://github.com/python-gitlab/python-gitlab/actions
Projectshttps://github.com/python-gitlab/python-gitlab/projects
Security and qualityhttps://github.com/python-gitlab/python-gitlab/security
Insightshttps://github.com/python-gitlab/python-gitlab/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fpython-gitlab%2Fpython-gitlab%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython-gitlab%2Fpython-gitlab%2Fissues%2Fnew%2Fchoose
nejchhttps://github.com/nejch
python-gitlab:mainhttps://github.com/python-gitlab/python-gitlab/tree/main
igorp-collabora:list-mixin-typing-overloadhttps://github.com/igorp-collabora/python-gitlab/tree/list-mixin-typing-overload
Conversation 12 https://github.com/python-gitlab/python-gitlab/pull/3122
Commits 1 https://github.com/python-gitlab/python-gitlab/pull/3122/commits
Checks 0 https://github.com/python-gitlab/python-gitlab/pull/3122/checks
Files changed https://github.com/python-gitlab/python-gitlab/pull/3122/files
Please reload this pagehttps://github.com/python-gitlab/python-gitlab/pull/3122/files
feat(api)!: ListMixin.list typing overload https://github.com/python-gitlab/python-gitlab/pull/3122/files#top
Show all changes 1 commit https://github.com/python-gitlab/python-gitlab/pull/3122/files
33b4a70 feat(api)!: ListMixin.list typing overload igorp-collabora Feb 6, 2025 https://github.com/python-gitlab/python-gitlab/pull/3122/commits/33b4a70733a3ae192dc2841b90fce55a535fd0dc
Clear filters https://github.com/python-gitlab/python-gitlab/pull/3122/files
Please reload this pagehttps://github.com/python-gitlab/python-gitlab/pull/3122/files
Please reload this pagehttps://github.com/python-gitlab/python-gitlab/pull/3122/files
client.py https://github.com/python-gitlab/python-gitlab/pull/3122/files#diff-cfa2b05f7b559e334405867e2c02564c88032f0dee928f61cba4b84d3d680886
mixins.py https://github.com/python-gitlab/python-gitlab/pull/3122/files#diff-dea3b4fc0debe78b4f98980803c1aaa7b7dd702052468b30385d444cad1f14c1
cli.py https://github.com/python-gitlab/python-gitlab/pull/3122/files#diff-8badc8c19001e2098ee4c85b7813eee577ce452bbfab3b220dfb54b51c6649cf
ldap.py https://github.com/python-gitlab/python-gitlab/pull/3122/files#diff-a296e85bb695630b142c93e9e14c319f4afe2f070da068859053b102d0ac2a18
snippets.py https://github.com/python-gitlab/python-gitlab/pull/3122/files#diff-b9d9b8b525cdd52413ec3511cc2fa15d98df7b0d382ba95aa7a6ca07b26cceaf
users.py https://github.com/python-gitlab/python-gitlab/pull/3122/files#diff-38adebafd33d25cef492d107b81342411b39d01cffdbe833c975351e6775551a
test_merge_requests.py https://github.com/python-gitlab/python-gitlab/pull/3122/files#diff-fccb490742a42321eeb586eb274863a8fae11abc54ea31253e043346e9065dfd
test_gitlab_http_methods.py https://github.com/python-gitlab/python-gitlab/pull/3122/files#diff-abdb153ac479ac4868032ad1a287a1be3c0627eba1d9e67defbda908d929115a
gitlab/client.pyhttps://github.com/python-gitlab/python-gitlab/pull/3122/files#diff-cfa2b05f7b559e334405867e2c02564c88032f0dee928f61cba4b84d3d680886
View file https://github.com/igorp-collabora/python-gitlab/blob/33b4a70733a3ae192dc2841b90fce55a535fd0dc/gitlab/client.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python-gitlab/python-gitlab/pull/3122/{{ revealButtonHref }}
https://github.com/python-gitlab/python-gitlab/pull/3122/files#diff-cfa2b05f7b559e334405867e2c02564c88032f0dee928f61cba4b84d3d680886
Please reload this pagehttps://github.com/python-gitlab/python-gitlab/pull/3122/files
https://github.com/python-gitlab/python-gitlab/pull/3122/files#diff-cfa2b05f7b559e334405867e2c02564c88032f0dee928f61cba4b84d3d680886
gitlab/mixins.pyhttps://github.com/python-gitlab/python-gitlab/pull/3122/files#diff-dea3b4fc0debe78b4f98980803c1aaa7b7dd702052468b30385d444cad1f14c1
View file https://github.com/igorp-collabora/python-gitlab/blob/33b4a70733a3ae192dc2841b90fce55a535fd0dc/gitlab/mixins.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python-gitlab/python-gitlab/pull/3122/{{ revealButtonHref }}
https://github.com/python-gitlab/python-gitlab/pull/3122/files#diff-dea3b4fc0debe78b4f98980803c1aaa7b7dd702052468b30385d444cad1f14c1
https://github.com/python-gitlab/python-gitlab/pull/3122/files#diff-dea3b4fc0debe78b4f98980803c1aaa7b7dd702052468b30385d444cad1f14c1
https://github.com/python-gitlab/python-gitlab/pull/3122/files#diff-dea3b4fc0debe78b4f98980803c1aaa7b7dd702052468b30385d444cad1f14c1
https://github.com/python-gitlab/python-gitlab/pull/3122/files#diff-dea3b4fc0debe78b4f98980803c1aaa7b7dd702052468b30385d444cad1f14c1
gitlab/v4/cli.pyhttps://github.com/python-gitlab/python-gitlab/pull/3122/files#diff-8badc8c19001e2098ee4c85b7813eee577ce452bbfab3b220dfb54b51c6649cf
View file https://github.com/igorp-collabora/python-gitlab/blob/33b4a70733a3ae192dc2841b90fce55a535fd0dc/gitlab/v4/cli.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python-gitlab/python-gitlab/pull/3122/{{ revealButtonHref }}
https://github.com/python-gitlab/python-gitlab/pull/3122/files#diff-8badc8c19001e2098ee4c85b7813eee577ce452bbfab3b220dfb54b51c6649cf
https://github.com/python-gitlab/python-gitlab/pull/3122/files#diff-8badc8c19001e2098ee4c85b7813eee577ce452bbfab3b220dfb54b51c6649cf
https://github.com/python-gitlab/python-gitlab/pull/3122/files#diff-8badc8c19001e2098ee4c85b7813eee577ce452bbfab3b220dfb54b51c6649cf
gitlab/v4/objects/ldap.pyhttps://github.com/python-gitlab/python-gitlab/pull/3122/files#diff-a296e85bb695630b142c93e9e14c319f4afe2f070da068859053b102d0ac2a18
View file https://github.com/igorp-collabora/python-gitlab/blob/33b4a70733a3ae192dc2841b90fce55a535fd0dc/gitlab/v4/objects/ldap.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python-gitlab/python-gitlab/pull/3122/{{ revealButtonHref }}
https://github.com/python-gitlab/python-gitlab/pull/3122/files#diff-a296e85bb695630b142c93e9e14c319f4afe2f070da068859053b102d0ac2a18
https://github.com/python-gitlab/python-gitlab/pull/3122/files#diff-a296e85bb695630b142c93e9e14c319f4afe2f070da068859053b102d0ac2a18
gitlab/v4/objects/snippets.pyhttps://github.com/python-gitlab/python-gitlab/pull/3122/files#diff-b9d9b8b525cdd52413ec3511cc2fa15d98df7b0d382ba95aa7a6ca07b26cceaf
View file https://github.com/igorp-collabora/python-gitlab/blob/33b4a70733a3ae192dc2841b90fce55a535fd0dc/gitlab/v4/objects/snippets.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python-gitlab/python-gitlab/pull/3122/{{ revealButtonHref }}
https://github.com/python-gitlab/python-gitlab/pull/3122/files#diff-b9d9b8b525cdd52413ec3511cc2fa15d98df7b0d382ba95aa7a6ca07b26cceaf
https://github.com/python-gitlab/python-gitlab/pull/3122/files#diff-b9d9b8b525cdd52413ec3511cc2fa15d98df7b0d382ba95aa7a6ca07b26cceaf
https://github.com/python-gitlab/python-gitlab/pull/3122/files#diff-b9d9b8b525cdd52413ec3511cc2fa15d98df7b0d382ba95aa7a6ca07b26cceaf
https://github.com/python-gitlab/python-gitlab/pull/3122/files#diff-b9d9b8b525cdd52413ec3511cc2fa15d98df7b0d382ba95aa7a6ca07b26cceaf
https://github.com/python-gitlab/python-gitlab/pull/3122/files#diff-b9d9b8b525cdd52413ec3511cc2fa15d98df7b0d382ba95aa7a6ca07b26cceaf
gitlab/v4/objects/users.pyhttps://github.com/python-gitlab/python-gitlab/pull/3122/files#diff-38adebafd33d25cef492d107b81342411b39d01cffdbe833c975351e6775551a
View file https://github.com/igorp-collabora/python-gitlab/blob/33b4a70733a3ae192dc2841b90fce55a535fd0dc/gitlab/v4/objects/users.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python-gitlab/python-gitlab/pull/3122/{{ revealButtonHref }}
https://github.com/python-gitlab/python-gitlab/pull/3122/files#diff-38adebafd33d25cef492d107b81342411b39d01cffdbe833c975351e6775551a
https://github.com/python-gitlab/python-gitlab/pull/3122/files#diff-38adebafd33d25cef492d107b81342411b39d01cffdbe833c975351e6775551a
https://github.com/python-gitlab/python-gitlab/pull/3122/files#diff-38adebafd33d25cef492d107b81342411b39d01cffdbe833c975351e6775551a
https://github.com/python-gitlab/python-gitlab/pull/3122/files#diff-38adebafd33d25cef492d107b81342411b39d01cffdbe833c975351e6775551a
https://github.com/python-gitlab/python-gitlab/pull/3122/files#diff-38adebafd33d25cef492d107b81342411b39d01cffdbe833c975351e6775551a
tests/functional/api/test_merge_requests.pyhttps://github.com/python-gitlab/python-gitlab/pull/3122/files#diff-fccb490742a42321eeb586eb274863a8fae11abc54ea31253e043346e9065dfd
View file https://github.com/igorp-collabora/python-gitlab/blob/33b4a70733a3ae192dc2841b90fce55a535fd0dc/tests/functional/api/test_merge_requests.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python-gitlab/python-gitlab/pull/3122/{{ revealButtonHref }}
https://github.com/python-gitlab/python-gitlab/pull/3122/files#diff-fccb490742a42321eeb586eb274863a8fae11abc54ea31253e043346e9065dfd
https://github.com/python-gitlab/python-gitlab/pull/3122/files#diff-fccb490742a42321eeb586eb274863a8fae11abc54ea31253e043346e9065dfd
tests/unit/test_gitlab_http_methods.pyhttps://github.com/python-gitlab/python-gitlab/pull/3122/files#diff-abdb153ac479ac4868032ad1a287a1be3c0627eba1d9e67defbda908d929115a
View file https://github.com/igorp-collabora/python-gitlab/blob/33b4a70733a3ae192dc2841b90fce55a535fd0dc/tests/unit/test_gitlab_http_methods.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python-gitlab/python-gitlab/pull/3122/{{ revealButtonHref }}
https://github.com/python-gitlab/python-gitlab/pull/3122/files#diff-abdb153ac479ac4868032ad1a287a1be3c0627eba1d9e67defbda908d929115a
https://github.com/python-gitlab/python-gitlab/pull/3122/files#diff-abdb153ac479ac4868032ad1a287a1be3c0627eba1d9e67defbda908d929115a
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.