René's URL Explorer Experiment


Title: fix(client): ensure encoded query params are never duplicated by nejch · Pull Request #2219 · python-gitlab/python-gitlab · GitHub

Open Graph Title: fix(client): ensure encoded query params are never duplicated by nejch · Pull Request #2219 · python-gitlab/python-gitlab

X Title: fix(client): ensure encoded query params are never duplicated by nejch · Pull Request #2219 · python-gitlab/python-gitlab

Description: Closes #2218 This provides a small generic fix at the http_request level instead of messing even more with our own flows. (I've always thought it was a bit weird that GitLab returns a lot of boilerplate query params in ther next header links, so I think this will also make other things more robust in the future).

Open Graph Description: Closes #2218 This provides a small generic fix at the http_request level instead of messing even more with our own flows. (I've always thought it was a bit weird that GitLab returns a lot of bo...

X Description: Closes #2218 This provides a small generic fix at the http_request level instead of messing even more with our own flows. (I've always thought it was a bit weird that GitLab returns a lot o...

Opengraph URL: https://github.com/python-gitlab/python-gitlab/pull/2219

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:abd9dc02-6975-a3d7-842e-bca541bbe1a9
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8978:1E82C3:29974B:37AE31:697305D6
html-safe-nonce590404d72f4ec792f042b53ab8028d0e183a5b4f31fee9800473c9be8a1bac58
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4OTc4OjFFODJDMzoyOTk3NEI6MzdBRTMxOjY5NzMwNUQ2IiwidmlzaXRvcl9pZCI6Ijg1OTU0ODMwNjQ0NTAzNTI1OTgiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac580fdf353f8ef012501485be8608ce6d90469370cfa518333e58d076a9820e53
hovercard-subject-tagpull_request:1017554435
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python-gitlab/python-gitlab/pull/2219/files
twitter:imagehttps://avatars.githubusercontent.com/u/16777978?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/16777978?s=400&v=4
og:image:altCloses #2218 This provides a small generic fix at the http_request level instead of messing even more with our own flows. (I've always thought it was a bit weird that GitLab returns a lot of bo...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None44ab3188c1dcfe3be0f9c3feca2e04e14fb79f120939ce2395e4f15ab96ec1d4
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python-gitlab/python-gitlab git https://github.com/python-gitlab/python-gitlab.git
octolytics-dimension-user_id28886265
octolytics-dimension-user_loginpython-gitlab
octolytics-dimension-repository_id8077625
octolytics-dimension-repository_nwopython-gitlab/python-gitlab
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id8077625
octolytics-dimension-repository_network_root_nwopython-gitlab/python-gitlab
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasea5e2b48bd1260476599758f5d253b5d24092ab84
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python-gitlab/python-gitlab/pull/2219/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython-gitlab%2Fpython-gitlab%2Fpull%2F2219%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython-gitlab%2Fpython-gitlab%2Fpull%2F2219%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python-gitlab%2Fpython-gitlab
Reloadhttps://github.com/python-gitlab/python-gitlab/pull/2219/files
Reloadhttps://github.com/python-gitlab/python-gitlab/pull/2219/files
Reloadhttps://github.com/python-gitlab/python-gitlab/pull/2219/files
python-gitlab https://github.com/python-gitlab
python-gitlabhttps://github.com/python-gitlab/python-gitlab
Notifications https://github.com/login?return_to=%2Fpython-gitlab%2Fpython-gitlab
Fork 675 https://github.com/login?return_to=%2Fpython-gitlab%2Fpython-gitlab
Star 2.4k https://github.com/login?return_to=%2Fpython-gitlab%2Fpython-gitlab
Code https://github.com/python-gitlab/python-gitlab
Issues 26 https://github.com/python-gitlab/python-gitlab/issues
Pull requests 12 https://github.com/python-gitlab/python-gitlab/pulls
Discussions https://github.com/python-gitlab/python-gitlab/discussions
Actions https://github.com/python-gitlab/python-gitlab/actions
Projects 0 https://github.com/python-gitlab/python-gitlab/projects
Security 0 https://github.com/python-gitlab/python-gitlab/security
Insights https://github.com/python-gitlab/python-gitlab/pulse
Code https://github.com/python-gitlab/python-gitlab
Issues https://github.com/python-gitlab/python-gitlab/issues
Pull requests https://github.com/python-gitlab/python-gitlab/pulls
Discussions https://github.com/python-gitlab/python-gitlab/discussions
Actions https://github.com/python-gitlab/python-gitlab/actions
Projects https://github.com/python-gitlab/python-gitlab/projects
Security https://github.com/python-gitlab/python-gitlab/security
Insights https://github.com/python-gitlab/python-gitlab/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython-gitlab%2Fpython-gitlab%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython-gitlab%2Fpython-gitlab%2Fissues%2Fnew%2Fchoose
max-wittighttps://github.com/max-wittig
mainhttps://github.com/python-gitlab/python-gitlab/tree/main
fix/no-duplicate-paramshttps://github.com/python-gitlab/python-gitlab/tree/fix/no-duplicate-params
Conversation 3 https://github.com/python-gitlab/python-gitlab/pull/2219
Commits 2 https://github.com/python-gitlab/python-gitlab/pull/2219/commits
Checks 0 https://github.com/python-gitlab/python-gitlab/pull/2219/checks
Files changed https://github.com/python-gitlab/python-gitlab/pull/2219/files
Please reload this pagehttps://github.com/python-gitlab/python-gitlab/pull/2219/files
fix(client): ensure encoded query params are never duplicated https://github.com/python-gitlab/python-gitlab/pull/2219/files#top
Show all changes 2 commits https://github.com/python-gitlab/python-gitlab/pull/2219/files
6f71c66 test(unit): reproduce duplicate encoded query params nejch Aug 4, 2022 https://github.com/python-gitlab/python-gitlab/pull/2219/commits/6f71c663a302b20632558b4c94be428ba831ee7f
1398426 fix(client): ensure encoded query params are never duplicated nejch Aug 4, 2022 https://github.com/python-gitlab/python-gitlab/pull/2219/commits/1398426cd748fdf492fe6184b03ac2fcb7e4fd6e
Clear filters https://github.com/python-gitlab/python-gitlab/pull/2219/files
Please reload this pagehttps://github.com/python-gitlab/python-gitlab/pull/2219/files
Please reload this pagehttps://github.com/python-gitlab/python-gitlab/pull/2219/files
client.py https://github.com/python-gitlab/python-gitlab/pull/2219/files#diff-cfa2b05f7b559e334405867e2c02564c88032f0dee928f61cba4b84d3d680886
test_gitlab_http_methods.py https://github.com/python-gitlab/python-gitlab/pull/2219/files#diff-abdb153ac479ac4868032ad1a287a1be3c0627eba1d9e67defbda908d929115a
gitlab/client.pyhttps://github.com/python-gitlab/python-gitlab/pull/2219/files#diff-cfa2b05f7b559e334405867e2c02564c88032f0dee928f61cba4b84d3d680886
View file https://github.com/python-gitlab/python-gitlab/blob/1398426cd748fdf492fe6184b03ac2fcb7e4fd6e/gitlab/client.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python-gitlab/python-gitlab/pull/2219/{{ revealButtonHref }}
https://github.com/python-gitlab/python-gitlab/pull/2219/files#diff-cfa2b05f7b559e334405867e2c02564c88032f0dee928f61cba4b84d3d680886
https://github.com/python-gitlab/python-gitlab/pull/2219/files#diff-cfa2b05f7b559e334405867e2c02564c88032f0dee928f61cba4b84d3d680886
https://github.com/python-gitlab/python-gitlab/pull/2219/files#diff-cfa2b05f7b559e334405867e2c02564c88032f0dee928f61cba4b84d3d680886
JohnVillalovoshttps://github.com/JohnVillalovos
Aug 4, 2022https://github.com/python-gitlab/python-gitlab/pull/2219/files#r937907373
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python-gitlab/python-gitlab/pull/2219/files
nejchhttps://github.com/nejch
Aug 4, 2022https://github.com/python-gitlab/python-gitlab/pull/2219/files#r937927383
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python-gitlab/python-gitlab/pull/2219/files
JohnVillalovoshttps://github.com/JohnVillalovos
Aug 4, 2022https://github.com/python-gitlab/python-gitlab/pull/2219/files#r937928688
Please reload this pagehttps://github.com/python-gitlab/python-gitlab/pull/2219/files
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
https://docs.python.org/3/library/urllib.parse.htmlhttps://docs.python.org/3/library/urllib.parse.html
Please reload this pagehttps://github.com/python-gitlab/python-gitlab/pull/2219/files
https://github.com/python-gitlab/python-gitlab/pull/2219/files#diff-cfa2b05f7b559e334405867e2c02564c88032f0dee928f61cba4b84d3d680886
tests/unit/test_gitlab_http_methods.pyhttps://github.com/python-gitlab/python-gitlab/pull/2219/files#diff-abdb153ac479ac4868032ad1a287a1be3c0627eba1d9e67defbda908d929115a
View file https://github.com/python-gitlab/python-gitlab/blob/1398426cd748fdf492fe6184b03ac2fcb7e4fd6e/tests/unit/test_gitlab_http_methods.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python-gitlab/python-gitlab/pull/2219/{{ revealButtonHref }}
https://github.com/python-gitlab/python-gitlab/pull/2219/files#diff-abdb153ac479ac4868032ad1a287a1be3c0627eba1d9e67defbda908d929115a
https://github.com/python-gitlab/python-gitlab/pull/2219/files#diff-abdb153ac479ac4868032ad1a287a1be3c0627eba1d9e67defbda908d929115a
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.