René's URL Explorer Experiment


Title: fix: remove custom URL encoding by JohnVillalovos · Pull Request #1816 · python-gitlab/python-gitlab · GitHub

Open Graph Title: fix: remove custom URL encoding by JohnVillalovos · Pull Request #1816 · python-gitlab/python-gitlab

X Title: fix: remove custom URL encoding by JohnVillalovos · Pull Request #1816 · python-gitlab/python-gitlab

Description: We were using str.replace() calls to take care of URL encoding issues. Switch them to use our utils._url_encode() function which itself uses urllib.parse.quote() Closes: #1356

Open Graph Description: We were using str.replace() calls to take care of URL encoding issues. Switch them to use our utils._url_encode() function which itself uses urllib.parse.quote() Closes: #1356

X Description: We were using str.replace() calls to take care of URL encoding issues. Switch them to use our utils._url_encode() function which itself uses urllib.parse.quote() Closes: #1356

Opengraph URL: https://github.com/python-gitlab/python-gitlab/pull/1816

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:e00ef5ed-6287-70e5-f37f-5885800fc2e1
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id90D4:B8167:37090DA:4B417E9:6972CB22
html-safe-nonce1ef0721d29510b43958e1a7a1f85ed69c8f004b3564e11e6e73bd0c2ce66cb7e
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5MEQ0OkI4MTY3OjM3MDkwREE6NEI0MTdFOTo2OTcyQ0IyMiIsInZpc2l0b3JfaWQiOiIyODU1NzI1ODM1NjQzNzAyMDUwIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmaceb98dd048f6c24112c77f46163534bd3a1e6a0bed50e6064b199e84f0788436a
hovercard-subject-tagpull_request:816931495
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python-gitlab/python-gitlab/pull/1816/files
twitter:imagehttps://avatars.githubusercontent.com/u/578155?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/578155?s=400&v=4
og:image:altWe were using str.replace() calls to take care of URL encoding issues. Switch them to use our utils._url_encode() function which itself uses urllib.parse.quote() Closes: #1356
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonee5abb0753dbd4190d15d366a819b0ca85f68a7e5bbe3d32213b346c41685c80a
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python-gitlab/python-gitlab git https://github.com/python-gitlab/python-gitlab.git
octolytics-dimension-user_id28886265
octolytics-dimension-user_loginpython-gitlab
octolytics-dimension-repository_id8077625
octolytics-dimension-repository_nwopython-gitlab/python-gitlab
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id8077625
octolytics-dimension-repository_network_root_nwopython-gitlab/python-gitlab
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release88896109b054799a7f22afaeee541d00f9170dc3
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python-gitlab/python-gitlab/pull/1816/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython-gitlab%2Fpython-gitlab%2Fpull%2F1816%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython-gitlab%2Fpython-gitlab%2Fpull%2F1816%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python-gitlab%2Fpython-gitlab
Reloadhttps://github.com/python-gitlab/python-gitlab/pull/1816/files
Reloadhttps://github.com/python-gitlab/python-gitlab/pull/1816/files
Reloadhttps://github.com/python-gitlab/python-gitlab/pull/1816/files
python-gitlab https://github.com/python-gitlab
python-gitlabhttps://github.com/python-gitlab/python-gitlab
Notifications https://github.com/login?return_to=%2Fpython-gitlab%2Fpython-gitlab
Fork 675 https://github.com/login?return_to=%2Fpython-gitlab%2Fpython-gitlab
Star 2.4k https://github.com/login?return_to=%2Fpython-gitlab%2Fpython-gitlab
Code https://github.com/python-gitlab/python-gitlab
Issues 26 https://github.com/python-gitlab/python-gitlab/issues
Pull requests 12 https://github.com/python-gitlab/python-gitlab/pulls
Discussions https://github.com/python-gitlab/python-gitlab/discussions
Actions https://github.com/python-gitlab/python-gitlab/actions
Projects 0 https://github.com/python-gitlab/python-gitlab/projects
Security 0 https://github.com/python-gitlab/python-gitlab/security
Insights https://github.com/python-gitlab/python-gitlab/pulse
Code https://github.com/python-gitlab/python-gitlab
Issues https://github.com/python-gitlab/python-gitlab/issues
Pull requests https://github.com/python-gitlab/python-gitlab/pulls
Discussions https://github.com/python-gitlab/python-gitlab/discussions
Actions https://github.com/python-gitlab/python-gitlab/actions
Projects https://github.com/python-gitlab/python-gitlab/projects
Security https://github.com/python-gitlab/python-gitlab/security
Insights https://github.com/python-gitlab/python-gitlab/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython-gitlab%2Fpython-gitlab%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython-gitlab%2Fpython-gitlab%2Fissues%2Fnew%2Fchoose
nejchhttps://github.com/nejch
mainhttps://github.com/python-gitlab/python-gitlab/tree/main
jlvillal/remove_replacehttps://github.com/python-gitlab/python-gitlab/tree/jlvillal/remove_replace
Conversation 11 https://github.com/python-gitlab/python-gitlab/pull/1816
Commits 1 https://github.com/python-gitlab/python-gitlab/pull/1816/commits
Checks 0 https://github.com/python-gitlab/python-gitlab/pull/1816/checks
Files changed https://github.com/python-gitlab/python-gitlab/pull/1816/files
Please reload this pagehttps://github.com/python-gitlab/python-gitlab/pull/1816/files
fix: remove custom URL encoding https://github.com/python-gitlab/python-gitlab/pull/1816/files#top
Show all changes 1 commit https://github.com/python-gitlab/python-gitlab/pull/1816/files
3d49e5e fix: remove custom URL encoding JohnVillalovos Jan 9, 2022 https://github.com/python-gitlab/python-gitlab/pull/1816/commits/3d49e5e6a2bf1c9a883497acb73d7ce7115b804d
Clear filters https://github.com/python-gitlab/python-gitlab/pull/1816/files
Please reload this pagehttps://github.com/python-gitlab/python-gitlab/pull/1816/files
Please reload this pagehttps://github.com/python-gitlab/python-gitlab/pull/1816/files
mixins.py https://github.com/python-gitlab/python-gitlab/pull/1816/files#diff-dea3b4fc0debe78b4f98980803c1aaa7b7dd702052468b30385d444cad1f14c1
utils.py https://github.com/python-gitlab/python-gitlab/pull/1816/files#diff-f8491e1894d267d0ea4bcd44eaf0e9313e2cd3d7a7a2a32bcbbb0dcba902b25e
cli.py https://github.com/python-gitlab/python-gitlab/pull/1816/files#diff-8badc8c19001e2098ee4c85b7813eee577ce452bbfab3b220dfb54b51c6649cf
features.py https://github.com/python-gitlab/python-gitlab/pull/1816/files#diff-9d2825e1a93feb2117169bd1aada224295ec27bc75ceedc0d41eb739ac938721
files.py https://github.com/python-gitlab/python-gitlab/pull/1816/files#diff-beda658bbd6468e0104c6157634af2fd512fbb4d1e5abbc304b261cb39b414ca
repositories.py https://github.com/python-gitlab/python-gitlab/pull/1816/files#diff-3029f4fdc8633beef2726cddd366d5e6d14e14f595c77ab428bfd7f6cf500374
test_repository.py https://github.com/python-gitlab/python-gitlab/pull/1816/files#diff-bc4950f989e49d8e56dd4918b3d47e63bf3b2cbe163f8c463d512f6567f2a9c3
test_utils.py https://github.com/python-gitlab/python-gitlab/pull/1816/files#diff-a28b281ee0902c932527e269c585ac109bdd98aa5ceebe05ca97a10a5a432651
gitlab/mixins.pyhttps://github.com/python-gitlab/python-gitlab/pull/1816/files#diff-dea3b4fc0debe78b4f98980803c1aaa7b7dd702052468b30385d444cad1f14c1
View file https://github.com/python-gitlab/python-gitlab/blob/3d49e5e6a2bf1c9a883497acb73d7ce7115b804d/gitlab/mixins.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python-gitlab/python-gitlab/pull/1816/{{ revealButtonHref }}
https://github.com/python-gitlab/python-gitlab/pull/1816/files#diff-dea3b4fc0debe78b4f98980803c1aaa7b7dd702052468b30385d444cad1f14c1
https://github.com/python-gitlab/python-gitlab/pull/1816/files#diff-dea3b4fc0debe78b4f98980803c1aaa7b7dd702052468b30385d444cad1f14c1
https://github.com/python-gitlab/python-gitlab/pull/1816/files#diff-dea3b4fc0debe78b4f98980803c1aaa7b7dd702052468b30385d444cad1f14c1
https://github.com/python-gitlab/python-gitlab/pull/1816/files#diff-dea3b4fc0debe78b4f98980803c1aaa7b7dd702052468b30385d444cad1f14c1
https://github.com/python-gitlab/python-gitlab/pull/1816/files#diff-dea3b4fc0debe78b4f98980803c1aaa7b7dd702052468b30385d444cad1f14c1
https://github.com/python-gitlab/python-gitlab/pull/1816/files#diff-dea3b4fc0debe78b4f98980803c1aaa7b7dd702052468b30385d444cad1f14c1
gitlab/utils.pyhttps://github.com/python-gitlab/python-gitlab/pull/1816/files#diff-f8491e1894d267d0ea4bcd44eaf0e9313e2cd3d7a7a2a32bcbbb0dcba902b25e
View file https://github.com/python-gitlab/python-gitlab/blob/3d49e5e6a2bf1c9a883497acb73d7ce7115b804d/gitlab/utils.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python-gitlab/python-gitlab/pull/1816/{{ revealButtonHref }}
https://github.com/python-gitlab/python-gitlab/pull/1816/files#diff-f8491e1894d267d0ea4bcd44eaf0e9313e2cd3d7a7a2a32bcbbb0dcba902b25e
Please reload this pagehttps://github.com/python-gitlab/python-gitlab/pull/1816/files
https://github.com/python-gitlab/python-gitlab/pull/1816/files#diff-f8491e1894d267d0ea4bcd44eaf0e9313e2cd3d7a7a2a32bcbbb0dcba902b25e
https://github.com/python-gitlab/python-gitlab/pull/1816/files#diff-f8491e1894d267d0ea4bcd44eaf0e9313e2cd3d7a7a2a32bcbbb0dcba902b25e
https://github.com/python-gitlab/python-gitlab/pull/1816/files#diff-f8491e1894d267d0ea4bcd44eaf0e9313e2cd3d7a7a2a32bcbbb0dcba902b25e
gitlab/v4/cli.pyhttps://github.com/python-gitlab/python-gitlab/pull/1816/files#diff-8badc8c19001e2098ee4c85b7813eee577ce452bbfab3b220dfb54b51c6649cf
View file https://github.com/python-gitlab/python-gitlab/blob/3d49e5e6a2bf1c9a883497acb73d7ce7115b804d/gitlab/v4/cli.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python-gitlab/python-gitlab/pull/1816/{{ revealButtonHref }}
https://github.com/python-gitlab/python-gitlab/pull/1816/files#diff-8badc8c19001e2098ee4c85b7813eee577ce452bbfab3b220dfb54b51c6649cf
https://github.com/python-gitlab/python-gitlab/pull/1816/files#diff-8badc8c19001e2098ee4c85b7813eee577ce452bbfab3b220dfb54b51c6649cf
gitlab/v4/objects/features.pyhttps://github.com/python-gitlab/python-gitlab/pull/1816/files#diff-9d2825e1a93feb2117169bd1aada224295ec27bc75ceedc0d41eb739ac938721
View file https://github.com/python-gitlab/python-gitlab/blob/3d49e5e6a2bf1c9a883497acb73d7ce7115b804d/gitlab/v4/objects/features.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python-gitlab/python-gitlab/pull/1816/{{ revealButtonHref }}
https://github.com/python-gitlab/python-gitlab/pull/1816/files#diff-9d2825e1a93feb2117169bd1aada224295ec27bc75ceedc0d41eb739ac938721
https://github.com/python-gitlab/python-gitlab/pull/1816/files#diff-9d2825e1a93feb2117169bd1aada224295ec27bc75ceedc0d41eb739ac938721
gitlab/v4/objects/files.pyhttps://github.com/python-gitlab/python-gitlab/pull/1816/files#diff-beda658bbd6468e0104c6157634af2fd512fbb4d1e5abbc304b261cb39b414ca
View file https://github.com/python-gitlab/python-gitlab/blob/3d49e5e6a2bf1c9a883497acb73d7ce7115b804d/gitlab/v4/objects/files.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python-gitlab/python-gitlab/pull/1816/{{ revealButtonHref }}
https://github.com/python-gitlab/python-gitlab/pull/1816/files#diff-beda658bbd6468e0104c6157634af2fd512fbb4d1e5abbc304b261cb39b414ca
https://github.com/python-gitlab/python-gitlab/pull/1816/files#diff-beda658bbd6468e0104c6157634af2fd512fbb4d1e5abbc304b261cb39b414ca
https://github.com/python-gitlab/python-gitlab/pull/1816/files#diff-beda658bbd6468e0104c6157634af2fd512fbb4d1e5abbc304b261cb39b414ca
https://github.com/python-gitlab/python-gitlab/pull/1816/files#diff-beda658bbd6468e0104c6157634af2fd512fbb4d1e5abbc304b261cb39b414ca
https://github.com/python-gitlab/python-gitlab/pull/1816/files#diff-beda658bbd6468e0104c6157634af2fd512fbb4d1e5abbc304b261cb39b414ca
https://github.com/python-gitlab/python-gitlab/pull/1816/files#diff-beda658bbd6468e0104c6157634af2fd512fbb4d1e5abbc304b261cb39b414ca
https://github.com/python-gitlab/python-gitlab/pull/1816/files#diff-beda658bbd6468e0104c6157634af2fd512fbb4d1e5abbc304b261cb39b414ca
https://github.com/python-gitlab/python-gitlab/pull/1816/files#diff-beda658bbd6468e0104c6157634af2fd512fbb4d1e5abbc304b261cb39b414ca
https://github.com/python-gitlab/python-gitlab/pull/1816/files#diff-beda658bbd6468e0104c6157634af2fd512fbb4d1e5abbc304b261cb39b414ca
https://github.com/python-gitlab/python-gitlab/pull/1816/files#diff-beda658bbd6468e0104c6157634af2fd512fbb4d1e5abbc304b261cb39b414ca
https://github.com/python-gitlab/python-gitlab/pull/1816/files#diff-beda658bbd6468e0104c6157634af2fd512fbb4d1e5abbc304b261cb39b414ca
https://github.com/python-gitlab/python-gitlab/pull/1816/files#diff-beda658bbd6468e0104c6157634af2fd512fbb4d1e5abbc304b261cb39b414ca
gitlab/v4/objects/repositories.pyhttps://github.com/python-gitlab/python-gitlab/pull/1816/files#diff-3029f4fdc8633beef2726cddd366d5e6d14e14f595c77ab428bfd7f6cf500374
View file https://github.com/python-gitlab/python-gitlab/blob/3d49e5e6a2bf1c9a883497acb73d7ce7115b804d/gitlab/v4/objects/repositories.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python-gitlab/python-gitlab/pull/1816/{{ revealButtonHref }}
https://github.com/python-gitlab/python-gitlab/pull/1816/files#diff-3029f4fdc8633beef2726cddd366d5e6d14e14f595c77ab428bfd7f6cf500374
https://github.com/python-gitlab/python-gitlab/pull/1816/files#diff-3029f4fdc8633beef2726cddd366d5e6d14e14f595c77ab428bfd7f6cf500374
tests/functional/api/test_repository.pyhttps://github.com/python-gitlab/python-gitlab/pull/1816/files#diff-bc4950f989e49d8e56dd4918b3d47e63bf3b2cbe163f8c463d512f6567f2a9c3
View file https://github.com/python-gitlab/python-gitlab/blob/3d49e5e6a2bf1c9a883497acb73d7ce7115b804d/tests/functional/api/test_repository.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python-gitlab/python-gitlab/pull/1816/{{ revealButtonHref }}
https://github.com/python-gitlab/python-gitlab/pull/1816/files#diff-bc4950f989e49d8e56dd4918b3d47e63bf3b2cbe163f8c463d512f6567f2a9c3
https://github.com/python-gitlab/python-gitlab/pull/1816/files#diff-bc4950f989e49d8e56dd4918b3d47e63bf3b2cbe163f8c463d512f6567f2a9c3
https://github.com/python-gitlab/python-gitlab/pull/1816/files#diff-bc4950f989e49d8e56dd4918b3d47e63bf3b2cbe163f8c463d512f6567f2a9c3
tests/unit/test_utils.pyhttps://github.com/python-gitlab/python-gitlab/pull/1816/files#diff-a28b281ee0902c932527e269c585ac109bdd98aa5ceebe05ca97a10a5a432651
View file https://github.com/python-gitlab/python-gitlab/blob/3d49e5e6a2bf1c9a883497acb73d7ce7115b804d/tests/unit/test_utils.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python-gitlab/python-gitlab/pull/1816/{{ revealButtonHref }}
https://github.com/python-gitlab/python-gitlab/pull/1816/files#diff-a28b281ee0902c932527e269c585ac109bdd98aa5ceebe05ca97a10a5a432651
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.