René's URL Explorer Experiment


Title: fix: remove custom URL encoding by JohnVillalovos · Pull Request #1816 · python-gitlab/python-gitlab · GitHub

Open Graph Title: fix: remove custom URL encoding by JohnVillalovos · Pull Request #1816 · python-gitlab/python-gitlab

X Title: fix: remove custom URL encoding by JohnVillalovos · Pull Request #1816 · python-gitlab/python-gitlab

Description: We were using str.replace() calls to take care of URL encoding issues. Switch them to use our utils._url_encode() function which itself uses urllib.parse.quote() Closes: #1356

Open Graph Description: We were using str.replace() calls to take care of URL encoding issues. Switch them to use our utils._url_encode() function which itself uses urllib.parse.quote() Closes: #1356

X Description: We were using str.replace() calls to take care of URL encoding issues. Switch them to use our utils._url_encode() function which itself uses urllib.parse.quote() Closes: #1356

Opengraph URL: https://github.com/python-gitlab/python-gitlab/pull/1816

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:9d149351-b9df-de37-5452-659b0f9be854
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id94E0:AF22:732536:A319BB:69724CCF
html-safe-nonce89c28a4dc1d2b90fae16d690adcde6b86a9297a1a0b5592644e1ef5eb81e5c30
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5NEUwOkFGMjI6NzMyNTM2OkEzMTlCQjo2OTcyNENDRiIsInZpc2l0b3JfaWQiOiI1NzU5MTE5NzQyMDEwMDE5MDIzIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac3bb0309a60fd8180de5053a7ff3ead093762f4f0326433dacf81487957599f0e
hovercard-subject-tagpull_request:816931495
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python-gitlab/python-gitlab/1816/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/d5d5bcccefa5ddf37678117107cfd25337d56f1753ecda28aa4b62dfd49c618a/python-gitlab/python-gitlab/pull/1816
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/d5d5bcccefa5ddf37678117107cfd25337d56f1753ecda28aa4b62dfd49c618a/python-gitlab/python-gitlab/pull/1816
og:image:altWe were using str.replace() calls to take care of URL encoding issues. Switch them to use our utils._url_encode() function which itself uses urllib.parse.quote() Closes: #1356
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameJohnVillalovos
hostnamegithub.com
expected-hostnamegithub.com
None0bf8f9c572ee803398ae08d37b5c4215b9e90e3afebbe4c722ebdecb8f680830
turbo-cache-controlno-preview
go-importgithub.com/python-gitlab/python-gitlab git https://github.com/python-gitlab/python-gitlab.git
octolytics-dimension-user_id28886265
octolytics-dimension-user_loginpython-gitlab
octolytics-dimension-repository_id8077625
octolytics-dimension-repository_nwopython-gitlab/python-gitlab
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id8077625
octolytics-dimension-repository_network_root_nwopython-gitlab/python-gitlab
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasef1a765aea9b6f5dcd4bf980043cb1434723fac64
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python-gitlab/python-gitlab/pull/1816#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython-gitlab%2Fpython-gitlab%2Fpull%2F1816
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython-gitlab%2Fpython-gitlab%2Fpull%2F1816
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python-gitlab%2Fpython-gitlab
Reloadhttps://github.com/python-gitlab/python-gitlab/pull/1816
Reloadhttps://github.com/python-gitlab/python-gitlab/pull/1816
Reloadhttps://github.com/python-gitlab/python-gitlab/pull/1816
python-gitlab https://github.com/python-gitlab
python-gitlabhttps://github.com/python-gitlab/python-gitlab
Notifications https://github.com/login?return_to=%2Fpython-gitlab%2Fpython-gitlab
Fork 675 https://github.com/login?return_to=%2Fpython-gitlab%2Fpython-gitlab
Star 2.4k https://github.com/login?return_to=%2Fpython-gitlab%2Fpython-gitlab
Code https://github.com/python-gitlab/python-gitlab
Issues 26 https://github.com/python-gitlab/python-gitlab/issues
Pull requests 10 https://github.com/python-gitlab/python-gitlab/pulls
Discussions https://github.com/python-gitlab/python-gitlab/discussions
Actions https://github.com/python-gitlab/python-gitlab/actions
Projects 0 https://github.com/python-gitlab/python-gitlab/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python-gitlab/python-gitlab/security
Please reload this pagehttps://github.com/python-gitlab/python-gitlab/pull/1816
Insights https://github.com/python-gitlab/python-gitlab/pulse
Code https://github.com/python-gitlab/python-gitlab
Issues https://github.com/python-gitlab/python-gitlab/issues
Pull requests https://github.com/python-gitlab/python-gitlab/pulls
Discussions https://github.com/python-gitlab/python-gitlab/discussions
Actions https://github.com/python-gitlab/python-gitlab/actions
Projects https://github.com/python-gitlab/python-gitlab/projects
Security https://github.com/python-gitlab/python-gitlab/security
Insights https://github.com/python-gitlab/python-gitlab/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython-gitlab%2Fpython-gitlab%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython-gitlab%2Fpython-gitlab%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/python-gitlab/python-gitlab/pull/1816#issue-comment-box
nejchhttps://github.com/nejch
mainhttps://github.com/python-gitlab/python-gitlab/tree/main
jlvillal/remove_replacehttps://github.com/python-gitlab/python-gitlab/tree/jlvillal/remove_replace
fix: remove custom URL encoding https://github.com/python-gitlab/python-gitlab/pull/1816#top
nejchhttps://github.com/nejch
mainhttps://github.com/python-gitlab/python-gitlab/tree/main
jlvillal/remove_replacehttps://github.com/python-gitlab/python-gitlab/tree/jlvillal/remove_replace
Conversation 11 https://github.com/python-gitlab/python-gitlab/pull/1816
Commits 1 https://github.com/python-gitlab/python-gitlab/pull/1816/commits
Checks 0 https://github.com/python-gitlab/python-gitlab/pull/1816/checks
Files changed https://github.com/python-gitlab/python-gitlab/pull/1816/files
Please reload this pagehttps://github.com/python-gitlab/python-gitlab/pull/1816
https://github.co/hiddenchars
https://github.com/python-gitlab/python-gitlab/pull/{{ revealButtonHref }}
https://github.com/JohnVillalovos
JohnVillalovoshttps://github.com/JohnVillalovos
Jan 8, 2022https://github.com/python-gitlab/python-gitlab/pull/1816#issue-1097047088
Please reload this pagehttps://github.com/python-gitlab/python-gitlab/pull/1816
#1356https://github.com/python-gitlab/python-gitlab/issues/1356
Please reload this pagehttps://github.com/python-gitlab/python-gitlab/pull/1816
https://github.com/JohnVillalovos
JohnVillalovoshttps://github.com/JohnVillalovos
nejchhttps://github.com/nejch
January 8, 2022 22:14https://github.com/python-gitlab/python-gitlab/pull/1816#event-5861682348
https://github.com/JohnVillalovos
JohnVillalovoshttps://github.com/JohnVillalovos
force-pushedhttps://github.com/python-gitlab/python-gitlab/compare/8c17afafcc7d9d2a8fecb53b853c2b4f004c4121..2a209c3bb746e6da0a107db16803fe0eb323e86f
8c17afahttps://github.com/python-gitlab/python-gitlab/commit/8c17afafcc7d9d2a8fecb53b853c2b4f004c4121
2a209c3https://github.com/python-gitlab/python-gitlab/commit/2a209c3bb746e6da0a107db16803fe0eb323e86f
Compare https://github.com/python-gitlab/python-gitlab/compare/8c17afafcc7d9d2a8fecb53b853c2b4f004c4121..2a209c3bb746e6da0a107db16803fe0eb323e86f
January 8, 2022 22:23https://github.com/python-gitlab/python-gitlab/pull/1816#event-5861688777
https://github.com/codecov-commenter
codecov-commenterhttps://github.com/codecov-commenter
Jan 8, 2022https://github.com/python-gitlab/python-gitlab/pull/1816#issuecomment-1008167735
Please reload this pagehttps://github.com/python-gitlab/python-gitlab/pull/1816
Codecovhttps://codecov.io/gh/python-gitlab/python-gitlab/pull/1816?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=python-gitlab
#1816https://codecov.io/gh/python-gitlab/python-gitlab/pull/1816?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=python-gitlab
3d49e5ehttps://github.com/python-gitlab/python-gitlab/commit/3d49e5e6a2bf1c9a883497acb73d7ce7115b804d
mainhttps://codecov.io/gh/python-gitlab/python-gitlab/commit/0dba899c20dda3a9789992a1186cfd718e5b588f?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=python-gitlab
0dba899https://github.com/python-gitlab/python-gitlab/commit/0dba899c20dda3a9789992a1186cfd718e5b588f
Click herehttps://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=python-gitlab#carryforward-flags-in-the-pull-request-comment
Impacted Fileshttps://codecov.io/gh/python-gitlab/python-gitlab/pull/1816?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=python-gitlab
gitlab/v4/objects/features.pyhttps://codecov.io/gh/python-gitlab/python-gitlab/pull/1816/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=python-gitlab#diff-Z2l0bGFiL3Y0L29iamVjdHMvZmVhdHVyZXMucHk=
gitlab/mixins.pyhttps://codecov.io/gh/python-gitlab/python-gitlab/pull/1816/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=python-gitlab#diff-Z2l0bGFiL21peGlucy5weQ==
gitlab/utils.pyhttps://codecov.io/gh/python-gitlab/python-gitlab/pull/1816/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=python-gitlab#diff-Z2l0bGFiL3V0aWxzLnB5
gitlab/v4/cli.pyhttps://codecov.io/gh/python-gitlab/python-gitlab/pull/1816/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=python-gitlab#diff-Z2l0bGFiL3Y0L2NsaS5weQ==
gitlab/v4/objects/files.pyhttps://codecov.io/gh/python-gitlab/python-gitlab/pull/1816/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=python-gitlab#diff-Z2l0bGFiL3Y0L29iamVjdHMvZmlsZXMucHk=
gitlab/v4/objects/repositories.pyhttps://codecov.io/gh/python-gitlab/python-gitlab/pull/1816/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=python-gitlab#diff-Z2l0bGFiL3Y0L29iamVjdHMvcmVwb3NpdG9yaWVzLnB5
Please reload this pagehttps://github.com/python-gitlab/python-gitlab/pull/1816
https://github.com/nejch
nejchhttps://github.com/nejch
Jan 8, 2022 https://github.com/python-gitlab/python-gitlab/pull/1816#pullrequestreview-847199967
View reviewed changes https://github.com/python-gitlab/python-gitlab/pull/1816/files
nejchhttps://github.com/nejch
https://github.com/python-gitlab/python-gitlab/pull/1816#pullrequestreview-847199967
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python-gitlab/python-gitlab/pull/1816
gitlab/utils.pyhttps://github.com/python-gitlab/python-gitlab/pull/1816/files#diff-f8491e1894d267d0ea4bcd44eaf0e9313e2cd3d7a7a2a32bcbbb0dcba902b25e
Please reload this pagehttps://github.com/python-gitlab/python-gitlab/pull/1816
gitlab/utils.pyhttps://github.com/python-gitlab/python-gitlab/pull/1816/files#diff-f8491e1894d267d0ea4bcd44eaf0e9313e2cd3d7a7a2a32bcbbb0dcba902b25e
Please reload this pagehttps://github.com/python-gitlab/python-gitlab/pull/1816
gitlab/v4/objects/files.pyhttps://github.com/python-gitlab/python-gitlab/pull/1816/files#diff-beda658bbd6468e0104c6157634af2fd512fbb4d1e5abbc304b261cb39b414ca
Please reload this pagehttps://github.com/python-gitlab/python-gitlab/pull/1816
https://github.com/JohnVillalovos
JohnVillalovoshttps://github.com/JohnVillalovos
force-pushedhttps://github.com/python-gitlab/python-gitlab/compare/ca85f9348daa99612f0b47623a1531eb35843288..94dd1e05b8dc591bfe7c1c82339c1c5e05c35a92
ca85f93https://github.com/python-gitlab/python-gitlab/commit/ca85f9348daa99612f0b47623a1531eb35843288
94dd1e0https://github.com/python-gitlab/python-gitlab/commit/94dd1e05b8dc591bfe7c1c82339c1c5e05c35a92
Compare https://github.com/python-gitlab/python-gitlab/compare/ca85f9348daa99612f0b47623a1531eb35843288..94dd1e05b8dc591bfe7c1c82339c1c5e05c35a92
January 8, 2022 23:43https://github.com/python-gitlab/python-gitlab/pull/1816#event-5861740830
https://github.com/nejch
nejchhttps://github.com/nejch
Jan 9, 2022https://github.com/python-gitlab/python-gitlab/pull/1816#issuecomment-1008188771
Please reload this pagehttps://github.com/python-gitlab/python-gitlab/pull/1816
https://github.com/JohnVillalovos
fix: remove custom URL encodinghttps://github.com/python-gitlab/python-gitlab/pull/1816/commits/3d49e5e6a2bf1c9a883497acb73d7ce7115b804d
3d49e5ehttps://github.com/python-gitlab/python-gitlab/pull/1816/commits/3d49e5e6a2bf1c9a883497acb73d7ce7115b804d
#1356https://github.com/python-gitlab/python-gitlab/issues/1356
https://github.com/JohnVillalovos
JohnVillalovoshttps://github.com/JohnVillalovos
force-pushedhttps://github.com/python-gitlab/python-gitlab/compare/94dd1e05b8dc591bfe7c1c82339c1c5e05c35a92..3d49e5e6a2bf1c9a883497acb73d7ce7115b804d
94dd1e0https://github.com/python-gitlab/python-gitlab/commit/94dd1e05b8dc591bfe7c1c82339c1c5e05c35a92
3d49e5ehttps://github.com/python-gitlab/python-gitlab/commit/3d49e5e6a2bf1c9a883497acb73d7ce7115b804d
Compare https://github.com/python-gitlab/python-gitlab/compare/94dd1e05b8dc591bfe7c1c82339c1c5e05c35a92..3d49e5e6a2bf1c9a883497acb73d7ce7115b804d
January 9, 2022 00:19https://github.com/python-gitlab/python-gitlab/pull/1816#event-5861767805
https://github.com/JohnVillalovos
JohnVillalovoshttps://github.com/JohnVillalovos
nejchhttps://github.com/nejch
January 9, 2022 00:20https://github.com/python-gitlab/python-gitlab/pull/1816#event-5861768075
https://github.com/nejch
nejchhttps://github.com/nejch
Jan 9, 2022https://github.com/python-gitlab/python-gitlab/pull/1816#event-5861782529
https://github.com/nejch
nejchhttps://github.com/nejch
24d2766https://github.com/python-gitlab/python-gitlab/commit/24d27662caec641a9834b10a3e7269ba63c2b389
Jan 9, 2022https://github.com/python-gitlab/python-gitlab/pull/1816#event-5861789118
https://github.com/nejch
nejchhttps://github.com/nejch
January 9, 2022 00:55https://github.com/python-gitlab/python-gitlab/pull/1816#event-5861789130
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython-gitlab%2Fpython-gitlab%2Fpull%2F1816
https://github.com/nejch
nejch https://github.com/nejch
Get rid of all custom URL encoding https://github.com/python-gitlab/python-gitlab/issues/1356
Please reload this pagehttps://github.com/python-gitlab/python-gitlab/pull/1816
https://github.com/JohnVillalovos
https://github.com/codecov-commenter
https://github.com/nejch
https://github.com/apps/copilot-swe-agent
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.