René's URL Explorer Experiment


Title: fix: raise error if there is a 301/302 redirection by JohnVillalovos · Pull Request #1486 · python-gitlab/python-gitlab · GitHub

Open Graph Title: fix: raise error if there is a 301/302 redirection by JohnVillalovos · Pull Request #1486 · python-gitlab/python-gitlab

X Title: fix: raise error if there is a 301/302 redirection by JohnVillalovos · Pull Request #1486 · python-gitlab/python-gitlab

Description: Before we raised an error if there was a 301, 302 redirect but only from an http URL to an https URL. But we didn't raise an error for any other redirects. This caused two problems: PUT requests that are redirected get changed to GET requests which don't perform the desired action but raise no error. This is because the GET response succeeds but since it wasn't a PUT it doesn't update. See issue: #1432 POST requests that are redirected also got changed to GET requests. They also caused hard to debug tracebacks for the user. See issue: #1477 Correct this by always raising a RedirectError exception and improve the exception message to let them know what was redirected. Closes: #1485 Closes: #1432 Closes: #1477

Open Graph Description: Before we raised an error if there was a 301, 302 redirect but only from an http URL to an https URL. But we didn't raise an error for any other redirects. This caused two problems: PUT reque...

X Description: Before we raised an error if there was a 301, 302 redirect but only from an http URL to an https URL. But we didn't raise an error for any other redirects. This caused two problems: PUT r...

Opengraph URL: https://github.com/python-gitlab/python-gitlab/pull/1486

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:a945ac55-8ef8-deef-f216-d1cc1e6399f2
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idAF14:3A860B:2057FAC:2DB32C0:6978F950
html-safe-noncec81abc226061ac875aa6c32dd5646e5bc57c0c53025dde948c6da4b62cab884d
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBRjE0OjNBODYwQjoyMDU3RkFDOjJEQjMyQzA6Njk3OEY5NTAiLCJ2aXNpdG9yX2lkIjoiODY5NDE0MDAzMDkwMjkyNTY0OSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac32f4408a332fb6a90d9fe3b8f9d443c96462f1475d9986bb29f4950482fabf63
hovercard-subject-tagpull_request:657834403
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python-gitlab/python-gitlab/pull/1486/files
twitter:imagehttps://avatars.githubusercontent.com/u/578155?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/578155?s=400&v=4
og:image:altBefore we raised an error if there was a 301, 302 redirect but only from an http URL to an https URL. But we didn't raise an error for any other redirects. This caused two problems: PUT reque...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None6d9b384ce19e0ac9756580c70eae9a3359939e77ff05c731561090d13085b2b7
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python-gitlab/python-gitlab git https://github.com/python-gitlab/python-gitlab.git
octolytics-dimension-user_id28886265
octolytics-dimension-user_loginpython-gitlab
octolytics-dimension-repository_id8077625
octolytics-dimension-repository_nwopython-gitlab/python-gitlab
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id8077625
octolytics-dimension-repository_network_root_nwopython-gitlab/python-gitlab
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release56ad33f6fdc0d0fb49c96b3c46ed74c55d926471
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python-gitlab/python-gitlab/pull/1486/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython-gitlab%2Fpython-gitlab%2Fpull%2F1486%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython-gitlab%2Fpython-gitlab%2Fpull%2F1486%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python-gitlab%2Fpython-gitlab
Reloadhttps://github.com/python-gitlab/python-gitlab/pull/1486/files
Reloadhttps://github.com/python-gitlab/python-gitlab/pull/1486/files
Reloadhttps://github.com/python-gitlab/python-gitlab/pull/1486/files
python-gitlab https://github.com/python-gitlab
python-gitlabhttps://github.com/python-gitlab/python-gitlab
Notifications https://github.com/login?return_to=%2Fpython-gitlab%2Fpython-gitlab
Fork 675 https://github.com/login?return_to=%2Fpython-gitlab%2Fpython-gitlab
Star 2.4k https://github.com/login?return_to=%2Fpython-gitlab%2Fpython-gitlab
Code https://github.com/python-gitlab/python-gitlab
Issues 26 https://github.com/python-gitlab/python-gitlab/issues
Pull requests 11 https://github.com/python-gitlab/python-gitlab/pulls
Discussions https://github.com/python-gitlab/python-gitlab/discussions
Actions https://github.com/python-gitlab/python-gitlab/actions
Projects 0 https://github.com/python-gitlab/python-gitlab/projects
Security 0 https://github.com/python-gitlab/python-gitlab/security
Insights https://github.com/python-gitlab/python-gitlab/pulse
Code https://github.com/python-gitlab/python-gitlab
Issues https://github.com/python-gitlab/python-gitlab/issues
Pull requests https://github.com/python-gitlab/python-gitlab/pulls
Discussions https://github.com/python-gitlab/python-gitlab/discussions
Actions https://github.com/python-gitlab/python-gitlab/actions
Projects https://github.com/python-gitlab/python-gitlab/projects
Security https://github.com/python-gitlab/python-gitlab/security
Insights https://github.com/python-gitlab/python-gitlab/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython-gitlab%2Fpython-gitlab%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython-gitlab%2Fpython-gitlab%2Fissues%2Fnew%2Fchoose
nejchhttps://github.com/nejch
python-gitlab:masterhttps://github.com/python-gitlab/python-gitlab/tree/master
Conversation 38 https://github.com/python-gitlab/python-gitlab/pull/1486
Commits 1 https://github.com/python-gitlab/python-gitlab/pull/1486/commits
Checks 0 https://github.com/python-gitlab/python-gitlab/pull/1486/checks
Files changed https://github.com/python-gitlab/python-gitlab/pull/1486/files
Please reload this pagehttps://github.com/python-gitlab/python-gitlab/pull/1486/files
fix: raise error if there is a 301/302 redirection https://github.com/python-gitlab/python-gitlab/pull/1486/files#top
Show all changes 1 commit https://github.com/python-gitlab/python-gitlab/pull/1486/files
d56a434 fix!: raise error if there is a 301/302 redirection JohnVillalovos May 30, 2021 https://github.com/python-gitlab/python-gitlab/pull/1486/commits/d56a4345c1ae05823b553e386bfa393541117467
Clear filters https://github.com/python-gitlab/python-gitlab/pull/1486/files
Please reload this pagehttps://github.com/python-gitlab/python-gitlab/pull/1486/files
Please reload this pagehttps://github.com/python-gitlab/python-gitlab/pull/1486/files
api-usage.rst https://github.com/python-gitlab/python-gitlab/pull/1486/files#diff-9c4257f0d19eefff9116d1485d277b4f55ca1e44d5780ec45b870663b3e8ce90
cli-usage.rst https://github.com/python-gitlab/python-gitlab/pull/1486/files#diff-e9228e16d54c7ce5e0e84e9571be5627b546be6dffd3f755b09c10971f0f106c
client.py https://github.com/python-gitlab/python-gitlab/pull/1486/files#diff-cfa2b05f7b559e334405867e2c02564c88032f0dee928f61cba4b84d3d680886
test_gitlab_http_methods.py https://github.com/python-gitlab/python-gitlab/pull/1486/files#diff-abdb153ac479ac4868032ad1a287a1be3c0627eba1d9e67defbda908d929115a
docs/api-usage.rsthttps://github.com/python-gitlab/python-gitlab/pull/1486/files#diff-9c4257f0d19eefff9116d1485d277b4f55ca1e44d5780ec45b870663b3e8ce90
View file https://github.com/python-gitlab/python-gitlab/blob/d56a4345c1ae05823b553e386bfa393541117467/docs/api-usage.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python-gitlab/python-gitlab/pull/1486/{{ revealButtonHref }}
https://github.com/python-gitlab/python-gitlab/pull/1486/files#diff-9c4257f0d19eefff9116d1485d277b4f55ca1e44d5780ec45b870663b3e8ce90
https://github.com/python-gitlab/python-gitlab/pull/1486/files#diff-9c4257f0d19eefff9116d1485d277b4f55ca1e44d5780ec45b870663b3e8ce90
https://github.com/python-gitlab/python-gitlab/pull/1486/files#diff-9c4257f0d19eefff9116d1485d277b4f55ca1e44d5780ec45b870663b3e8ce90
https://github.com/python-gitlab/python-gitlab/pull/1486/files#diff-9c4257f0d19eefff9116d1485d277b4f55ca1e44d5780ec45b870663b3e8ce90
docs/cli-usage.rsthttps://github.com/python-gitlab/python-gitlab/pull/1486/files#diff-e9228e16d54c7ce5e0e84e9571be5627b546be6dffd3f755b09c10971f0f106c
View file https://github.com/python-gitlab/python-gitlab/blob/d56a4345c1ae05823b553e386bfa393541117467/docs/cli-usage.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python-gitlab/python-gitlab/pull/1486/{{ revealButtonHref }}
https://github.com/python-gitlab/python-gitlab/pull/1486/files#diff-e9228e16d54c7ce5e0e84e9571be5627b546be6dffd3f755b09c10971f0f106c
https://github.com/python-gitlab/python-gitlab/pull/1486/files#diff-e9228e16d54c7ce5e0e84e9571be5627b546be6dffd3f755b09c10971f0f106c
https://github.com/python-gitlab/python-gitlab/pull/1486/files#diff-e9228e16d54c7ce5e0e84e9571be5627b546be6dffd3f755b09c10971f0f106c
gitlab/client.pyhttps://github.com/python-gitlab/python-gitlab/pull/1486/files#diff-cfa2b05f7b559e334405867e2c02564c88032f0dee928f61cba4b84d3d680886
View file https://github.com/python-gitlab/python-gitlab/blob/d56a4345c1ae05823b553e386bfa393541117467/gitlab/client.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python-gitlab/python-gitlab/pull/1486/{{ revealButtonHref }}
https://github.com/python-gitlab/python-gitlab/pull/1486/files#diff-cfa2b05f7b559e334405867e2c02564c88032f0dee928f61cba4b84d3d680886
Please reload this pagehttps://github.com/python-gitlab/python-gitlab/pull/1486/files
https://github.com/python-gitlab/python-gitlab/pull/1486/files#diff-cfa2b05f7b559e334405867e2c02564c88032f0dee928f61cba4b84d3d680886
https://github.com/python-gitlab/python-gitlab/pull/1486/files#diff-cfa2b05f7b559e334405867e2c02564c88032f0dee928f61cba4b84d3d680886
https://github.com/python-gitlab/python-gitlab/pull/1486/files#diff-cfa2b05f7b559e334405867e2c02564c88032f0dee928f61cba4b84d3d680886
tests/unit/test_gitlab_http_methods.pyhttps://github.com/python-gitlab/python-gitlab/pull/1486/files#diff-abdb153ac479ac4868032ad1a287a1be3c0627eba1d9e67defbda908d929115a
View file https://github.com/python-gitlab/python-gitlab/blob/d56a4345c1ae05823b553e386bfa393541117467/tests/unit/test_gitlab_http_methods.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python-gitlab/python-gitlab/pull/1486/{{ revealButtonHref }}
https://github.com/python-gitlab/python-gitlab/pull/1486/files#diff-abdb153ac479ac4868032ad1a287a1be3c0627eba1d9e67defbda908d929115a
https://github.com/python-gitlab/python-gitlab/pull/1486/files#diff-abdb153ac479ac4868032ad1a287a1be3c0627eba1d9e67defbda908d929115a
https://github.com/python-gitlab/python-gitlab/pull/1486/files#diff-abdb153ac479ac4868032ad1a287a1be3c0627eba1d9e67defbda908d929115a
Please reload this pagehttps://github.com/python-gitlab/python-gitlab/pull/1486/files
https://github.com/python-gitlab/python-gitlab/pull/1486/files#diff-abdb153ac479ac4868032ad1a287a1be3c0627eba1d9e67defbda908d929115a
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.