René's URL Explorer Experiment

{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"ProjectMergeRequest.save() discards _optional_get_attrs","articleBody":"## Description of the problem, including code/CLI snippet\r\nWhen we request the MR object we can specify extra attributes to be returned to us. Once instantiated if we update part of the object and _.save()_ it, our object loses these attributes.\r\n\r\n## Expected Behavior\r\nThe optional key:value in the MR attribute data should be retained\r\n\r\n## Actual Behavior\r\nThe keys and values for these particular attributes are lost\r\n\r\n## Specifications\r\n\r\n  - python-gitlab version:\r\n    - 3.4.0 \r\n  - API version you are using (v3/v4):\r\n    - v4\r\n  - Gitlab server version (or gitlab.com):\r\n    - 13.12.10-ee\r\n\r\nHere is a patch to retain these attributes across the _.save()_ method. I'm working on a PR for this but _tox_ is blowing up.\r\n\r\n```diff\r\ndiff --git a/gitlab/mixins.py b/gitlab/mixins.py\r\nindex 1a3ff4d..1af1b2e 100644\r\n--- a/gitlab/mixins.py\r\n+++ b/gitlab/mixins.py\r\n@@ -548,11 +548,29 @@ class SaveMixin(_RestObjectBase):\r\n         if not updated_data:\r\n             return None\r\n \r\n+        # we need to save these attribute values across the .save() method\r\n+        # or they'll be lost. the user didn't ask us to reload the MR object\r\n+        # so be minimal in our actions\r\n+        save_across_update = {}\r\n+        for attr in self.manager._optional_get_attrs:\r\n+            find_attr = attr\r\n+            if find_attr.startswith(\"include_\"):\r\n+                find_attr = find_attr[8:]\r\n+            if find_attr in self._attrs:\r\n+                save_across_update[find_attr] = self._attrs[find_attr]\r\n+\r\n         # call the manager\r\n         obj_id = self.encoded_id\r\n         if TYPE_CHECKING:\r\n             assert isinstance(self.manager, UpdateMixin)\r\n         server_data = self.manager.update(obj_id, updated_data, **kwargs)\r\n+\r\n+        # restore the optional requested attributes lost when we did the .save()\r\n+        # the gitlab REST API doesn't offer a way to request these attributes\r\n+        # during the POST operation thus we can't blindly overwrite our existing\r\n+        # data with the new data\r\n+        server_data.update(save_across_update)\r\n+\r\n         self._update_attrs(server_data)\r\n         return server_data\r\n\r\n```","author":{"url":"https://github.com/FirefighterBlu3","@type":"Person","name":"FirefighterBlu3"},"datePublished":"2022-05-05T13:41:21.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":6},"url":"https://github.com/2007/python-gitlab/issues/2007"}