Title: Fix typo in ICSystem updfcn, outfcn: update_params -> _update_params by murrayrm · Pull Request #990 · python-control/python-control · GitHub
Open Graph Title: Fix typo in ICSystem updfcn, outfcn: update_params -> _update_params by murrayrm · Pull Request #990 · python-control/python-control
X Title: Fix typo in ICSystem updfcn, outfcn: update_params -> _update_params by murrayrm · Pull Request #990 · python-control/python-control
Description: This PR fixes a bug in the InterconnectedSystem class, where the updfcn and outfcn methods call update_params instead of _update_params. This bug didn't who up because there were no direct calls to updfcn and outfcn for an IC system. However, these show up in the new phaseplot module code, so it can generate a error. Simple fix; just adding an underscore in two places (and a unit test to uncover the bug).
Open Graph Description: This PR fixes a bug in the InterconnectedSystem class, where the updfcn and outfcn methods call update_params instead of _update_params. This bug didn't who up because there were no direct cal...
X Description: This PR fixes a bug in the InterconnectedSystem class, where the updfcn and outfcn methods call update_params instead of _update_params. This bug didn't who up because there were no direct...
Opengraph URL: https://github.com/python-control/python-control/pull/990
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/checks(.:format) |
| route-controller | pull_requests |
| route-action | checks |
| fetch-nonce | v2:87c412bb-7cff-2dfa-59d0-8fafba20697f |
| current-catalog-service-hash | 87dc3bc62d9b466312751bfd5f889726f4f1337bdff4e8be7da7c93d6c00a25a |
| request-id | E822:6DFF8:862EC2:BB5638:6979C47D |
| html-safe-nonce | 79e548fbd4cc62ed3b089858bd5dbe25f8125d2b9eab9280734d5578a493c752 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFODIyOjZERkY4Ojg2MkVDMjpCQjU2Mzg6Njk3OUM0N0QiLCJ2aXNpdG9yX2lkIjoiMjUxMzQ0ODU5NDgwODM1MTk3IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | ae942beadcd544baa264ac1988aa2328152542dd309f98fc6ec5f6df17fe1a71 |
| hovercard-subject-tag | pull_request:1811145358 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,checks,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/python-control/python-control/pull/990/checks |
| twitter:image | https://avatars.githubusercontent.com/u/293362?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/293362?s=400&v=4 |
| og:image:alt | This PR fixes a bug in the InterconnectedSystem class, where the updfcn and outfcn methods call update_params instead of _update_params. This bug didn't who up because there were no direct cal... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | c049b65ec7e54cbf2521f5a560b6527714c612b0bd169188e2ea6e16f83bd5f4 |
| turbo-cache-control | no-preview |
| go-import | github.com/python-control/python-control git https://github.com/python-control/python-control.git |
| octolytics-dimension-user_id | 2285872 |
| octolytics-dimension-user_login | python-control |
| octolytics-dimension-repository_id | 22791752 |
| octolytics-dimension-repository_nwo | python-control/python-control |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 22791752 |
| octolytics-dimension-repository_network_root_nwo | python-control/python-control |
| turbo-body-classes | logged-out env-production page-responsive full-width full-width-p-0 |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 87b137883e35e2766c3d0f6a257c4044f6390b83 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width