René's URL Explorer Experiment


Title: Update pole/zero and root locus plots to use _map/_plot pattern by murrayrm · Pull Request #953 · python-control/python-control · GitHub

Open Graph Title: Update pole/zero and root locus plots to use _map/_plot pattern by murrayrm · Pull Request #953 · python-control/python-control

X Title: Update pole/zero and root locus plots to use _map/_plot pattern by murrayrm · Pull Request #953 · python-control/python-control

Description: This PR updates pole/zero and root locus plots to use the _map/_plot calling pattern described in #645. The following patterns will work: rldata = ct.root_locus_map(syslist[, klist]) lines = rldata.plot(plot_options) lines = ct.root_locus_plot(response[, klist, plot_options]) ct.root_locus(sys) ct.rlocus(sys) ct.pole_zero_map(sys).plot() ct.pole_zero_plot(sys) ct.pzmap(sys) Everything is mostly backwards compatible except that the outputs from a _plot function are now an array of Line2D objects instead of the roots and gains. You can still get the original data using the _map function and there is some legacy processing if you used the plot keyword to try let some code work without changes. Summary of changes: All pole/zero and root locus plots now have a _map function and a _plot function. You can access the latter via the .plot() method on the response. The _plot functions accept either the output of the _map function or a list of systems (in which case the _map function is called internally). This allows the common pattern of pole_zero_plot(sys), root_locus_plot(sys) to work as expected. The interactive mode for root locus plots is on by default (it used to be there only within sisotool). Clicking on a portion of the root locus diagram will generate markers at the locations on the loci corresponding to that gain and add a message above the plot giving the frequency and damping ratio for the point that was clicked. The print_gain keyword is replaced with interactive. The (deprecated) Plot keyword is now plot (and generates a warning, since it triggers the legacy return values). Recalculation of the root locus plot when zooming no longer works (you can still zoom in and out, you just don't get a recalculated curve). The short versions pzmap and rlocus are still there. The control.matlab version of rlocus returns roots, gains (compatible with MATLAB) Added unit tests plus user documentation. Some other small fixes, code streamlining, etc along the way. This PR is going to break existing code. It would be great if a few people could try this out so that we can make sure we are OK with the changes here. Examples (from the user documentation): Pole/zero maps and root locus diagrams provide insights into system response based on the locations of system poles and zeros in the complex plane. The pole_zero_map() function returns the poles and zeros and can be used to generate a pole/zero plot: sys = ct.tf([1, 2], [1, 2, 3], name='SISO transfer function') response = ct.pole_zero_map(sys) ct.pole_zero_plot(response) A root locus plot shows the location of the closed loop poles of a system as a function of the loop gain: ct.root_locus_map(sys).plot() The grid in the left hand plane shows lines of constant damping ratio as well as arcs corresponding to the frequency of the complex pole. The grid can be turned off using the grid keyword. Setting grid to False will turn off the grid but show the real and imaginary axis. To completely remove all lines except the root loci, use grid=’empty’. On systems that support interactive plots, clicking on a location on the root locus diagram will mark the pole locations on all branches of the diagram and display the gain and damping ratio below the plot title: Root locus diagrams are also supported for discrete time systems, in which case the grid is show inside the unit circle: sysd = sys.sample(0.1) ct.root_locus_plot(sysd) Lists of systems can also be given, in which case the root locus diagram for each system is plotted in different colors: sys1 = ct.tf([1], [1, 2, 1], name='sys1') sys2 = ct.tf([1, 0.2], [1, 1, 3, 1, 1], name='sys2') ct.root_locus_plot([sys1, sys2], grid=False)

Open Graph Description: This PR updates pole/zero and root locus plots to use the _map/_plot calling pattern described in #645. The following patterns will work: rldata = ct.root_locus_map(syslist[, klist]) lines = rldata...

X Description: This PR updates pole/zero and root locus plots to use the _map/_plot calling pattern described in #645. The following patterns will work: rldata = ct.root_locus_map(syslist[, klist]) lines = rldata...

Opengraph URL: https://github.com/python-control/python-control/pull/953

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/checks(.:format)
route-controllerpull_requests
route-actionchecks
fetch-noncev2:7eaba624-c093-55ba-a929-18272c4bd5f7
current-catalog-service-hash87dc3bc62d9b466312751bfd5f889726f4f1337bdff4e8be7da7c93d6c00a25a
request-idE308:2A8A53:2156AA:2E9DD8:697B4020
html-safe-nonce363230a6f4856824a7c8f335cfb0cd3ce9aa6a9c864978766edaf9cad665ed43
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFMzA4OjJBOEE1MzoyMTU2QUE6MkU5REQ4OjY5N0I0MDIwIiwidmlzaXRvcl9pZCI6IjIwMjAxMTk5NjM3MjQ2MjgwMDAiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac2d552c3dfd49440f4f621cbb89f0096aa52e768c6414350f7da175e5661d637b
hovercard-subject-tagpull_request:1660087444
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,checks,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/checks
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python-control/python-control/pull/953/checks
twitter:imagehttps://avatars.githubusercontent.com/u/293362?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/293362?s=400&v=4
og:image:altThis PR updates pole/zero and root locus plots to use the _map/_plot calling pattern described in #645. The following patterns will work: rldata = ct.root_locus_map(syslist[, klist]) lines = rldata...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None6fe64d94889230be19a900846cfc91707e7dd4206878d6c208922b46a6b0735d
turbo-cache-controlno-preview
go-importgithub.com/python-control/python-control git https://github.com/python-control/python-control.git
octolytics-dimension-user_id2285872
octolytics-dimension-user_loginpython-control
octolytics-dimension-repository_id22791752
octolytics-dimension-repository_nwopython-control/python-control
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id22791752
octolytics-dimension-repository_network_root_nwopython-control/python-control
turbo-body-classeslogged-out env-production page-responsive full-width full-width-p-0
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release15736a47b83581130a149aa1b928696bea06adde
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python-control/python-control/pull/953/checks#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython-control%2Fpython-control%2Fpull%2F953%2Fchecks
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython-control%2Fpython-control%2Fpull%2F953%2Fchecks
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Fchecks&source=header-repo&source_repo=python-control%2Fpython-control
Reloadhttps://github.com/python-control/python-control/pull/953/checks
Reloadhttps://github.com/python-control/python-control/pull/953/checks
Reloadhttps://github.com/python-control/python-control/pull/953/checks
python-control https://github.com/python-control
python-controlhttps://github.com/python-control/python-control
Notifications https://github.com/login?return_to=%2Fpython-control%2Fpython-control
Fork 447 https://github.com/login?return_to=%2Fpython-control%2Fpython-control
Star 2k https://github.com/login?return_to=%2Fpython-control%2Fpython-control
Code https://github.com/python-control/python-control
Issues 87 https://github.com/python-control/python-control/issues
Pull requests 8 https://github.com/python-control/python-control/pulls
Discussions https://github.com/python-control/python-control/discussions
Actions https://github.com/python-control/python-control/actions
Projects 0 https://github.com/python-control/python-control/projects
Wiki https://github.com/python-control/python-control/wiki
Security 0 https://github.com/python-control/python-control/security
Insights https://github.com/python-control/python-control/pulse
Code https://github.com/python-control/python-control
Issues https://github.com/python-control/python-control/issues
Pull requests https://github.com/python-control/python-control/pulls
Discussions https://github.com/python-control/python-control/discussions
Actions https://github.com/python-control/python-control/actions
Projects https://github.com/python-control/python-control/projects
Wiki https://github.com/python-control/python-control/wiki
Security https://github.com/python-control/python-control/security
Insights https://github.com/python-control/python-control/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython-control%2Fpython-control%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython-control%2Fpython-control%2Fissues%2Fnew%2Fchoose
murrayrmhttps://github.com/murrayrm
python-control:mainhttps://github.com/python-control/python-control/tree/main
murrayrm:pzmap_plots-22Jul2023https://github.com/murrayrm/python-control/tree/pzmap_plots-22Jul2023
Conversation 4 https://github.com/python-control/python-control/pull/953
Commits 16 https://github.com/python-control/python-control/pull/953/commits
Checks 0 https://github.com/python-control/python-control/pull/953/checks
Files changed https://github.com/python-control/python-control/pull/953/files
Please reload this pagehttps://github.com/python-control/python-control/pull/953/checks
Please reload this pagehttps://github.com/python-control/python-control/pull/953/checks
Update pole/zero and root locus plots to use _map/_plot pattern https://github.com/python-control/python-control/pull/953/checks#top
Please reload this pagehttps://github.com/python-control/python-control/pull/953/checks
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.