| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:6407e37d-dae8-507b-8771-eab169648555 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 920E:3523AF:1756E3B:1F45883:697D233A |
| html-safe-nonce | 462df1555cd89c54bc46958474586816eae0b9c53048f9ad4cbed29545c9ebc9 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5MjBFOjM1MjNBRjoxNzU2RTNCOjFGNDU4ODM6Njk3RDIzM0EiLCJ2aXNpdG9yX2lkIjoiNTI3MzYyNjM0OTc5MTk0NTUzMCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | f25949bdd8f9e4c310a127344080fc6b00d6581d13e382e44850fba9cc84f414 |
| hovercard-subject-tag | pull_request:1660087444 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///pull_requests/show/files |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/python-control/python-control/pull/953/files |
| twitter:image | https://avatars.githubusercontent.com/u/293362?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/293362?s=400&v=4 |
| og:image:alt | This PR updates pole/zero and root locus plots to use the _map/_plot calling pattern described in #645. The following patterns will work:
rldata = ct.root_locus_map(syslist[, klist])
lines = rldata... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 85f2067815dbbcfc3c95ddc086aaa4bb85c804c8c1fb2c0a58abac2793271b0b |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/python-control/python-control git https://github.com/python-control/python-control.git |
| octolytics-dimension-user_id | 2285872 |
| octolytics-dimension-user_login | python-control |
| octolytics-dimension-repository_id | 22791752 |
| octolytics-dimension-repository_nwo | python-control/python-control |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 22791752 |
| octolytics-dimension-repository_network_root_nwo | python-control/python-control |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 2c8ad0f3fda6467e88f69a0b1fb9a04f96d34a4d |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/python-control/python-control/pull/953/changes#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython-control%2Fpython-control%2Fpull%2F953%2Ffiles |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython-control%2Fpython-control%2Fpull%2F953%2Ffiles |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python-control%2Fpython-control |
| Reload | https://github.com/python-control/python-control/pull/953/changes |
| Reload | https://github.com/python-control/python-control/pull/953/changes |
| Reload | https://github.com/python-control/python-control/pull/953/changes |
|
python-control
| https://github.com/python-control |
| python-control | https://github.com/python-control/python-control |
|
Notifications
| https://github.com/login?return_to=%2Fpython-control%2Fpython-control |
|
Fork
447
| https://github.com/login?return_to=%2Fpython-control%2Fpython-control |
|
Star
2k
| https://github.com/login?return_to=%2Fpython-control%2Fpython-control |
|
Code
| https://github.com/python-control/python-control |
|
Issues
87
| https://github.com/python-control/python-control/issues |
|
Pull requests
8
| https://github.com/python-control/python-control/pulls |
|
Discussions
| https://github.com/python-control/python-control/discussions |
|
Actions
| https://github.com/python-control/python-control/actions |
|
Projects
0
| https://github.com/python-control/python-control/projects |
|
Wiki
| https://github.com/python-control/python-control/wiki |
|
Security
0
| https://github.com/python-control/python-control/security |
|
Insights
| https://github.com/python-control/python-control/pulse |
|
Code
| https://github.com/python-control/python-control |
|
Issues
| https://github.com/python-control/python-control/issues |
|
Pull requests
| https://github.com/python-control/python-control/pulls |
|
Discussions
| https://github.com/python-control/python-control/discussions |
|
Actions
| https://github.com/python-control/python-control/actions |
|
Projects
| https://github.com/python-control/python-control/projects |
|
Wiki
| https://github.com/python-control/python-control/wiki |
|
Security
| https://github.com/python-control/python-control/security |
|
Insights
| https://github.com/python-control/python-control/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fpython-control%2Fpython-control%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fpython-control%2Fpython-control%2Fissues%2Fnew%2Fchoose |
| murrayrm | https://github.com/murrayrm |
| python-control:main | https://github.com/python-control/python-control/tree/main |
| murrayrm:pzmap_plots-22Jul2023 | https://github.com/murrayrm/python-control/tree/pzmap_plots-22Jul2023 |
|
Conversation
4
| https://github.com/python-control/python-control/pull/953 |
|
Commits
16
| https://github.com/python-control/python-control/pull/953/commits |
|
Checks
0
| https://github.com/python-control/python-control/pull/953/checks |
|
Files changed
| https://github.com/python-control/python-control/pull/953/files |
| Please reload this page | https://github.com/python-control/python-control/pull/953/changes |
|
Update pole/zero and root locus plots to use _map/_plot pattern
| https://github.com/python-control/python-control/pull/953/changes#top |
|
Show all changes
16 commits
| https://github.com/python-control/python-control/pull/953/files |
|
6b5cafc
refactoring of pzmap into response/plot + unit test changes
murrayrm Aug 3, 2023
| https://github.com/python-control/python-control/pull/953/commits/6b5cafc5078aa3adc9ad610e66f96165e38c9844 |
|
1451f3a
pz -> pole_zero + add loci plotting
murrayrm Aug 9, 2023
| https://github.com/python-control/python-control/pull/953/commits/1451f3a35baebc5f49febaef7d2538483443d9fd |
|
1390e37
remove sisotool dependencies in rlocus
murrayrm Aug 12, 2023
| https://github.com/python-control/python-control/pull/953/commits/1390e3771f76a964b63730a8fb6cae02ad648186 |
|
6e33598
update xlim, ylim handling in pzmap + other supporting changes
murrayrm Aug 21, 2023
| https://github.com/python-control/python-control/pull/953/commits/6e335981ec98adde55385dcbf24b0aac4f5e9dea |
|
1c4322c
reorder ct.isdtime parameters for backward compatibility
murrayrm Sep 20, 2023
| https://github.com/python-control/python-control/pull/953/commits/1c4322cac20ec823c423d12468ca0bd3f2e6e3b2 |
|
57dac87
initial refactoring of root_locus_{map,plot}
murrayrm Sep 23, 2023
| https://github.com/python-control/python-control/pull/953/commits/57dac87da3c5885ef4912fa4484a0dff811e0b9c |
|
ee46ac6
adjust root locus spacing and add scaling keyword
murrayrm Dec 26, 2023
| https://github.com/python-control/python-control/pull/953/commits/ee46ac6a2fa1f7375706d28b135ac07cdfd6156f |
|
0d23598
tweak grid processing, add documentation, interactive by default
murrayrm Dec 28, 2023
| https://github.com/python-control/python-control/pull/953/commits/0d23598ce89bb0d8af7187a952351a7c63ce3fdb |
|
0137056
add legacy processing for root_locus
murrayrm Dec 28, 2023
| https://github.com/python-control/python-control/pull/953/commits/0137056dace0476f6663f20cd099753f70e79e74 |
|
08e55b1
add backward compatibility for matlab.{rlocus,pzmap} + suppress warnings
murrayrm Dec 28, 2023
| https://github.com/python-control/python-control/pull/953/commits/08e55b133dbe9a15f23108c80caaa4a5a50a0932 |
|
8776875
updated grid handling (add 'empty')
murrayrm Dec 28, 2023
| https://github.com/python-control/python-control/pull/953/commits/8776875cda88692746792abf87bcc247e3c2b8c4 |
|
416dff8
updated rlocus/pzmap docs, docstrings, tests
murrayrm Dec 29, 2023
| https://github.com/python-control/python-control/pull/953/commits/416dff8b4a46fb3e595c9a92590b068d6d4f9825 |
|
52f8127
updated unit test for coverage + some fixes
murrayrm Dec 29, 2023
| https://github.com/python-control/python-control/pull/953/commits/52f81271f49a653cc2bab570ed8c7ac7ee07b5a3 |
|
5ca2d5c
fix initial_gain in documentation example
murrayrm Dec 31, 2023
| https://github.com/python-control/python-control/pull/953/commits/5ca2d5c88cdefad3b6d9ccd3d58888108f2c730d |
|
d532dc9
isort files
murrayrm Jan 12, 2024
| https://github.com/python-control/python-control/pull/953/commits/d532dc9922f016d755cb034f28460adc8a08c675 |
|
f500cbe
parametrize test per @bnavigator suggestion
murrayrm Jan 12, 2024
| https://github.com/python-control/python-control/pull/953/commits/f500cbe9c0f537d03e54d51db3b43769edbec886 |
|
Clear filters
| https://github.com/python-control/python-control/pull/953/files |
| Please reload this page | https://github.com/python-control/python-control/pull/953/changes |
| Please reload this page | https://github.com/python-control/python-control/pull/953/changes |
|
freqplot.py
| https://github.com/python-control/python-control/pull/953/changes#diff-a751fe1009e7b656d19357a39abb58dd88b89052c9d9259c3393a4648b697a16 |
|
grid.py
| https://github.com/python-control/python-control/pull/953/changes#diff-2a2bfe804c121e19d428ee5dcb9410d07ba02ef20f3080cc5175faf78076bbdd |
|
iosys.py
| https://github.com/python-control/python-control/pull/953/changes#diff-12b378d96d36c9d59a9fbc5afbc7cc158d153ff7591b4769f8312772e1d74ed1 |
|
wrappers.py
| https://github.com/python-control/python-control/pull/953/changes#diff-a78036738b627bfb9a8806e6e9ca28ed3874ad6e69cb9ebdaa2b51207a18c583 |
|
pzmap.py
| https://github.com/python-control/python-control/pull/953/changes#diff-fdd48a8f4e62116d8bb53ab21c499352f4dcb4b95f632e002126d869a10ba722 |
|
rlocus.py
| https://github.com/python-control/python-control/pull/953/changes#diff-6846933c325aaef66d5b0aa46a0ea077a03dcaf1edb4e513d795d8bc938ce2ee |
|
sisotool.py
| https://github.com/python-control/python-control/pull/953/changes#diff-5b1b1a164f395f3f0ea7bad5761983be0d398ad5462147b1f69de6dd48a52e1d |
|
kwargs_test.py
| https://github.com/python-control/python-control/pull/953/changes#diff-3144c3ea9a838756fe63a094bb84c293d32c5190d9b081cbb2f10926fda2e19e |
|
matlab_test.py
| https://github.com/python-control/python-control/pull/953/changes#diff-79c20f0d3385778d9d3499c17ebf67060db66785a0eae139486d3e7a468ceb32 |
|
pzmap_test.py
| https://github.com/python-control/python-control/pull/953/changes#diff-4f4187c4a377622a547d531dfcc044558eabeb876cbb61623768fa9581d3ea08 |
|
rlocus_test.py
| https://github.com/python-control/python-control/pull/953/changes#diff-14191ee376d7e0c4ef10224e6883edc949e6195f7700198a8599b57cf96fd414 |
|
sisotool_test.py
| https://github.com/python-control/python-control/pull/953/changes#diff-b3c0bda12803d07552099104b16bef2d88e8704596539d753460355deeea0c92 |
|
Makefile
| https://github.com/python-control/python-control/pull/953/changes#diff-f48ddfd1eec38c4d39f84e195259371f8397cd30146f46b113bdcb4590ed262c |
|
plotting.rst
| https://github.com/python-control/python-control/pull/953/changes#diff-7d87c42933f69063b454fa6021951255b0061c5f7c39c347e2d0887078dc9c2a |
|
pzmap-siso_ctime-default.png
| https://github.com/python-control/python-control/pull/953/changes#diff-aea3021e1e3b67ed0824e29bec8bfd281285835b34d4806ad043e0a352bf7e4a |
|
rlocus-siso_ctime-clicked.png
| https://github.com/python-control/python-control/pull/953/changes#diff-b50e10318186ff8248d3a9f18ab32b6e58525e6dfb500c619aaba739e701c394 |
|
rlocus-siso_ctime-default.png
| https://github.com/python-control/python-control/pull/953/changes#diff-daba86a5029d5a6ecdc8caf6e3079a32b4e62e6885dad9046fee5502ceebf15e |
|
rlocus-siso_dtime-default.png
| https://github.com/python-control/python-control/pull/953/changes#diff-1281b1638fb226f4b08af700733ae9b91f82ddedc9fe0fcc708021d0d3da3d25 |
|
rlocus-siso_multiple-nogrid.png
| https://github.com/python-control/python-control/pull/953/changes#diff-11e59c76c20d7326b60216e313f58b70409f7af7526742832d0b1c69976a7b02 |
| control/freqplot.py | https://github.com/python-control/python-control/pull/953/changes#diff-a751fe1009e7b656d19357a39abb58dd88b89052c9d9259c3393a4648b697a16 |
|
View file
| https://github.com/murrayrm/python-control/blob/f500cbe9c0f537d03e54d51db3b43769edbec886/control/freqplot.py |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/python-control/python-control/pull/953/{{ revealButtonHref }} |
|
| https://github.com/python-control/python-control/pull/953/changes#diff-a751fe1009e7b656d19357a39abb58dd88b89052c9d9259c3393a4648b697a16 |
|
| https://github.com/python-control/python-control/pull/953/changes#diff-a751fe1009e7b656d19357a39abb58dd88b89052c9d9259c3393a4648b697a16 |
| control/grid.py | https://github.com/python-control/python-control/pull/953/changes#diff-2a2bfe804c121e19d428ee5dcb9410d07ba02ef20f3080cc5175faf78076bbdd |
|
View file
| https://github.com/murrayrm/python-control/blob/f500cbe9c0f537d03e54d51db3b43769edbec886/control/grid.py |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/python-control/python-control/pull/953/{{ revealButtonHref }} |
|
| https://github.com/python-control/python-control/pull/953/changes#diff-2a2bfe804c121e19d428ee5dcb9410d07ba02ef20f3080cc5175faf78076bbdd |
|
| https://github.com/python-control/python-control/pull/953/changes#diff-2a2bfe804c121e19d428ee5dcb9410d07ba02ef20f3080cc5175faf78076bbdd |
|
| https://github.com/python-control/python-control/pull/953/changes#diff-2a2bfe804c121e19d428ee5dcb9410d07ba02ef20f3080cc5175faf78076bbdd |
|
| https://github.com/python-control/python-control/pull/953/changes#diff-2a2bfe804c121e19d428ee5dcb9410d07ba02ef20f3080cc5175faf78076bbdd |
|
| https://github.com/python-control/python-control/pull/953/changes#diff-2a2bfe804c121e19d428ee5dcb9410d07ba02ef20f3080cc5175faf78076bbdd |
|
| https://github.com/python-control/python-control/pull/953/changes#diff-2a2bfe804c121e19d428ee5dcb9410d07ba02ef20f3080cc5175faf78076bbdd |
|
| https://github.com/python-control/python-control/pull/953/changes#diff-2a2bfe804c121e19d428ee5dcb9410d07ba02ef20f3080cc5175faf78076bbdd |
| control/iosys.py | https://github.com/python-control/python-control/pull/953/changes#diff-12b378d96d36c9d59a9fbc5afbc7cc158d153ff7591b4769f8312772e1d74ed1 |
|
View file
| https://github.com/murrayrm/python-control/blob/f500cbe9c0f537d03e54d51db3b43769edbec886/control/iosys.py |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/python-control/python-control/pull/953/{{ revealButtonHref }} |
|
| https://github.com/python-control/python-control/pull/953/changes#diff-12b378d96d36c9d59a9fbc5afbc7cc158d153ff7591b4769f8312772e1d74ed1 |
|
| https://github.com/python-control/python-control/pull/953/changes#diff-12b378d96d36c9d59a9fbc5afbc7cc158d153ff7591b4769f8312772e1d74ed1 |
| control/matlab/wrappers.py | https://github.com/python-control/python-control/pull/953/changes#diff-a78036738b627bfb9a8806e6e9ca28ed3874ad6e69cb9ebdaa2b51207a18c583 |
|
View file
| https://github.com/murrayrm/python-control/blob/f500cbe9c0f537d03e54d51db3b43769edbec886/control/matlab/wrappers.py |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/python-control/python-control/pull/953/{{ revealButtonHref }} |
|
| https://github.com/python-control/python-control/pull/953/changes#diff-a78036738b627bfb9a8806e6e9ca28ed3874ad6e69cb9ebdaa2b51207a18c583 |
|
| https://github.com/python-control/python-control/pull/953/changes#diff-a78036738b627bfb9a8806e6e9ca28ed3874ad6e69cb9ebdaa2b51207a18c583 |
|
| https://github.com/python-control/python-control/pull/953/changes#diff-a78036738b627bfb9a8806e6e9ca28ed3874ad6e69cb9ebdaa2b51207a18c583 |
|
| https://github.com/python-control/python-control/pull/953/changes#diff-a78036738b627bfb9a8806e6e9ca28ed3874ad6e69cb9ebdaa2b51207a18c583 |
|
| https://github.com/python-control/python-control/pull/953/changes#diff-a78036738b627bfb9a8806e6e9ca28ed3874ad6e69cb9ebdaa2b51207a18c583 |
|
| https://github.com/python-control/python-control/pull/953/changes#diff-a78036738b627bfb9a8806e6e9ca28ed3874ad6e69cb9ebdaa2b51207a18c583 |
| Please reload this page | https://github.com/python-control/python-control/pull/953/changes |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |