Title: Add unit test illustrating issue #935 + add method keyword for tf2ss by murrayrm · Pull Request #937 · python-control/python-control · GitHub
Open Graph Title: Add unit test illustrating issue #935 + add method keyword for tf2ss by murrayrm · Pull Request #937 · python-control/python-control
X Title: Add unit test illustrating issue #935 + add method keyword for tf2ss by murrayrm · Pull Request #937 · python-control/python-control
Description: This PR puts in some unit tests associated with issue #935, which looks like it is a problem in slycot where the tf2ss functionality (in td04ad) doesn't work properly. As a partial workaround, a method keyword is added to tf2ss (and ss) that allows method='scipy' to be used for SISO systems. Docstrings updated for the new keyword and a note on the slycot issue. A bug report has been created in the slycot repository (#222 and the unit tests will fail when the bug is fixed (so we can go back and update the unit tests and documentation).
Open Graph Description: This PR puts in some unit tests associated with issue #935, which looks like it is a problem in slycot where the tf2ss functionality (in td04ad) doesn't work properly. As a partial workaround,...
X Description: This PR puts in some unit tests associated with issue #935, which looks like it is a problem in slycot where the tf2ss functionality (in td04ad) doesn't work properly. As a partial workaro...
Opengraph URL: https://github.com/python-control/python-control/pull/937
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:8fcc1adb-91a7-0474-5571-c8d4d6968a94 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 951A:3464BF:16E8EBC:1F0F743:697A95D1 |
| html-safe-nonce | 57417659a76c406704aef728a5a6bfdf33c353d517804283a3df53f14242dfcc |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5NTFBOjM0NjRCRjoxNkU4RUJDOjFGMEY3NDM6Njk3QTk1RDEiLCJ2aXNpdG9yX2lkIjoiNTM2MzcxOTg0Mjk0NTQ3MTk1MyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 996ce9e2b8f69f785e2e30bbadcf8ecb141adb86cb0a78ae5e03984e8d2b5267 |
| hovercard-subject-tag | pull_request:1568187959 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/python-control/python-control/pull/937/files |
| twitter:image | https://avatars.githubusercontent.com/u/293362?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/293362?s=400&v=4 |
| og:image:alt | This PR puts in some unit tests associated with issue #935, which looks like it is a problem in slycot where the tf2ss functionality (in td04ad) doesn't work properly. As a partial workaround,... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 0912f2a9aa0160e08239520d461a4b4c4ce1caa972a8370b7442b94a38a194c5 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/python-control/python-control git https://github.com/python-control/python-control.git |
| octolytics-dimension-user_id | 2285872 |
| octolytics-dimension-user_login | python-control |
| octolytics-dimension-repository_id | 22791752 |
| octolytics-dimension-repository_nwo | python-control/python-control |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 22791752 |
| octolytics-dimension-repository_network_root_nwo | python-control/python-control |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | f8f5270c10a913bfa56f2dad4b864f1cda383754 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width