René's URL Explorer Experiment


Title: Add unit test illustrating issue #935 + add method keyword for tf2ss by murrayrm · Pull Request #937 · python-control/python-control · GitHub

Open Graph Title: Add unit test illustrating issue #935 + add method keyword for tf2ss by murrayrm · Pull Request #937 · python-control/python-control

X Title: Add unit test illustrating issue #935 + add method keyword for tf2ss by murrayrm · Pull Request #937 · python-control/python-control

Description: This PR puts in some unit tests associated with issue #935, which looks like it is a problem in slycot where the tf2ss functionality (in td04ad) doesn't work properly. As a partial workaround, a method keyword is added to tf2ss (and ss) that allows method='scipy' to be used for SISO systems. Docstrings updated for the new keyword and a note on the slycot issue. A bug report has been created in the slycot repository (#222 and the unit tests will fail when the bug is fixed (so we can go back and update the unit tests and documentation).

Open Graph Description: This PR puts in some unit tests associated with issue #935, which looks like it is a problem in slycot where the tf2ss functionality (in td04ad) doesn't work properly. As a partial workaround,...

X Description: This PR puts in some unit tests associated with issue #935, which looks like it is a problem in slycot where the tf2ss functionality (in td04ad) doesn't work properly. As a partial workaro...

Opengraph URL: https://github.com/python-control/python-control/pull/937

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:0b55b9c7-1005-f92f-262d-be1a0e1f7057
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB8FA:1F1E44:1CBB4D9:27F3AC7:697BB2C8
html-safe-noncebaed434d68118760e617b812e620c50c37e6c280b07b94491288658e8546b152
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCOEZBOjFGMUU0NDoxQ0JCNEQ5OjI3RjNBQzc6Njk3QkIyQzgiLCJ2aXNpdG9yX2lkIjoiMjAwNjEyMjQ2MjE5MTA5MDY0IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac05e02b44f9bcbeb4161a3b23cdb8b87d641df7920646f84b7ae3474886913464
hovercard-subject-tagpull_request:1568187959
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python-control/python-control/pull/937/files
twitter:imagehttps://avatars.githubusercontent.com/u/293362?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/293362?s=400&v=4
og:image:altThis PR puts in some unit tests associated with issue #935, which looks like it is a problem in slycot where the tf2ss functionality (in td04ad) doesn't work properly. As a partial workaround,...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None8bc38d671c70edff28c64b04e5023d8f7625cc16e79d648cc9e09f13dfea093e
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python-control/python-control git https://github.com/python-control/python-control.git
octolytics-dimension-user_id2285872
octolytics-dimension-user_loginpython-control
octolytics-dimension-repository_id22791752
octolytics-dimension-repository_nwopython-control/python-control
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id22791752
octolytics-dimension-repository_network_root_nwopython-control/python-control
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releaseff5994c68a126d172a1574fc9d83aaa9a0aac131
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python-control/python-control/pull/937/changes#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython-control%2Fpython-control%2Fpull%2F937%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython-control%2Fpython-control%2Fpull%2F937%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python-control%2Fpython-control
Reloadhttps://github.com/python-control/python-control/pull/937/changes
Reloadhttps://github.com/python-control/python-control/pull/937/changes
Reloadhttps://github.com/python-control/python-control/pull/937/changes
python-control https://github.com/python-control
python-controlhttps://github.com/python-control/python-control
Notifications https://github.com/login?return_to=%2Fpython-control%2Fpython-control
Fork 447 https://github.com/login?return_to=%2Fpython-control%2Fpython-control
Star 2k https://github.com/login?return_to=%2Fpython-control%2Fpython-control
Code https://github.com/python-control/python-control
Issues 87 https://github.com/python-control/python-control/issues
Pull requests 8 https://github.com/python-control/python-control/pulls
Discussions https://github.com/python-control/python-control/discussions
Actions https://github.com/python-control/python-control/actions
Projects 0 https://github.com/python-control/python-control/projects
Wiki https://github.com/python-control/python-control/wiki
Security 0 https://github.com/python-control/python-control/security
Insights https://github.com/python-control/python-control/pulse
Code https://github.com/python-control/python-control
Issues https://github.com/python-control/python-control/issues
Pull requests https://github.com/python-control/python-control/pulls
Discussions https://github.com/python-control/python-control/discussions
Actions https://github.com/python-control/python-control/actions
Projects https://github.com/python-control/python-control/projects
Wiki https://github.com/python-control/python-control/wiki
Security https://github.com/python-control/python-control/security
Insights https://github.com/python-control/python-control/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython-control%2Fpython-control%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython-control%2Fpython-control%2Fissues%2Fnew%2Fchoose
murrayrmhttps://github.com/murrayrm
python-control:mainhttps://github.com/python-control/python-control/tree/main
murrayrm:tf2ss_unstable_bug-21Oct2023https://github.com/murrayrm/python-control/tree/tf2ss_unstable_bug-21Oct2023
Conversation 3 https://github.com/python-control/python-control/pull/937
Commits 3 https://github.com/python-control/python-control/pull/937/commits
Checks 0 https://github.com/python-control/python-control/pull/937/checks
Files changed https://github.com/python-control/python-control/pull/937/files
Please reload this pagehttps://github.com/python-control/python-control/pull/937/changes
Add unit test illustrating issue #935 + add method keyword for tf2ss https://github.com/python-control/python-control/pull/937/changes#top
Show all changes 3 commits https://github.com/python-control/python-control/pull/937/files
fe8888f add unit test illustrating issue #935 + add keyword for tf2ss murrayrm Oct 22, 2023 https://github.com/python-control/python-control/pull/937/commits/fe8888f94e2f126599cc28dfdec22926f0b28984
2580d18 add some documentation and notes murrayrm Oct 22, 2023 https://github.com/python-control/python-control/pull/937/commits/2580d1862e5bbcb6b7d4e4ca03299332b0cf69db
31793e6 updated MIMO not implemented w/ unit test, per @sawyerbfuller murrayrm Nov 8, 2023 https://github.com/python-control/python-control/pull/937/commits/31793e6d4a75faa9f81d730df5f100b4eb79ccd1
Clear filters https://github.com/python-control/python-control/pull/937/files
Please reload this pagehttps://github.com/python-control/python-control/pull/937/changes
Please reload this pagehttps://github.com/python-control/python-control/pull/937/changes
statesp.py https://github.com/python-control/python-control/pull/937/changes#diff-b5aac033a6dd07653e82d9f5a40afaa775010c2d2d5af8beeb159487b566df72
convert_test.py https://github.com/python-control/python-control/pull/937/changes#diff-cebcec17ebc58131080d1e205ff7eb7dd87a5354def1adb46964e2a5c08a2140
statesp_test.py https://github.com/python-control/python-control/pull/937/changes#diff-4c76080acbdea36493458693d93ec10e4e10b2e04ce01c56e8a81567cc1ea0d6
control/statesp.pyhttps://github.com/python-control/python-control/pull/937/changes#diff-b5aac033a6dd07653e82d9f5a40afaa775010c2d2d5af8beeb159487b566df72
View file https://github.com/murrayrm/python-control/blob/31793e6d4a75faa9f81d730df5f100b4eb79ccd1/control/statesp.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python-control/python-control/pull/937/{{ revealButtonHref }}
https://github.com/python-control/python-control/pull/937/changes#diff-b5aac033a6dd07653e82d9f5a40afaa775010c2d2d5af8beeb159487b566df72
https://github.com/python-control/python-control/pull/937/changes#diff-b5aac033a6dd07653e82d9f5a40afaa775010c2d2d5af8beeb159487b566df72
https://github.com/python-control/python-control/pull/937/changes#diff-b5aac033a6dd07653e82d9f5a40afaa775010c2d2d5af8beeb159487b566df72
https://github.com/python-control/python-control/pull/937/changes#diff-b5aac033a6dd07653e82d9f5a40afaa775010c2d2d5af8beeb159487b566df72
https://github.com/python-control/python-control/pull/937/changes#diff-b5aac033a6dd07653e82d9f5a40afaa775010c2d2d5af8beeb159487b566df72
https://github.com/python-control/python-control/pull/937/changes#diff-b5aac033a6dd07653e82d9f5a40afaa775010c2d2d5af8beeb159487b566df72
https://github.com/python-control/python-control/pull/937/changes#diff-b5aac033a6dd07653e82d9f5a40afaa775010c2d2d5af8beeb159487b566df72
https://github.com/python-control/python-control/pull/937/changes#diff-b5aac033a6dd07653e82d9f5a40afaa775010c2d2d5af8beeb159487b566df72
https://github.com/python-control/python-control/pull/937/changes#diff-b5aac033a6dd07653e82d9f5a40afaa775010c2d2d5af8beeb159487b566df72
https://github.com/python-control/python-control/pull/937/changes#diff-b5aac033a6dd07653e82d9f5a40afaa775010c2d2d5af8beeb159487b566df72
https://github.com/python-control/python-control/pull/937/changes#diff-b5aac033a6dd07653e82d9f5a40afaa775010c2d2d5af8beeb159487b566df72
https://github.com/python-control/python-control/pull/937/changes#diff-b5aac033a6dd07653e82d9f5a40afaa775010c2d2d5af8beeb159487b566df72
https://github.com/python-control/python-control/pull/937/changes#diff-b5aac033a6dd07653e82d9f5a40afaa775010c2d2d5af8beeb159487b566df72
sawyerbfullerhttps://github.com/sawyerbfuller
Oct 26, 2023https://github.com/python-control/python-control/pull/937/changes#r1373519818
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python-control/python-control/pull/937/changes
sawyerbfullerhttps://github.com/sawyerbfuller
Oct 26, 2023https://github.com/python-control/python-control/pull/937/changes#r1373524659
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python-control/python-control/pull/937/changes
https://github.com/python-control/python-control/pull/937/changes#diff-b5aac033a6dd07653e82d9f5a40afaa775010c2d2d5af8beeb159487b566df72
control/tests/convert_test.pyhttps://github.com/python-control/python-control/pull/937/changes#diff-cebcec17ebc58131080d1e205ff7eb7dd87a5354def1adb46964e2a5c08a2140
View file https://github.com/murrayrm/python-control/blob/31793e6d4a75faa9f81d730df5f100b4eb79ccd1/control/tests/convert_test.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python-control/python-control/pull/937/{{ revealButtonHref }}
https://github.com/python-control/python-control/pull/937/changes#diff-cebcec17ebc58131080d1e205ff7eb7dd87a5354def1adb46964e2a5c08a2140
https://github.com/python-control/python-control/pull/937/changes#diff-cebcec17ebc58131080d1e205ff7eb7dd87a5354def1adb46964e2a5c08a2140
https://github.com/python-control/python-control/pull/937/changes#diff-cebcec17ebc58131080d1e205ff7eb7dd87a5354def1adb46964e2a5c08a2140
https://github.com/python-control/python-control/pull/937/changes#diff-cebcec17ebc58131080d1e205ff7eb7dd87a5354def1adb46964e2a5c08a2140
control/tests/statesp_test.pyhttps://github.com/python-control/python-control/pull/937/changes#diff-4c76080acbdea36493458693d93ec10e4e10b2e04ce01c56e8a81567cc1ea0d6
View file https://github.com/murrayrm/python-control/blob/31793e6d4a75faa9f81d730df5f100b4eb79ccd1/control/tests/statesp_test.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python-control/python-control/pull/937/{{ revealButtonHref }}
https://github.com/python-control/python-control/pull/937/changes#diff-4c76080acbdea36493458693d93ec10e4e10b2e04ce01c56e8a81567cc1ea0d6
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.