Title: Addressing #84 and #85 by mp4096 · Pull Request #91 · python-control/python-control · GitHub
Open Graph Title: Addressing #84 and #85 by mp4096 · Pull Request #91 · python-control/python-control
X Title: Addressing #84 and #85 by mp4096 · Pull Request #91 · python-control/python-control
Description: Compute poles of a state-space system using numpy.linalg.eigvals as suggested in #84 Replaced matrix inversion in the feedback computation by numpy.linalg.solve as suggested in #85 Also replaced the singularity check with a more stable one. numpy.linalg.matrix_rank uses a reasonable numerical threshold, so that we don't need to check abs(det(F)) by hand. Determinant is actually very sensitive to matrix scaling, so better not use it. Both the determinant and the SVD required for matrix_rank are cubic, so there should be no slowdown.
Open Graph Description: Compute poles of a state-space system using numpy.linalg.eigvals as suggested in #84 Replaced matrix inversion in the feedback computation by numpy.linalg.solve as suggested in #85 Also replaced th...
X Description: Compute poles of a state-space system using numpy.linalg.eigvals as suggested in #84 Replaced matrix inversion in the feedback computation by numpy.linalg.solve as suggested in #85 Also replaced th...
Opengraph URL: https://github.com/python-control/python-control/pull/91
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/checks(.:format) |
| route-controller | pull_requests |
| route-action | checks |
| fetch-nonce | v2:1b0437de-fb7c-d803-2dc2-306060d48c4a |
| current-catalog-service-hash | 87dc3bc62d9b466312751bfd5f889726f4f1337bdff4e8be7da7c93d6c00a25a |
| request-id | ADE8:28DCF0:25CC91:347E60:697B4014 |
| html-safe-nonce | 5a0f39ef725158c52656afbcf3f7f7f7a63713b93bf5e84b5f0e80de09108a31 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBREU4OjI4RENGMDoyNUNDOTE6MzQ3RTYwOjY5N0I0MDE0IiwidmlzaXRvcl9pZCI6IjY4MDMzNDA5Mjg2NDAzMDMxMjQiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | b6dea4d485174437d838d69c5f80e5f591831550b4f72c23137c94cd35314a57 |
| hovercard-subject-tag | pull_request:70900679 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,checks,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/python-control/python-control/pull/91/checks |
| twitter:image | https://avatars.githubusercontent.com/u/5394551?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/5394551?s=400&v=4 |
| og:image:alt | Compute poles of a state-space system using numpy.linalg.eigvals as suggested in #84 Replaced matrix inversion in the feedback computation by numpy.linalg.solve as suggested in #85 Also replaced th... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 6fe64d94889230be19a900846cfc91707e7dd4206878d6c208922b46a6b0735d |
| turbo-cache-control | no-preview |
| go-import | github.com/python-control/python-control git https://github.com/python-control/python-control.git |
| octolytics-dimension-user_id | 2285872 |
| octolytics-dimension-user_login | python-control |
| octolytics-dimension-repository_id | 22791752 |
| octolytics-dimension-repository_nwo | python-control/python-control |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 22791752 |
| octolytics-dimension-repository_network_root_nwo | python-control/python-control |
| turbo-body-classes | logged-out env-production page-responsive full-width full-width-p-0 |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 15736a47b83581130a149aa1b928696bea06adde |
| ui-target | canary-1 |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width