Title: fix up some warning messages due to converted systems by murrayrm · Pull Request #907 · python-control/python-control · GitHub
Open Graph Title: fix up some warning messages due to converted systems by murrayrm · Pull Request #907 · python-control/python-control
X Title: fix up some warning messages due to converted systems by murrayrm · Pull Request #907 · python-control/python-control
Description: Small PR to fix up some issues where the functionality in #903 was causing some warning messages. In particular, the following snipped was causing a warning (from matlab_test.py): siso_tf2 = tf([1, 1], [1, 2, 3, 1]) siso_ss2 = ss(siso_tf2) [gm, pm, gmc, pmc] = margin(siso_ss2 * siso_ss2 * 2) The reason for the warning was that siso_ss2 had the name 'sys[0]$converted' and when you create an interconnected system with duplicated non-generic names it gives you a warning (since things like change the parameters of one of the systems would affect the other. To fix this, converted LinearIOSystems with "generic" names (sys[0]) do not get '$converted' added to the end. Instead they just get a new generic system name. That change meant that some of the previous unit tests needed to use an explicitly named system, which is what the the changes in the unit tests are about.
Open Graph Description: Small PR to fix up some issues where the functionality in #903 was causing some warning messages. In particular, the following snipped was causing a warning (from matlab_test.py): siso_tf2 = tf([1...
X Description: Small PR to fix up some issues where the functionality in #903 was causing some warning messages. In particular, the following snipped was causing a warning (from matlab_test.py): siso_tf2 = tf([1...
Opengraph URL: https://github.com/python-control/python-control/pull/907
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:34b16a7f-3c22-f56b-c17a-326d91850dee |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 83D8:1B1D6E:2560CBD:32B29DE:6979AB54 |
| html-safe-nonce | 07020c6b3429f0a4dee2ff7527095f5425e1005c203ca9c7b52d66d7531275b3 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4M0Q4OjFCMUQ2RToyNTYwQ0JEOjMyQjI5REU6Njk3OUFCNTQiLCJ2aXNpdG9yX2lkIjoiMTQ1NTAzMzA4MzY4NDgyNTk0MCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 0a82b4698472361bc86ca6c241b9006d9bc5eae50041fb1acb44cb55f6648ffb |
| hovercard-subject-tag | pull_request:1383757726 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/python-control/python-control/pull/907/files |
| twitter:image | https://avatars.githubusercontent.com/u/293362?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/293362?s=400&v=4 |
| og:image:alt | Small PR to fix up some issues where the functionality in #903 was causing some warning messages. In particular, the following snipped was causing a warning (from matlab_test.py): siso_tf2 = tf([1... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | c049b65ec7e54cbf2521f5a560b6527714c612b0bd169188e2ea6e16f83bd5f4 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/python-control/python-control git https://github.com/python-control/python-control.git |
| octolytics-dimension-user_id | 2285872 |
| octolytics-dimension-user_login | python-control |
| octolytics-dimension-repository_id | 22791752 |
| octolytics-dimension-repository_nwo | python-control/python-control |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 22791752 |
| octolytics-dimension-repository_network_root_nwo | python-control/python-control |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 87b137883e35e2766c3d0f6a257c4044f6390b83 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width