René's URL Explorer Experiment


Title: make _convert_to_statespace properly pass signal and system names by sawyerbfuller · Pull Request #884 · python-control/python-control · GitHub

Open Graph Title: make _convert_to_statespace properly pass signal and system names by sawyerbfuller · Pull Request #884 · python-control/python-control

X Title: make _convert_to_statespace properly pass signal and system names by sawyerbfuller · Pull Request #884 · python-control/python-control

Description: update: this PR has been converted to a bugfix in _convert_to_statespace to insure it copies signal and system names correctly. Found the bug by using the test suite. Old PR description: On some systems computers , the process of converting tf systems into LinearIOSystems in the interconnect function loses signal names -- if the transfer function is static. For example, if a system is defined as sys=tf(1, 2, inputs='a', outputs='b'), an error is raised when that system is interconnected with others because sys gets copied but loses its signal names, something along the lines of Signal 'a' not found. But this doesn't happen on my system on Python 3.9, 3.10, or 3.11. Maybe something peculiar to windows? This PR adds unit tests in an attempt to see if our test suite catches this bug.

Open Graph Description: update: this PR has been converted to a bugfix in _convert_to_statespace to insure it copies signal and system names correctly. Found the bug by using the test suite. Old PR description: On some sy...

X Description: update: this PR has been converted to a bugfix in _convert_to_statespace to insure it copies signal and system names correctly. Found the bug by using the test suite. Old PR description: On some sy...

Opengraph URL: https://github.com/python-control/python-control/pull/884

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:3db9179f-8a84-1545-a739-21411e140da0
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idEDD4:1B9F7C:AFFD47:FA1F24:6979FA52
html-safe-nonce04e9aa6faf56f8675eb331550b09a2019f7e4c6b2caec7f9b9a7f73aa7557385
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFREQ0OjFCOUY3QzpBRkZENDc6RkExRjI0OjY5NzlGQTUyIiwidmlzaXRvcl9pZCI6IjQ1NDI2Nzc2NTEwNzU3NTg2NzQiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac36c3b344a6e70ae7c622aa6424ba18b77a3aabf6fb256eeaf732da8f477adf25
hovercard-subject-tagpull_request:1317448336
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python-control/python-control/pull/884/files
twitter:imagehttps://avatars.githubusercontent.com/u/58706249?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/58706249?s=400&v=4
og:image:altupdate: this PR has been converted to a bugfix in _convert_to_statespace to insure it copies signal and system names correctly. Found the bug by using the test suite. Old PR description: On some sy...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noned518616844426fb176f4177c4776349f6e70ef1ce75f459c8c53bf9293bb6982
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python-control/python-control git https://github.com/python-control/python-control.git
octolytics-dimension-user_id2285872
octolytics-dimension-user_loginpython-control
octolytics-dimension-repository_id22791752
octolytics-dimension-repository_nwopython-control/python-control
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id22791752
octolytics-dimension-repository_network_root_nwopython-control/python-control
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release22c6ce7724007ae85d7487fce3308a1c7cea8be6
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python-control/python-control/pull/884/changes#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython-control%2Fpython-control%2Fpull%2F884%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython-control%2Fpython-control%2Fpull%2F884%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python-control%2Fpython-control
Reloadhttps://github.com/python-control/python-control/pull/884/changes
Reloadhttps://github.com/python-control/python-control/pull/884/changes
Reloadhttps://github.com/python-control/python-control/pull/884/changes
python-control https://github.com/python-control
python-controlhttps://github.com/python-control/python-control
Notifications https://github.com/login?return_to=%2Fpython-control%2Fpython-control
Fork 447 https://github.com/login?return_to=%2Fpython-control%2Fpython-control
Star 2k https://github.com/login?return_to=%2Fpython-control%2Fpython-control
Code https://github.com/python-control/python-control
Issues 87 https://github.com/python-control/python-control/issues
Pull requests 8 https://github.com/python-control/python-control/pulls
Discussions https://github.com/python-control/python-control/discussions
Actions https://github.com/python-control/python-control/actions
Projects 0 https://github.com/python-control/python-control/projects
Wiki https://github.com/python-control/python-control/wiki
Security 0 https://github.com/python-control/python-control/security
Insights https://github.com/python-control/python-control/pulse
Code https://github.com/python-control/python-control
Issues https://github.com/python-control/python-control/issues
Pull requests https://github.com/python-control/python-control/pulls
Discussions https://github.com/python-control/python-control/discussions
Actions https://github.com/python-control/python-control/actions
Projects https://github.com/python-control/python-control/projects
Wiki https://github.com/python-control/python-control/wiki
Security https://github.com/python-control/python-control/security
Insights https://github.com/python-control/python-control/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython-control%2Fpython-control%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython-control%2Fpython-control%2Fissues%2Fnew%2Fchoose
murrayrmhttps://github.com/murrayrm
python-control:mainhttps://github.com/python-control/python-control/tree/main
sawyerbfuller:static-signal-nameshttps://github.com/sawyerbfuller/python-control/tree/static-signal-names
Conversation 7 https://github.com/python-control/python-control/pull/884
Commits 3 https://github.com/python-control/python-control/pull/884/commits
Checks 0 https://github.com/python-control/python-control/pull/884/checks
Files changed https://github.com/python-control/python-control/pull/884/files
Please reload this pagehttps://github.com/python-control/python-control/pull/884/changes
make _convert_to_statespace properly pass signal and system names https://github.com/python-control/python-control/pull/884/changes#top
Show all changes 3 commits https://github.com/python-control/python-control/pull/884/files
78f5aec fix bug in namedio unit test that was treating static SS systems the … sawyerbfuller Apr 17, 2023 https://github.com/python-control/python-control/pull/884/commits/78f5aec6f35b69d33584da3ce4830e7eced2f7c5
ebabbd6 add unit tests for interconnect with static system sawyerbfuller Apr 18, 2023 https://github.com/python-control/python-control/pull/884/commits/ebabbd6f8481a47adb83fe7c6368275b6b8a624c
8b5eb47 squashed noslycot losing signal names bug, added unit tests sawyerbfuller Apr 18, 2023 https://github.com/python-control/python-control/pull/884/commits/8b5eb47e60f8263da33609528bde34b5bf2be8a8
Clear filters https://github.com/python-control/python-control/pull/884/files
Please reload this pagehttps://github.com/python-control/python-control/pull/884/changes
Please reload this pagehttps://github.com/python-control/python-control/pull/884/changes
statesp.py https://github.com/python-control/python-control/pull/884/changes#diff-b5aac033a6dd07653e82d9f5a40afaa775010c2d2d5af8beeb159487b566df72
interconnect_test.py https://github.com/python-control/python-control/pull/884/changes#diff-6e4f4e00ba4b94a479c66a7dad1291c8d2f31d7af2e60b8d827db782113fad75
namedio_test.py https://github.com/python-control/python-control/pull/884/changes#diff-94bfe2c2e359db3059f456bc5f48673ee573b286bb4834719ca5173fceeffa50
control/statesp.pyhttps://github.com/python-control/python-control/pull/884/changes#diff-b5aac033a6dd07653e82d9f5a40afaa775010c2d2d5af8beeb159487b566df72
View file https://github.com/sawyerbfuller/python-control/blob/8b5eb47e60f8263da33609528bde34b5bf2be8a8/control/statesp.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python-control/python-control/pull/884/{{ revealButtonHref }}
https://github.com/python-control/python-control/pull/884/changes#diff-b5aac033a6dd07653e82d9f5a40afaa775010c2d2d5af8beeb159487b566df72
https://github.com/python-control/python-control/pull/884/changes#diff-b5aac033a6dd07653e82d9f5a40afaa775010c2d2d5af8beeb159487b566df72
https://github.com/python-control/python-control/pull/884/changes#diff-b5aac033a6dd07653e82d9f5a40afaa775010c2d2d5af8beeb159487b566df72
https://github.com/python-control/python-control/pull/884/changes#diff-b5aac033a6dd07653e82d9f5a40afaa775010c2d2d5af8beeb159487b566df72
https://github.com/python-control/python-control/pull/884/changes#diff-b5aac033a6dd07653e82d9f5a40afaa775010c2d2d5af8beeb159487b566df72
https://github.com/python-control/python-control/pull/884/changes#diff-b5aac033a6dd07653e82d9f5a40afaa775010c2d2d5af8beeb159487b566df72
control/tests/interconnect_test.pyhttps://github.com/python-control/python-control/pull/884/changes#diff-6e4f4e00ba4b94a479c66a7dad1291c8d2f31d7af2e60b8d827db782113fad75
View file https://github.com/sawyerbfuller/python-control/blob/8b5eb47e60f8263da33609528bde34b5bf2be8a8/control/tests/interconnect_test.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python-control/python-control/pull/884/{{ revealButtonHref }}
https://github.com/python-control/python-control/pull/884/changes#diff-6e4f4e00ba4b94a479c66a7dad1291c8d2f31d7af2e60b8d827db782113fad75
https://github.com/python-control/python-control/pull/884/changes#diff-6e4f4e00ba4b94a479c66a7dad1291c8d2f31d7af2e60b8d827db782113fad75
https://github.com/python-control/python-control/pull/884/changes#diff-6e4f4e00ba4b94a479c66a7dad1291c8d2f31d7af2e60b8d827db782113fad75
https://github.com/python-control/python-control/pull/884/changes#diff-6e4f4e00ba4b94a479c66a7dad1291c8d2f31d7af2e60b8d827db782113fad75
https://github.com/python-control/python-control/pull/884/changes#diff-6e4f4e00ba4b94a479c66a7dad1291c8d2f31d7af2e60b8d827db782113fad75
control/tests/namedio_test.pyhttps://github.com/python-control/python-control/pull/884/changes#diff-94bfe2c2e359db3059f456bc5f48673ee573b286bb4834719ca5173fceeffa50
View file https://github.com/sawyerbfuller/python-control/blob/8b5eb47e60f8263da33609528bde34b5bf2be8a8/control/tests/namedio_test.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python-control/python-control/pull/884/{{ revealButtonHref }}
https://github.com/python-control/python-control/pull/884/changes#diff-94bfe2c2e359db3059f456bc5f48673ee573b286bb4834719ca5173fceeffa50
https://github.com/python-control/python-control/pull/884/changes#diff-94bfe2c2e359db3059f456bc5f48673ee573b286bb4834719ca5173fceeffa50
https://github.com/python-control/python-control/pull/884/changes#diff-94bfe2c2e359db3059f456bc5f48673ee573b286bb4834719ca5173fceeffa50
https://github.com/python-control/python-control/pull/884/changes#diff-94bfe2c2e359db3059f456bc5f48673ee573b286bb4834719ca5173fceeffa50
https://github.com/python-control/python-control/pull/884/changes#diff-94bfe2c2e359db3059f456bc5f48673ee573b286bb4834719ca5173fceeffa50
https://github.com/python-control/python-control/pull/884/changes#diff-94bfe2c2e359db3059f456bc5f48673ee573b286bb4834719ca5173fceeffa50
https://github.com/python-control/python-control/pull/884/changes#diff-94bfe2c2e359db3059f456bc5f48673ee573b286bb4834719ca5173fceeffa50
https://github.com/python-control/python-control/pull/884/changes#diff-94bfe2c2e359db3059f456bc5f48673ee573b286bb4834719ca5173fceeffa50
https://github.com/python-control/python-control/pull/884/changes#diff-94bfe2c2e359db3059f456bc5f48673ee573b286bb4834719ca5173fceeffa50
https://github.com/python-control/python-control/pull/884/changes#diff-94bfe2c2e359db3059f456bc5f48673ee573b286bb4834719ca5173fceeffa50
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.