René's URL Explorer Experiment


Title: fix control.matlab.lsim bug for discrete time system by murrayrm · Pull Request #765 · python-control/python-control · GitHub

Open Graph Title: fix control.matlab.lsim bug for discrete time system by murrayrm · Pull Request #765 · python-control/python-control

X Title: fix control.matlab.lsim bug for discrete time system by murrayrm · Pull Request #765 · python-control/python-control

Description: This PR fixes issue #764. There was a dimension check in forced_response for discrete time systems that occurred before processing of the transpose parameter. Removing the dimension check (which gets done later, after transpose processing) fixes the bug. Add a unit test to catch the error and also turned on some tests that were @slycotonly but that didn't rely on slycot.

Open Graph Description: This PR fixes issue #764. There was a dimension check in forced_response for discrete time systems that occurred before processing of the transpose parameter. Removing the dimension check (which ...

X Description: This PR fixes issue #764. There was a dimension check in forced_response for discrete time systems that occurred before processing of the transpose parameter. Removing the dimension check (which ...

Opengraph URL: https://github.com/python-control/python-control/pull/765

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:ce1f579d-5aa7-ed68-fa5f-c9ac1175f13d
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9316:3DDA26:9AFCC:D5D8F:697BC681
html-safe-nonceab543f30cfc168bf680f9f6313ec22d3038197ecfaa8be1c87fa63a14531622e
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5MzE2OjNEREEyNjo5QUZDQzpENUQ4Rjo2OTdCQzY4MSIsInZpc2l0b3JfaWQiOiI4ODM1NDU4MDYxMzk3OTAyOTc3IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacdb0c8d2a03ccd1efb79caa48fd5183c54395ddb74364b95662c2cc2eb610d493
hovercard-subject-tagpull_request:1036242200
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python-control/python-control/pull/765/files
twitter:imagehttps://avatars.githubusercontent.com/u/293362?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/293362?s=400&v=4
og:image:altThis PR fixes issue #764. There was a dimension check in forced_response for discrete time systems that occurred before processing of the transpose parameter. Removing the dimension check (which ...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None300bc1c13c6b7e78c073c9264c722c624187bbdfc3b25a5b021396c805f56978
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python-control/python-control git https://github.com/python-control/python-control.git
octolytics-dimension-user_id2285872
octolytics-dimension-user_loginpython-control
octolytics-dimension-repository_id22791752
octolytics-dimension-repository_nwopython-control/python-control
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id22791752
octolytics-dimension-repository_network_root_nwopython-control/python-control
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasef571aa04a5e12a930e3b781f4b1c4b4408e5ba61
ui-targetcanary-1
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python-control/python-control/pull/765/changes#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython-control%2Fpython-control%2Fpull%2F765%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython-control%2Fpython-control%2Fpull%2F765%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python-control%2Fpython-control
Reloadhttps://github.com/python-control/python-control/pull/765/changes
Reloadhttps://github.com/python-control/python-control/pull/765/changes
Reloadhttps://github.com/python-control/python-control/pull/765/changes
python-control https://github.com/python-control
python-controlhttps://github.com/python-control/python-control
Notifications https://github.com/login?return_to=%2Fpython-control%2Fpython-control
Fork 447 https://github.com/login?return_to=%2Fpython-control%2Fpython-control
Star 2k https://github.com/login?return_to=%2Fpython-control%2Fpython-control
Code https://github.com/python-control/python-control
Issues 87 https://github.com/python-control/python-control/issues
Pull requests 8 https://github.com/python-control/python-control/pulls
Discussions https://github.com/python-control/python-control/discussions
Actions https://github.com/python-control/python-control/actions
Projects 0 https://github.com/python-control/python-control/projects
Wiki https://github.com/python-control/python-control/wiki
Security 0 https://github.com/python-control/python-control/security
Insights https://github.com/python-control/python-control/pulse
Code https://github.com/python-control/python-control
Issues https://github.com/python-control/python-control/issues
Pull requests https://github.com/python-control/python-control/pulls
Discussions https://github.com/python-control/python-control/discussions
Actions https://github.com/python-control/python-control/actions
Projects https://github.com/python-control/python-control/projects
Wiki https://github.com/python-control/python-control/wiki
Security https://github.com/python-control/python-control/security
Insights https://github.com/python-control/python-control/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython-control%2Fpython-control%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython-control%2Fpython-control%2Fissues%2Fnew%2Fchoose
bnavigatorhttps://github.com/bnavigator
python-control:mainhttps://github.com/python-control/python-control/tree/main
murrayrm:matlab.lsim-24Aug2022https://github.com/murrayrm/python-control/tree/matlab.lsim-24Aug2022
Conversation 2 https://github.com/python-control/python-control/pull/765
Commits 2 https://github.com/python-control/python-control/pull/765/commits
Checks 0 https://github.com/python-control/python-control/pull/765/checks
Files changed https://github.com/python-control/python-control/pull/765/files
Please reload this pagehttps://github.com/python-control/python-control/pull/765/changes
fix control.matlab.lsim bug for discrete time system https://github.com/python-control/python-control/pull/765/changes#top
Show all changes 2 commits https://github.com/python-control/python-control/pull/765/files
4c954d2 remove slycotonly from selected MIMO tests murrayrm Aug 25, 2022 https://github.com/python-control/python-control/pull/765/commits/4c954d21450ccfad4a13a98c1d08ddcad880cdff
6e3113a remove bad dimension check in forced_response for dtime systems murrayrm Aug 25, 2022 https://github.com/python-control/python-control/pull/765/commits/6e3113a0b82eec20712211b6ed77f2cc3692fa26
Clear filters https://github.com/python-control/python-control/pull/765/files
Please reload this pagehttps://github.com/python-control/python-control/pull/765/changes
Please reload this pagehttps://github.com/python-control/python-control/pull/765/changes
matlab_test.py https://github.com/python-control/python-control/pull/765/changes#diff-79c20f0d3385778d9d3499c17ebf67060db66785a0eae139486d3e7a468ceb32
timeresp_test.py https://github.com/python-control/python-control/pull/765/changes#diff-ecf5a23a5f3aa1be4faff8673255c1610fd61b011b8ed010e1dc1497e3d8a9b1
timeresp.py https://github.com/python-control/python-control/pull/765/changes#diff-3200453f1cf62f183f04dbf39d1129d91245c53a9f74675cee6bd384351c45b4
control/tests/matlab_test.pyhttps://github.com/python-control/python-control/pull/765/changes#diff-79c20f0d3385778d9d3499c17ebf67060db66785a0eae139486d3e7a468ceb32
View file https://github.com/murrayrm/python-control/blob/6e3113a0b82eec20712211b6ed77f2cc3692fa26/control/tests/matlab_test.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python-control/python-control/pull/765/{{ revealButtonHref }}
https://github.com/python-control/python-control/pull/765/changes#diff-79c20f0d3385778d9d3499c17ebf67060db66785a0eae139486d3e7a468ceb32
https://github.com/python-control/python-control/pull/765/changes#diff-79c20f0d3385778d9d3499c17ebf67060db66785a0eae139486d3e7a468ceb32
https://github.com/python-control/python-control/pull/765/changes#diff-79c20f0d3385778d9d3499c17ebf67060db66785a0eae139486d3e7a468ceb32
https://github.com/python-control/python-control/pull/765/changes#diff-79c20f0d3385778d9d3499c17ebf67060db66785a0eae139486d3e7a468ceb32
https://github.com/python-control/python-control/pull/765/changes#diff-79c20f0d3385778d9d3499c17ebf67060db66785a0eae139486d3e7a468ceb32
https://github.com/python-control/python-control/pull/765/changes#diff-79c20f0d3385778d9d3499c17ebf67060db66785a0eae139486d3e7a468ceb32
https://github.com/python-control/python-control/pull/765/changes#diff-79c20f0d3385778d9d3499c17ebf67060db66785a0eae139486d3e7a468ceb32
https://github.com/python-control/python-control/pull/765/changes#diff-79c20f0d3385778d9d3499c17ebf67060db66785a0eae139486d3e7a468ceb32
https://github.com/python-control/python-control/pull/765/changes#diff-79c20f0d3385778d9d3499c17ebf67060db66785a0eae139486d3e7a468ceb32
https://github.com/python-control/python-control/pull/765/changes#diff-79c20f0d3385778d9d3499c17ebf67060db66785a0eae139486d3e7a468ceb32
https://github.com/python-control/python-control/pull/765/changes#diff-79c20f0d3385778d9d3499c17ebf67060db66785a0eae139486d3e7a468ceb32
control/tests/timeresp_test.pyhttps://github.com/python-control/python-control/pull/765/changes#diff-ecf5a23a5f3aa1be4faff8673255c1610fd61b011b8ed010e1dc1497e3d8a9b1
View file https://github.com/murrayrm/python-control/blob/6e3113a0b82eec20712211b6ed77f2cc3692fa26/control/tests/timeresp_test.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python-control/python-control/pull/765/{{ revealButtonHref }}
https://github.com/python-control/python-control/pull/765/changes#diff-ecf5a23a5f3aa1be4faff8673255c1610fd61b011b8ed010e1dc1497e3d8a9b1
https://github.com/python-control/python-control/pull/765/changes#diff-ecf5a23a5f3aa1be4faff8673255c1610fd61b011b8ed010e1dc1497e3d8a9b1
control/timeresp.pyhttps://github.com/python-control/python-control/pull/765/changes#diff-3200453f1cf62f183f04dbf39d1129d91245c53a9f74675cee6bd384351c45b4
View file https://github.com/murrayrm/python-control/blob/6e3113a0b82eec20712211b6ed77f2cc3692fa26/control/timeresp.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python-control/python-control/pull/765/{{ revealButtonHref }}
https://github.com/python-control/python-control/pull/765/changes#diff-3200453f1cf62f183f04dbf39d1129d91245c53a9f74675cee6bd384351c45b4
https://github.com/python-control/python-control/pull/765/changes#diff-3200453f1cf62f183f04dbf39d1129d91245c53a9f74675cee6bd384351c45b4
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.