René's URL Explorer Experiment


Title: Fix timebase bug in InterconnectedSystem (issue #754) by murrayrm · Pull Request #755 · python-control/python-control · GitHub

Open Graph Title: Fix timebase bug in InterconnectedSystem (issue #754) by murrayrm · Pull Request #755 · python-control/python-control

X Title: Fix timebase bug in InterconnectedSystem (issue #754) by murrayrm · Pull Request #755 · python-control/python-control

Description: This PR fixes the timebase bug identified in issue #754. The fix was to modify the processing of the timebase in InterconnectedSystem so that it looks at the systems for the default timebase.

Open Graph Description: This PR fixes the timebase bug identified in issue #754. The fix was to modify the processing of the timebase in InterconnectedSystem so that it looks at the systems for the default timebase.

X Description: This PR fixes the timebase bug identified in issue #754. The fix was to modify the processing of the timebase in InterconnectedSystem so that it looks at the systems for the default timebase.

Opengraph URL: https://github.com/python-control/python-control/pull/755

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:c621ddb1-6f36-dad5-acae-d85ff184f6b9
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA0FA:2884EA:13FD512:1ACF57B:69797765
html-safe-noncec732439dd7f4929cf0735f5328dc5719c6548e397caeb98d6521924962c6cd76
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBMEZBOjI4ODRFQToxM0ZENTEyOjFBQ0Y1N0I6Njk3OTc3NjUiLCJ2aXNpdG9yX2lkIjoiNDg1MTY3ODg1ODQzODA4MDM1NyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac1255753749b1766790cd1a7dd8d799c36cacfd0e8e216ad3b0c533606dfc542a
hovercard-subject-tagpull_request:1017045963
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python-control/python-control/755/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/efa1b816936ee02d4af36cd04023f9d94460fd3278286f0e823d15895c61b840/python-control/python-control/pull/755
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/efa1b816936ee02d4af36cd04023f9d94460fd3278286f0e823d15895c61b840/python-control/python-control/pull/755
og:image:altThis PR fixes the timebase bug identified in issue #754. The fix was to modify the processing of the timebase in InterconnectedSystem so that it looks at the systems for the default timebase.
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamemurrayrm
hostnamegithub.com
expected-hostnamegithub.com
Nonec049b65ec7e54cbf2521f5a560b6527714c612b0bd169188e2ea6e16f83bd5f4
turbo-cache-controlno-preview
go-importgithub.com/python-control/python-control git https://github.com/python-control/python-control.git
octolytics-dimension-user_id2285872
octolytics-dimension-user_loginpython-control
octolytics-dimension-repository_id22791752
octolytics-dimension-repository_nwopython-control/python-control
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id22791752
octolytics-dimension-repository_network_root_nwopython-control/python-control
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release87b137883e35e2766c3d0f6a257c4044f6390b83
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python-control/python-control/pull/755#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython-control%2Fpython-control%2Fpull%2F755
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython-control%2Fpython-control%2Fpull%2F755
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python-control%2Fpython-control
Reloadhttps://github.com/python-control/python-control/pull/755
Reloadhttps://github.com/python-control/python-control/pull/755
Reloadhttps://github.com/python-control/python-control/pull/755
python-control https://github.com/python-control
python-controlhttps://github.com/python-control/python-control
Notifications https://github.com/login?return_to=%2Fpython-control%2Fpython-control
Fork 447 https://github.com/login?return_to=%2Fpython-control%2Fpython-control
Star 2k https://github.com/login?return_to=%2Fpython-control%2Fpython-control
Code https://github.com/python-control/python-control
Issues 87 https://github.com/python-control/python-control/issues
Pull requests 8 https://github.com/python-control/python-control/pulls
Discussions https://github.com/python-control/python-control/discussions
Actions https://github.com/python-control/python-control/actions
Projects 0 https://github.com/python-control/python-control/projects
Wiki https://github.com/python-control/python-control/wiki
Security 0 https://github.com/python-control/python-control/security
Insights https://github.com/python-control/python-control/pulse
Code https://github.com/python-control/python-control
Issues https://github.com/python-control/python-control/issues
Pull requests https://github.com/python-control/python-control/pulls
Discussions https://github.com/python-control/python-control/discussions
Actions https://github.com/python-control/python-control/actions
Projects https://github.com/python-control/python-control/projects
Wiki https://github.com/python-control/python-control/wiki
Security https://github.com/python-control/python-control/security
Insights https://github.com/python-control/python-control/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython-control%2Fpython-control%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython-control%2Fpython-control%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/python-control/python-control/pull/755#issue-comment-box
bnavigatorhttps://github.com/bnavigator
python-control:mainhttps://github.com/python-control/python-control/tree/main
murrayrm:timebase_bug-03Aug2022https://github.com/murrayrm/python-control/tree/timebase_bug-03Aug2022
Fix timebase bug in InterconnectedSystem (issue #754) https://github.com/python-control/python-control/pull/755#top
bnavigatorhttps://github.com/bnavigator
python-control:mainhttps://github.com/python-control/python-control/tree/main
murrayrm:timebase_bug-03Aug2022https://github.com/murrayrm/python-control/tree/timebase_bug-03Aug2022
Conversation 4 https://github.com/python-control/python-control/pull/755
Commits 3 https://github.com/python-control/python-control/pull/755/commits
Checks 0 https://github.com/python-control/python-control/pull/755/checks
Files changed https://github.com/python-control/python-control/pull/755/files
Please reload this pagehttps://github.com/python-control/python-control/pull/755
https://github.co/hiddenchars
https://github.com/python-control/python-control/pull/{{ revealButtonHref }}
https://github.com/murrayrm
murrayrmhttps://github.com/murrayrm
Aug 4, 2022https://github.com/python-control/python-control/pull/755#issue-1328066678
#754https://github.com/python-control/python-control/issues/754
Please reload this pagehttps://github.com/python-control/python-control/pull/755
https://github.com/murrayrm
murrayrmhttps://github.com/murrayrm
Aug 4, 2022https://github.com/python-control/python-control/pull/755#issuecomment-1204766398
Please reload this pagehttps://github.com/python-control/python-control/pull/755
https://github.com/murrayrm
murrayrmhttps://github.com/murrayrm
Aug 4, 2022 https://github.com/python-control/python-control/pull/755#ref-issue-1328076066
CI tests are failing (xvfb issue?) #756 https://github.com/python-control/python-control/issues/756
https://github.com/sawyerbfuller
sawyerbfullerhttps://github.com/sawyerbfuller
Aug 4, 2022 https://github.com/python-control/python-control/pull/755#pullrequestreview-1061314314
View reviewed changes https://github.com/python-control/python-control/pull/755/files
control/tests/timebase_test.pyhttps://github.com/python-control/python-control/pull/755/files#diff-612d6b19662d8e7789b877186aaaaf795d2a276b5b22f62c8c2f29f1bc72af8e
sawyerbfullerhttps://github.com/sawyerbfuller
Aug 4, 2022https://github.com/python-control/python-control/pull/755#discussion_r937373167
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
https://python-control.readthedocs.io/en/0.9.2/conventions.htmlhttps://python-control.readthedocs.io/en/0.9.2/conventions.html
Please reload this pagehttps://github.com/python-control/python-control/pull/755
murrayrmhttps://github.com/murrayrm
Aug 4, 2022https://github.com/python-control/python-control/pull/755#discussion_r937375666
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python-control/python-control/pull/755
https://github.com/murrayrm
murrayrmhttps://github.com/murrayrm
Aug 6, 2022 https://github.com/python-control/python-control/pull/755#ref-pullrequest-1330557600
Switch CI to mambaforge and conda-forge channel #757 https://github.com/python-control/python-control/pull/757
murrayrmhttps://github.com/murrayrm
August 5, 2022 21:37https://github.com/python-control/python-control/pull/755#commits-pushed-f17c919
https://github.com/murrayrm
fix timebase bug in InterconnectedSystem (issuehttps://github.com/python-control/python-control/pull/755/commits/f17c9194456b659c390c0190d14d2c38f5bc932c
python-control#754https://github.com/python-control/python-control/issues/754
)https://github.com/python-control/python-control/pull/755/commits/f17c9194456b659c390c0190d14d2c38f5bc932c
f17c919https://github.com/python-control/python-control/pull/755/commits/f17c9194456b659c390c0190d14d2c38f5bc932c
https://github.com/murrayrm
add additional checks for overriding timebasehttps://github.com/python-control/python-control/pull/755/commits/3c13f2c58eb17f37a95551a5171dc7c9ad45bd6b
3c13f2chttps://github.com/python-control/python-control/pull/755/commits/3c13f2c58eb17f37a95551a5171dc7c9ad45bd6b
https://github.com/murrayrm
added tests for dt=True case perhttps://github.com/python-control/python-control/pull/755/commits/cf304794745baf4aa246df30feccdc3b0c43a490
@sawyerbfullerhttps://github.com/sawyerbfuller
suggestionhttps://github.com/python-control/python-control/pull/755/commits/cf304794745baf4aa246df30feccdc3b0c43a490
cf30479https://github.com/python-control/python-control/pull/755/commits/cf304794745baf4aa246df30feccdc3b0c43a490
https://github.com/murrayrm
murrayrmhttps://github.com/murrayrm
force-pushedhttps://github.com/python-control/python-control/compare/229bfe64593ed9d69d8a042ee0728d8efa1efa94..cf304794745baf4aa246df30feccdc3b0c43a490
229bfe6https://github.com/python-control/python-control/commit/229bfe64593ed9d69d8a042ee0728d8efa1efa94
cf30479https://github.com/python-control/python-control/commit/cf304794745baf4aa246df30feccdc3b0c43a490
Compare https://github.com/python-control/python-control/compare/229bfe64593ed9d69d8a042ee0728d8efa1efa94..cf304794745baf4aa246df30feccdc3b0c43a490
August 6, 2022 04:37https://github.com/python-control/python-control/pull/755#event-7140459224
https://github.com/coveralls
coverallshttps://github.com/coveralls
Aug 6, 2022https://github.com/python-control/python-control/pull/755#issuecomment-1207147868
https://coveralls.io/builds/51466113
cf30479https://github.com/python-control/python-control/commit/cf304794745baf4aa246df30feccdc3b0c43a490
a73a03dhttps://github.com/python-control/python-control/commit/a73a03daecc0d40d04085948beecdb7419c13c37
Please reload this pagehttps://github.com/python-control/python-control/pull/755
https://github.com/bnavigator
bnavigatorhttps://github.com/bnavigator
b9cf384https://github.com/python-control/python-control/commit/b9cf384e57a70e2994878c51a0650224afef596a
Aug 6, 2022https://github.com/python-control/python-control/pull/755#event-7140641180
https://github.com/bnavigator
bnavigatorhttps://github.com/bnavigator
Aug 6, 2022 https://github.com/python-control/python-control/pull/755#ref-issue-1326489268
Bug: Incorrect ValueError: incompatible timebases #754 https://github.com/python-control/python-control/issues/754
https://github.com/murrayrm
murrayrmhttps://github.com/murrayrm
0.9.3https://github.com/python-control/python-control/milestone/11
Dec 24, 2022https://github.com/python-control/python-control/pull/755#event-8106673043
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython-control%2Fpython-control%2Fpull%2F755
https://github.com/sawyerbfuller
sawyerbfuller https://github.com/sawyerbfuller
https://github.com/python-control/python-control/pull/755/files/93411036aa1d0efa9d7f31c92877babf358f91e5
0.9.3 https://github.com/python-control/python-control/milestone/11
Please reload this pagehttps://github.com/python-control/python-control/pull/755
https://github.com/murrayrm
https://github.com/coveralls
https://github.com/sawyerbfuller
https://github.com/bnavigator
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.