Title: Improvements to Nichols chart plotting by roryyorke · Pull Request #723 · python-control/python-control · GitHub
Open Graph Title: Improvements to Nichols chart plotting by roryyorke · Pull Request #723 · python-control/python-control
X Title: Improvements to Nichols chart plotting by roryyorke · Pull Request #723 · python-control/python-control
Description: These are relatively minor updates to the Nichols chart (AKA grid) plotting. It's far from ideal; further possible improvements: more tightly fitting the chart to the view (or data) xlim and ylim (the "extent"); the pain here is figuring out which contours to plot, and where to place the labels depending on the limits, some contours will end up with a two visible segments recreating the axis on zoom and pan events this might not be too difficult; Axes support 'xlim_changed' and 'ylim_changed' events a deluxe version of this would be too add (secondary?) axes, and show the closed-loop gain and phase in the "data value" text (the "x= , y = " on the Matplotlib toolbar) I wonder if we could use a custom ContourSets, and plug into however that labelling is done? Here are some before-and-after pictures (left is before) of a few example systems. The new code gives a better result in almost all respects. One visible problem is that the closed-loop phase label for "0°" clashes with the "-40dB" (and similar) closed-loop gain label. The gains become crowded when the gain span is large (final figure), but that is the same in both versions. I haven't added tests; I'll see how much time I have to do that. Easyish tests: check for "tight" phase limits (see first example below) check that the axes child text elements are have clip_on (I'd have to not check title & tick labels, presume this is possible) check for existence of phase labels, contingent on label_cl_phases flag test both branches of the if in _inner_extents, and in fact test the behaviour in general by setting xlim & ylim before calling nichols_grid. Please suggest other tests. Details (commit message) Clip closed-loop contour labels. Add labels for constant closed-loop phase contours. Use smaller of data or view extents when deciding on how big, in phase, a chart to create. Use more uniformly spaced closed-loop phase contours, and use more widely-spaced contours when phase extent is large. Add optional ax argument, for axes to add grid to.
Open Graph Description: These are relatively minor updates to the Nichols chart (AKA grid) plotting. It's far from ideal; further possible improvements: more tightly fitting the chart to the view (or data) xlim and y...
X Description: These are relatively minor updates to the Nichols chart (AKA grid) plotting. It's far from ideal; further possible improvements: more tightly fitting the chart to the view (or data) xlim a...
Opengraph URL: https://github.com/python-control/python-control/pull/723
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:c8891ee6-836f-6364-42fc-dff316beea4d |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | DA40:38B173:109CB15:1571EF2:697E4AAA |
| html-safe-nonce | 1a12a6f8f729d37ccc09add37d88b78d482856eb3e168af551b535bf0232c080 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEQTQwOjM4QjE3MzoxMDlDQjE1OjE1NzFFRjI6Njk3RTRBQUEiLCJ2aXNpdG9yX2lkIjoiNzI4NzQ1NjE4MTgxODExNjc3OCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 3ef627512fa75ac19cdeb3ef7c78699ba811df458bc6e75dc511360633ad3f36 |
| hovercard-subject-tag | pull_request:911276517 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/python-control/python-control/pull/723/files |
| twitter:image | https://avatars.githubusercontent.com/u/110974?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/110974?s=400&v=4 |
| og:image:alt | These are relatively minor updates to the Nichols chart (AKA grid) plotting. It's far from ideal; further possible improvements: more tightly fitting the chart to the view (or data) xlim and y... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 60279d4097367e16897439d16d6bbe4180663db828c666eeed2656988ffe59f6 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/python-control/python-control git https://github.com/python-control/python-control.git |
| octolytics-dimension-user_id | 2285872 |
| octolytics-dimension-user_login | python-control |
| octolytics-dimension-repository_id | 22791752 |
| octolytics-dimension-repository_nwo | python-control/python-control |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 22791752 |
| octolytics-dimension-repository_network_root_nwo | python-control/python-control |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 7c85641c598ad130c74f7bcc27f58575cac69551 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width