| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:982043c7-ce3e-8f17-b910-7169ddf949f2 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | E47C:38B6CA:2C43B7:3BEEFC:697942ED |
| html-safe-nonce | 310ea21ca7ee382a90b52a93c4be005b605324627b467a315c71d098170f14ca |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFNDdDOjM4QjZDQToyQzQzQjc6M0JFRUZDOjY5Nzk0MkVEIiwidmlzaXRvcl9pZCI6IjQ4MzI1NTkwNTAwNTY4MzQzNyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | d532cb210783964a788d86bcb5b6f2a6d3b02c0b555f4e6df648e08233150020 |
| hovercard-subject-tag | pull_request:911019723 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python-control/python-control/722/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/4c0eede4600fd45aef9d5ede4c9cbf862e22bd9c6e0cc2d6d47ae683a2c97b1b/python-control/python-control/pull/722 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/4c0eede4600fd45aef9d5ede4c9cbf862e22bd9c6e0cc2d6d47ae683a2c97b1b/python-control/python-control/pull/722 |
| og:image:alt | This PR fixes a bug in the the way that the nyquist_plot command was implemented and introduces a bunch of enhancements, including some of the ideas in PR #671.
Bug fix: because of the new default ... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | murrayrm |
| hostname | github.com |
| expected-hostname | github.com |
| None | f9bf80f4f4d71a2f9361692e65b326c887a4b25c15fe127257a2d331d14031bd |
| turbo-cache-control | no-preview |
| go-import | github.com/python-control/python-control git https://github.com/python-control/python-control.git |
| octolytics-dimension-user_id | 2285872 |
| octolytics-dimension-user_login | python-control |
| octolytics-dimension-repository_id | 22791752 |
| octolytics-dimension-repository_nwo | python-control/python-control |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 22791752 |
| octolytics-dimension-repository_network_root_nwo | python-control/python-control |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 4aabbf3f1d27b754d95d7a9a6e02d14a5aaeb4e6 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/python-control/python-control/pull/722#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython-control%2Fpython-control%2Fpull%2F722 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython-control%2Fpython-control%2Fpull%2F722 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python-control%2Fpython-control |
| Reload | https://github.com/python-control/python-control/pull/722 |
| Reload | https://github.com/python-control/python-control/pull/722 |
| Reload | https://github.com/python-control/python-control/pull/722 |
|
python-control
| https://github.com/python-control |
| python-control | https://github.com/python-control/python-control |
|
Notifications
| https://github.com/login?return_to=%2Fpython-control%2Fpython-control |
|
Fork
447
| https://github.com/login?return_to=%2Fpython-control%2Fpython-control |
|
Star
2k
| https://github.com/login?return_to=%2Fpython-control%2Fpython-control |
|
Code
| https://github.com/python-control/python-control |
|
Issues
87
| https://github.com/python-control/python-control/issues |
|
Pull requests
8
| https://github.com/python-control/python-control/pulls |
|
Discussions
| https://github.com/python-control/python-control/discussions |
|
Actions
| https://github.com/python-control/python-control/actions |
|
Projects
0
| https://github.com/python-control/python-control/projects |
|
Wiki
| https://github.com/python-control/python-control/wiki |
|
Security
0
| https://github.com/python-control/python-control/security |
|
Insights
| https://github.com/python-control/python-control/pulse |
|
Code
| https://github.com/python-control/python-control |
|
Issues
| https://github.com/python-control/python-control/issues |
|
Pull requests
| https://github.com/python-control/python-control/pulls |
|
Discussions
| https://github.com/python-control/python-control/discussions |
|
Actions
| https://github.com/python-control/python-control/actions |
|
Projects
| https://github.com/python-control/python-control/projects |
|
Wiki
| https://github.com/python-control/python-control/wiki |
|
Security
| https://github.com/python-control/python-control/security |
|
Insights
| https://github.com/python-control/python-control/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fpython-control%2Fpython-control%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fpython-control%2Fpython-control%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/python-control/python-control/pull/722#issue-comment-box |
| murrayrm | https://github.com/murrayrm |
| python-control:master | https://github.com/python-control/python-control/tree/master |
| murrayrm:nyquist_bug_09Apr2022 | https://github.com/murrayrm/python-control/tree/nyquist_bug_09Apr2022 |
|
Bug fix and improvements to Nyquist plots
| https://github.com/python-control/python-control/pull/722#top |
| murrayrm | https://github.com/murrayrm |
| python-control:master | https://github.com/python-control/python-control/tree/master |
| murrayrm:nyquist_bug_09Apr2022 | https://github.com/murrayrm/python-control/tree/nyquist_bug_09Apr2022 |
|
Conversation
7
| https://github.com/python-control/python-control/pull/722 |
|
Commits
11
| https://github.com/python-control/python-control/pull/722/commits |
|
Checks
0
| https://github.com/python-control/python-control/pull/722/checks |
|
Files changed
| https://github.com/python-control/python-control/pull/722/files |
| Please reload this page | https://github.com/python-control/python-control/pull/722 |
| https://github.co/hiddenchars |
| https://github.com/python-control/python-control/pull/{{ revealButtonHref }} |
|
| https://github.com/murrayrm |
| murrayrm | https://github.com/murrayrm |
| Apr 15, 2022 | https://github.com/python-control/python-control/pull/722#issue-1205775241 |
| #671 | https://github.com/python-control/python-control/pull/671 |
| #534 | https://github.com/python-control/python-control/pull/534 |
| #671 | https://github.com/python-control/python-control/pull/671 |
| https://user-images.githubusercontent.com/293362/163602569-3f371159-4235-4e88-b8c5-64f131f08ca8.png |
| https://user-images.githubusercontent.com/293362/163602342-e00a07df-d486-496f-a779-5bd0b52e4e2b.png |
| https://user-images.githubusercontent.com/293362/163602369-5823a11c-b72c-4d2b-96d3-bfa52a93882e.png |
| https://user-images.githubusercontent.com/293362/163603070-c9e15cab-8634-4ecd-9193-d00b96517186.png |
| https://user-images.githubusercontent.com/293362/163603077-cfeb7cb9-a423-406a-99de-1965ee354d5d.png |
| https://user-images.githubusercontent.com/293362/163603203-f501868e-da87-436d-a9f9-7e1fd3530856.png |
| https://user-images.githubusercontent.com/293362/163603221-939c7f96-31d8-4629-ad12-853a0833d5b2.png |
| https://user-images.githubusercontent.com/293362/163606115-366e2daf-973a-40de-aa3c-13a3bb0af341.png |
| https://user-images.githubusercontent.com/293362/163606130-46d3e938-299d-4cc8-9a73-9f51f418aa08.png |
| Please reload this page | https://github.com/python-control/python-control/pull/722 |
| https://github.com/coveralls |
| coveralls | https://github.com/coveralls |
| Apr 15, 2022 | https://github.com/python-control/python-control/pull/722#issuecomment-1100275945 |
| Please reload this page | https://github.com/python-control/python-control/pull/722 |
| https://coveralls.io/builds/48330301 |
| 7407265 | https://github.com/python-control/python-control/commit/7407265496ecf03de95d31416a663afb09aa7d3c |
| 2102181 | https://github.com/python-control/python-control/commit/2102181c444221385a61ffb180f18ad5b45bc62f |
| Please reload this page | https://github.com/python-control/python-control/pull/722 |
| murrayrm | https://github.com/murrayrm |
| April 15, 2022 17:52 | https://github.com/python-control/python-control/pull/722#commits-pushed-18e997c |
|
| https://github.com/murrayrm |
| add warning for nyquist_plot() when indent_radius is too large | https://github.com/python-control/python-control/pull/722/commits/18e997c037db361076c4fb9c61250ef7139d03f9 |
| 18e997c | https://github.com/python-control/python-control/pull/722/commits/18e997c037db361076c4fb9c61250ef7139d03f9 |
|
| https://github.com/murrayrm |
| add warning for nyquist_plot() when Nyquist criterion isn't met | https://github.com/python-control/python-control/pull/722/commits/1e12a51f457a7ada030f5b80d25dabe27ad3f68a |
| 1e12a51 | https://github.com/python-control/python-control/pull/722/commits/1e12a51f457a7ada030f5b80d25dabe27ad3f68a |
|
| https://github.com/murrayrm |
| add code to limit magnitude of response and enhance contour near poles | https://github.com/python-control/python-control/pull/722/commits/6da87066cf065bde32b23222519e653b65a34df7 |
| 6da8706 | https://github.com/python-control/python-control/pull/722/commits/6da87066cf065bde32b23222519e653b65a34df7 |
|
| https://github.com/murrayrm |
| smooth curve offsets to avoid discontinuities | https://github.com/python-control/python-control/pull/722/commits/3d3a5593742c938f58a69a11a64406eadcd5dfd5 |
| 3d3a559 | https://github.com/python-control/python-control/pull/722/commits/3d3a5593742c938f58a69a11a64406eadcd5dfd5 |
|
| https://github.com/murrayrm |
| tweak max_curve_magnitude + add start point | https://github.com/python-control/python-control/pull/722/commits/aef3b0618faa2af26372219ea0c20e0ea34a16b4 |
| aef3b06 | https://github.com/python-control/python-control/pull/722/commits/aef3b0618faa2af26372219ea0c20e0ea34a16b4 |
|
| https://github.com/murrayrm |
| add warning if encirclements is not near an integer | https://github.com/python-control/python-control/pull/722/commits/c25c0cb39a00c22078d83a288302a21e4fc9e634 |
| c25c0cb | https://github.com/python-control/python-control/pull/722/commits/c25c0cb39a00c22078d83a288302a21e4fc9e634 |
|
| https://github.com/murrayrm |
| add legacy settings for nyquist | https://github.com/python-control/python-control/pull/722/commits/67c1f3f68944feecae6e9028744f2c007746423b |
| 67c1f3f | https://github.com/python-control/python-control/pull/722/commits/67c1f3f68944feecae6e9028744f2c007746423b |
|
| https://github.com/murrayrm |
| increase coverage; PEP8 cleanup | https://github.com/python-control/python-control/pull/722/commits/9a5759fb2809db1ca8c8f7ed42168646cc42be3a |
| 9a5759f | https://github.com/python-control/python-control/pull/722/commits/9a5759fb2809db1ca8c8f7ed42168646cc42be3a |
|
| https://github.com/murrayrm |
| turn off encirclement warnings for describing function plot | https://github.com/python-control/python-control/pull/722/commits/5dd6a70ba731983188e40e99a0519aef39b9767c |
| 5dd6a70 | https://github.com/python-control/python-control/pull/722/commits/5dd6a70ba731983188e40e99a0519aef39b9767c |
|
| https://github.com/murrayrm |
| rebase cleanup | https://github.com/python-control/python-control/pull/722/commits/5d9c7f0e890e1db7f41d5d2c4fbe93aece9cbdf9 |
| 5d9c7f0 | https://github.com/python-control/python-control/pull/722/commits/5d9c7f0e890e1db7f41d5d2c4fbe93aece9cbdf9 |
| https://github.com/murrayrm |
| murrayrm | https://github.com/murrayrm |
| force-pushed | https://github.com/python-control/python-control/compare/f3dfe04de48257803a751313ee638d09cb466c1a..5d9c7f0e890e1db7f41d5d2c4fbe93aece9cbdf9 |
| f3dfe04 | https://github.com/python-control/python-control/commit/f3dfe04de48257803a751313ee638d09cb466c1a |
| 5d9c7f0 | https://github.com/python-control/python-control/commit/5d9c7f0e890e1db7f41d5d2c4fbe93aece9cbdf9 |
|
Compare
| https://github.com/python-control/python-control/compare/f3dfe04de48257803a751313ee638d09cb466c1a..5d9c7f0e890e1db7f41d5d2c4fbe93aece9cbdf9 |
| April 16, 2022 00:59 | https://github.com/python-control/python-control/pull/722#event-6442734208 |
| https://github.com/murrayrm |
| murrayrm | https://github.com/murrayrm |
|
Apr 16, 2022
| https://github.com/python-control/python-control/pull/722#ref-issue-1104697350 |
|
Discontinuous Nyquist Plot
#691
| https://github.com/python-control/python-control/issues/691 |
| https://github.com/roryyorke |
| roryyorke | https://github.com/roryyorke |
|
Apr 16, 2022
| https://github.com/python-control/python-control/pull/722#pullrequestreview-943865656 |
|
View reviewed changes
| https://github.com/python-control/python-control/pull/722/files/5d9c7f0e890e1db7f41d5d2c4fbe93aece9cbdf9 |
| roryyorke | https://github.com/roryyorke |
| https://github.com/python-control/python-control/pull/722#pullrequestreview-943865656 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python-control/python-control/pull/722 |
| control/freqplot.py | https://github.com/python-control/python-control/pull/722/files/5d9c7f0e890e1db7f41d5d2c4fbe93aece9cbdf9#diff-a751fe1009e7b656d19357a39abb58dd88b89052c9d9259c3393a4648b697a16 |
| Please reload this page | https://github.com/python-control/python-control/pull/722 |
| control/freqplot.py | https://github.com/python-control/python-control/pull/722/files/5d9c7f0e890e1db7f41d5d2c4fbe93aece9cbdf9#diff-a751fe1009e7b656d19357a39abb58dd88b89052c9d9259c3393a4648b697a16 |
| Please reload this page | https://github.com/python-control/python-control/pull/722 |
| control/freqplot.py | https://github.com/python-control/python-control/pull/722/files/5d9c7f0e890e1db7f41d5d2c4fbe93aece9cbdf9#diff-a751fe1009e7b656d19357a39abb58dd88b89052c9d9259c3393a4648b697a16 |
| Please reload this page | https://github.com/python-control/python-control/pull/722 |
|
| https://github.com/murrayrm |
| Fixed docstrings per roryyorke plus discrete-time corrections | https://github.com/python-control/python-control/pull/722/commits/7407265496ecf03de95d31416a663afb09aa7d3c |
| 7407265 | https://github.com/python-control/python-control/pull/722/commits/7407265496ecf03de95d31416a663afb09aa7d3c |
| https://github.com/sawyerbfuller |
| sawyerbfuller | https://github.com/sawyerbfuller |
|
Apr 16, 2022
| https://github.com/python-control/python-control/pull/722#pullrequestreview-943892599 |
|
View reviewed changes
| https://github.com/python-control/python-control/pull/722/files/7407265496ecf03de95d31416a663afb09aa7d3c |
| control/freqplot.py | https://github.com/python-control/python-control/pull/722/files/7407265496ecf03de95d31416a663afb09aa7d3c#diff-a751fe1009e7b656d19357a39abb58dd88b89052c9d9259c3393a4648b697a16 |
| sawyerbfuller | https://github.com/sawyerbfuller |
| Apr 16, 2022 | https://github.com/python-control/python-control/pull/722#discussion_r851680646 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python-control/python-control/pull/722 |
| murrayrm | https://github.com/murrayrm |
| Apr 17, 2022 | https://github.com/python-control/python-control/pull/722#discussion_r851694406 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| https://user-images.githubusercontent.com/293362/163697990-6c0ef7a1-dee7-4e79-b97f-b3d6461db11c.png |
| https://user-images.githubusercontent.com/293362/163698076-e134ceb2-7ecc-43af-be60-8a1a0d7dbbb0.png |
| Please reload this page | https://github.com/python-control/python-control/pull/722 |
| https://github.com/murrayrm |
| murrayrm | https://github.com/murrayrm |
| 46b3c53 | https://github.com/python-control/python-control/commit/46b3c53f752ccc7359083e3347da82b6020c80e0 |
| Apr 25, 2022 | https://github.com/python-control/python-control/pull/722#event-6487529234 |
| https://github.com/murrayrm |
| murrayrm | https://github.com/murrayrm |
| April 26, 2022 05:20 | https://github.com/python-control/python-control/pull/722#event-6495574493 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython-control%2Fpython-control%2Fpull%2F722 |
|
| https://github.com/sawyerbfuller |
|
sawyerbfuller
| https://github.com/sawyerbfuller |
|
| https://github.com/python-control/python-control/pull/722/files/7407265496ecf03de95d31416a663afb09aa7d3c |
|
| https://github.com/roryyorke |
|
roryyorke
| https://github.com/roryyorke |
|
| https://github.com/python-control/python-control/pull/722/files/5d9c7f0e890e1db7f41d5d2c4fbe93aece9cbdf9 |
| Please reload this page | https://github.com/python-control/python-control/pull/722 |
|
| https://github.com/murrayrm |
|
| https://github.com/coveralls |
|
| https://github.com/roryyorke |
|
| https://github.com/sawyerbfuller |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |