René's URL Explorer Experiment


Title: Fix warning messages in rootlocus_pid_designer unit tests by murrayrm · Pull Request #684 · python-control/python-control · GitHub

Open Graph Title: Fix warning messages in rootlocus_pid_designer unit tests by murrayrm · Pull Request #684 · python-control/python-control

X Title: Fix warning messages in rootlocus_pid_designer unit tests by murrayrm · Pull Request #684 · python-control/python-control

Description: This PR gets rid of warning messages introduced in PR #662: Since rootlocus_pid_designer leaves either r or d disconnected, the interconnect function was generating warnings (76 of them...). This was fixed by using check_unused=False. Calling rootlocus_pid_designer with plot=True seems to generate a Bode plot that is -1 and this creates a warning: control/ctrlutil.py:75: RuntimeWarning: invalid value encountered in remainder dangle_desired = (dangle + period/2.) % period - period/2. For now this latter problem is fixed by skipping this test. @sawyerbfuller I'm not quite sure how to fix this error. If I try running the test by hand using ct.rootlocus_pid_designer(syscont, input_signal='r', Kp0=0.01, derivative_in_feedback_path=True, gain='P') then I get the following plot:

Open Graph Description: This PR gets rid of warning messages introduced in PR #662: Since rootlocus_pid_designer leaves either r or d disconnected, the interconnect function was generating warnings (76 of them...). This...

X Description: This PR gets rid of warning messages introduced in PR #662: Since rootlocus_pid_designer leaves either r or d disconnected, the interconnect function was generating warnings (76 of them...). This...

Opengraph URL: https://github.com/python-control/python-control/pull/684

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:15ab5a47-4121-6c2f-4ce7-52f2f4e44f3c
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA698:1C1FF4:E4CA68:13A3A5A:697A7E5F
html-safe-nonce123b28f1a240986bb3d42ff4c9a11c4a996b3d3eb6487eb0c79d9e9c051547fc
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBNjk4OjFDMUZGNDpFNENBNjg6MTNBM0E1QTo2OTdBN0U1RiIsInZpc2l0b3JfaWQiOiI2MTA5OTA5MTUxNTA2OTIzMTAzIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacdffa3e374662023e093172202e412b07e771d1fcbee579b34f3bc41e0e583357
hovercard-subject-tagpull_request:810212471
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python-control/python-control/pull/684/files
twitter:imagehttps://avatars.githubusercontent.com/u/293362?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/293362?s=400&v=4
og:image:altThis PR gets rid of warning messages introduced in PR #662: Since rootlocus_pid_designer leaves either r or d disconnected, the interconnect function was generating warnings (76 of them...). This...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonef6192227ebb08ae3d66e887f7363efea6f1ba29abe280990e1f6ad2d2962b6c8
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python-control/python-control git https://github.com/python-control/python-control.git
octolytics-dimension-user_id2285872
octolytics-dimension-user_loginpython-control
octolytics-dimension-repository_id22791752
octolytics-dimension-repository_nwopython-control/python-control
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id22791752
octolytics-dimension-repository_network_root_nwopython-control/python-control
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release7f58967b50cdccb4b617fbacac94376e17eef59e
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python-control/python-control/pull/684/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython-control%2Fpython-control%2Fpull%2F684%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython-control%2Fpython-control%2Fpull%2F684%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python-control%2Fpython-control
Reloadhttps://github.com/python-control/python-control/pull/684/files
Reloadhttps://github.com/python-control/python-control/pull/684/files
Reloadhttps://github.com/python-control/python-control/pull/684/files
python-control https://github.com/python-control
python-controlhttps://github.com/python-control/python-control
Notifications https://github.com/login?return_to=%2Fpython-control%2Fpython-control
Fork 447 https://github.com/login?return_to=%2Fpython-control%2Fpython-control
Star 2k https://github.com/login?return_to=%2Fpython-control%2Fpython-control
Code https://github.com/python-control/python-control
Issues 87 https://github.com/python-control/python-control/issues
Pull requests 8 https://github.com/python-control/python-control/pulls
Discussions https://github.com/python-control/python-control/discussions
Actions https://github.com/python-control/python-control/actions
Projects 0 https://github.com/python-control/python-control/projects
Wiki https://github.com/python-control/python-control/wiki
Security 0 https://github.com/python-control/python-control/security
Insights https://github.com/python-control/python-control/pulse
Code https://github.com/python-control/python-control
Issues https://github.com/python-control/python-control/issues
Pull requests https://github.com/python-control/python-control/pulls
Discussions https://github.com/python-control/python-control/discussions
Actions https://github.com/python-control/python-control/actions
Projects https://github.com/python-control/python-control/projects
Wiki https://github.com/python-control/python-control/wiki
Security https://github.com/python-control/python-control/security
Insights https://github.com/python-control/python-control/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython-control%2Fpython-control%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython-control%2Fpython-control%2Fissues%2Fnew%2Fchoose
murrayrmhttps://github.com/murrayrm
python-control:masterhttps://github.com/python-control/python-control/tree/master
murrayrm:fix_pid_designer_warningshttps://github.com/murrayrm/python-control/tree/fix_pid_designer_warnings
Conversation 2 https://github.com/python-control/python-control/pull/684
Commits 2 https://github.com/python-control/python-control/pull/684/commits
Checks 0 https://github.com/python-control/python-control/pull/684/checks
Files changed https://github.com/python-control/python-control/pull/684/files
Please reload this pagehttps://github.com/python-control/python-control/pull/684/files
Fix warning messages in rootlocus_pid_designer unit tests https://github.com/python-control/python-control/pull/684/files#top
Show all changes 2 commits https://github.com/python-control/python-control/pull/684/files
674f6f6 fix warning messages in pid_designer murrayrm Dec 27, 2021 https://github.com/python-control/python-control/pull/684/commits/674f6f6868a1f672e0aea4be1be2093110749070
7cfa42a skip rootlocus_pid_designer tests that are generating warnings murrayrm Dec 27, 2021 https://github.com/python-control/python-control/pull/684/commits/7cfa42a97b2e91188c294a417dd15af0f8e580a6
Clear filters https://github.com/python-control/python-control/pull/684/files
Please reload this pagehttps://github.com/python-control/python-control/pull/684/files
Please reload this pagehttps://github.com/python-control/python-control/pull/684/files
sisotool.py https://github.com/python-control/python-control/pull/684/files#diff-5b1b1a164f395f3f0ea7bad5761983be0d398ad5462147b1f69de6dd48a52e1d
sisotool_test.py https://github.com/python-control/python-control/pull/684/files#diff-b3c0bda12803d07552099104b16bef2d88e8704596539d753460355deeea0c92
control/sisotool.pyhttps://github.com/python-control/python-control/pull/684/files#diff-5b1b1a164f395f3f0ea7bad5761983be0d398ad5462147b1f69de6dd48a52e1d
View file https://github.com/murrayrm/python-control/blob/7cfa42a97b2e91188c294a417dd15af0f8e580a6/control/sisotool.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python-control/python-control/pull/684/{{ revealButtonHref }}
https://github.com/python-control/python-control/pull/684/files#diff-5b1b1a164f395f3f0ea7bad5761983be0d398ad5462147b1f69de6dd48a52e1d
https://github.com/python-control/python-control/pull/684/files#diff-5b1b1a164f395f3f0ea7bad5761983be0d398ad5462147b1f69de6dd48a52e1d
control/tests/sisotool_test.pyhttps://github.com/python-control/python-control/pull/684/files#diff-b3c0bda12803d07552099104b16bef2d88e8704596539d753460355deeea0c92
View file https://github.com/murrayrm/python-control/blob/7cfa42a97b2e91188c294a417dd15af0f8e580a6/control/tests/sisotool_test.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python-control/python-control/pull/684/{{ revealButtonHref }}
https://github.com/python-control/python-control/pull/684/files#diff-b3c0bda12803d07552099104b16bef2d88e8704596539d753460355deeea0c92
https://github.com/python-control/python-control/pull/684/files#diff-b3c0bda12803d07552099104b16bef2d88e8704596539d753460355deeea0c92
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.