Title: LQR using SciPy by murrayrm · Pull Request #683 · python-control/python-control · GitHub
Open Graph Title: LQR using SciPy by murrayrm · Pull Request #683 · python-control/python-control
X Title: LQR using SciPy by murrayrm · Pull Request #683 · python-control/python-control
Description: This PR updates the mateqn module to allow the use of SciPy linear algebra functions as a replacement for Slycot functions. Among other things, this allows the use of the lqr command without having to install Slycot. I implemented this by changing all of the mateqn functions (lyap, care, dare, etc) to accept at method keyword that can either be scipy or slycot. The default value for method is slycot if it is installed, otherwise scipy, so there is no change in behavior if you have Slycot. Other changes: Updated lqr to call care rather than replicating the code and cleaned up a lot of the code in mateqn to be more Pythonic. Modified the slycot_check function so that it stores the result of checking whether slycot can be imported rather than trying to import every time the function is called. Implemented a function for checking size and properties of matrices passed to mateqn functions (mateqn._check_shape) that provides more consistent errors (this also required updating some of the unit tests). Modified dare to solve the generalized Sylvester equation using slycot.sg02ad rather than using slycot.sg02md to solve the simplified form of the discrete algebraic Riccati equation because there seems to be an error in the way that stabilizing is handled in sg02md (it returns the closed loop eigenvalues in the wrong order). (I'm working on generating a concrete counterexample for posting to Slycot.)
Open Graph Description: This PR updates the mateqn module to allow the use of SciPy linear algebra functions as a replacement for Slycot functions. Among other things, this allows the use of the lqr command without havin...
X Description: This PR updates the mateqn module to allow the use of SciPy linear algebra functions as a replacement for Slycot functions. Among other things, this allows the use of the lqr command without havin...
Opengraph URL: https://github.com/python-control/python-control/pull/683
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:bda11419-2e6e-a01a-cea0-24bcc0682970 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | A832:A959E:106CFBC:1715712:697A0950 |
| html-safe-nonce | 473f7bcc92088682c6381f87f270931828327159e978713741c616cb77079ce4 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBODMyOkE5NTlFOjEwNkNGQkM6MTcxNTcxMjo2OTdBMDk1MCIsInZpc2l0b3JfaWQiOiIxOTUzMzk0MTc5NDg5MTYwNDgiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 32701cb4fb305b3ad8dc4739fa4e5c651e8945f86cce1c72e727e9b4a92eded7 |
| hovercard-subject-tag | pull_request:809760729 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/python-control/python-control/pull/683/files |
| twitter:image | https://avatars.githubusercontent.com/u/293362?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/293362?s=400&v=4 |
| og:image:alt | This PR updates the mateqn module to allow the use of SciPy linear algebra functions as a replacement for Slycot functions. Among other things, this allows the use of the lqr command without havin... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 24021c77440f544078f9cbe80d78a2fb16ccff65fca92deda9da3c51d1cdc5fc |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/python-control/python-control git https://github.com/python-control/python-control.git |
| octolytics-dimension-user_id | 2285872 |
| octolytics-dimension-user_login | python-control |
| octolytics-dimension-repository_id | 22791752 |
| octolytics-dimension-repository_nwo | python-control/python-control |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 22791752 |
| octolytics-dimension-repository_network_root_nwo | python-control/python-control |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | bd34d6cb576e14ec8da51f144ef82b621f68256d |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width