| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:f7b28d05-c767-d614-e50c-9f1e3a3aac42 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 8986:12F576:417231:598953:697BD108 |
| html-safe-nonce | aa6ebf1b3691e498ca2c2eb0bafd0b8e9222b98e8ea12a7b01be67f4a614a60b |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4OTg2OjEyRjU3Njo0MTcyMzE6NTk4OTUzOjY5N0JEMTA4IiwidmlzaXRvcl9pZCI6IjU5NjA4ODI2ODEyMTMwNzk4MTYiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 47d6e7272a2f40c3a3bad36c1f51ff057ed558cc1d81bf7273ff23bb2de32df2 |
| hovercard-subject-tag | pull_request:771806698 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///pull_requests/show/files |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/python-control/python-control/pull/662/files |
| twitter:image | https://avatars.githubusercontent.com/u/58706249?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/58706249?s=400&v=4 |
| og:image:alt | Provides a manual means of tuning a PID controller but does not attempt an automatic solution, thus its name pid_designer. Edit: renamed function to rootlocus_pid_designer to distinguish it from lo... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 88b7b3079ea5046bb661ad315dabef17ecc28e5f9f988d30044f4f6e56520728 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/python-control/python-control git https://github.com/python-control/python-control.git |
| octolytics-dimension-user_id | 2285872 |
| octolytics-dimension-user_login | python-control |
| octolytics-dimension-repository_id | 22791752 |
| octolytics-dimension-repository_nwo | python-control/python-control |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 22791752 |
| octolytics-dimension-repository_network_root_nwo | python-control/python-control |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 42cddef55c232612d1a39797b85abf955112a1b4 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/python-control/python-control/pull/662/changes#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython-control%2Fpython-control%2Fpull%2F662%2Ffiles |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython-control%2Fpython-control%2Fpull%2F662%2Ffiles |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python-control%2Fpython-control |
| Reload | https://github.com/python-control/python-control/pull/662/changes |
| Reload | https://github.com/python-control/python-control/pull/662/changes |
| Reload | https://github.com/python-control/python-control/pull/662/changes |
|
python-control
| https://github.com/python-control |
| python-control | https://github.com/python-control/python-control |
|
Notifications
| https://github.com/login?return_to=%2Fpython-control%2Fpython-control |
|
Fork
447
| https://github.com/login?return_to=%2Fpython-control%2Fpython-control |
|
Star
2k
| https://github.com/login?return_to=%2Fpython-control%2Fpython-control |
|
Code
| https://github.com/python-control/python-control |
|
Issues
87
| https://github.com/python-control/python-control/issues |
|
Pull requests
8
| https://github.com/python-control/python-control/pulls |
|
Discussions
| https://github.com/python-control/python-control/discussions |
|
Actions
| https://github.com/python-control/python-control/actions |
|
Projects
0
| https://github.com/python-control/python-control/projects |
|
Wiki
| https://github.com/python-control/python-control/wiki |
|
Security
0
| https://github.com/python-control/python-control/security |
|
Insights
| https://github.com/python-control/python-control/pulse |
|
Code
| https://github.com/python-control/python-control |
|
Issues
| https://github.com/python-control/python-control/issues |
|
Pull requests
| https://github.com/python-control/python-control/pulls |
|
Discussions
| https://github.com/python-control/python-control/discussions |
|
Actions
| https://github.com/python-control/python-control/actions |
|
Projects
| https://github.com/python-control/python-control/projects |
|
Wiki
| https://github.com/python-control/python-control/wiki |
|
Security
| https://github.com/python-control/python-control/security |
|
Insights
| https://github.com/python-control/python-control/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fpython-control%2Fpython-control%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fpython-control%2Fpython-control%2Fissues%2Fnew%2Fchoose |
| bnavigator | https://github.com/bnavigator |
| python-control:master | https://github.com/python-control/python-control/tree/master |
| sawyerbfuller:pid-designer | https://github.com/sawyerbfuller/python-control/tree/pid-designer |
|
Conversation
7
| https://github.com/python-control/python-control/pull/662 |
|
Commits
10
| https://github.com/python-control/python-control/pull/662/commits |
|
Checks
0
| https://github.com/python-control/python-control/pull/662/checks |
|
Files changed
| https://github.com/python-control/python-control/pull/662/files |
| Please reload this page | https://github.com/python-control/python-control/pull/662/changes |
|
new Pid design function built on sisotool
| https://github.com/python-control/python-control/pull/662/changes#top |
|
Show all changes
10 commits
| https://github.com/python-control/python-control/pull/662/files |
|
3263646
new pid-designer, built on sisotool, for manual tuning of a PID contr…
sawyerbfuller Nov 2, 2021
| https://github.com/python-control/python-control/pull/662/commits/3263646588936fcd506838f1fecab458a3b8b0da |
|
c4bd384
attribution
sawyerbfuller Nov 2, 2021
| https://github.com/python-control/python-control/pull/662/commits/c4bd38406f81197228b51c995e8f808752bd230a |
|
ffd7b5f
changed color of root locus pole markers to black instead of randomly…
sawyerbfuller Nov 2, 2021
| https://github.com/python-control/python-control/pull/662/commits/ffd7b5fbd4e083f79998328c276fd4f0bf942b7b |
|
cd7faaa
fixed unit test code
sawyerbfuller Nov 2, 2021
| https://github.com/python-control/python-control/pull/662/commits/cd7faaa12206d4f339c243ab71e346bb818301b4 |
|
ec0f0a8
renamed function to highlight that it is based on root locus, set ini…
sawyerbfuller Nov 4, 2021
| https://github.com/python-control/python-control/pull/662/commits/ec0f0a83f22677b088c5e8c35e7c605c5840d18f |
|
3dca645
fix for github #623
sawyerbfuller Nov 4, 2021
| https://github.com/python-control/python-control/pull/662/commits/3dca645452bb634f752ed3cd6546ce7a71c01072 |
|
5c3e823
added pointer to new function to docs
sawyerbfuller Nov 5, 2021
| https://github.com/python-control/python-control/pull/662/commits/5c3e82376550bad740814b4a905a27a74d023f19 |
|
2af1171
more comprehensive system construction tests
sawyerbfuller Nov 5, 2021
| https://github.com/python-control/python-control/pull/662/commits/2af117130d388b91a3b0b742879e3c6250e232a7 |
|
746e089
return loop transfer function as statespace
sawyerbfuller Nov 5, 2021
| https://github.com/python-control/python-control/pull/662/commits/746e089e3d93639a69c9dfc87ac2df29b95ecc4d |
|
4ee9fd1
small docstring fix
sawyerbfuller Nov 5, 2021
| https://github.com/python-control/python-control/pull/662/commits/4ee9fd172906cf7beac77be396ced251e79eb90c |
|
Clear filters
| https://github.com/python-control/python-control/pull/662/files |
| Please reload this page | https://github.com/python-control/python-control/pull/662/changes |
| Please reload this page | https://github.com/python-control/python-control/pull/662/changes |
|
rlocus.py
| https://github.com/python-control/python-control/pull/662/changes#diff-6846933c325aaef66d5b0aa46a0ea077a03dcaf1edb4e513d795d8bc938ce2ee |
|
sisotool.py
| https://github.com/python-control/python-control/pull/662/changes#diff-5b1b1a164f395f3f0ea7bad5761983be0d398ad5462147b1f69de6dd48a52e1d |
|
lti_test.py
| https://github.com/python-control/python-control/pull/662/changes#diff-485af8392823eae5427ee85989fd5a2da1379077477709269159b5b28336abd1 |
|
sisotool_test.py
| https://github.com/python-control/python-control/pull/662/changes#diff-b3c0bda12803d07552099104b16bef2d88e8704596539d753460355deeea0c92 |
|
control.rst
| https://github.com/python-control/python-control/pull/662/changes#diff-5a8429a2bfd64a7041b2ba651f0f4a0318299c85c8dd095c1150fe7c788ddcb4 |
| control/rlocus.py | https://github.com/python-control/python-control/pull/662/changes#diff-6846933c325aaef66d5b0aa46a0ea077a03dcaf1edb4e513d795d8bc938ce2ee |
|
View file
| https://github.com/sawyerbfuller/python-control/blob/4ee9fd172906cf7beac77be396ced251e79eb90c/control/rlocus.py |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/python-control/python-control/pull/662/{{ revealButtonHref }} |
|
| https://github.com/python-control/python-control/pull/662/changes#diff-6846933c325aaef66d5b0aa46a0ea077a03dcaf1edb4e513d795d8bc938ce2ee |
|
| https://github.com/python-control/python-control/pull/662/changes#diff-6846933c325aaef66d5b0aa46a0ea077a03dcaf1edb4e513d795d8bc938ce2ee |
|
| https://github.com/python-control/python-control/pull/662/changes#diff-6846933c325aaef66d5b0aa46a0ea077a03dcaf1edb4e513d795d8bc938ce2ee |
|
| https://github.com/python-control/python-control/pull/662/changes#diff-6846933c325aaef66d5b0aa46a0ea077a03dcaf1edb4e513d795d8bc938ce2ee |
|
| https://github.com/python-control/python-control/pull/662/changes#diff-6846933c325aaef66d5b0aa46a0ea077a03dcaf1edb4e513d795d8bc938ce2ee |
|
| https://github.com/python-control/python-control/pull/662/changes#diff-6846933c325aaef66d5b0aa46a0ea077a03dcaf1edb4e513d795d8bc938ce2ee |
|
| https://github.com/python-control/python-control/pull/662/changes#diff-6846933c325aaef66d5b0aa46a0ea077a03dcaf1edb4e513d795d8bc938ce2ee |
| control/sisotool.py | https://github.com/python-control/python-control/pull/662/changes#diff-5b1b1a164f395f3f0ea7bad5761983be0d398ad5462147b1f69de6dd48a52e1d |
|
View file
| https://github.com/sawyerbfuller/python-control/blob/4ee9fd172906cf7beac77be396ced251e79eb90c/control/sisotool.py |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/python-control/python-control/pull/662/{{ revealButtonHref }} |
|
| https://github.com/python-control/python-control/pull/662/changes#diff-5b1b1a164f395f3f0ea7bad5761983be0d398ad5462147b1f69de6dd48a52e1d |
|
| https://github.com/python-control/python-control/pull/662/changes#diff-5b1b1a164f395f3f0ea7bad5761983be0d398ad5462147b1f69de6dd48a52e1d |
| control/tests/lti_test.py | https://github.com/python-control/python-control/pull/662/changes#diff-485af8392823eae5427ee85989fd5a2da1379077477709269159b5b28336abd1 |
|
View file
| https://github.com/sawyerbfuller/python-control/blob/4ee9fd172906cf7beac77be396ced251e79eb90c/control/tests/lti_test.py |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/python-control/python-control/pull/662/{{ revealButtonHref }} |
|
| https://github.com/python-control/python-control/pull/662/changes#diff-485af8392823eae5427ee85989fd5a2da1379077477709269159b5b28336abd1 |
|
| https://github.com/python-control/python-control/pull/662/changes#diff-485af8392823eae5427ee85989fd5a2da1379077477709269159b5b28336abd1 |
|
| https://github.com/python-control/python-control/pull/662/changes#diff-485af8392823eae5427ee85989fd5a2da1379077477709269159b5b28336abd1 |
|
| https://github.com/python-control/python-control/pull/662/changes#diff-485af8392823eae5427ee85989fd5a2da1379077477709269159b5b28336abd1 |
| control/tests/sisotool_test.py | https://github.com/python-control/python-control/pull/662/changes#diff-b3c0bda12803d07552099104b16bef2d88e8704596539d753460355deeea0c92 |
|
View file
| https://github.com/sawyerbfuller/python-control/blob/4ee9fd172906cf7beac77be396ced251e79eb90c/control/tests/sisotool_test.py |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/python-control/python-control/pull/662/{{ revealButtonHref }} |
|
| https://github.com/python-control/python-control/pull/662/changes#diff-b3c0bda12803d07552099104b16bef2d88e8704596539d753460355deeea0c92 |
|
| https://github.com/python-control/python-control/pull/662/changes#diff-b3c0bda12803d07552099104b16bef2d88e8704596539d753460355deeea0c92 |
|
| https://github.com/python-control/python-control/pull/662/changes#diff-b3c0bda12803d07552099104b16bef2d88e8704596539d753460355deeea0c92 |
| doc/control.rst | https://github.com/python-control/python-control/pull/662/changes#diff-5a8429a2bfd64a7041b2ba651f0f4a0318299c85c8dd095c1150fe7c788ddcb4 |
|
View file
| https://github.com/sawyerbfuller/python-control/blob/4ee9fd172906cf7beac77be396ced251e79eb90c/doc/control.rst |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/python-control/python-control/pull/662/{{ revealButtonHref }} |
|
| https://github.com/python-control/python-control/pull/662/changes#diff-5a8429a2bfd64a7041b2ba651f0f4a0318299c85c8dd095c1150fe7c788ddcb4 |
|
| https://github.com/python-control/python-control/pull/662/changes#diff-5a8429a2bfd64a7041b2ba651f0f4a0318299c85c8dd095c1150fe7c788ddcb4 |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |