Title: Fix warnings generated by sisotool by roryyorke · Pull Request #608 · python-control/python-control · GitHub
Open Graph Title: Fix warnings generated by sisotool by roryyorke · Pull Request #608 · python-control/python-control
X Title: Fix warnings generated by sisotool by roryyorke · Pull Request #608 · python-control/python-control
Description: Use recommended canvas.manager.{get,set}_window_title instead of deprecated canvas.{get,set}_window_title. Remove redundant marker specification in sisotool rlocus plot.canvas.manager.{get,set}_window_title Fixes these warnings on master (Python 3.9.2, Matplotlib 3.4.1, python-control 8299ebb): ontrol/tests/sisotool_test.py::TestSisotool::test_sisotool control/tests/sisotool_test.py::TestSisotool::test_sisotool_tvect control/tests/sisotool_test.py::TestSisotool::test_sisotool_tvect_dt control/tests/sisotool_test.py::TestSisotool::test_sisotool_mimo /home/rory/src/python-control/control/sisotool.py:84: MatplotlibDeprecationWarning: The get_window_title function was deprecated in Matplotlib 3.4 and will be removed two minor releases later. Use manager.get_window_title or GUI-specific methods instead. if fig.canvas.get_window_title() != 'Sisotool': control/tests/sisotool_test.py::TestSisotool::test_sisotool control/tests/sisotool_test.py::TestSisotool::test_sisotool_tvect control/tests/sisotool_test.py::TestSisotool::test_sisotool_tvect_dt control/tests/sisotool_test.py::TestSisotool::test_sisotool_mimo /home/rory/src/python-control/control/sisotool.py:87: MatplotlibDeprecationWarning: The set_window_title function was deprecated in Matplotlib 3.4 and will be removed two minor releases later. Use manager.set_window_title or GUI-specific methods instead. fig.canvas.set_window_title('Sisotool') control/tests/sisotool_test.py::TestSisotool::test_sisotool control/tests/sisotool_test.py::TestSisotool::test_sisotool_tvect control/tests/sisotool_test.py::TestSisotool::test_sisotool_tvect_dt control/tests/sisotool_test.py::TestSisotool::test_sisotool_mimo /home/rory/src/python-control/control/rlocus.py:180: UserWarning: marker is redundantly defined by the 'marker' keyword argument and the fmt string "m." (-> marker='.'). The keyword argument will take precedence. fig.axes[1].plot( control/tests/sisotool_test.py::TestSisotool::test_sisotool control/tests/sisotool_test.py::TestSisotool::test_sisotool_tvect control/tests/sisotool_test.py::TestSisotool::test_sisotool_tvect_dt /home/rory/src/python-control/control/rlocus.py:628: UserWarning: marker is redundantly defined by the 'marker' keyword argument and the fmt string "m." (-> marker='.'). The keyword argument will take precedence. ax_rlocus.plot(
Open Graph Description: Use recommended canvas.manager.{get,set}_window_title instead of deprecated canvas.{get,set}_window_title. Remove redundant marker specification in sisotool rlocus plot.canvas.manager.{get,set}_win...
X Description: Use recommended canvas.manager.{get,set}_window_title instead of deprecated canvas.{get,set}_window_title. Remove redundant marker specification in sisotool rlocus plot.canvas.manager.{get,set}_win...
Opengraph URL: https://github.com/python-control/python-control/pull/608
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/checks(.:format) |
| route-controller | pull_requests |
| route-action | checks |
| fetch-nonce | v2:1ae7d22f-069e-af58-1fe2-2f47dce8494e |
| current-catalog-service-hash | 87dc3bc62d9b466312751bfd5f889726f4f1337bdff4e8be7da7c93d6c00a25a |
| request-id | C08C:26E572:8AAE27:C6C29B:697A210B |
| html-safe-nonce | ab0edc6ab262c911545a46ce3a6bba4c0c45860261beea64566d01f11b846153 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDMDhDOjI2RTU3Mjo4QUFFMjc6QzZDMjlCOjY5N0EyMTBCIiwidmlzaXRvcl9pZCI6IjgxMDQzMTgzNzQwNzYwOTY3NzkiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 5128f33786cf25485d528486f07ec12271000ed778231ecf14004d2c33f2c62d |
| hovercard-subject-tag | pull_request:613077853 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,checks,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/python-control/python-control/pull/608/checks |
| twitter:image | https://avatars.githubusercontent.com/u/110974?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/110974?s=400&v=4 |
| og:image:alt | Use recommended canvas.manager.{get,set}_window_title instead of deprecated canvas.{get,set}_window_title. Remove redundant marker specification in sisotool rlocus plot.canvas.manager.{get,set}_win... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | e45f4a1aa1d2f5e476694a8ca3079eb927f0ea276035a2d5e78665f09121ff98 |
| turbo-cache-control | no-preview |
| go-import | github.com/python-control/python-control git https://github.com/python-control/python-control.git |
| octolytics-dimension-user_id | 2285872 |
| octolytics-dimension-user_login | python-control |
| octolytics-dimension-repository_id | 22791752 |
| octolytics-dimension-repository_nwo | python-control/python-control |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 22791752 |
| octolytics-dimension-repository_network_root_nwo | python-control/python-control |
| turbo-body-classes | logged-out env-production page-responsive full-width full-width-p-0 |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 8a5f67754bd81296f454ff3fa910631e09e4052c |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width